drm/i915/mst: use reference counted connectors. (v3)
[cascardo/linux.git] / drivers / gpu / drm / i915 / intel_dp_mst.c
1 /*
2  * Copyright © 2008 Intel Corporation
3  *             2014 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice (including the next
13  * paragraph) shall be included in all copies or substantial portions of the
14  * Software.
15  *
16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
22  * IN THE SOFTWARE.
23  *
24  */
25
26 #include <drm/drmP.h>
27 #include "i915_drv.h"
28 #include "intel_drv.h"
29 #include <drm/drm_atomic_helper.h>
30 #include <drm/drm_crtc_helper.h>
31 #include <drm/drm_edid.h>
32
33 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
34                                         struct intel_crtc_state *pipe_config)
35 {
36         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
37         struct intel_digital_port *intel_dig_port = intel_mst->primary;
38         struct intel_dp *intel_dp = &intel_dig_port->dp;
39         struct drm_atomic_state *state;
40         int bpp, i;
41         int lane_count, slots;
42         const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
43         struct drm_connector *drm_connector;
44         struct intel_connector *connector, *found = NULL;
45         struct drm_connector_state *connector_state;
46         int mst_pbn;
47
48         pipe_config->dp_encoder_is_mst = true;
49         pipe_config->has_pch_encoder = false;
50         pipe_config->has_dp_encoder = true;
51         bpp = 24;
52         /*
53          * for MST we always configure max link bw - the spec doesn't
54          * seem to suggest we should do otherwise.
55          */
56         lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
57
58
59         pipe_config->lane_count = lane_count;
60
61         pipe_config->pipe_bpp = 24;
62         pipe_config->port_clock = intel_dp_max_link_rate(intel_dp);
63
64         state = pipe_config->base.state;
65
66         for_each_connector_in_state(state, drm_connector, connector_state, i) {
67                 connector = to_intel_connector(drm_connector);
68
69                 if (connector_state->best_encoder == &encoder->base) {
70                         found = connector;
71                         break;
72                 }
73         }
74
75         if (!found) {
76                 DRM_ERROR("can't find connector\n");
77                 return false;
78         }
79
80         if (drm_dp_mst_port_has_audio(&intel_dp->mst_mgr, found->port))
81                 pipe_config->has_audio = true;
82         mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->crtc_clock, bpp);
83
84         pipe_config->pbn = mst_pbn;
85         slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
86
87         intel_link_compute_m_n(bpp, lane_count,
88                                adjusted_mode->crtc_clock,
89                                pipe_config->port_clock,
90                                &pipe_config->dp_m_n);
91
92         pipe_config->dp_m_n.tu = slots;
93
94         return true;
95
96 }
97
98 static void intel_mst_disable_dp(struct intel_encoder *encoder)
99 {
100         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
101         struct intel_digital_port *intel_dig_port = intel_mst->primary;
102         struct intel_dp *intel_dp = &intel_dig_port->dp;
103         struct drm_device *dev = encoder->base.dev;
104         struct drm_i915_private *dev_priv = dev->dev_private;
105         struct drm_crtc *crtc = encoder->base.crtc;
106         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
107
108         int ret;
109
110         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
111
112         drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, intel_mst->connector->port);
113
114         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
115         if (ret) {
116                 DRM_ERROR("failed to update payload %d\n", ret);
117         }
118         if (intel_crtc->config->has_audio) {
119                 intel_audio_codec_disable(encoder);
120                 intel_display_power_put(dev_priv, POWER_DOMAIN_AUDIO);
121         }
122 }
123
124 static void intel_mst_post_disable_dp(struct intel_encoder *encoder)
125 {
126         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
127         struct intel_digital_port *intel_dig_port = intel_mst->primary;
128         struct intel_dp *intel_dp = &intel_dig_port->dp;
129
130         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
131
132         /* this can fail */
133         drm_dp_check_act_status(&intel_dp->mst_mgr);
134         /* and this can also fail */
135         drm_dp_update_payload_part2(&intel_dp->mst_mgr);
136
137         drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, intel_mst->connector->port);
138
139         intel_dp->active_mst_links--;
140
141         intel_mst->connector = NULL;
142         if (intel_dp->active_mst_links == 0) {
143                 intel_dig_port->base.post_disable(&intel_dig_port->base);
144                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
145         }
146 }
147
148 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
149 {
150         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
151         struct intel_digital_port *intel_dig_port = intel_mst->primary;
152         struct intel_dp *intel_dp = &intel_dig_port->dp;
153         struct drm_device *dev = encoder->base.dev;
154         struct drm_i915_private *dev_priv = dev->dev_private;
155         enum port port = intel_dig_port->port;
156         int ret;
157         uint32_t temp;
158         struct intel_connector *found = NULL, *connector;
159         int slots;
160         struct drm_crtc *crtc = encoder->base.crtc;
161         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
162
163         for_each_intel_connector(dev, connector) {
164                 if (connector->base.state->best_encoder == &encoder->base) {
165                         found = connector;
166                         break;
167                 }
168         }
169
170         if (!found) {
171                 DRM_ERROR("can't find connector\n");
172                 return;
173         }
174
175         /* MST encoders are bound to a crtc, not to a connector,
176          * force the mapping here for get_hw_state.
177          */
178         found->encoder = encoder;
179
180         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
181
182         intel_mst->connector = found;
183
184         if (intel_dp->active_mst_links == 0) {
185                 intel_prepare_ddi_buffer(&intel_dig_port->base);
186
187                 intel_ddi_clk_select(&intel_dig_port->base, intel_crtc->config);
188
189                 intel_dp_set_link_params(intel_dp, intel_crtc->config);
190
191                 intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
192
193                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
194
195                 intel_dp_start_link_train(intel_dp);
196                 intel_dp_stop_link_train(intel_dp);
197         }
198
199         ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
200                                        intel_mst->connector->port,
201                                        intel_crtc->config->pbn, &slots);
202         if (ret == false) {
203                 DRM_ERROR("failed to allocate vcpi\n");
204                 return;
205         }
206
207
208         intel_dp->active_mst_links++;
209         temp = I915_READ(DP_TP_STATUS(port));
210         I915_WRITE(DP_TP_STATUS(port), temp);
211
212         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
213 }
214
215 static void intel_mst_enable_dp(struct intel_encoder *encoder)
216 {
217         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
218         struct intel_digital_port *intel_dig_port = intel_mst->primary;
219         struct intel_dp *intel_dp = &intel_dig_port->dp;
220         struct drm_device *dev = intel_dig_port->base.base.dev;
221         struct drm_i915_private *dev_priv = dev->dev_private;
222         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
223         enum port port = intel_dig_port->port;
224         int ret;
225
226         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
227
228         if (wait_for((I915_READ(DP_TP_STATUS(port)) & DP_TP_STATUS_ACT_SENT),
229                      1))
230                 DRM_ERROR("Timed out waiting for ACT sent\n");
231
232         ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
233
234         ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
235
236         if (crtc->config->has_audio) {
237                 DRM_DEBUG_DRIVER("Enabling DP audio on pipe %c\n",
238                                  pipe_name(crtc->pipe));
239                 intel_display_power_get(dev_priv, POWER_DOMAIN_AUDIO);
240                 intel_audio_codec_enable(encoder);
241         }
242 }
243
244 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
245                                       enum pipe *pipe)
246 {
247         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
248         *pipe = intel_mst->pipe;
249         if (intel_mst->connector)
250                 return true;
251         return false;
252 }
253
254 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
255                                         struct intel_crtc_state *pipe_config)
256 {
257         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
258         struct intel_digital_port *intel_dig_port = intel_mst->primary;
259         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
260         struct drm_device *dev = encoder->base.dev;
261         struct drm_i915_private *dev_priv = dev->dev_private;
262         enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
263         u32 temp, flags = 0;
264
265         pipe_config->has_dp_encoder = true;
266
267         pipe_config->has_audio =
268                 intel_ddi_is_audio_enabled(dev_priv, crtc);
269
270         temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
271         if (temp & TRANS_DDI_PHSYNC)
272                 flags |= DRM_MODE_FLAG_PHSYNC;
273         else
274                 flags |= DRM_MODE_FLAG_NHSYNC;
275         if (temp & TRANS_DDI_PVSYNC)
276                 flags |= DRM_MODE_FLAG_PVSYNC;
277         else
278                 flags |= DRM_MODE_FLAG_NVSYNC;
279
280         switch (temp & TRANS_DDI_BPC_MASK) {
281         case TRANS_DDI_BPC_6:
282                 pipe_config->pipe_bpp = 18;
283                 break;
284         case TRANS_DDI_BPC_8:
285                 pipe_config->pipe_bpp = 24;
286                 break;
287         case TRANS_DDI_BPC_10:
288                 pipe_config->pipe_bpp = 30;
289                 break;
290         case TRANS_DDI_BPC_12:
291                 pipe_config->pipe_bpp = 36;
292                 break;
293         default:
294                 break;
295         }
296         pipe_config->base.adjusted_mode.flags |= flags;
297
298         pipe_config->lane_count =
299                 ((temp & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;
300
301         intel_dp_get_m_n(crtc, pipe_config);
302
303         intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
304 }
305
306 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
307 {
308         struct intel_connector *intel_connector = to_intel_connector(connector);
309         struct intel_dp *intel_dp = intel_connector->mst_port;
310         struct edid *edid;
311         int ret;
312
313         if (!intel_dp) {
314                 return intel_connector_update_modes(connector, NULL);
315         }
316
317         edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
318         ret = intel_connector_update_modes(connector, edid);
319         kfree(edid);
320
321         return ret;
322 }
323
324 static enum drm_connector_status
325 intel_dp_mst_detect(struct drm_connector *connector, bool force)
326 {
327         struct intel_connector *intel_connector = to_intel_connector(connector);
328         struct intel_dp *intel_dp = intel_connector->mst_port;
329
330         if (!intel_dp)
331                 return connector_status_disconnected;
332         return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
333 }
334
335 static int
336 intel_dp_mst_set_property(struct drm_connector *connector,
337                           struct drm_property *property,
338                           uint64_t val)
339 {
340         return 0;
341 }
342
343 static void
344 intel_dp_mst_connector_destroy(struct drm_connector *connector)
345 {
346         struct intel_connector *intel_connector = to_intel_connector(connector);
347
348         if (!IS_ERR_OR_NULL(intel_connector->edid))
349                 kfree(intel_connector->edid);
350
351         drm_connector_cleanup(connector);
352         kfree(connector);
353 }
354
355 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
356         .dpms = drm_atomic_helper_connector_dpms,
357         .detect = intel_dp_mst_detect,
358         .fill_modes = drm_helper_probe_single_connector_modes,
359         .set_property = intel_dp_mst_set_property,
360         .atomic_get_property = intel_connector_atomic_get_property,
361         .destroy = intel_dp_mst_connector_destroy,
362         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
363         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
364 };
365
366 static int intel_dp_mst_get_modes(struct drm_connector *connector)
367 {
368         return intel_dp_mst_get_ddc_modes(connector);
369 }
370
371 static enum drm_mode_status
372 intel_dp_mst_mode_valid(struct drm_connector *connector,
373                         struct drm_display_mode *mode)
374 {
375         int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
376
377         /* TODO - validate mode against available PBN for link */
378         if (mode->clock < 10000)
379                 return MODE_CLOCK_LOW;
380
381         if (mode->flags & DRM_MODE_FLAG_DBLCLK)
382                 return MODE_H_ILLEGAL;
383
384         if (mode->clock > max_dotclk)
385                 return MODE_CLOCK_HIGH;
386
387         return MODE_OK;
388 }
389
390 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
391                                                          struct drm_connector_state *state)
392 {
393         struct intel_connector *intel_connector = to_intel_connector(connector);
394         struct intel_dp *intel_dp = intel_connector->mst_port;
395         struct intel_crtc *crtc = to_intel_crtc(state->crtc);
396
397         if (!intel_dp)
398                 return NULL;
399         return &intel_dp->mst_encoders[crtc->pipe]->base.base;
400 }
401
402 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
403 {
404         struct intel_connector *intel_connector = to_intel_connector(connector);
405         struct intel_dp *intel_dp = intel_connector->mst_port;
406         if (!intel_dp)
407                 return NULL;
408         return &intel_dp->mst_encoders[0]->base.base;
409 }
410
411 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
412         .get_modes = intel_dp_mst_get_modes,
413         .mode_valid = intel_dp_mst_mode_valid,
414         .atomic_best_encoder = intel_mst_atomic_best_encoder,
415         .best_encoder = intel_mst_best_encoder,
416 };
417
418 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
419 {
420         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
421
422         drm_encoder_cleanup(encoder);
423         kfree(intel_mst);
424 }
425
426 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
427         .destroy = intel_dp_mst_encoder_destroy,
428 };
429
430 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
431 {
432         if (connector->encoder && connector->base.state->crtc) {
433                 enum pipe pipe;
434                 if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
435                         return false;
436                 return true;
437         }
438         return false;
439 }
440
441 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
442 {
443 #ifdef CONFIG_DRM_FBDEV_EMULATION
444         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
445
446         if (dev_priv->fbdev)
447                 drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper,
448                                                 &connector->base);
449 #endif
450 }
451
452 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
453 {
454 #ifdef CONFIG_DRM_FBDEV_EMULATION
455         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
456
457         if (dev_priv->fbdev)
458                 drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper,
459                                                    &connector->base);
460 #endif
461 }
462
463 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
464 {
465         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
466         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
467         struct drm_device *dev = intel_dig_port->base.base.dev;
468         struct intel_connector *intel_connector;
469         struct drm_connector *connector;
470         int i;
471
472         intel_connector = intel_connector_alloc();
473         if (!intel_connector)
474                 return NULL;
475
476         connector = &intel_connector->base;
477         drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
478         drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
479
480         intel_connector->unregister = intel_connector_unregister;
481         intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
482         intel_connector->mst_port = intel_dp;
483         intel_connector->port = port;
484
485         for (i = PIPE_A; i <= PIPE_C; i++) {
486                 drm_mode_connector_attach_encoder(&intel_connector->base,
487                                                   &intel_dp->mst_encoders[i]->base.base);
488         }
489         intel_dp_add_properties(intel_dp, connector);
490
491         drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
492         drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
493
494         drm_mode_connector_set_path_property(connector, pathprop);
495         return connector;
496 }
497
498 static void intel_dp_register_mst_connector(struct drm_connector *connector)
499 {
500         struct intel_connector *intel_connector = to_intel_connector(connector);
501         struct drm_device *dev = connector->dev;
502         drm_modeset_lock_all(dev);
503         intel_connector_add_to_fbdev(intel_connector);
504         drm_modeset_unlock_all(dev);
505         drm_connector_register(&intel_connector->base);
506 }
507
508 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
509                                            struct drm_connector *connector)
510 {
511         struct intel_connector *intel_connector = to_intel_connector(connector);
512         struct drm_device *dev = connector->dev;
513
514         intel_connector->unregister(intel_connector);
515
516         /* need to nuke the connector */
517         drm_modeset_lock_all(dev);
518         intel_connector_remove_from_fbdev(intel_connector);
519         intel_connector->mst_port = NULL;
520         drm_modeset_unlock_all(dev);
521
522         drm_connector_unreference(&intel_connector->base);
523         DRM_DEBUG_KMS("\n");
524 }
525
526 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
527 {
528         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
529         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
530         struct drm_device *dev = intel_dig_port->base.base.dev;
531
532         drm_kms_helper_hotplug_event(dev);
533 }
534
535 static const struct drm_dp_mst_topology_cbs mst_cbs = {
536         .add_connector = intel_dp_add_mst_connector,
537         .register_connector = intel_dp_register_mst_connector,
538         .destroy_connector = intel_dp_destroy_mst_connector,
539         .hotplug = intel_dp_mst_hotplug,
540 };
541
542 static struct intel_dp_mst_encoder *
543 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
544 {
545         struct intel_dp_mst_encoder *intel_mst;
546         struct intel_encoder *intel_encoder;
547         struct drm_device *dev = intel_dig_port->base.base.dev;
548
549         intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
550
551         if (!intel_mst)
552                 return NULL;
553
554         intel_mst->pipe = pipe;
555         intel_encoder = &intel_mst->base;
556         intel_mst->primary = intel_dig_port;
557
558         drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
559                          DRM_MODE_ENCODER_DPMST, NULL);
560
561         intel_encoder->type = INTEL_OUTPUT_DP_MST;
562         intel_encoder->crtc_mask = 0x7;
563         intel_encoder->cloneable = 0;
564
565         intel_encoder->compute_config = intel_dp_mst_compute_config;
566         intel_encoder->disable = intel_mst_disable_dp;
567         intel_encoder->post_disable = intel_mst_post_disable_dp;
568         intel_encoder->pre_enable = intel_mst_pre_enable_dp;
569         intel_encoder->enable = intel_mst_enable_dp;
570         intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
571         intel_encoder->get_config = intel_dp_mst_enc_get_config;
572
573         return intel_mst;
574
575 }
576
577 static bool
578 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
579 {
580         int i;
581         struct intel_dp *intel_dp = &intel_dig_port->dp;
582
583         for (i = PIPE_A; i <= PIPE_C; i++)
584                 intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
585         return true;
586 }
587
588 int
589 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
590 {
591         struct intel_dp *intel_dp = &intel_dig_port->dp;
592         struct drm_device *dev = intel_dig_port->base.base.dev;
593         int ret;
594
595         intel_dp->can_mst = true;
596         intel_dp->mst_mgr.cbs = &mst_cbs;
597
598         /* create encoders */
599         intel_dp_create_fake_mst_encoders(intel_dig_port);
600         ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
601         if (ret) {
602                 intel_dp->can_mst = false;
603                 return ret;
604         }
605         return 0;
606 }
607
608 void
609 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
610 {
611         struct intel_dp *intel_dp = &intel_dig_port->dp;
612
613         if (!intel_dp->can_mst)
614                 return;
615
616         drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
617         /* encoders will get killed by normal cleanup */
618 }