1 /* Copyright (c) 2011, 2012, 2013, 2014 Nicira, Inc.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
21 #include "connectivity.h"
22 #include "dynamic-string.h"
27 #include "poll-loop.h"
35 VLOG_DEFINE_THIS_MODULE(lacp);
37 /* Masks for lacp_info state member. */
38 #define LACP_STATE_ACT 0x01 /* Activity. Active or passive? */
39 #define LACP_STATE_TIME 0x02 /* Timeout. Short or long timeout? */
40 #define LACP_STATE_AGG 0x04 /* Aggregation. Is the link is bondable? */
41 #define LACP_STATE_SYNC 0x08 /* Synchronization. Is the link in up to date? */
42 #define LACP_STATE_COL 0x10 /* Collecting. Is the link receiving frames? */
43 #define LACP_STATE_DIST 0x20 /* Distributing. Is the link sending frames? */
44 #define LACP_STATE_DEF 0x40 /* Defaulted. Using default partner info? */
45 #define LACP_STATE_EXP 0x80 /* Expired. Using expired partner info? */
47 #define LACP_FAST_TIME_TX 1000 /* Fast transmission rate. */
48 #define LACP_SLOW_TIME_TX 30000 /* Slow transmission rate. */
49 #define LACP_RX_MULTIPLIER 3 /* Multiply by TX rate to get RX rate. */
51 #define LACP_INFO_LEN 15
54 ovs_be16 sys_priority; /* System priority. */
55 uint8_t sys_id[ETH_ADDR_LEN]; /* System ID. */
56 ovs_be16 key; /* Operational key. */
57 ovs_be16 port_priority; /* Port priority. */
58 ovs_be16 port_id; /* Port ID. */
59 uint8_t state; /* State mask. See LACP_STATE macros. */
61 BUILD_ASSERT_DECL(LACP_INFO_LEN == sizeof(struct lacp_info));
63 #define LACP_PDU_LEN 110
66 uint8_t subtype; /* Always 1. */
67 uint8_t version; /* Always 1. */
69 uint8_t actor_type; /* Always 1. */
70 uint8_t actor_len; /* Always 20. */
71 struct lacp_info actor; /* LACP actor information. */
72 uint8_t z1[3]; /* Reserved. Always 0. */
74 uint8_t partner_type; /* Always 2. */
75 uint8_t partner_len; /* Always 20. */
76 struct lacp_info partner; /* LACP partner information. */
77 uint8_t z2[3]; /* Reserved. Always 0. */
79 uint8_t collector_type; /* Always 3. */
80 uint8_t collector_len; /* Always 16. */
81 ovs_be16 collector_delay; /* Maximum collector delay. Set to UINT16_MAX. */
82 uint8_t z3[64]; /* Combination of several fields. Always 0. */
84 BUILD_ASSERT_DECL(LACP_PDU_LEN == sizeof(struct lacp_pdu));
89 LACP_CURRENT, /* Current State. Partner up to date. */
90 LACP_EXPIRED, /* Expired State. Partner out of date. */
91 LACP_DEFAULTED, /* Defaulted State. No partner. */
95 struct list node; /* Node in all_lacps list. */
96 char *name; /* Name of this lacp object. */
97 uint8_t sys_id[ETH_ADDR_LEN]; /* System ID. */
98 uint16_t sys_priority; /* System Priority. */
99 bool active; /* Active or Passive. */
101 struct hmap slaves; /* Slaves this LACP object controls. */
102 struct slave *key_slave; /* Slave whose ID will be the aggregation key. */
104 bool fast; /* True if using fast probe interval. */
105 bool negotiated; /* True if LACP negotiations were successful. */
106 bool update; /* True if lacp_update() needs to be called. */
107 bool fallback_ab; /* True if fallback to active-backup on LACP failure. */
109 struct ovs_refcount ref_cnt;
113 void *aux; /* Handle used to identify this slave. */
114 struct hmap_node node; /* Node in master's slaves map. */
116 struct lacp *lacp; /* LACP object containing this slave. */
117 uint16_t port_id; /* Port ID. */
118 uint16_t port_priority; /* Port Priority. */
119 uint16_t key; /* Aggregation Key. 0 if default. */
120 char *name; /* Name of this slave. */
122 enum slave_status status; /* Slave status. */
123 bool attached; /* Attached. Traffic may flow. */
124 struct lacp_info partner; /* Partner information. */
125 struct lacp_info ntt_actor; /* Used to decide if we Need To Transmit. */
126 struct timer tx; /* Next message transmission timer. */
127 struct timer rx; /* Expected message receive timer. */
130 static struct ovs_mutex mutex;
131 static struct list all_lacps__ = LIST_INITIALIZER(&all_lacps__);
132 static struct list *const all_lacps OVS_GUARDED_BY(mutex) = &all_lacps__;
134 static void lacp_update_attached(struct lacp *) OVS_REQUIRES(mutex);
136 static void slave_destroy(struct slave *) OVS_REQUIRES(mutex);
137 static void slave_set_defaulted(struct slave *) OVS_REQUIRES(mutex);
138 static void slave_set_expired(struct slave *) OVS_REQUIRES(mutex);
139 static void slave_get_actor(struct slave *, struct lacp_info *actor)
141 static void slave_get_priority(struct slave *, struct lacp_info *priority)
143 static bool slave_may_tx(const struct slave *)
145 static struct slave *slave_lookup(const struct lacp *, const void *slave)
147 static bool info_tx_equal(struct lacp_info *, struct lacp_info *)
150 static unixctl_cb_func lacp_unixctl_show;
152 /* Populates 'pdu' with a LACP PDU comprised of 'actor' and 'partner'. */
154 compose_lacp_pdu(const struct lacp_info *actor,
155 const struct lacp_info *partner, struct lacp_pdu *pdu)
157 memset(pdu, 0, sizeof *pdu);
166 pdu->partner_type = 2;
167 pdu->partner_len = 20;
168 pdu->partner = *partner;
170 pdu->collector_type = 3;
171 pdu->collector_len = 16;
172 pdu->collector_delay = htons(0);
175 /* Parses 'b' which represents a packet containing a LACP PDU. This function
176 * returns NULL if 'b' is malformed, or does not represent a LACP PDU format
177 * supported by OVS. Otherwise, it returns a pointer to the lacp_pdu contained
179 static const struct lacp_pdu *
180 parse_lacp_packet(const struct ofpbuf *b)
182 const struct lacp_pdu *pdu;
184 pdu = ofpbuf_at(b, (uint8_t *)ofpbuf_l3(b) - (uint8_t *)ofpbuf_data(b),
187 if (pdu && pdu->subtype == 1
188 && pdu->actor_type == 1 && pdu->actor_len == 20
189 && pdu->partner_type == 2 && pdu->partner_len == 20) {
196 /* LACP Protocol Implementation. */
198 /* Initializes the lacp module. */
202 unixctl_command_register("lacp/show", "[port]", 0, 1,
203 lacp_unixctl_show, NULL);
207 lacp_lock(void) OVS_ACQUIRES(mutex)
209 static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
211 if (ovsthread_once_start(&once)) {
212 ovs_mutex_init_recursive(&mutex);
213 ovsthread_once_done(&once);
215 ovs_mutex_lock(&mutex);
219 lacp_unlock(void) OVS_RELEASES(mutex)
221 ovs_mutex_unlock(&mutex);
224 /* Creates a LACP object. */
226 lacp_create(void) OVS_EXCLUDED(mutex)
230 lacp = xzalloc(sizeof *lacp);
231 hmap_init(&lacp->slaves);
232 ovs_refcount_init(&lacp->ref_cnt);
235 list_push_back(all_lacps, &lacp->node);
241 lacp_ref(const struct lacp *lacp_)
243 struct lacp *lacp = CONST_CAST(struct lacp *, lacp_);
245 ovs_refcount_ref(&lacp->ref_cnt);
250 /* Destroys 'lacp' and its slaves. Does nothing if 'lacp' is NULL. */
252 lacp_unref(struct lacp *lacp) OVS_EXCLUDED(mutex)
254 if (lacp && ovs_refcount_unref_relaxed(&lacp->ref_cnt) == 1) {
255 struct slave *slave, *next;
258 HMAP_FOR_EACH_SAFE (slave, next, node, &lacp->slaves) {
259 slave_destroy(slave);
262 hmap_destroy(&lacp->slaves);
263 list_remove(&lacp->node);
270 /* Configures 'lacp' with settings from 's'. */
272 lacp_configure(struct lacp *lacp, const struct lacp_settings *s)
275 ovs_assert(!eth_addr_is_zero(s->id));
278 if (!lacp->name || strcmp(s->name, lacp->name)) {
280 lacp->name = xstrdup(s->name);
283 if (!eth_addr_equals(lacp->sys_id, s->id)
284 || lacp->sys_priority != s->priority) {
285 memcpy(lacp->sys_id, s->id, ETH_ADDR_LEN);
286 lacp->sys_priority = s->priority;
290 lacp->active = s->active;
291 lacp->fast = s->fast;
293 if (lacp->fallback_ab != s->fallback_ab_cfg) {
294 lacp->fallback_ab = s->fallback_ab_cfg;
301 /* Returns true if 'lacp' is configured in active mode, false if 'lacp' is
302 * configured for passive mode. */
304 lacp_is_active(const struct lacp *lacp) OVS_EXCLUDED(mutex)
313 /* Processes 'packet' which was received on 'slave_'. This function should be
314 * called on all packets received on 'slave_' with Ethernet Type ETH_TYPE_LACP.
317 lacp_process_packet(struct lacp *lacp, const void *slave_,
318 const struct ofpbuf *packet)
321 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
322 const struct lacp_pdu *pdu;
323 long long int tx_rate;
327 slave = slave_lookup(lacp, slave_);
332 pdu = parse_lacp_packet(packet);
334 VLOG_WARN_RL(&rl, "%s: received an unparsable LACP PDU.", lacp->name);
338 slave->status = LACP_CURRENT;
339 tx_rate = lacp->fast ? LACP_FAST_TIME_TX : LACP_SLOW_TIME_TX;
340 timer_set_duration(&slave->rx, LACP_RX_MULTIPLIER * tx_rate);
342 slave->ntt_actor = pdu->partner;
344 /* Update our information about our partner if it's out of date. This may
345 * cause priorities to change so re-calculate attached status of all
347 if (memcmp(&slave->partner, &pdu->actor, sizeof pdu->actor)) {
349 slave->partner = pdu->actor;
356 /* Returns the lacp_status of the given 'lacp' object (which may be NULL). */
358 lacp_status(const struct lacp *lacp) OVS_EXCLUDED(mutex)
361 enum lacp_status ret;
364 ret = lacp->negotiated ? LACP_NEGOTIATED : LACP_CONFIGURED;
368 /* Don't take 'mutex'. It might not even be initialized, since we
369 * don't know that any lacp object has been created. */
370 return LACP_DISABLED;
374 /* Registers 'slave_' as subordinate to 'lacp'. This should be called at least
375 * once per slave in a LACP managed bond. Should also be called whenever a
376 * slave's settings change. */
378 lacp_slave_register(struct lacp *lacp, void *slave_,
379 const struct lacp_slave_settings *s)
385 slave = slave_lookup(lacp, slave_);
387 slave = xzalloc(sizeof *slave);
390 hmap_insert(&lacp->slaves, &slave->node, hash_pointer(slave_, 0));
391 slave_set_defaulted(slave);
393 if (!lacp->key_slave) {
394 lacp->key_slave = slave;
398 if (!slave->name || strcmp(s->name, slave->name)) {
400 slave->name = xstrdup(s->name);
403 if (slave->port_id != s->id
404 || slave->port_priority != s->priority
405 || slave->key != s->key) {
406 slave->port_id = s->id;
407 slave->port_priority = s->priority;
412 if (lacp->active || lacp->negotiated) {
413 slave_set_expired(slave);
419 /* Unregisters 'slave_' with 'lacp'. */
421 lacp_slave_unregister(struct lacp *lacp, const void *slave_)
427 slave = slave_lookup(lacp, slave_);
429 slave_destroy(slave);
435 /* This function should be called whenever the carrier status of 'slave_' has
436 * changed. If 'lacp' is null, this function has no effect.*/
438 lacp_slave_carrier_changed(const struct lacp *lacp, const void *slave_)
447 slave = slave_lookup(lacp, slave_);
452 if (slave->status == LACP_CURRENT || slave->lacp->active) {
453 slave_set_expired(slave);
461 slave_may_enable__(struct slave *slave) OVS_REQUIRES(mutex)
463 /* The slave may be enabled if it's attached to an aggregator and its
464 * partner is synchronized.*/
465 return slave->attached && (slave->partner.state & LACP_STATE_SYNC
466 || (slave->lacp && slave->lacp->fallback_ab
467 && slave->status == LACP_DEFAULTED));
470 /* This function should be called before enabling 'slave_' to send or receive
471 * traffic. If it returns false, 'slave_' should not enabled. As a
472 * convenience, returns true if 'lacp' is NULL. */
474 lacp_slave_may_enable(const struct lacp *lacp, const void *slave_)
482 slave = slave_lookup(lacp, slave_);
483 ret = slave ? slave_may_enable__(slave) : false;
491 /* Returns true if partner information on 'slave_' is up to date. 'slave_'
492 * not being current, generally indicates a connectivity problem, or a
493 * misconfigured (or broken) partner. */
495 lacp_slave_is_current(const struct lacp *lacp, const void *slave_)
502 slave = slave_lookup(lacp, slave_);
503 ret = slave ? slave->status != LACP_DEFAULTED : false;
508 /* This function should be called periodically to update 'lacp'. */
510 lacp_run(struct lacp *lacp, lacp_send_pdu *send_pdu) OVS_EXCLUDED(mutex)
515 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
516 if (timer_expired(&slave->rx)) {
517 enum slave_status old_status = slave->status;
519 if (slave->status == LACP_CURRENT) {
520 slave_set_expired(slave);
521 } else if (slave->status == LACP_EXPIRED) {
522 slave_set_defaulted(slave);
524 if (slave->status != old_status) {
525 seq_change(connectivity_seq_get());
531 lacp_update_attached(lacp);
534 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
535 struct lacp_info actor;
537 if (!slave_may_tx(slave)) {
541 slave_get_actor(slave, &actor);
543 if (timer_expired(&slave->tx)
544 || !info_tx_equal(&actor, &slave->ntt_actor)) {
545 long long int duration;
548 slave->ntt_actor = actor;
549 compose_lacp_pdu(&actor, &slave->partner, &pdu);
550 send_pdu(slave->aux, &pdu, sizeof pdu);
552 duration = (slave->partner.state & LACP_STATE_TIME
554 : LACP_SLOW_TIME_TX);
556 timer_set_duration(&slave->tx, duration);
557 seq_change(connectivity_seq_get());
563 /* Causes poll_block() to wake up when lacp_run() needs to be called again. */
565 lacp_wait(struct lacp *lacp) OVS_EXCLUDED(mutex)
570 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
571 if (slave_may_tx(slave)) {
572 timer_wait(&slave->tx);
575 if (slave->status != LACP_DEFAULTED) {
576 timer_wait(&slave->rx);
582 /* Static Helpers. */
584 /* Updates the attached status of all slaves controlled by 'lacp' and sets its
585 * negotiated parameter to true if any slaves are attachable. */
587 lacp_update_attached(struct lacp *lacp) OVS_REQUIRES(mutex)
589 struct slave *lead, *slave;
590 struct lacp_info lead_pri;
591 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
593 lacp->update = false;
596 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
597 struct lacp_info pri;
599 slave->attached = false;
601 /* XXX: In the future allow users to configure the expected system ID.
602 * For now just special case loopback. */
603 if (eth_addr_equals(slave->partner.sys_id, slave->lacp->sys_id)) {
604 VLOG_WARN_RL(&rl, "slave %s: Loopback detected. Slave is "
605 "connected to its own bond", slave->name);
609 if (slave->status == LACP_DEFAULTED) {
610 if (lacp->fallback_ab) {
611 slave->attached = true;
616 slave->attached = true;
617 slave_get_priority(slave, &pri);
619 if (!lead || memcmp(&pri, &lead_pri, sizeof pri) < 0) {
625 lacp->negotiated = lead != NULL;
628 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
629 if ((lacp->fallback_ab && slave->status == LACP_DEFAULTED)
630 || lead->partner.key != slave->partner.key
631 || !eth_addr_equals(lead->partner.sys_id,
632 slave->partner.sys_id)) {
633 slave->attached = false;
640 slave_destroy(struct slave *slave) OVS_REQUIRES(mutex)
643 struct lacp *lacp = slave->lacp;
646 hmap_remove(&lacp->slaves, &slave->node);
648 if (lacp->key_slave == slave) {
649 struct hmap_node *slave_node = hmap_first(&lacp->slaves);
652 lacp->key_slave = CONTAINER_OF(slave_node, struct slave, node);
654 lacp->key_slave = NULL;
664 slave_set_defaulted(struct slave *slave) OVS_REQUIRES(mutex)
666 memset(&slave->partner, 0, sizeof slave->partner);
668 slave->lacp->update = true;
669 slave->status = LACP_DEFAULTED;
673 slave_set_expired(struct slave *slave) OVS_REQUIRES(mutex)
675 slave->status = LACP_EXPIRED;
676 slave->partner.state |= LACP_STATE_TIME;
677 slave->partner.state &= ~LACP_STATE_SYNC;
679 timer_set_duration(&slave->rx, LACP_RX_MULTIPLIER * LACP_FAST_TIME_TX);
683 slave_get_actor(struct slave *slave, struct lacp_info *actor)
686 struct lacp *lacp = slave->lacp;
691 state |= LACP_STATE_ACT;
695 state |= LACP_STATE_TIME;
698 if (slave->attached) {
699 state |= LACP_STATE_SYNC;
702 if (slave->status == LACP_DEFAULTED) {
703 state |= LACP_STATE_DEF;
706 if (slave->status == LACP_EXPIRED) {
707 state |= LACP_STATE_EXP;
710 if (hmap_count(&lacp->slaves) > 1) {
711 state |= LACP_STATE_AGG;
714 if (slave->attached || !lacp->negotiated) {
715 state |= LACP_STATE_COL | LACP_STATE_DIST;
718 key = lacp->key_slave->key;
720 key = lacp->key_slave->port_id;
723 actor->state = state;
724 actor->key = htons(key);
725 actor->port_priority = htons(slave->port_priority);
726 actor->port_id = htons(slave->port_id);
727 actor->sys_priority = htons(lacp->sys_priority);
728 memcpy(&actor->sys_id, lacp->sys_id, ETH_ADDR_LEN);
731 /* Given 'slave', populates 'priority' with data representing its LACP link
732 * priority. If two priority objects populated by this function are compared
733 * using memcmp, the higher priority link will be less than the lower priority
736 slave_get_priority(struct slave *slave, struct lacp_info *priority)
739 uint16_t partner_priority, actor_priority;
741 /* Choose the lacp_info of the higher priority system by comparing their
742 * system priorities and mac addresses. */
743 actor_priority = slave->lacp->sys_priority;
744 partner_priority = ntohs(slave->partner.sys_priority);
745 if (actor_priority < partner_priority) {
746 slave_get_actor(slave, priority);
747 } else if (partner_priority < actor_priority) {
748 *priority = slave->partner;
749 } else if (eth_addr_compare_3way(slave->lacp->sys_id,
750 slave->partner.sys_id) < 0) {
751 slave_get_actor(slave, priority);
753 *priority = slave->partner;
756 /* Key and state are not used in priority comparisons. */
762 slave_may_tx(const struct slave *slave) OVS_REQUIRES(mutex)
764 return slave->lacp->active || slave->status != LACP_DEFAULTED;
767 static struct slave *
768 slave_lookup(const struct lacp *lacp, const void *slave_) OVS_REQUIRES(mutex)
772 HMAP_FOR_EACH_IN_BUCKET (slave, node, hash_pointer(slave_, 0),
774 if (slave->aux == slave_) {
782 /* Two lacp_info structures are tx_equal if and only if they do not differ in
783 * ways which would require a lacp_pdu transmission. */
785 info_tx_equal(struct lacp_info *a, struct lacp_info *b)
788 /* LACP specification dictates that we transmit whenever the actor and
789 * remote_actor differ in the following fields: Port, Port Priority,
790 * System, System Priority, Aggregation Key, Activity State, Timeout State,
791 * Sync State, and Aggregation State. The state flags are most likely to
792 * change so are checked first. */
793 return !((a->state ^ b->state) & (LACP_STATE_ACT
797 && a->port_id == b->port_id
798 && a->port_priority == b->port_priority
800 && a->sys_priority == b->sys_priority
801 && eth_addr_equals(a->sys_id, b->sys_id);
805 lacp_find(const char *name) OVS_REQUIRES(mutex)
809 LIST_FOR_EACH (lacp, node, all_lacps) {
810 if (!strcmp(lacp->name, name)) {
819 ds_put_lacp_state(struct ds *ds, uint8_t state)
821 if (state & LACP_STATE_ACT) {
822 ds_put_cstr(ds, " activity");
825 if (state & LACP_STATE_TIME) {
826 ds_put_cstr(ds, " timeout");
829 if (state & LACP_STATE_AGG) {
830 ds_put_cstr(ds, " aggregation");
833 if (state & LACP_STATE_SYNC) {
834 ds_put_cstr(ds, " synchronized");
837 if (state & LACP_STATE_COL) {
838 ds_put_cstr(ds, " collecting");
841 if (state & LACP_STATE_DIST) {
842 ds_put_cstr(ds, " distributing");
845 if (state & LACP_STATE_DEF) {
846 ds_put_cstr(ds, " defaulted");
849 if (state & LACP_STATE_EXP) {
850 ds_put_cstr(ds, " expired");
855 lacp_print_details(struct ds *ds, struct lacp *lacp) OVS_REQUIRES(mutex)
857 struct shash slave_shash = SHASH_INITIALIZER(&slave_shash);
858 const struct shash_node **sorted_slaves = NULL;
863 ds_put_format(ds, "---- %s ----\n", lacp->name);
864 ds_put_format(ds, "\tstatus: %s", lacp->active ? "active" : "passive");
865 if (lacp->negotiated) {
866 ds_put_cstr(ds, " negotiated");
868 ds_put_cstr(ds, "\n");
870 ds_put_format(ds, "\tsys_id: " ETH_ADDR_FMT "\n", ETH_ADDR_ARGS(lacp->sys_id));
871 ds_put_format(ds, "\tsys_priority: %u\n", lacp->sys_priority);
872 ds_put_cstr(ds, "\taggregation key: ");
873 if (lacp->key_slave) {
874 ds_put_format(ds, "%u", lacp->key_slave->key
875 ? lacp->key_slave->key
876 : lacp->key_slave->port_id);
878 ds_put_cstr(ds, "none");
880 ds_put_cstr(ds, "\n");
882 ds_put_cstr(ds, "\tlacp_time: ");
884 ds_put_cstr(ds, "fast\n");
886 ds_put_cstr(ds, "slow\n");
889 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
890 shash_add(&slave_shash, slave->name, slave);
892 sorted_slaves = shash_sort(&slave_shash);
894 for (i = 0; i < shash_count(&slave_shash); i++) {
896 struct lacp_info actor;
898 slave = sorted_slaves[i]->data;
899 slave_get_actor(slave, &actor);
900 switch (slave->status) {
908 status = "defaulted";
914 ds_put_format(ds, "\nslave: %s: %s %s\n", slave->name, status,
915 slave->attached ? "attached" : "detached");
916 ds_put_format(ds, "\tport_id: %u\n", slave->port_id);
917 ds_put_format(ds, "\tport_priority: %u\n", slave->port_priority);
918 ds_put_format(ds, "\tmay_enable: %s\n", (slave_may_enable__(slave)
919 ? "true" : "false"));
921 ds_put_format(ds, "\n\tactor sys_id: " ETH_ADDR_FMT "\n",
922 ETH_ADDR_ARGS(actor.sys_id));
923 ds_put_format(ds, "\tactor sys_priority: %u\n",
924 ntohs(actor.sys_priority));
925 ds_put_format(ds, "\tactor port_id: %u\n",
926 ntohs(actor.port_id));
927 ds_put_format(ds, "\tactor port_priority: %u\n",
928 ntohs(actor.port_priority));
929 ds_put_format(ds, "\tactor key: %u\n",
931 ds_put_cstr(ds, "\tactor state:");
932 ds_put_lacp_state(ds, actor.state);
933 ds_put_cstr(ds, "\n\n");
935 ds_put_format(ds, "\tpartner sys_id: " ETH_ADDR_FMT "\n",
936 ETH_ADDR_ARGS(slave->partner.sys_id));
937 ds_put_format(ds, "\tpartner sys_priority: %u\n",
938 ntohs(slave->partner.sys_priority));
939 ds_put_format(ds, "\tpartner port_id: %u\n",
940 ntohs(slave->partner.port_id));
941 ds_put_format(ds, "\tpartner port_priority: %u\n",
942 ntohs(slave->partner.port_priority));
943 ds_put_format(ds, "\tpartner key: %u\n",
944 ntohs(slave->partner.key));
945 ds_put_cstr(ds, "\tpartner state:");
946 ds_put_lacp_state(ds, slave->partner.state);
947 ds_put_cstr(ds, "\n");
950 shash_destroy(&slave_shash);
955 lacp_unixctl_show(struct unixctl_conn *conn, int argc, const char *argv[],
956 void *aux OVS_UNUSED) OVS_EXCLUDED(mutex)
958 struct ds ds = DS_EMPTY_INITIALIZER;
963 lacp = lacp_find(argv[1]);
965 unixctl_command_reply_error(conn, "no such lacp object");
968 lacp_print_details(&ds, lacp);
970 LIST_FOR_EACH (lacp, node, all_lacps) {
971 lacp_print_details(&ds, lacp);
975 unixctl_command_reply(conn, ds_cstr(&ds));