1 /* Copyright (c) 2008, 2009, 2010, 2011, 2012 Nicira Networks
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
28 #include "dynamic-string.h"
35 #include "mac-learning.h"
36 #include "meta-flow.h"
38 #include "ofp-print.h"
40 #include "ofproto/ofproto.h"
41 #include "poll-loop.h"
44 #include "socket-util.h"
46 #include "stream-ssl.h"
48 #include "system-stats.h"
53 #include "vswitchd/vswitch-idl.h"
54 #include "xenserver.h"
56 #include "sflow_api.h"
57 #include "vlan-bitmap.h"
59 VLOG_DEFINE_THIS_MODULE(bridge);
61 COVERAGE_DEFINE(bridge_reconfigure);
63 /* Configuration of an uninstantiated iface. */
65 struct hmap_node hmap_node; /* Node in bridge's if_cfg_todo. */
66 const struct ovsrec_interface *cfg; /* Interface record. */
67 const struct ovsrec_port *parent; /* Parent port record. */
70 /* OpenFlow port slated for removal from ofproto. */
72 struct list list_node; /* Node in bridge's ofpp_garbage. */
73 uint16_t ofp_port; /* Port to be deleted. */
77 /* These members are always valid. */
78 struct list port_elem; /* Element in struct port's "ifaces" list. */
79 struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */
80 struct port *port; /* Containing port. */
81 char *name; /* Host network device name. */
83 /* These members are valid only after bridge_reconfigure() causes them to
85 struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */
86 int ofp_port; /* OpenFlow port number, -1 if unknown. */
87 struct netdev *netdev; /* Network device. */
88 const char *type; /* Usually same as cfg->type. */
89 const struct ovsrec_interface *cfg;
93 struct uuid uuid; /* UUID of this "mirror" record in database. */
94 struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */
95 struct bridge *bridge;
97 const struct ovsrec_mirror *cfg;
101 struct bridge *bridge;
102 struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */
105 const struct ovsrec_port *cfg;
107 /* An ordinary bridge port has 1 interface.
108 * A bridge port for bonding has at least 2 interfaces. */
109 struct list ifaces; /* List of "struct iface"s. */
113 struct hmap_node node; /* In 'all_bridges'. */
114 char *name; /* User-specified arbitrary name. */
115 char *type; /* Datapath type. */
116 uint8_t ea[ETH_ADDR_LEN]; /* Bridge Ethernet Address. */
117 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
118 const struct ovsrec_bridge *cfg;
120 /* OpenFlow switch processing. */
121 struct ofproto *ofproto; /* OpenFlow switch. */
124 struct hmap ports; /* "struct port"s indexed by name. */
125 struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */
126 struct hmap iface_by_name; /* "struct iface"s indexed by name. */
128 struct list ofpp_garbage; /* "struct ofpp_garbage" slated for removal. */
129 struct hmap if_cfg_todo; /* "struct if_cfg"s slated for creation.
130 Indexed on 'cfg->name'. */
132 /* Port mirroring. */
133 struct hmap mirrors; /* "struct mirror" indexed by UUID. */
135 /* Synthetic local port if necessary. */
136 struct ovsrec_port synth_local_port;
137 struct ovsrec_interface synth_local_iface;
138 struct ovsrec_interface *synth_local_ifacep;
141 /* All bridges, indexed by name. */
142 static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges);
144 /* OVSDB IDL used to obtain configuration. */
145 static struct ovsdb_idl *idl;
147 /* Each time this timer expires, the bridge fetches systems and interface
148 * statistics and pushes them into the database. */
149 #define STATS_INTERVAL (5 * 1000) /* In milliseconds. */
150 static long long int stats_timer = LLONG_MIN;
152 /* Stores the time after which rate limited statistics may be written to the
153 * database. Only updated when changes to the database require rate limiting.
155 #define DB_LIMIT_INTERVAL (1 * 1000) /* In milliseconds. */
156 static long long int db_limiter = LLONG_MIN;
158 /* In some datapaths, creating and destroying OpenFlow ports can be extremely
159 * expensive. This can cause bridge_reconfigure() to take a long time during
160 * which no other work can be done. To deal with this problem, we limit port
161 * adds and deletions to a window of OFP_PORT_ACTION_WINDOW milliseconds per
162 * call to bridge_reconfigure(). If there is more work to do after the limit
163 * is reached, 'need_reconfigure', is flagged and it's done on the next loop.
164 * This allows the rest of the code to catch up on important things like
165 * forwarding packets. */
166 #define OFP_PORT_ACTION_WINDOW 10
167 static bool reconfiguring = false;
169 static void add_del_bridges(const struct ovsrec_open_vswitch *);
170 static void bridge_update_ofprotos(void);
171 static void bridge_create(const struct ovsrec_bridge *);
172 static void bridge_destroy(struct bridge *);
173 static struct bridge *bridge_lookup(const char *name);
174 static unixctl_cb_func bridge_unixctl_dump_flows;
175 static unixctl_cb_func bridge_unixctl_reconnect;
176 static size_t bridge_get_controllers(const struct bridge *br,
177 struct ovsrec_controller ***controllersp);
178 static void bridge_add_del_ports(struct bridge *,
179 const unsigned long int *splinter_vlans);
180 static void bridge_refresh_ofp_port(struct bridge *);
181 static void bridge_configure_datapath_id(struct bridge *);
182 static void bridge_configure_flow_eviction_threshold(struct bridge *);
183 static void bridge_configure_netflow(struct bridge *);
184 static void bridge_configure_forward_bpdu(struct bridge *);
185 static void bridge_configure_mac_idle_time(struct bridge *);
186 static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number);
187 static void bridge_configure_stp(struct bridge *);
188 static void bridge_configure_tables(struct bridge *);
189 static void bridge_configure_remotes(struct bridge *,
190 const struct sockaddr_in *managers,
192 static void bridge_pick_local_hw_addr(struct bridge *,
193 uint8_t ea[ETH_ADDR_LEN],
194 struct iface **hw_addr_iface);
195 static uint64_t bridge_pick_datapath_id(struct bridge *,
196 const uint8_t bridge_ea[ETH_ADDR_LEN],
197 struct iface *hw_addr_iface);
198 static const char *bridge_get_other_config(const struct ovsrec_bridge *,
200 static const char *get_port_other_config(const struct ovsrec_port *,
202 const char *default_value);
203 static void bridge_queue_if_cfg(struct bridge *,
204 const struct ovsrec_interface *,
205 const struct ovsrec_port *);
206 static uint64_t dpid_from_hash(const void *, size_t nbytes);
207 static bool bridge_has_bond_fake_iface(const struct bridge *,
209 static bool port_is_bond_fake_iface(const struct port *);
211 static unixctl_cb_func qos_unixctl_show;
213 static struct port *port_create(struct bridge *, const struct ovsrec_port *);
214 static void port_del_ifaces(struct port *);
215 static void port_destroy(struct port *);
216 static struct port *port_lookup(const struct bridge *, const char *name);
217 static void port_configure(struct port *);
218 static struct lacp_settings *port_configure_lacp(struct port *,
219 struct lacp_settings *);
220 static void port_configure_bond(struct port *, struct bond_settings *,
221 uint32_t *bond_stable_ids);
222 static bool port_is_synthetic(const struct port *);
224 static void bridge_configure_mirrors(struct bridge *);
225 static struct mirror *mirror_create(struct bridge *,
226 const struct ovsrec_mirror *);
227 static void mirror_destroy(struct mirror *);
228 static bool mirror_configure(struct mirror *);
229 static void mirror_refresh_stats(struct mirror *);
231 static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *);
232 static void iface_create(struct bridge *, struct if_cfg *, int ofp_port);
233 static const char *iface_get_type(const struct ovsrec_interface *,
234 const struct ovsrec_bridge *);
235 static void iface_destroy(struct iface *);
236 static struct iface *iface_lookup(const struct bridge *, const char *name);
237 static struct iface *iface_find(const char *name);
238 static struct if_cfg *if_cfg_lookup(const struct bridge *, const char *name);
239 static struct iface *iface_from_ofp_port(const struct bridge *,
241 static void iface_set_mac(struct iface *);
242 static void iface_set_ofport(const struct ovsrec_interface *, int64_t ofport);
243 static void iface_clear_db_record(const struct ovsrec_interface *if_cfg);
244 static void iface_configure_qos(struct iface *, const struct ovsrec_qos *);
245 static void iface_configure_cfm(struct iface *);
246 static void iface_refresh_cfm_stats(struct iface *);
247 static void iface_refresh_stats(struct iface *);
248 static void iface_refresh_status(struct iface *);
249 static bool iface_is_synthetic(const struct iface *);
250 static const char *get_interface_other_config(const struct ovsrec_interface *,
252 const char *default_value);
254 static void shash_from_ovs_idl_map(char **keys, char **values, size_t n,
256 static void shash_to_ovs_idl_map(struct shash *,
257 char ***keys, char ***values, size_t *n);
259 /* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.)
261 * This is deprecated. It is only for compatibility with broken device drivers
262 * in old versions of Linux that do not properly support VLANs when VLAN
263 * devices are not used. When broken device drivers are no longer in
264 * widespread use, we will delete these interfaces. */
266 /* True if VLAN splinters are enabled on any interface, false otherwise.*/
267 static bool vlan_splinters_enabled_anywhere;
269 static bool vlan_splinters_is_enabled(const struct ovsrec_interface *);
270 static unsigned long int *collect_splinter_vlans(
271 const struct ovsrec_open_vswitch *);
272 static void configure_splinter_port(struct port *);
273 static void add_vlan_splinter_ports(struct bridge *,
274 const unsigned long int *splinter_vlans,
275 struct shash *ports);
277 /* Public functions. */
279 /* Initializes the bridge module, configuring it to obtain its configuration
280 * from an OVSDB server accessed over 'remote', which should be a string in a
281 * form acceptable to ovsdb_idl_create(). */
283 bridge_init(const char *remote)
285 /* Create connection to database. */
286 idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true);
287 ovsdb_idl_set_lock(idl, "ovs_vswitchd");
289 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
290 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
291 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
292 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
293 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
294 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
295 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
297 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
298 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status);
299 ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
301 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status);
302 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_statistics);
303 ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
304 ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
306 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
307 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
308 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);
309 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
310 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets);
311 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);
312 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
313 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
314 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);
315 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault);
316 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault_status);
317 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids);
318 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current);
319 ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
321 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
322 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
323 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);
324 ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
326 ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
328 ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);
330 ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
331 ovsdb_idl_omit_alert(idl, &ovsrec_mirror_col_statistics);
333 ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
335 ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
337 ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
338 ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);
339 ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
340 ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
341 ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
343 ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
345 /* Register unixctl commands. */
346 unixctl_command_register("qos/show", "interface", 1, 1,
347 qos_unixctl_show, NULL);
348 unixctl_command_register("bridge/dump-flows", "bridge", 1, 1,
349 bridge_unixctl_dump_flows, NULL);
350 unixctl_command_register("bridge/reconnect", "[bridge]", 0, 1,
351 bridge_unixctl_reconnect, NULL);
361 struct bridge *br, *next_br;
363 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
366 ovsdb_idl_destroy(idl);
369 /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
370 * addresses and ports into '*managersp' and '*n_managersp'. The caller is
371 * responsible for freeing '*managersp' (with free()).
373 * You may be asking yourself "why does ovs-vswitchd care?", because
374 * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
375 * should not be and in fact is not directly involved in that. But
376 * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
377 * it has to tell in-band control where the managers are to enable that.
378 * (Thus, only managers connected in-band are collected.)
381 collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
382 struct sockaddr_in **managersp, size_t *n_managersp)
384 struct sockaddr_in *managers = NULL;
385 size_t n_managers = 0;
389 /* Collect all of the potential targets from the "targets" columns of the
390 * rows pointed to by "manager_options", excluding any that are
393 for (i = 0; i < ovs_cfg->n_manager_options; i++) {
394 struct ovsrec_manager *m = ovs_cfg->manager_options[i];
396 if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
397 sset_find_and_delete(&targets, m->target);
399 sset_add(&targets, m->target);
403 /* Now extract the targets' IP addresses. */
404 if (!sset_is_empty(&targets)) {
407 managers = xmalloc(sset_count(&targets) * sizeof *managers);
408 SSET_FOR_EACH (target, &targets) {
409 struct sockaddr_in *sin = &managers[n_managers];
411 if (stream_parse_target_with_default_ports(target,
419 sset_destroy(&targets);
421 *managersp = managers;
422 *n_managersp = n_managers;
426 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
428 unsigned long int *splinter_vlans;
431 COVERAGE_INC(bridge_reconfigure);
433 assert(!reconfiguring);
434 reconfiguring = true;
436 /* Destroy "struct bridge"s, "struct port"s, and "struct iface"s according
437 * to 'ovs_cfg' while update the "if_cfg_queue", with only very minimal
438 * configuration otherwise.
440 * This is mostly an update to bridge data structures. Nothing is pushed
441 * down to ofproto or lower layers. */
442 add_del_bridges(ovs_cfg);
443 splinter_vlans = collect_splinter_vlans(ovs_cfg);
444 HMAP_FOR_EACH (br, node, &all_bridges) {
445 bridge_add_del_ports(br, splinter_vlans);
447 free(splinter_vlans);
449 /* Delete datapaths that are no longer configured, and create ones which
450 * don't exist but should. */
451 bridge_update_ofprotos();
453 /* Make sure each "struct iface" has a correct ofp_port in its ofproto. */
454 HMAP_FOR_EACH (br, node, &all_bridges) {
455 bridge_refresh_ofp_port(br);
458 /* Clear database records for "if_cfg"s which haven't been instantiated. */
459 HMAP_FOR_EACH (br, node, &all_bridges) {
460 struct if_cfg *if_cfg;
462 HMAP_FOR_EACH (if_cfg, hmap_node, &br->if_cfg_todo) {
463 iface_clear_db_record(if_cfg->cfg);
469 bridge_reconfigure_ofp(void)
471 long long int deadline;
475 deadline = time_msec() + OFP_PORT_ACTION_WINDOW;
477 /* The kernel will reject any attempt to add a given port to a datapath if
478 * that port already belongs to a different datapath, so we must do all
479 * port deletions before any port additions. */
480 HMAP_FOR_EACH (br, node, &all_bridges) {
481 struct ofpp_garbage *garbage, *next;
483 LIST_FOR_EACH_SAFE (garbage, next, list_node, &br->ofpp_garbage) {
484 ofproto_port_del(br->ofproto, garbage->ofp_port);
485 list_remove(&garbage->list_node);
489 if (time_msec() >= deadline) {
495 HMAP_FOR_EACH (br, node, &all_bridges) {
496 struct if_cfg *if_cfg, *next;
498 HMAP_FOR_EACH_SAFE (if_cfg, next, hmap_node, &br->if_cfg_todo) {
499 iface_create(br, if_cfg, -1);
501 if (time_msec() >= deadline) {
511 bridge_reconfigure_continue(const struct ovsrec_open_vswitch *ovs_cfg)
513 struct sockaddr_in *managers;
514 int sflow_bridge_number;
519 assert(reconfiguring);
520 done = bridge_reconfigure_ofp();
522 /* Complete the configuration. */
523 sflow_bridge_number = 0;
524 collect_in_band_managers(ovs_cfg, &managers, &n_managers);
525 HMAP_FOR_EACH (br, node, &all_bridges) {
528 /* We need the datapath ID early to allow LACP ports to use it as the
529 * default system ID. */
530 bridge_configure_datapath_id(br);
532 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
535 port_configure(port);
537 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
538 iface_configure_cfm(iface);
539 iface_configure_qos(iface, port->cfg->qos);
540 iface_set_mac(iface);
543 bridge_configure_mirrors(br);
544 bridge_configure_flow_eviction_threshold(br);
545 bridge_configure_forward_bpdu(br);
546 bridge_configure_mac_idle_time(br);
547 bridge_configure_remotes(br, managers, n_managers);
548 bridge_configure_netflow(br);
549 bridge_configure_sflow(br, &sflow_bridge_number);
550 bridge_configure_stp(br);
551 bridge_configure_tables(br);
556 /* ovs-vswitchd has completed initialization, so allow the process that
557 * forked us to exit successfully. */
558 daemonize_complete();
559 reconfiguring = false;
565 /* Delete ofprotos which aren't configured or have the wrong type. Create
566 * ofprotos which don't exist but need to. */
568 bridge_update_ofprotos(void)
570 struct bridge *br, *next;
575 /* Delete ofprotos with no bridge or with the wrong type. */
578 ofproto_enumerate_types(&types);
579 SSET_FOR_EACH (type, &types) {
582 ofproto_enumerate_names(type, &names);
583 SSET_FOR_EACH (name, &names) {
584 br = bridge_lookup(name);
585 if (!br || strcmp(type, br->type)) {
586 ofproto_delete(name, type);
590 sset_destroy(&names);
591 sset_destroy(&types);
593 /* Add ofprotos for bridges which don't have one yet. */
594 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
602 /* Remove ports from any datapath with the same name as 'br'. If we
603 * don't do this, creating 'br''s ofproto will fail because a port with
604 * the same name as its local port already exists. */
605 HMAP_FOR_EACH (br2, node, &all_bridges) {
606 struct ofproto_port ofproto_port;
612 if (!ofproto_port_query_by_name(br2->ofproto, br->name,
614 error = ofproto_port_del(br2->ofproto, ofproto_port.ofp_port);
616 VLOG_ERR("failed to delete port %s: %s", ofproto_port.name,
619 ofproto_port_destroy(&ofproto_port);
623 error = ofproto_create(br->name, br->type, &br->ofproto);
625 VLOG_ERR("failed to create bridge %s: %s", br->name,
633 port_configure(struct port *port)
635 const struct ovsrec_port *cfg = port->cfg;
636 struct bond_settings bond_settings;
637 struct lacp_settings lacp_settings;
638 struct ofproto_bundle_settings s;
641 if (cfg->vlan_mode && !strcmp(cfg->vlan_mode, "splinter")) {
642 configure_splinter_port(port);
651 s.slaves = xmalloc(list_size(&port->ifaces) * sizeof *s.slaves);
652 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
653 s.slaves[s.n_slaves++] = iface->ofp_port;
658 if (cfg->tag && *cfg->tag >= 0 && *cfg->tag <= 4095) {
662 /* Get VLAN trunks. */
665 s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks);
669 if (cfg->vlan_mode) {
670 if (!strcmp(cfg->vlan_mode, "access")) {
671 s.vlan_mode = PORT_VLAN_ACCESS;
672 } else if (!strcmp(cfg->vlan_mode, "trunk")) {
673 s.vlan_mode = PORT_VLAN_TRUNK;
674 } else if (!strcmp(cfg->vlan_mode, "native-tagged")) {
675 s.vlan_mode = PORT_VLAN_NATIVE_TAGGED;
676 } else if (!strcmp(cfg->vlan_mode, "native-untagged")) {
677 s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED;
679 /* This "can't happen" because ovsdb-server should prevent it. */
680 VLOG_ERR("unknown VLAN mode %s", cfg->vlan_mode);
681 s.vlan_mode = PORT_VLAN_TRUNK;
685 s.vlan_mode = PORT_VLAN_ACCESS;
687 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
691 s.vlan_mode = PORT_VLAN_TRUNK;
694 s.use_priority_tags = !strcmp("true", get_port_other_config(
695 cfg, "priority-tags", ""));
697 /* Get LACP settings. */
698 s.lacp = port_configure_lacp(port, &lacp_settings);
702 s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves);
703 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
704 iface_configure_lacp(iface, &s.lacp_slaves[i++]);
707 s.lacp_slaves = NULL;
710 /* Get bond settings. */
711 if (s.n_slaves > 1) {
712 s.bond = &bond_settings;
713 s.bond_stable_ids = xmalloc(s.n_slaves * sizeof *s.bond_stable_ids);
714 port_configure_bond(port, &bond_settings, s.bond_stable_ids);
717 s.bond_stable_ids = NULL;
719 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
720 netdev_set_miimon_interval(iface->netdev, 0);
725 ofproto_bundle_register(port->bridge->ofproto, port, &s);
731 free(s.bond_stable_ids);
734 /* Pick local port hardware address and datapath ID for 'br'. */
736 bridge_configure_datapath_id(struct bridge *br)
738 uint8_t ea[ETH_ADDR_LEN];
740 struct iface *local_iface;
741 struct iface *hw_addr_iface;
744 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
745 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
747 int error = netdev_set_etheraddr(local_iface->netdev, ea);
749 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
750 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
751 "Ethernet address: %s",
752 br->name, strerror(error));
755 memcpy(br->ea, ea, ETH_ADDR_LEN);
757 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
758 ofproto_set_datapath_id(br->ofproto, dpid);
760 dpid_string = xasprintf("%016"PRIx64, dpid);
761 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
765 /* Set NetFlow configuration on 'br'. */
767 bridge_configure_netflow(struct bridge *br)
769 struct ovsrec_netflow *cfg = br->cfg->netflow;
770 struct netflow_options opts;
773 ofproto_set_netflow(br->ofproto, NULL);
777 memset(&opts, 0, sizeof opts);
779 /* Get default NetFlow configuration from datapath.
780 * Apply overrides from 'cfg'. */
781 ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id);
782 if (cfg->engine_type) {
783 opts.engine_type = *cfg->engine_type;
785 if (cfg->engine_id) {
786 opts.engine_id = *cfg->engine_id;
789 /* Configure active timeout interval. */
790 opts.active_timeout = cfg->active_timeout;
791 if (!opts.active_timeout) {
792 opts.active_timeout = -1;
793 } else if (opts.active_timeout < 0) {
794 VLOG_WARN("bridge %s: active timeout interval set to negative "
795 "value, using default instead (%d seconds)", br->name,
796 NF_ACTIVE_TIMEOUT_DEFAULT);
797 opts.active_timeout = -1;
800 /* Add engine ID to interface number to disambiguate bridgs? */
801 opts.add_id_to_iface = cfg->add_id_to_interface;
802 if (opts.add_id_to_iface) {
803 if (opts.engine_id > 0x7f) {
804 VLOG_WARN("bridge %s: NetFlow port mangling may conflict with "
805 "another vswitch, choose an engine id less than 128",
808 if (hmap_count(&br->ports) > 508) {
809 VLOG_WARN("bridge %s: NetFlow port mangling will conflict with "
810 "another port when more than 508 ports are used",
816 sset_init(&opts.collectors);
817 sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets);
820 if (ofproto_set_netflow(br->ofproto, &opts)) {
821 VLOG_ERR("bridge %s: problem setting netflow collectors", br->name);
823 sset_destroy(&opts.collectors);
826 /* Set sFlow configuration on 'br'. */
828 bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number)
830 const struct ovsrec_sflow *cfg = br->cfg->sflow;
831 struct ovsrec_controller **controllers;
832 struct ofproto_sflow_options oso;
833 size_t n_controllers;
837 ofproto_set_sflow(br->ofproto, NULL);
841 memset(&oso, 0, sizeof oso);
843 sset_init(&oso.targets);
844 sset_add_array(&oso.targets, cfg->targets, cfg->n_targets);
846 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
848 oso.sampling_rate = *cfg->sampling;
851 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
853 oso.polling_interval = *cfg->polling;
856 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
858 oso.header_len = *cfg->header;
861 oso.sub_id = (*sflow_bridge_number)++;
862 oso.agent_device = cfg->agent;
864 oso.control_ip = NULL;
865 n_controllers = bridge_get_controllers(br, &controllers);
866 for (i = 0; i < n_controllers; i++) {
867 if (controllers[i]->local_ip) {
868 oso.control_ip = controllers[i]->local_ip;
872 ofproto_set_sflow(br->ofproto, &oso);
874 sset_destroy(&oso.targets);
878 port_configure_stp(const struct ofproto *ofproto, struct port *port,
879 struct ofproto_port_stp_settings *port_s,
880 int *port_num_counter, unsigned long *port_num_bitmap)
882 const char *config_str;
885 config_str = get_port_other_config(port->cfg, "stp-enable", NULL);
886 if (config_str && !strcmp(config_str, "false")) {
887 port_s->enable = false;
890 port_s->enable = true;
893 /* STP over bonds is not supported. */
894 if (!list_is_singleton(&port->ifaces)) {
895 VLOG_ERR("port %s: cannot enable STP on bonds, disabling",
897 port_s->enable = false;
901 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
903 /* Internal ports shouldn't participate in spanning tree, so
905 if (!strcmp(iface->type, "internal")) {
906 VLOG_DBG("port %s: disable STP on internal ports", port->name);
907 port_s->enable = false;
911 /* STP on mirror output ports is not supported. */
912 if (ofproto_is_mirror_output_bundle(ofproto, port)) {
913 VLOG_DBG("port %s: disable STP on mirror ports", port->name);
914 port_s->enable = false;
918 config_str = get_port_other_config(port->cfg, "stp-port-num", NULL);
920 unsigned long int port_num = strtoul(config_str, NULL, 0);
921 int port_idx = port_num - 1;
923 if (port_num < 1 || port_num > STP_MAX_PORTS) {
924 VLOG_ERR("port %s: invalid stp-port-num", port->name);
925 port_s->enable = false;
929 if (bitmap_is_set(port_num_bitmap, port_idx)) {
930 VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling",
931 port->name, port_num);
932 port_s->enable = false;
935 bitmap_set1(port_num_bitmap, port_idx);
936 port_s->port_num = port_idx;
938 if (*port_num_counter > STP_MAX_PORTS) {
939 VLOG_ERR("port %s: too many STP ports, disabling", port->name);
940 port_s->enable = false;
944 port_s->port_num = (*port_num_counter)++;
947 config_str = get_port_other_config(port->cfg, "stp-path-cost", NULL);
949 port_s->path_cost = strtoul(config_str, NULL, 10);
953 if (netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL)) {
954 /* Couldn't get speed, so assume 100Mb/s. */
955 port_s->path_cost = 19;
959 mbps = netdev_features_to_bps(current) / 1000000;
960 port_s->path_cost = stp_convert_speed_to_cost(mbps);
964 config_str = get_port_other_config(port->cfg, "stp-port-priority", NULL);
966 port_s->priority = strtoul(config_str, NULL, 0);
968 port_s->priority = STP_DEFAULT_PORT_PRIORITY;
972 /* Set spanning tree configuration on 'br'. */
974 bridge_configure_stp(struct bridge *br)
976 if (!br->cfg->stp_enable) {
977 ofproto_set_stp(br->ofproto, NULL);
979 struct ofproto_stp_settings br_s;
980 const char *config_str;
982 int port_num_counter;
983 unsigned long *port_num_bitmap;
985 config_str = bridge_get_other_config(br->cfg, "stp-system-id");
987 uint8_t ea[ETH_ADDR_LEN];
989 if (eth_addr_from_string(config_str, ea)) {
990 br_s.system_id = eth_addr_to_uint64(ea);
992 br_s.system_id = eth_addr_to_uint64(br->ea);
993 VLOG_ERR("bridge %s: invalid stp-system-id, defaulting "
994 "to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
997 br_s.system_id = eth_addr_to_uint64(br->ea);
1000 config_str = bridge_get_other_config(br->cfg, "stp-priority");
1002 br_s.priority = strtoul(config_str, NULL, 0);
1004 br_s.priority = STP_DEFAULT_BRIDGE_PRIORITY;
1007 config_str = bridge_get_other_config(br->cfg, "stp-hello-time");
1009 br_s.hello_time = strtoul(config_str, NULL, 10) * 1000;
1011 br_s.hello_time = STP_DEFAULT_HELLO_TIME;
1014 config_str = bridge_get_other_config(br->cfg, "stp-max-age");
1016 br_s.max_age = strtoul(config_str, NULL, 10) * 1000;
1018 br_s.max_age = STP_DEFAULT_MAX_AGE;
1021 config_str = bridge_get_other_config(br->cfg, "stp-forward-delay");
1023 br_s.fwd_delay = strtoul(config_str, NULL, 10) * 1000;
1025 br_s.fwd_delay = STP_DEFAULT_FWD_DELAY;
1028 /* Configure STP on the bridge. */
1029 if (ofproto_set_stp(br->ofproto, &br_s)) {
1030 VLOG_ERR("bridge %s: could not enable STP", br->name);
1034 /* Users must either set the port number with the "stp-port-num"
1035 * configuration on all ports or none. If manual configuration
1036 * is not done, then we allocate them sequentially. */
1037 port_num_counter = 0;
1038 port_num_bitmap = bitmap_allocate(STP_MAX_PORTS);
1039 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1040 struct ofproto_port_stp_settings port_s;
1041 struct iface *iface;
1043 port_configure_stp(br->ofproto, port, &port_s,
1044 &port_num_counter, port_num_bitmap);
1046 /* As bonds are not supported, just apply configuration to
1047 * all interfaces. */
1048 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1049 if (ofproto_port_set_stp(br->ofproto, iface->ofp_port,
1051 VLOG_ERR("port %s: could not enable STP", port->name);
1057 if (bitmap_scan(port_num_bitmap, 0, STP_MAX_PORTS) != STP_MAX_PORTS
1058 && port_num_counter) {
1059 VLOG_ERR("bridge %s: must manually configure all STP port "
1060 "IDs or none, disabling", br->name);
1061 ofproto_set_stp(br->ofproto, NULL);
1063 bitmap_free(port_num_bitmap);
1068 bridge_has_bond_fake_iface(const struct bridge *br, const char *name)
1070 const struct port *port = port_lookup(br, name);
1071 return port && port_is_bond_fake_iface(port);
1075 port_is_bond_fake_iface(const struct port *port)
1077 return port->cfg->bond_fake_iface && !list_is_short(&port->ifaces);
1081 add_del_bridges(const struct ovsrec_open_vswitch *cfg)
1083 struct bridge *br, *next;
1084 struct shash new_br;
1087 /* Collect new bridges' names and types. */
1088 shash_init(&new_br);
1089 for (i = 0; i < cfg->n_bridges; i++) {
1090 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1091 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
1093 if (strchr(br_cfg->name, '/')) {
1094 /* Prevent remote ovsdb-server users from accessing arbitrary
1095 * directories, e.g. consider a bridge named "../../../etc/". */
1096 VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"",
1098 } else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
1099 VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name);
1103 /* Get rid of deleted bridges or those whose types have changed.
1104 * Update 'cfg' of bridges that still exist. */
1105 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
1106 br->cfg = shash_find_data(&new_br, br->name);
1107 if (!br->cfg || strcmp(br->type, ofproto_normalize_type(
1108 br->cfg->datapath_type))) {
1113 /* Add new bridges. */
1114 for (i = 0; i < cfg->n_bridges; i++) {
1115 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
1116 struct bridge *br = bridge_lookup(br_cfg->name);
1118 bridge_create(br_cfg);
1122 shash_destroy(&new_br);
1126 iface_set_ofp_port(struct iface *iface, int ofp_port)
1128 struct bridge *br = iface->port->bridge;
1130 assert(iface->ofp_port < 0 && ofp_port >= 0);
1131 iface->ofp_port = ofp_port;
1132 hmap_insert(&br->ifaces, &iface->ofp_port_node, hash_int(ofp_port, 0));
1133 iface_set_ofport(iface->cfg, ofp_port);
1136 /* Configures 'netdev' based on the "options" column in 'iface_cfg'.
1137 * Returns 0 if successful, otherwise a positive errno value. */
1139 iface_set_netdev_config(const struct ovsrec_interface *iface_cfg,
1140 struct netdev *netdev)
1146 shash_from_ovs_idl_map(iface_cfg->key_options,
1147 iface_cfg->value_options,
1148 iface_cfg->n_options, &args);
1149 error = netdev_set_config(netdev, &args);
1150 shash_destroy(&args);
1153 VLOG_WARN("could not configure network device %s (%s)",
1154 iface_cfg->name, strerror(error));
1160 bridge_ofproto_port_del(struct bridge *br, struct ofproto_port ofproto_port)
1162 int error = ofproto_port_del(br->ofproto, ofproto_port.ofp_port);
1164 VLOG_WARN("bridge %s: failed to remove %s interface (%s)",
1165 br->name, ofproto_port.name, strerror(error));
1167 VLOG_INFO("bridge %s: removed interface %s (%d)", br->name,
1168 ofproto_port.name, ofproto_port.ofp_port);
1172 /* Update bridges "if_cfg"s, "struct port"s, and "struct iface"s to be
1173 * consistent with the ofp_ports in "br->ofproto". */
1175 bridge_refresh_ofp_port(struct bridge *br)
1177 struct ofproto_port_dump dump;
1178 struct ofproto_port ofproto_port;
1179 struct port *port, *port_next;
1181 /* Clear each "struct iface"s ofp_port so we can get its correct value. */
1182 hmap_clear(&br->ifaces);
1183 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1184 struct iface *iface;
1186 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1187 iface->ofp_port = -1;
1191 /* Obtain the correct "ofp_port"s from ofproto. Find any if_cfg's which
1192 * already exist in the datapath and promote them to full fledged "struct
1193 * iface"s. Mark ports in the datapath which don't belong as garbage. */
1194 OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
1195 struct iface *iface = iface_lookup(br, ofproto_port.name);
1197 if (iface->ofp_port >= 0) {
1198 VLOG_WARN("bridge %s: interface %s reported twice",
1199 br->name, ofproto_port.name);
1200 } else if (iface_from_ofp_port(br, ofproto_port.ofp_port)) {
1201 VLOG_WARN("bridge %s: interface %"PRIu16" reported twice",
1202 br->name, ofproto_port.ofp_port);
1203 } else if (!strcmp(ofproto_port.type, iface->type)) {
1204 iface_set_ofp_port(iface, ofproto_port.ofp_port);
1206 /* Port has incorrect type so delete it later. */
1209 struct if_cfg *if_cfg = if_cfg_lookup(br, ofproto_port.name);
1212 iface_create(br, if_cfg, ofproto_port.ofp_port);
1213 } else if (bridge_has_bond_fake_iface(br, ofproto_port.name)
1214 && strcmp(ofproto_port.type, "internal")) {
1215 /* Bond fake iface with the wrong type. */
1216 bridge_ofproto_port_del(br, ofproto_port);
1218 struct ofpp_garbage *garbage = xmalloc(sizeof *garbage);
1219 garbage->ofp_port = ofproto_port.ofp_port;
1220 list_push_front(&br->ofpp_garbage, &garbage->list_node);
1225 /* Some ifaces may not have "ofp_port"s in ofproto and therefore don't
1226 * deserve to have "struct iface"s. Demote these to "if_cfg"s so that
1227 * later they can be added to ofproto. */
1228 HMAP_FOR_EACH_SAFE (port, port_next, hmap_node, &br->ports) {
1229 struct iface *iface, *iface_next;
1231 LIST_FOR_EACH_SAFE (iface, iface_next, port_elem, &port->ifaces) {
1232 if (iface->ofp_port < 0) {
1233 bridge_queue_if_cfg(br, iface->cfg, port->cfg);
1234 iface_destroy(iface);
1238 if (list_is_empty(&port->ifaces)) {
1244 /* Creates a new iface on 'br' based on 'if_cfg'. The new iface has OpenFlow
1245 * port number 'ofp_port'. If ofp_port is negative, an OpenFlow port is
1246 * automatically allocated for the iface. Takes ownership of and
1247 * deallocates 'if_cfg'. */
1249 iface_create(struct bridge *br, struct if_cfg *if_cfg, int ofp_port)
1251 struct iface *iface;
1255 assert(!iface_lookup(br, if_cfg->cfg->name));
1257 port = port_lookup(br, if_cfg->parent->name);
1259 port = port_create(br, if_cfg->parent);
1262 iface = xzalloc(sizeof *iface);
1264 iface->name = xstrdup(if_cfg->cfg->name);
1265 iface->ofp_port = -1;
1266 iface->netdev = NULL;
1267 iface->cfg = if_cfg->cfg;
1268 hmap_insert(&br->iface_by_name, &iface->name_node,
1269 hash_string(iface->name, 0));
1270 list_push_back(&port->ifaces, &iface->port_elem);
1271 iface->type = iface_get_type(iface->cfg, br->cfg);
1272 if (ofp_port >= 0) {
1273 iface_set_ofp_port(iface, ofp_port);
1276 hmap_remove(&br->if_cfg_todo, &if_cfg->hmap_node);
1280 error = netdev_open(iface->name, iface->type, &iface->netdev);
1282 VLOG_WARN("could not open network device %s (%s)", iface->name,
1287 && port->cfg->vlan_mode
1288 && !strcmp(port->cfg->vlan_mode, "splinter")) {
1289 netdev_turn_flags_on(iface->netdev, NETDEV_UP, true);
1292 /* Configure the netdev. */
1293 if (iface->netdev) {
1294 int error = iface_set_netdev_config(iface->cfg, iface->netdev);
1296 netdev_close(iface->netdev);
1297 iface->netdev = NULL;
1301 /* Add the port, if necessary. */
1302 if (iface->netdev && iface->ofp_port < 0) {
1303 uint16_t new_ofp_port;
1306 error = ofproto_port_add(br->ofproto, iface->netdev, &new_ofp_port);
1308 VLOG_INFO("bridge %s: added interface %s (%d)", br->name,
1309 iface->name, new_ofp_port);
1310 iface_set_ofp_port(iface, new_ofp_port);
1312 netdev_close(iface->netdev);
1313 iface->netdev = NULL;
1317 /* Initially populate stats columns. */
1318 if (iface->netdev) {
1319 iface_refresh_stats(iface);
1320 iface_refresh_status(iface);
1323 /* Delete the iface if we failed. */
1324 if (iface->netdev && iface->ofp_port >= 0) {
1325 VLOG_DBG("bridge %s: interface %s is on port %d",
1326 br->name, iface->name, iface->ofp_port);
1328 struct ofproto_port ofproto_port;
1330 if (iface->netdev) {
1331 VLOG_ERR("bridge %s: missing %s interface, dropping",
1332 br->name, iface->name);
1334 /* We already reported a related error, don't bother
1335 * duplicating it. */
1337 if (!ofproto_port_query_by_name(br->ofproto, port->name,
1339 VLOG_INFO("bridge %s: removed interface %s (%d)",
1340 br->name, port->name, ofproto_port.ofp_port);
1341 bridge_ofproto_port_del(br, ofproto_port);
1342 ofproto_port_destroy(&ofproto_port);
1344 iface_clear_db_record(iface->cfg);
1345 iface_destroy(iface);
1348 if (list_is_empty(&port->ifaces)) {
1353 /* Add bond fake iface if necessary. */
1354 if (port_is_bond_fake_iface(port)) {
1355 struct ofproto_port ofproto_port;
1357 if (ofproto_port_query_by_name(br->ofproto, port->name,
1359 struct netdev *netdev;
1362 error = netdev_open(port->name, "internal", &netdev);
1364 ofproto_port_add(br->ofproto, netdev, NULL);
1365 netdev_close(netdev);
1367 VLOG_WARN("could not open network device %s (%s)",
1368 port->name, strerror(error));
1371 /* Already exists, nothing to do. */
1372 ofproto_port_destroy(&ofproto_port);
1378 get_ovsrec_key_value(char **keys, char **values, size_t n, const char *key)
1382 for (i = 0; i < n; i++) {
1383 if (!strcmp(keys[i], key)) {
1391 bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
1393 return get_ovsrec_key_value(br_cfg->key_other_config,
1394 br_cfg->value_other_config,
1395 br_cfg->n_other_config, key);
1398 /* Set Flow eviction threshold */
1400 bridge_configure_flow_eviction_threshold(struct bridge *br)
1402 const char *threshold_str;
1405 threshold_str = bridge_get_other_config(br->cfg, "flow-eviction-threshold");
1406 if (threshold_str) {
1407 threshold = strtoul(threshold_str, NULL, 10);
1409 threshold = OFPROTO_FLOW_EVICTON_THRESHOLD_DEFAULT;
1411 ofproto_set_flow_eviction_threshold(br->ofproto, threshold);
1414 /* Set forward BPDU option. */
1416 bridge_configure_forward_bpdu(struct bridge *br)
1418 const char *forward_bpdu_str;
1419 bool forward_bpdu = false;
1421 forward_bpdu_str = bridge_get_other_config(br->cfg, "forward-bpdu");
1422 if (forward_bpdu_str && !strcmp(forward_bpdu_str, "true")) {
1423 forward_bpdu = true;
1425 ofproto_set_forward_bpdu(br->ofproto, forward_bpdu);
1428 /* Set MAC aging time for 'br'. */
1430 bridge_configure_mac_idle_time(struct bridge *br)
1432 const char *idle_time_str;
1435 idle_time_str = bridge_get_other_config(br->cfg, "mac-aging-time");
1436 idle_time = (idle_time_str && atoi(idle_time_str)
1437 ? atoi(idle_time_str)
1438 : MAC_ENTRY_DEFAULT_IDLE_TIME);
1439 ofproto_set_mac_idle_time(br->ofproto, idle_time);
1443 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
1444 struct iface **hw_addr_iface)
1446 struct hmapx mirror_output_ports;
1449 bool found_addr = false;
1453 *hw_addr_iface = NULL;
1455 /* Did the user request a particular MAC? */
1456 hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
1457 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
1458 if (eth_addr_is_multicast(ea)) {
1459 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
1460 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1461 } else if (eth_addr_is_zero(ea)) {
1462 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
1468 /* Mirror output ports don't participate in picking the local hardware
1469 * address. ofproto can't help us find out whether a given port is a
1470 * mirror output because we haven't configured mirrors yet, so we need to
1471 * accumulate them ourselves. */
1472 hmapx_init(&mirror_output_ports);
1473 for (i = 0; i < br->cfg->n_mirrors; i++) {
1474 struct ovsrec_mirror *m = br->cfg->mirrors[i];
1475 if (m->output_port) {
1476 hmapx_add(&mirror_output_ports, m->output_port);
1480 /* Otherwise choose the minimum non-local MAC address among all of the
1482 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1483 uint8_t iface_ea[ETH_ADDR_LEN];
1484 struct iface *candidate;
1485 struct iface *iface;
1487 /* Mirror output ports don't participate. */
1488 if (hmapx_contains(&mirror_output_ports, port->cfg)) {
1492 /* Choose the MAC address to represent the port. */
1494 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
1495 /* Find the interface with this Ethernet address (if any) so that
1496 * we can provide the correct devname to the caller. */
1497 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1498 uint8_t candidate_ea[ETH_ADDR_LEN];
1499 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
1500 && eth_addr_equals(iface_ea, candidate_ea)) {
1505 /* Choose the interface whose MAC address will represent the port.
1506 * The Linux kernel bonding code always chooses the MAC address of
1507 * the first slave added to a bond, and the Fedora networking
1508 * scripts always add slaves to a bond in alphabetical order, so
1509 * for compatibility we choose the interface with the name that is
1510 * first in alphabetical order. */
1511 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1512 if (!iface || strcmp(candidate->name, iface->name) < 0) {
1517 /* The local port doesn't count (since we're trying to choose its
1518 * MAC address anyway). */
1519 if (iface->ofp_port == OFPP_LOCAL) {
1524 error = netdev_get_etheraddr(iface->netdev, iface_ea);
1530 /* Compare against our current choice. */
1531 if (!eth_addr_is_multicast(iface_ea) &&
1532 !eth_addr_is_local(iface_ea) &&
1533 !eth_addr_is_reserved(iface_ea) &&
1534 !eth_addr_is_zero(iface_ea) &&
1535 (!found_addr || eth_addr_compare_3way(iface_ea, ea) < 0))
1537 memcpy(ea, iface_ea, ETH_ADDR_LEN);
1538 *hw_addr_iface = iface;
1543 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
1544 br->name, ETH_ADDR_ARGS(ea));
1546 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
1547 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
1548 *hw_addr_iface = NULL;
1549 VLOG_WARN_RL(&rl, "bridge %s: using default bridge Ethernet "
1550 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1553 hmapx_destroy(&mirror_output_ports);
1556 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
1557 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
1558 * an interface on 'br', then that interface must be passed in as
1559 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
1560 * 'hw_addr_iface' must be passed in as a null pointer. */
1562 bridge_pick_datapath_id(struct bridge *br,
1563 const uint8_t bridge_ea[ETH_ADDR_LEN],
1564 struct iface *hw_addr_iface)
1567 * The procedure for choosing a bridge MAC address will, in the most
1568 * ordinary case, also choose a unique MAC that we can use as a datapath
1569 * ID. In some special cases, though, multiple bridges will end up with
1570 * the same MAC address. This is OK for the bridges, but it will confuse
1571 * the OpenFlow controller, because each datapath needs a unique datapath
1574 * Datapath IDs must be unique. It is also very desirable that they be
1575 * stable from one run to the next, so that policy set on a datapath
1578 const char *datapath_id;
1581 datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
1582 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
1586 if (!hw_addr_iface) {
1588 * A purely internal bridge, that is, one that has no non-virtual
1589 * network devices on it at all, is difficult because it has no
1590 * natural unique identifier at all.
1592 * When the host is a XenServer, we handle this case by hashing the
1593 * host's UUID with the name of the bridge. Names of bridges are
1594 * persistent across XenServer reboots, although they can be reused if
1595 * an internal network is destroyed and then a new one is later
1596 * created, so this is fairly effective.
1598 * When the host is not a XenServer, we punt by using a random MAC
1599 * address on each run.
1601 const char *host_uuid = xenserver_get_host_uuid();
1603 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1604 dpid = dpid_from_hash(combined, strlen(combined));
1610 return eth_addr_to_uint64(bridge_ea);
1614 dpid_from_hash(const void *data, size_t n)
1616 uint8_t hash[SHA1_DIGEST_SIZE];
1618 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1619 sha1_bytes(data, n, hash);
1620 eth_addr_mark_random(hash);
1621 return eth_addr_to_uint64(hash);
1625 iface_refresh_status(struct iface *iface)
1629 enum netdev_flags flags;
1636 if (iface_is_synthetic(iface)) {
1642 if (!netdev_get_status(iface->netdev, &sh)) {
1644 char **keys, **values;
1646 shash_to_ovs_idl_map(&sh, &keys, &values, &n);
1647 ovsrec_interface_set_status(iface->cfg, keys, values, n);
1652 ovsrec_interface_set_status(iface->cfg, NULL, NULL, 0);
1655 shash_destroy_free_data(&sh);
1657 error = netdev_get_flags(iface->netdev, &flags);
1659 ovsrec_interface_set_admin_state(iface->cfg, flags & NETDEV_UP ? "up" : "down");
1662 ovsrec_interface_set_admin_state(iface->cfg, NULL);
1665 error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
1667 ovsrec_interface_set_duplex(iface->cfg,
1668 netdev_features_is_full_duplex(current)
1670 /* warning: uint64_t -> int64_t conversion */
1671 bps = netdev_features_to_bps(current);
1672 ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
1675 ovsrec_interface_set_duplex(iface->cfg, NULL);
1676 ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
1679 error = netdev_get_mtu(iface->netdev, &mtu);
1682 ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
1685 ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
1689 /* Writes 'iface''s CFM statistics to the database. */
1691 iface_refresh_cfm_stats(struct iface *iface)
1693 const struct ovsrec_interface *cfg = iface->cfg;
1695 const uint64_t *rmps;
1698 if (iface_is_synthetic(iface)) {
1702 fault = ofproto_port_get_cfm_fault(iface->port->bridge->ofproto,
1705 const char *reasons[CFM_FAULT_N_REASONS];
1706 bool fault_bool = fault;
1710 for (i = 0; i < CFM_FAULT_N_REASONS; i++) {
1711 int reason = 1 << i;
1712 if (fault & reason) {
1713 reasons[j++] = cfm_fault_reason_to_str(reason);
1717 ovsrec_interface_set_cfm_fault(cfg, &fault_bool, 1);
1718 ovsrec_interface_set_cfm_fault_status(cfg, (char **) reasons, j);
1720 ovsrec_interface_set_cfm_fault(cfg, NULL, 0);
1721 ovsrec_interface_set_cfm_fault_status(cfg, NULL, 0);
1724 error = ofproto_port_get_cfm_remote_mpids(iface->port->bridge->ofproto,
1725 iface->ofp_port, &rmps, &n_rmps);
1727 ovsrec_interface_set_cfm_remote_mpids(cfg, (const int64_t *)rmps,
1730 ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0);
1735 iface_refresh_stats(struct iface *iface)
1737 #define IFACE_STATS \
1738 IFACE_STAT(rx_packets, "rx_packets") \
1739 IFACE_STAT(tx_packets, "tx_packets") \
1740 IFACE_STAT(rx_bytes, "rx_bytes") \
1741 IFACE_STAT(tx_bytes, "tx_bytes") \
1742 IFACE_STAT(rx_dropped, "rx_dropped") \
1743 IFACE_STAT(tx_dropped, "tx_dropped") \
1744 IFACE_STAT(rx_errors, "rx_errors") \
1745 IFACE_STAT(tx_errors, "tx_errors") \
1746 IFACE_STAT(rx_frame_errors, "rx_frame_err") \
1747 IFACE_STAT(rx_over_errors, "rx_over_err") \
1748 IFACE_STAT(rx_crc_errors, "rx_crc_err") \
1749 IFACE_STAT(collisions, "collisions")
1751 #define IFACE_STAT(MEMBER, NAME) NAME,
1752 static char *keys[] = { IFACE_STATS };
1754 int64_t values[ARRAY_SIZE(keys)];
1757 struct netdev_stats stats;
1759 if (iface_is_synthetic(iface)) {
1763 /* Intentionally ignore return value, since errors will set 'stats' to
1764 * all-1s, and we will deal with that correctly below. */
1765 netdev_get_stats(iface->netdev, &stats);
1767 /* Copy statistics into values[] array. */
1769 #define IFACE_STAT(MEMBER, NAME) values[i++] = stats.MEMBER;
1772 assert(i == ARRAY_SIZE(keys));
1774 ovsrec_interface_set_statistics(iface->cfg, keys, values, ARRAY_SIZE(keys));
1779 br_refresh_stp_status(struct bridge *br)
1781 struct ofproto *ofproto = br->ofproto;
1782 struct ofproto_stp_status status;
1783 char *keys[3], *values[3];
1786 if (ofproto_get_stp_status(ofproto, &status)) {
1790 if (!status.enabled) {
1791 ovsrec_bridge_set_status(br->cfg, NULL, NULL, 0);
1795 keys[0] = "stp_bridge_id",
1796 values[0] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.bridge_id));
1797 keys[1] = "stp_designated_root",
1798 values[1] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.designated_root));
1799 keys[2] = "stp_root_path_cost",
1800 values[2] = xasprintf("%d", status.root_path_cost);
1802 ovsrec_bridge_set_status(br->cfg, keys, values, ARRAY_SIZE(values));
1804 for (i = 0; i < ARRAY_SIZE(values); i++) {
1810 port_refresh_stp_status(struct port *port)
1812 struct ofproto *ofproto = port->bridge->ofproto;
1813 struct iface *iface;
1814 struct ofproto_port_stp_status status;
1816 char *str_values[4];
1817 int64_t int_values[3];
1820 if (port_is_synthetic(port)) {
1824 /* STP doesn't currently support bonds. */
1825 if (!list_is_singleton(&port->ifaces)) {
1826 ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
1830 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
1832 if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) {
1836 if (!status.enabled) {
1837 ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
1838 ovsrec_port_set_statistics(port->cfg, NULL, NULL, 0);
1842 /* Set Status column. */
1843 keys[0] = "stp_port_id";
1844 str_values[0] = xasprintf(STP_PORT_ID_FMT, status.port_id);
1845 keys[1] = "stp_state";
1846 str_values[1] = xstrdup(stp_state_name(status.state));
1847 keys[2] = "stp_sec_in_state";
1848 str_values[2] = xasprintf("%u", status.sec_in_state);
1849 keys[3] = "stp_role";
1850 str_values[3] = xstrdup(stp_role_name(status.role));
1852 ovsrec_port_set_status(port->cfg, keys, str_values,
1853 ARRAY_SIZE(str_values));
1855 for (i = 0; i < ARRAY_SIZE(str_values); i++) {
1856 free(str_values[i]);
1859 /* Set Statistics column. */
1860 keys[0] = "stp_tx_count";
1861 int_values[0] = status.tx_count;
1862 keys[1] = "stp_rx_count";
1863 int_values[1] = status.rx_count;
1864 keys[2] = "stp_error_count";
1865 int_values[2] = status.error_count;
1867 ovsrec_port_set_statistics(port->cfg, keys, int_values,
1868 ARRAY_SIZE(int_values));
1872 enable_system_stats(const struct ovsrec_open_vswitch *cfg)
1876 /* Use other-config:enable-system-stats by preference. */
1877 enable = get_ovsrec_key_value(cfg->key_other_config,
1878 cfg->value_other_config,
1879 cfg->n_other_config,
1880 "enable-statistics");
1882 return !strcmp(enable, "true");
1885 /* Disable by default. */
1890 refresh_system_stats(const struct ovsrec_open_vswitch *cfg)
1892 struct ovsdb_datum datum;
1896 if (enable_system_stats(cfg)) {
1897 get_system_stats(&stats);
1900 ovsdb_datum_from_shash(&datum, &stats);
1901 ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
1905 static inline const char *
1906 nx_role_to_str(enum nx_role role)
1911 case NX_ROLE_MASTER:
1916 return "*** INVALID ROLE ***";
1921 refresh_controller_status(void)
1925 const struct ovsrec_controller *cfg;
1929 /* Accumulate status for controllers on all bridges. */
1930 HMAP_FOR_EACH (br, node, &all_bridges) {
1931 ofproto_get_ofproto_controller_info(br->ofproto, &info);
1934 /* Update each controller in the database with current status. */
1935 OVSREC_CONTROLLER_FOR_EACH(cfg, idl) {
1936 struct ofproto_controller_info *cinfo =
1937 shash_find_data(&info, cfg->target);
1940 ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
1941 ovsrec_controller_set_role(cfg, nx_role_to_str(cinfo->role));
1942 ovsrec_controller_set_status(cfg, (char **) cinfo->pairs.keys,
1943 (char **) cinfo->pairs.values,
1946 ovsrec_controller_set_is_connected(cfg, false);
1947 ovsrec_controller_set_role(cfg, NULL);
1948 ovsrec_controller_set_status(cfg, NULL, NULL, 0);
1952 ofproto_free_ofproto_controller_info(&info);
1956 refresh_cfm_stats(void)
1958 static struct ovsdb_idl_txn *txn = NULL;
1963 txn = ovsdb_idl_txn_create(idl);
1965 HMAP_FOR_EACH (br, node, &all_bridges) {
1966 struct iface *iface;
1968 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
1969 iface_refresh_cfm_stats(iface);
1974 if (ovsdb_idl_txn_commit(txn) != TXN_INCOMPLETE) {
1975 ovsdb_idl_txn_destroy(txn);
1980 /* Performs periodic activity required by bridges that needs to be done with
1981 * the least possible latency.
1983 * It makes sense to call this function a couple of times per poll loop, to
1984 * provide a significant performance boost on some benchmarks with ofprotos
1985 * that use the ofproto-dpif implementation. */
1987 bridge_run_fast(void)
1991 HMAP_FOR_EACH (br, node, &all_bridges) {
1992 ofproto_run_fast(br->ofproto);
1999 static const struct ovsrec_open_vswitch null_cfg;
2000 const struct ovsrec_open_vswitch *cfg;
2001 struct ovsdb_idl_txn *reconf_txn = NULL;
2003 bool vlan_splinters_changed;
2004 bool database_changed;
2007 /* (Re)configure if necessary. */
2008 if (!reconfiguring) {
2009 database_changed = ovsdb_idl_run(idl);
2010 if (ovsdb_idl_is_lock_contended(idl)) {
2011 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
2012 struct bridge *br, *next_br;
2014 VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
2015 "disabling this process until it goes away");
2017 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
2021 } else if (!ovsdb_idl_has_lock(idl)) {
2025 cfg = ovsrec_open_vswitch_first(idl);
2027 /* Let each bridge do the work that it needs to do. */
2028 HMAP_FOR_EACH (br, node, &all_bridges) {
2029 ofproto_run(br->ofproto);
2032 /* Re-configure SSL. We do this on every trip through the main loop,
2033 * instead of just when the database changes, because the contents of the
2034 * key and certificate files can change without the database changing.
2036 * We do this before bridge_reconfigure() because that function might
2037 * initiate SSL connections and thus requires SSL to be configured. */
2038 if (cfg && cfg->ssl) {
2039 const struct ovsrec_ssl *ssl = cfg->ssl;
2041 stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
2042 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
2045 if (!reconfiguring) {
2046 /* If VLAN splinters are in use, then we need to reconfigure if VLAN
2047 * usage has changed. */
2048 vlan_splinters_changed = false;
2049 if (vlan_splinters_enabled_anywhere) {
2050 HMAP_FOR_EACH (br, node, &all_bridges) {
2051 if (ofproto_has_vlan_usage_changed(br->ofproto)) {
2052 vlan_splinters_changed = true;
2058 if (database_changed || vlan_splinters_changed) {
2060 reconf_txn = ovsdb_idl_txn_create(idl);
2061 bridge_reconfigure(cfg);
2063 /* We still need to reconfigure to avoid dangling pointers to
2064 * now-destroyed ovsrec structures inside bridge data. */
2065 bridge_reconfigure(&null_cfg);
2070 if (reconfiguring) {
2073 reconf_txn = ovsdb_idl_txn_create(idl);
2075 if (bridge_reconfigure_continue(cfg)) {
2076 ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
2079 bridge_reconfigure_continue(&null_cfg);
2084 ovsdb_idl_txn_commit(reconf_txn);
2085 ovsdb_idl_txn_destroy(reconf_txn);
2089 /* Refresh system and interface stats if necessary. */
2090 if (time_msec() >= stats_timer) {
2092 struct ovsdb_idl_txn *txn;
2094 txn = ovsdb_idl_txn_create(idl);
2095 HMAP_FOR_EACH (br, node, &all_bridges) {
2099 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
2100 struct iface *iface;
2102 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
2103 iface_refresh_stats(iface);
2104 iface_refresh_status(iface);
2108 HMAP_FOR_EACH (m, hmap_node, &br->mirrors) {
2109 mirror_refresh_stats(m);
2113 refresh_system_stats(cfg);
2114 refresh_controller_status();
2115 ovsdb_idl_txn_commit(txn);
2116 ovsdb_idl_txn_destroy(txn); /* XXX */
2119 stats_timer = time_msec() + STATS_INTERVAL;
2122 if (time_msec() >= db_limiter) {
2123 struct ovsdb_idl_txn *txn;
2125 txn = ovsdb_idl_txn_create(idl);
2126 HMAP_FOR_EACH (br, node, &all_bridges) {
2127 struct iface *iface;
2130 br_refresh_stp_status(br);
2132 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
2133 port_refresh_stp_status(port);
2136 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
2137 const char *link_state;
2138 int64_t link_resets;
2141 if (iface_is_synthetic(iface)) {
2145 current = ofproto_port_is_lacp_current(br->ofproto,
2149 ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1);
2151 ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0);
2154 link_state = netdev_get_carrier(iface->netdev) ? "up" : "down";
2155 ovsrec_interface_set_link_state(iface->cfg, link_state);
2157 link_resets = netdev_get_carrier_resets(iface->netdev);
2158 ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1);
2162 if (ovsdb_idl_txn_commit(txn) != TXN_UNCHANGED) {
2163 db_limiter = time_msec() + DB_LIMIT_INTERVAL;
2165 ovsdb_idl_txn_destroy(txn);
2168 refresh_cfm_stats();
2174 ovsdb_idl_wait(idl);
2176 if (reconfiguring) {
2177 poll_immediate_wake();
2180 if (!hmap_is_empty(&all_bridges)) {
2183 HMAP_FOR_EACH (br, node, &all_bridges) {
2184 ofproto_wait(br->ofproto);
2186 poll_timer_wait_until(stats_timer);
2188 if (db_limiter > time_msec()) {
2189 poll_timer_wait_until(db_limiter);
2194 /* QoS unixctl user interface functions. */
2196 struct qos_unixctl_show_cbdata {
2198 struct iface *iface;
2202 qos_unixctl_show_cb(unsigned int queue_id,
2203 const struct shash *details,
2206 struct qos_unixctl_show_cbdata *data = aux;
2207 struct ds *ds = data->ds;
2208 struct iface *iface = data->iface;
2209 struct netdev_queue_stats stats;
2210 struct shash_node *node;
2213 ds_put_cstr(ds, "\n");
2215 ds_put_format(ds, "Queue %u:\n", queue_id);
2217 ds_put_cstr(ds, "Default:\n");
2220 SHASH_FOR_EACH (node, details) {
2221 ds_put_format(ds, "\t%s: %s\n", node->name, (char *)node->data);
2224 error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
2226 if (stats.tx_packets != UINT64_MAX) {
2227 ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
2230 if (stats.tx_bytes != UINT64_MAX) {
2231 ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
2234 if (stats.tx_errors != UINT64_MAX) {
2235 ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
2238 ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
2239 queue_id, strerror(error));
2244 qos_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED,
2245 const char *argv[], void *aux OVS_UNUSED)
2247 struct ds ds = DS_EMPTY_INITIALIZER;
2248 struct shash sh = SHASH_INITIALIZER(&sh);
2249 struct iface *iface;
2251 struct shash_node *node;
2252 struct qos_unixctl_show_cbdata data;
2255 iface = iface_find(argv[1]);
2257 unixctl_command_reply_error(conn, "no such interface");
2261 netdev_get_qos(iface->netdev, &type, &sh);
2263 if (*type != '\0') {
2264 ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
2266 SHASH_FOR_EACH (node, &sh) {
2267 ds_put_format(&ds, "%s: %s\n", node->name, (char *)node->data);
2272 error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
2275 ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
2277 unixctl_command_reply(conn, ds_cstr(&ds));
2279 ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
2280 unixctl_command_reply_error(conn, ds_cstr(&ds));
2283 shash_destroy_free_data(&sh);
2287 /* Bridge reconfiguration functions. */
2289 bridge_create(const struct ovsrec_bridge *br_cfg)
2293 assert(!bridge_lookup(br_cfg->name));
2294 br = xzalloc(sizeof *br);
2296 br->name = xstrdup(br_cfg->name);
2297 br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type));
2300 /* Derive the default Ethernet address from the bridge's UUID. This should
2301 * be unique and it will be stable between ovs-vswitchd runs. */
2302 memcpy(br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN);
2303 eth_addr_mark_random(br->default_ea);
2305 hmap_init(&br->ports);
2306 hmap_init(&br->ifaces);
2307 hmap_init(&br->iface_by_name);
2308 hmap_init(&br->mirrors);
2310 hmap_init(&br->if_cfg_todo);
2311 list_init(&br->ofpp_garbage);
2313 hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0));
2317 bridge_destroy(struct bridge *br)
2320 struct mirror *mirror, *next_mirror;
2321 struct port *port, *next_port;
2322 struct if_cfg *if_cfg, *next_if_cfg;
2323 struct ofpp_garbage *garbage, *next_garbage;
2325 HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
2328 HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) {
2329 mirror_destroy(mirror);
2331 HMAP_FOR_EACH_SAFE (if_cfg, next_if_cfg, hmap_node, &br->if_cfg_todo) {
2332 hmap_remove(&br->if_cfg_todo, &if_cfg->hmap_node);
2335 LIST_FOR_EACH_SAFE (garbage, next_garbage, list_node,
2336 &br->ofpp_garbage) {
2337 list_remove(&garbage->list_node);
2341 hmap_remove(&all_bridges, &br->node);
2342 ofproto_destroy(br->ofproto);
2343 hmap_destroy(&br->ifaces);
2344 hmap_destroy(&br->ports);
2345 hmap_destroy(&br->iface_by_name);
2346 hmap_destroy(&br->mirrors);
2347 hmap_destroy(&br->if_cfg_todo);
2354 static struct bridge *
2355 bridge_lookup(const char *name)
2359 HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) {
2360 if (!strcmp(br->name, name)) {
2367 /* Handle requests for a listing of all flows known by the OpenFlow
2368 * stack, including those normally hidden. */
2370 bridge_unixctl_dump_flows(struct unixctl_conn *conn, int argc OVS_UNUSED,
2371 const char *argv[], void *aux OVS_UNUSED)
2376 br = bridge_lookup(argv[1]);
2378 unixctl_command_reply_error(conn, "Unknown bridge");
2383 ofproto_get_all_flows(br->ofproto, &results);
2385 unixctl_command_reply(conn, ds_cstr(&results));
2386 ds_destroy(&results);
2389 /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
2390 * connections and reconnect. If BRIDGE is not specified, then all bridges
2391 * drop their controller connections and reconnect. */
2393 bridge_unixctl_reconnect(struct unixctl_conn *conn, int argc,
2394 const char *argv[], void *aux OVS_UNUSED)
2398 br = bridge_lookup(argv[1]);
2400 unixctl_command_reply_error(conn, "Unknown bridge");
2403 ofproto_reconnect_controllers(br->ofproto);
2405 HMAP_FOR_EACH (br, node, &all_bridges) {
2406 ofproto_reconnect_controllers(br->ofproto);
2409 unixctl_command_reply(conn, NULL);
2413 bridge_get_controllers(const struct bridge *br,
2414 struct ovsrec_controller ***controllersp)
2416 struct ovsrec_controller **controllers;
2417 size_t n_controllers;
2419 controllers = br->cfg->controller;
2420 n_controllers = br->cfg->n_controller;
2422 if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
2428 *controllersp = controllers;
2430 return n_controllers;
2434 bridge_queue_if_cfg(struct bridge *br,
2435 const struct ovsrec_interface *cfg,
2436 const struct ovsrec_port *parent)
2438 struct if_cfg *if_cfg = xmalloc(sizeof *if_cfg);
2441 if_cfg->parent = parent;
2442 hmap_insert(&br->if_cfg_todo, &if_cfg->hmap_node,
2443 hash_string(if_cfg->cfg->name, 0));
2446 /* Deletes "struct port"s and "struct iface"s under 'br' which aren't
2447 * consistent with 'br->cfg'. Updates 'br->if_cfg_queue' with interfaces which
2448 * 'br' needs to complete its configuration. */
2450 bridge_add_del_ports(struct bridge *br,
2451 const unsigned long int *splinter_vlans)
2453 struct shash_node *port_node;
2454 struct port *port, *next;
2455 struct shash new_ports;
2458 assert(hmap_is_empty(&br->if_cfg_todo));
2460 /* Collect new ports. */
2461 shash_init(&new_ports);
2462 for (i = 0; i < br->cfg->n_ports; i++) {
2463 const char *name = br->cfg->ports[i]->name;
2464 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
2465 VLOG_WARN("bridge %s: %s specified twice as bridge port",
2469 if (bridge_get_controllers(br, NULL)
2470 && !shash_find(&new_ports, br->name)) {
2471 VLOG_WARN("bridge %s: no port named %s, synthesizing one",
2472 br->name, br->name);
2474 br->synth_local_port.interfaces = &br->synth_local_ifacep;
2475 br->synth_local_port.n_interfaces = 1;
2476 br->synth_local_port.name = br->name;
2478 br->synth_local_iface.name = br->name;
2479 br->synth_local_iface.type = "internal";
2481 br->synth_local_ifacep = &br->synth_local_iface;
2483 shash_add(&new_ports, br->name, &br->synth_local_port);
2486 if (splinter_vlans) {
2487 add_vlan_splinter_ports(br, splinter_vlans, &new_ports);
2490 /* Get rid of deleted ports.
2491 * Get rid of deleted interfaces on ports that still exist. */
2492 HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) {
2493 port->cfg = shash_find_data(&new_ports, port->name);
2497 port_del_ifaces(port);
2501 /* Update iface->cfg and iface->type in interfaces that still exist.
2502 * Add new interfaces to creation queue. */
2503 SHASH_FOR_EACH (port_node, &new_ports) {
2504 const struct ovsrec_port *port = port_node->data;
2507 for (i = 0; i < port->n_interfaces; i++) {
2508 const struct ovsrec_interface *cfg = port->interfaces[i];
2509 struct iface *iface = iface_lookup(br, cfg->name);
2513 iface->type = iface_get_type(cfg, br->cfg);
2515 bridge_queue_if_cfg(br, cfg, port);
2520 shash_destroy(&new_ports);
2523 /* Initializes 'oc' appropriately as a management service controller for
2526 * The caller must free oc->target when it is no longer needed. */
2528 bridge_ofproto_controller_for_mgmt(const struct bridge *br,
2529 struct ofproto_controller *oc)
2531 oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name);
2532 oc->max_backoff = 0;
2533 oc->probe_interval = 60;
2534 oc->band = OFPROTO_OUT_OF_BAND;
2536 oc->burst_limit = 0;
2537 oc->enable_async_msgs = true;
2540 /* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */
2542 bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
2543 struct ofproto_controller *oc)
2545 oc->target = c->target;
2546 oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
2547 oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
2548 oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
2549 ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
2550 oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
2551 oc->burst_limit = (c->controller_burst_limit
2552 ? *c->controller_burst_limit : 0);
2553 oc->enable_async_msgs = (!c->enable_async_messages
2554 || *c->enable_async_messages);
2557 /* Configures the IP stack for 'br''s local interface properly according to the
2558 * configuration in 'c'. */
2560 bridge_configure_local_iface_netdev(struct bridge *br,
2561 struct ovsrec_controller *c)
2563 struct netdev *netdev;
2564 struct in_addr mask, gateway;
2566 struct iface *local_iface;
2569 /* If there's no local interface or no IP address, give up. */
2570 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
2571 if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
2575 /* Bring up the local interface. */
2576 netdev = local_iface->netdev;
2577 netdev_turn_flags_on(netdev, NETDEV_UP, true);
2579 /* Configure the IP address and netmask. */
2580 if (!c->local_netmask
2581 || !inet_aton(c->local_netmask, &mask)
2583 mask.s_addr = guess_netmask(ip.s_addr);
2585 if (!netdev_set_in4(netdev, ip, mask)) {
2586 VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
2587 br->name, IP_ARGS(&ip.s_addr), IP_ARGS(&mask.s_addr));
2590 /* Configure the default gateway. */
2591 if (c->local_gateway
2592 && inet_aton(c->local_gateway, &gateway)
2593 && gateway.s_addr) {
2594 if (!netdev_add_router(netdev, gateway)) {
2595 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
2596 br->name, IP_ARGS(&gateway.s_addr));
2601 /* Returns true if 'a' and 'b' are the same except that any number of slashes
2602 * in either string are treated as equal to any number of slashes in the other,
2603 * e.g. "x///y" is equal to "x/y". */
2605 equal_pathnames(const char *a, const char *b)
2609 a += strspn(a, "/");
2610 b += strspn(b, "/");
2611 } else if (*a == '\0') {
2622 bridge_configure_remotes(struct bridge *br,
2623 const struct sockaddr_in *managers, size_t n_managers)
2625 const char *disable_ib_str, *queue_id_str;
2626 bool disable_in_band = false;
2629 struct ovsrec_controller **controllers;
2630 size_t n_controllers;
2632 enum ofproto_fail_mode fail_mode;
2634 struct ofproto_controller *ocs;
2638 /* Check if we should disable in-band control on this bridge. */
2639 disable_ib_str = bridge_get_other_config(br->cfg, "disable-in-band");
2640 if (disable_ib_str && !strcmp(disable_ib_str, "true")) {
2641 disable_in_band = true;
2644 /* Set OpenFlow queue ID for in-band control. */
2645 queue_id_str = bridge_get_other_config(br->cfg, "in-band-queue");
2646 queue_id = queue_id_str ? strtol(queue_id_str, NULL, 10) : -1;
2647 ofproto_set_in_band_queue(br->ofproto, queue_id);
2649 if (disable_in_band) {
2650 ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
2652 ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
2655 n_controllers = bridge_get_controllers(br, &controllers);
2657 ocs = xmalloc((n_controllers + 1) * sizeof *ocs);
2660 bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]);
2661 for (i = 0; i < n_controllers; i++) {
2662 struct ovsrec_controller *c = controllers[i];
2664 if (!strncmp(c->target, "punix:", 6)
2665 || !strncmp(c->target, "unix:", 5)) {
2666 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2669 whitelist = xasprintf("unix:%s/%s.controller",
2670 ovs_rundir(), br->name);
2671 if (!equal_pathnames(c->target, whitelist)) {
2672 /* Prevent remote ovsdb-server users from accessing arbitrary
2673 * Unix domain sockets and overwriting arbitrary local
2675 VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket "
2676 "controller \"%s\" due to possibility for remote "
2677 "exploit. Instead, specify whitelisted \"%s\" or "
2678 "connect to \"unix:%s/%s.mgmt\" (which is always "
2679 "available without special configuration).",
2680 br->name, c->target, whitelist,
2681 ovs_rundir(), br->name);
2689 bridge_configure_local_iface_netdev(br, c);
2690 bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]);
2691 if (disable_in_band) {
2692 ocs[n_ocs].band = OFPROTO_OUT_OF_BAND;
2697 ofproto_set_controllers(br->ofproto, ocs, n_ocs);
2698 free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */
2701 /* Set the fail-mode. */
2702 fail_mode = !br->cfg->fail_mode
2703 || !strcmp(br->cfg->fail_mode, "standalone")
2704 ? OFPROTO_FAIL_STANDALONE
2705 : OFPROTO_FAIL_SECURE;
2706 ofproto_set_fail_mode(br->ofproto, fail_mode);
2708 /* Configure OpenFlow controller connection snooping. */
2709 if (!ofproto_has_snoops(br->ofproto)) {
2713 sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop",
2714 ovs_rundir(), br->name));
2715 ofproto_set_snoops(br->ofproto, &snoops);
2716 sset_destroy(&snoops);
2721 bridge_configure_tables(struct bridge *br)
2723 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2727 n_tables = ofproto_get_n_tables(br->ofproto);
2729 for (i = 0; i < n_tables; i++) {
2730 struct ofproto_table_settings s;
2733 s.max_flows = UINT_MAX;
2737 if (j < br->cfg->n_flow_tables && i == br->cfg->key_flow_tables[j]) {
2738 struct ovsrec_flow_table *cfg = br->cfg->value_flow_tables[j++];
2741 if (cfg->n_flow_limit && *cfg->flow_limit < UINT_MAX) {
2742 s.max_flows = *cfg->flow_limit;
2744 if (cfg->overflow_policy
2745 && !strcmp(cfg->overflow_policy, "evict")) {
2748 s.groups = xmalloc(cfg->n_groups * sizeof *s.groups);
2749 for (k = 0; k < cfg->n_groups; k++) {
2750 const char *string = cfg->groups[k];
2753 msg = mf_parse_subfield__(&s.groups[k], &string);
2755 VLOG_WARN_RL(&rl, "bridge %s table %d: error parsing "
2756 "'groups' (%s)", br->name, i, msg);
2758 } else if (*string) {
2759 VLOG_WARN_RL(&rl, "bridge %s table %d: 'groups' "
2760 "element '%s' contains trailing garbage",
2761 br->name, i, cfg->groups[k]);
2769 ofproto_configure_table(br->ofproto, i, &s);
2773 for (; j < br->cfg->n_flow_tables; j++) {
2774 VLOG_WARN_RL(&rl, "bridge %s: ignoring configuration for flow table "
2775 "%"PRId64" not supported by this datapath", br->name,
2776 br->cfg->key_flow_tables[j]);
2780 /* Port functions. */
2782 static struct port *
2783 port_create(struct bridge *br, const struct ovsrec_port *cfg)
2787 port = xzalloc(sizeof *port);
2789 port->name = xstrdup(cfg->name);
2791 list_init(&port->ifaces);
2793 hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0));
2798 get_port_other_config(const struct ovsrec_port *port, const char *key,
2799 const char *default_value)
2803 value = get_ovsrec_key_value(port->key_other_config,
2804 port->value_other_config,
2805 port->n_other_config, key);
2806 return value ? value : default_value;
2810 get_interface_other_config(const struct ovsrec_interface *iface,
2811 const char *key, const char *default_value)
2815 value = get_ovsrec_key_value(iface->key_other_config,
2816 iface->value_other_config,
2817 iface->n_other_config, key);
2818 return value ? value : default_value;
2821 /* Deletes interfaces from 'port' that are no longer configured for it. */
2823 port_del_ifaces(struct port *port)
2825 struct iface *iface, *next;
2826 struct sset new_ifaces;
2829 /* Collect list of new interfaces. */
2830 sset_init(&new_ifaces);
2831 for (i = 0; i < port->cfg->n_interfaces; i++) {
2832 const char *name = port->cfg->interfaces[i]->name;
2833 const char *type = port->cfg->interfaces[i]->name;
2834 if (strcmp(type, "null")) {
2835 sset_add(&new_ifaces, name);
2839 /* Get rid of deleted interfaces. */
2840 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2841 if (!sset_contains(&new_ifaces, iface->name)) {
2842 iface_destroy(iface);
2846 sset_destroy(&new_ifaces);
2850 port_destroy(struct port *port)
2853 struct bridge *br = port->bridge;
2854 struct iface *iface, *next;
2857 ofproto_bundle_unregister(br->ofproto, port);
2860 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2861 iface_destroy(iface);
2864 hmap_remove(&br->ports, &port->hmap_node);
2870 static struct port *
2871 port_lookup(const struct bridge *br, const char *name)
2875 HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0),
2877 if (!strcmp(port->name, name)) {
2885 enable_lacp(struct port *port, bool *activep)
2887 if (!port->cfg->lacp) {
2888 /* XXX when LACP implementation has been sufficiently tested, enable by
2889 * default and make active on bonded ports. */
2891 } else if (!strcmp(port->cfg->lacp, "off")) {
2893 } else if (!strcmp(port->cfg->lacp, "active")) {
2896 } else if (!strcmp(port->cfg->lacp, "passive")) {
2900 VLOG_WARN("port %s: unknown LACP mode %s",
2901 port->name, port->cfg->lacp);
2906 static struct lacp_settings *
2907 port_configure_lacp(struct port *port, struct lacp_settings *s)
2909 const char *lacp_time, *system_id;
2910 long long int custom_time;
2913 if (!enable_lacp(port, &s->active)) {
2917 s->name = port->name;
2919 system_id = get_port_other_config(port->cfg, "lacp-system-id", NULL);
2921 if (sscanf(system_id, ETH_ADDR_SCAN_FMT,
2922 ETH_ADDR_SCAN_ARGS(s->id)) != ETH_ADDR_SCAN_COUNT) {
2923 VLOG_WARN("port %s: LACP system ID (%s) must be an Ethernet"
2924 " address.", port->name, system_id);
2928 memcpy(s->id, port->bridge->ea, ETH_ADDR_LEN);
2931 if (eth_addr_is_zero(s->id)) {
2932 VLOG_WARN("port %s: Invalid zero LACP system ID.", port->name);
2936 /* Prefer bondable links if unspecified. */
2937 priority = atoi(get_port_other_config(port->cfg, "lacp-system-priority",
2939 s->priority = (priority > 0 && priority <= UINT16_MAX
2941 : UINT16_MAX - !list_is_short(&port->ifaces));
2943 s->heartbeat = !strcmp(get_port_other_config(port->cfg,
2947 lacp_time = get_port_other_config(port->cfg, "lacp-time", "slow");
2948 custom_time = atoi(lacp_time);
2949 if (!strcmp(lacp_time, "fast")) {
2950 s->lacp_time = LACP_TIME_FAST;
2951 } else if (!strcmp(lacp_time, "slow")) {
2952 s->lacp_time = LACP_TIME_SLOW;
2953 } else if (custom_time > 0) {
2954 s->lacp_time = LACP_TIME_CUSTOM;
2955 s->custom_time = custom_time;
2957 s->lacp_time = LACP_TIME_SLOW;
2964 iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s)
2966 int priority, portid, key;
2968 portid = atoi(get_interface_other_config(iface->cfg, "lacp-port-id", "0"));
2969 priority = atoi(get_interface_other_config(iface->cfg,
2970 "lacp-port-priority", "0"));
2971 key = atoi(get_interface_other_config(iface->cfg, "lacp-aggregation-key",
2974 if (portid <= 0 || portid > UINT16_MAX) {
2975 portid = iface->ofp_port;
2978 if (priority <= 0 || priority > UINT16_MAX) {
2979 priority = UINT16_MAX;
2982 if (key < 0 || key > UINT16_MAX) {
2986 s->name = iface->name;
2988 s->priority = priority;
2993 port_configure_bond(struct port *port, struct bond_settings *s,
2994 uint32_t *bond_stable_ids)
2996 const char *detect_s;
2997 struct iface *iface;
2998 int miimon_interval;
3001 s->name = port->name;
3003 if (port->cfg->bond_mode) {
3004 if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
3005 VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
3006 port->name, port->cfg->bond_mode,
3007 bond_mode_to_string(s->balance));
3010 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
3012 /* XXX: Post version 1.5.*, the default bond_mode changed from SLB to
3013 * active-backup. At some point we should remove this warning. */
3014 VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that"
3015 " in previous versions, the default bond_mode was"
3016 " balance-slb", port->name,
3017 bond_mode_to_string(s->balance));
3019 if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
3020 VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
3021 "please use another bond type or disable flood_vlans",
3025 miimon_interval = atoi(get_port_other_config(port->cfg,
3026 "bond-miimon-interval", "0"));
3027 if (miimon_interval <= 0) {
3028 miimon_interval = 200;
3031 detect_s = get_port_other_config(port->cfg, "bond-detect-mode", "carrier");
3032 if (!strcmp(detect_s, "carrier")) {
3033 miimon_interval = 0;
3034 } else if (strcmp(detect_s, "miimon")) {
3035 VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
3036 "defaulting to carrier", port->name, detect_s);
3037 miimon_interval = 0;
3040 s->up_delay = MAX(0, port->cfg->bond_updelay);
3041 s->down_delay = MAX(0, port->cfg->bond_downdelay);
3042 s->basis = atoi(get_port_other_config(port->cfg, "bond-hash-basis", "0"));
3043 s->rebalance_interval = atoi(
3044 get_port_other_config(port->cfg, "bond-rebalance-interval", "10000"));
3045 if (s->rebalance_interval && s->rebalance_interval < 1000) {
3046 s->rebalance_interval = 1000;
3049 s->fake_iface = port->cfg->bond_fake_iface;
3052 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
3053 long long stable_id;
3055 stable_id = atoll(get_interface_other_config(iface->cfg,
3056 "bond-stable-id", "0"));
3057 if (stable_id <= 0 || stable_id >= UINT32_MAX) {
3058 stable_id = iface->ofp_port;
3060 bond_stable_ids[i++] = stable_id;
3062 netdev_set_miimon_interval(iface->netdev, miimon_interval);
3066 /* Returns true if 'port' is synthetic, that is, if we constructed it locally
3067 * instead of obtaining it from the database. */
3069 port_is_synthetic(const struct port *port)
3071 return ovsdb_idl_row_is_synthetic(&port->cfg->header_);
3074 /* Interface functions. */
3076 /* Returns the correct network device type for interface 'iface' in bridge
3079 iface_get_type(const struct ovsrec_interface *iface,
3080 const struct ovsrec_bridge *br)
3082 /* The local port always has type "internal". Other ports take their type
3083 * from the database and default to "system" if none is specified. */
3084 return (!strcmp(iface->name, br->name) ? "internal"
3085 : iface->type[0] ? iface->type
3090 iface_destroy(struct iface *iface)
3093 struct port *port = iface->port;
3094 struct bridge *br = port->bridge;
3096 if (br->ofproto && iface->ofp_port >= 0) {
3097 ofproto_port_unregister(br->ofproto, iface->ofp_port);
3100 if (iface->ofp_port >= 0) {
3101 hmap_remove(&br->ifaces, &iface->ofp_port_node);
3104 list_remove(&iface->port_elem);
3105 hmap_remove(&br->iface_by_name, &iface->name_node);
3107 netdev_close(iface->netdev);
3114 static struct iface *
3115 iface_lookup(const struct bridge *br, const char *name)
3117 struct iface *iface;
3119 HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0),
3120 &br->iface_by_name) {
3121 if (!strcmp(iface->name, name)) {
3129 static struct iface *
3130 iface_find(const char *name)
3132 const struct bridge *br;
3134 HMAP_FOR_EACH (br, node, &all_bridges) {
3135 struct iface *iface = iface_lookup(br, name);
3144 static struct if_cfg *
3145 if_cfg_lookup(const struct bridge *br, const char *name)
3147 struct if_cfg *if_cfg;
3149 HMAP_FOR_EACH_WITH_HASH (if_cfg, hmap_node, hash_string(name, 0),
3151 if (!strcmp(if_cfg->cfg->name, name)) {
3159 static struct iface *
3160 iface_from_ofp_port(const struct bridge *br, uint16_t ofp_port)
3162 struct iface *iface;
3164 HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node,
3165 hash_int(ofp_port, 0), &br->ifaces) {
3166 if (iface->ofp_port == ofp_port) {
3173 /* Set Ethernet address of 'iface', if one is specified in the configuration
3176 iface_set_mac(struct iface *iface)
3178 uint8_t ea[ETH_ADDR_LEN];
3180 if (!strcmp(iface->type, "internal")
3181 && iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
3182 if (iface->ofp_port == OFPP_LOCAL) {
3183 VLOG_ERR("interface %s: ignoring mac in Interface record "
3184 "(use Bridge record to set local port's mac)",
3186 } else if (eth_addr_is_multicast(ea)) {
3187 VLOG_ERR("interface %s: cannot set MAC to multicast address",
3190 int error = netdev_set_etheraddr(iface->netdev, ea);
3192 VLOG_ERR("interface %s: setting MAC failed (%s)",
3193 iface->name, strerror(error));
3199 /* Sets the ofport column of 'if_cfg' to 'ofport'. */
3201 iface_set_ofport(const struct ovsrec_interface *if_cfg, int64_t ofport)
3203 if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
3204 ovsrec_interface_set_ofport(if_cfg, &ofport, 1);
3208 /* Clears all of the fields in 'if_cfg' that indicate interface status, and
3209 * sets the "ofport" field to -1.
3211 * This is appropriate when 'if_cfg''s interface cannot be created or is
3212 * otherwise invalid. */
3214 iface_clear_db_record(const struct ovsrec_interface *if_cfg)
3216 if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
3217 iface_set_ofport(if_cfg, -1);
3218 ovsrec_interface_set_status(if_cfg, NULL, NULL, 0);
3219 ovsrec_interface_set_admin_state(if_cfg, NULL);
3220 ovsrec_interface_set_duplex(if_cfg, NULL);
3221 ovsrec_interface_set_link_speed(if_cfg, NULL, 0);
3222 ovsrec_interface_set_link_state(if_cfg, NULL);
3223 ovsrec_interface_set_mtu(if_cfg, NULL, 0);
3224 ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0);
3225 ovsrec_interface_set_cfm_fault_status(if_cfg, NULL, 0);
3226 ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0);
3227 ovsrec_interface_set_lacp_current(if_cfg, NULL, 0);
3228 ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0);
3232 /* Adds the 'n' key-value pairs in 'keys' in 'values' to 'shash'.
3234 * The value strings in '*shash' are taken directly from values[], not copied,
3235 * so the caller should not modify or free them. */
3237 shash_from_ovs_idl_map(char **keys, char **values, size_t n,
3238 struct shash *shash)
3243 for (i = 0; i < n; i++) {
3244 shash_add(shash, keys[i], values[i]);
3248 /* Creates 'keys' and 'values' arrays from 'shash'.
3250 * Sets 'keys' and 'values' to heap allocated arrays representing the key-value
3251 * pairs in 'shash'. The caller takes ownership of 'keys' and 'values'. They
3252 * are populated with with strings taken directly from 'shash' and thus have
3253 * the same ownership of the key-value pairs in shash.
3256 shash_to_ovs_idl_map(struct shash *shash,
3257 char ***keys, char ***values, size_t *n)
3261 struct shash_node *sn;
3263 count = shash_count(shash);
3265 k = xmalloc(count * sizeof *k);
3266 v = xmalloc(count * sizeof *v);
3269 SHASH_FOR_EACH(sn, shash) {
3280 struct iface_delete_queues_cbdata {
3281 struct netdev *netdev;
3282 const struct ovsdb_datum *queues;
3286 queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
3288 union ovsdb_atom atom;
3290 atom.integer = target;
3291 return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
3295 iface_delete_queues(unsigned int queue_id,
3296 const struct shash *details OVS_UNUSED, void *cbdata_)
3298 struct iface_delete_queues_cbdata *cbdata = cbdata_;
3300 if (!queue_ids_include(cbdata->queues, queue_id)) {
3301 netdev_delete_queue(cbdata->netdev, queue_id);
3306 iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos)
3308 struct ofpbuf queues_buf;
3310 ofpbuf_init(&queues_buf, 0);
3312 if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) {
3313 netdev_set_qos(iface->netdev, NULL, NULL);
3315 struct iface_delete_queues_cbdata cbdata;
3316 struct shash details;
3320 /* Configure top-level Qos for 'iface'. */
3321 shash_from_ovs_idl_map(qos->key_other_config, qos->value_other_config,
3322 qos->n_other_config, &details);
3323 netdev_set_qos(iface->netdev, qos->type, &details);
3324 shash_destroy(&details);
3326 /* Deconfigure queues that were deleted. */
3327 cbdata.netdev = iface->netdev;
3328 cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
3330 netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
3332 /* Configure queues for 'iface'. */
3334 for (i = 0; i < qos->n_queues; i++) {
3335 const struct ovsrec_queue *queue = qos->value_queues[i];
3336 unsigned int queue_id = qos->key_queues[i];
3338 if (queue_id == 0) {
3342 if (queue->n_dscp == 1) {
3343 struct ofproto_port_queue *port_queue;
3345 port_queue = ofpbuf_put_uninit(&queues_buf,
3346 sizeof *port_queue);
3347 port_queue->queue = queue_id;
3348 port_queue->dscp = queue->dscp[0];
3351 shash_from_ovs_idl_map(queue->key_other_config,
3352 queue->value_other_config,
3353 queue->n_other_config, &details);
3354 netdev_set_queue(iface->netdev, queue_id, &details);
3355 shash_destroy(&details);
3358 shash_init(&details);
3359 netdev_set_queue(iface->netdev, 0, &details);
3360 shash_destroy(&details);
3364 if (iface->ofp_port >= 0) {
3365 const struct ofproto_port_queue *port_queues = queues_buf.data;
3366 size_t n_queues = queues_buf.size / sizeof *port_queues;
3368 ofproto_port_set_queues(iface->port->bridge->ofproto, iface->ofp_port,
3369 port_queues, n_queues);
3372 netdev_set_policing(iface->netdev,
3373 iface->cfg->ingress_policing_rate,
3374 iface->cfg->ingress_policing_burst);
3376 ofpbuf_uninit(&queues_buf);
3380 iface_configure_cfm(struct iface *iface)
3382 const struct ovsrec_interface *cfg = iface->cfg;
3383 const char *extended_str, *opstate_str;
3384 struct cfm_settings s;
3386 if (!cfg->n_cfm_mpid) {
3387 ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port);
3391 s.mpid = *cfg->cfm_mpid;
3392 s.interval = atoi(get_interface_other_config(iface->cfg, "cfm_interval",
3394 s.ccm_vlan = atoi(get_interface_other_config(iface->cfg, "cfm_ccm_vlan",
3396 s.ccm_pcp = atoi(get_interface_other_config(iface->cfg, "cfm_ccm_pcp",
3398 if (s.interval <= 0) {
3402 extended_str = get_interface_other_config(iface->cfg, "cfm_extended",
3404 s.extended = !strcasecmp("true", extended_str);
3406 opstate_str = get_interface_other_config(iface->cfg, "cfm_opstate", "up");
3407 s.opup = !strcasecmp("up", opstate_str);
3409 ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s);
3412 /* Returns true if 'iface' is synthetic, that is, if we constructed it locally
3413 * instead of obtaining it from the database. */
3415 iface_is_synthetic(const struct iface *iface)
3417 return ovsdb_idl_row_is_synthetic(&iface->cfg->header_);
3420 /* Port mirroring. */
3422 static struct mirror *
3423 mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
3427 HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) {
3428 if (uuid_equals(uuid, &m->uuid)) {
3436 bridge_configure_mirrors(struct bridge *br)
3438 const struct ovsdb_datum *mc;
3439 unsigned long *flood_vlans;
3440 struct mirror *m, *next;
3443 /* Get rid of deleted mirrors. */
3444 mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
3445 HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) {
3446 union ovsdb_atom atom;
3448 atom.uuid = m->uuid;
3449 if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
3454 /* Add new mirrors and reconfigure existing ones. */
3455 for (i = 0; i < br->cfg->n_mirrors; i++) {
3456 const struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
3457 struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
3459 m = mirror_create(br, cfg);
3462 if (!mirror_configure(m)) {
3467 /* Update flooded vlans (for RSPAN). */
3468 flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans,
3469 br->cfg->n_flood_vlans);
3470 ofproto_set_flood_vlans(br->ofproto, flood_vlans);
3471 bitmap_free(flood_vlans);
3474 static struct mirror *
3475 mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg)
3479 m = xzalloc(sizeof *m);
3480 m->uuid = cfg->header_.uuid;
3481 hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid));
3483 m->name = xstrdup(cfg->name);
3489 mirror_destroy(struct mirror *m)
3492 struct bridge *br = m->bridge;
3495 ofproto_mirror_unregister(br->ofproto, m);
3498 hmap_remove(&br->mirrors, &m->hmap_node);
3505 mirror_collect_ports(struct mirror *m,
3506 struct ovsrec_port **in_ports, int n_in_ports,
3507 void ***out_portsp, size_t *n_out_portsp)
3509 void **out_ports = xmalloc(n_in_ports * sizeof *out_ports);
3510 size_t n_out_ports = 0;
3513 for (i = 0; i < n_in_ports; i++) {
3514 const char *name = in_ports[i]->name;
3515 struct port *port = port_lookup(m->bridge, name);
3517 out_ports[n_out_ports++] = port;
3519 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
3520 "port %s", m->bridge->name, m->name, name);
3523 *out_portsp = out_ports;
3524 *n_out_portsp = n_out_ports;
3528 mirror_configure(struct mirror *m)
3530 const struct ovsrec_mirror *cfg = m->cfg;
3531 struct ofproto_mirror_settings s;
3534 if (strcmp(cfg->name, m->name)) {
3536 m->name = xstrdup(cfg->name);
3540 /* Get output port or VLAN. */
3541 if (cfg->output_port) {
3542 s.out_bundle = port_lookup(m->bridge, cfg->output_port->name);
3543 if (!s.out_bundle) {
3544 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
3545 m->bridge->name, m->name);
3548 s.out_vlan = UINT16_MAX;
3550 if (cfg->output_vlan) {
3551 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
3552 "output vlan; ignoring output vlan",
3553 m->bridge->name, m->name);
3555 } else if (cfg->output_vlan) {
3556 /* The database should prevent invalid VLAN values. */
3557 s.out_bundle = NULL;
3558 s.out_vlan = *cfg->output_vlan;
3560 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
3561 m->bridge->name, m->name);
3565 /* Get port selection. */
3566 if (cfg->select_all) {
3567 size_t n_ports = hmap_count(&m->bridge->ports);
3568 void **ports = xmalloc(n_ports * sizeof *ports);
3573 HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) {
3583 /* Get ports, dropping ports that don't exist.
3584 * The IDL ensures that there are no duplicates. */
3585 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
3586 &s.srcs, &s.n_srcs);
3587 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
3588 &s.dsts, &s.n_dsts);
3591 /* Get VLAN selection. */
3592 s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan);
3595 ofproto_mirror_register(m->bridge->ofproto, m, &s);
3598 if (s.srcs != s.dsts) {
3607 /* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.)
3609 * This is deprecated. It is only for compatibility with broken device drivers
3610 * in old versions of Linux that do not properly support VLANs when VLAN
3611 * devices are not used. When broken device drivers are no longer in
3612 * widespread use, we will delete these interfaces. */
3614 static void **blocks;
3615 static size_t n_blocks, allocated_blocks;
3617 /* Adds 'block' to a list of blocks that have to be freed with free() when the
3618 * VLAN splinters are reconfigured. */
3620 register_block(void *block)
3622 if (n_blocks >= allocated_blocks) {
3623 blocks = x2nrealloc(blocks, &allocated_blocks, sizeof *blocks);
3625 blocks[n_blocks++] = block;
3628 /* Frees all of the blocks registered with register_block(). */
3630 free_registered_blocks(void)
3634 for (i = 0; i < n_blocks; i++) {
3640 /* Returns true if VLAN splinters are enabled on 'iface_cfg', false
3643 vlan_splinters_is_enabled(const struct ovsrec_interface *iface_cfg)
3647 value = get_interface_other_config(iface_cfg, "enable-vlan-splinters", "");
3648 return !strcmp(value, "true");
3651 /* Figures out the set of VLANs that are in use for the purpose of VLAN
3654 * If VLAN splinters are enabled on at least one interface and any VLANs are in
3655 * use, returns a 4096-bit bitmap with a 1-bit for each in-use VLAN (bits 0 and
3656 * 4095 will not be set). The caller is responsible for freeing the bitmap,
3659 * If VLANs splinters are not enabled on any interface or if no VLANs are in
3660 * use, returns NULL.
3662 * Updates 'vlan_splinters_enabled_anywhere'. */
3663 static unsigned long int *
3664 collect_splinter_vlans(const struct ovsrec_open_vswitch *ovs_cfg)
3666 unsigned long int *splinter_vlans;
3667 struct sset splinter_ifaces;
3668 const char *real_dev_name;
3669 struct shash *real_devs;
3670 struct shash_node *node;
3674 /* Free space allocated for synthesized ports and interfaces, since we're
3675 * in the process of reconstructing all of them. */
3676 free_registered_blocks();
3678 splinter_vlans = bitmap_allocate(4096);
3679 sset_init(&splinter_ifaces);
3680 vlan_splinters_enabled_anywhere = false;
3681 for (i = 0; i < ovs_cfg->n_bridges; i++) {
3682 struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i];
3685 for (j = 0; j < br_cfg->n_ports; j++) {
3686 struct ovsrec_port *port_cfg = br_cfg->ports[j];
3689 for (k = 0; k < port_cfg->n_interfaces; k++) {
3690 struct ovsrec_interface *iface_cfg = port_cfg->interfaces[k];
3692 if (vlan_splinters_is_enabled(iface_cfg)) {
3693 vlan_splinters_enabled_anywhere = true;
3694 sset_add(&splinter_ifaces, iface_cfg->name);
3695 vlan_bitmap_from_array__(port_cfg->trunks,
3701 if (port_cfg->tag && *port_cfg->tag > 0 && *port_cfg->tag < 4095) {
3702 bitmap_set1(splinter_vlans, *port_cfg->tag);
3707 if (!vlan_splinters_enabled_anywhere) {
3708 free(splinter_vlans);
3709 sset_destroy(&splinter_ifaces);
3713 HMAP_FOR_EACH (br, node, &all_bridges) {
3715 ofproto_get_vlan_usage(br->ofproto, splinter_vlans);
3719 /* Don't allow VLANs 0 or 4095 to be splintered. VLAN 0 should appear on
3720 * the real device. VLAN 4095 is reserved and Linux doesn't allow a VLAN
3721 * device to be created for it. */
3722 bitmap_set0(splinter_vlans, 0);
3723 bitmap_set0(splinter_vlans, 4095);
3725 /* Delete all VLAN devices that we don't need. */
3727 real_devs = vlandev_get_real_devs();
3728 SHASH_FOR_EACH (node, real_devs) {
3729 const struct vlan_real_dev *real_dev = node->data;
3730 const struct vlan_dev *vlan_dev;
3731 bool real_dev_has_splinters;
3733 real_dev_has_splinters = sset_contains(&splinter_ifaces,
3735 HMAP_FOR_EACH (vlan_dev, hmap_node, &real_dev->vlan_devs) {
3736 if (!real_dev_has_splinters
3737 || !bitmap_is_set(splinter_vlans, vlan_dev->vid)) {
3738 struct netdev *netdev;
3740 if (!netdev_open(vlan_dev->name, "system", &netdev)) {
3741 if (!netdev_get_in4(netdev, NULL, NULL) ||
3742 !netdev_get_in6(netdev, NULL)) {
3743 vlandev_del(vlan_dev->name);
3745 /* It has an IP address configured, so we don't own
3746 * it. Don't delete it. */
3748 netdev_close(netdev);
3755 /* Add all VLAN devices that we need. */
3756 SSET_FOR_EACH (real_dev_name, &splinter_ifaces) {
3759 BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) {
3760 if (!vlandev_get_name(real_dev_name, vid)) {
3761 vlandev_add(real_dev_name, vid);
3768 sset_destroy(&splinter_ifaces);
3770 if (bitmap_scan(splinter_vlans, 0, 4096) >= 4096) {
3771 free(splinter_vlans);
3774 return splinter_vlans;
3777 /* Pushes the configure of VLAN splinter port 'port' (e.g. eth0.9) down to
3780 configure_splinter_port(struct port *port)
3782 struct ofproto *ofproto = port->bridge->ofproto;
3783 uint16_t realdev_ofp_port;
3784 const char *realdev_name;
3785 struct iface *vlandev, *realdev;
3787 ofproto_bundle_unregister(port->bridge->ofproto, port);
3789 vlandev = CONTAINER_OF(list_front(&port->ifaces), struct iface,
3792 realdev_name = get_port_other_config(port->cfg, "realdev", NULL);
3793 realdev = iface_lookup(port->bridge, realdev_name);
3794 realdev_ofp_port = realdev ? realdev->ofp_port : 0;
3796 ofproto_port_set_realdev(ofproto, vlandev->ofp_port, realdev_ofp_port,
3800 static struct ovsrec_port *
3801 synthesize_splinter_port(const char *real_dev_name,
3802 const char *vlan_dev_name, int vid)
3804 struct ovsrec_interface *iface;
3805 struct ovsrec_port *port;
3807 iface = xzalloc(sizeof *iface);
3808 iface->name = xstrdup(vlan_dev_name);
3809 iface->type = "system";
3811 port = xzalloc(sizeof *port);
3812 port->interfaces = xmemdup(&iface, sizeof iface);
3813 port->n_interfaces = 1;
3814 port->name = xstrdup(vlan_dev_name);
3815 port->vlan_mode = "splinter";
3816 port->tag = xmalloc(sizeof *port->tag);
3818 port->key_other_config = xmalloc(sizeof *port->key_other_config);
3819 port->key_other_config[0] = "realdev";
3820 port->value_other_config = xmalloc(sizeof *port->value_other_config);
3821 port->value_other_config[0] = xstrdup(real_dev_name);
3822 port->n_other_config = 1;
3824 register_block(iface);
3825 register_block(iface->name);
3826 register_block(port);
3827 register_block(port->interfaces);
3828 register_block(port->name);
3829 register_block(port->tag);
3830 register_block(port->key_other_config);
3831 register_block(port->value_other_config);
3832 register_block(port->value_other_config[0]);
3837 /* For each interface with 'br' that has VLAN splinters enabled, adds a
3838 * corresponding ovsrec_port to 'ports' for each splinter VLAN marked with a
3839 * 1-bit in the 'splinter_vlans' bitmap. */
3841 add_vlan_splinter_ports(struct bridge *br,
3842 const unsigned long int *splinter_vlans,
3843 struct shash *ports)
3847 /* We iterate through 'br->cfg->ports' instead of 'ports' here because
3848 * we're modifying 'ports'. */
3849 for (i = 0; i < br->cfg->n_ports; i++) {
3850 const char *name = br->cfg->ports[i]->name;
3851 struct ovsrec_port *port_cfg = shash_find_data(ports, name);
3854 for (j = 0; j < port_cfg->n_interfaces; j++) {
3855 struct ovsrec_interface *iface_cfg = port_cfg->interfaces[j];
3857 if (vlan_splinters_is_enabled(iface_cfg)) {
3858 const char *real_dev_name;
3861 real_dev_name = iface_cfg->name;
3862 BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) {
3863 const char *vlan_dev_name;
3865 vlan_dev_name = vlandev_get_name(real_dev_name, vid);
3867 && !shash_find(ports, vlan_dev_name)) {
3868 shash_add(ports, vlan_dev_name,
3869 synthesize_splinter_port(
3870 real_dev_name, vlan_dev_name, vid));
3879 mirror_refresh_stats(struct mirror *m)
3881 struct ofproto *ofproto = m->bridge->ofproto;
3882 uint64_t tx_packets, tx_bytes;
3885 size_t stat_cnt = 0;
3887 if (ofproto_mirror_get_stats(ofproto, m, &tx_packets, &tx_bytes)) {
3888 ovsrec_mirror_set_statistics(m->cfg, NULL, NULL, 0);
3892 if (tx_packets != UINT64_MAX) {
3893 keys[stat_cnt] = "tx_packets";
3894 values[stat_cnt] = tx_packets;
3897 if (tx_bytes != UINT64_MAX) {
3898 keys[stat_cnt] = "tx_bytes";
3899 values[stat_cnt] = tx_bytes;
3903 ovsrec_mirror_set_statistics(m->cfg, keys, values, stat_cnt);