projects
/
cascardo
/
linux.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
tpm: fix the rollback in tpm_chip_register()
[cascardo/linux.git]
/
drivers
/
char
/
tpm
/
tpm-chip.c
diff --git
a/drivers/char/tpm/tpm-chip.c
b/drivers/char/tpm/tpm-chip.c
index
45cc39a
..
1a9dcee
100644
(file)
--- a/
drivers/char/tpm/tpm-chip.c
+++ b/
drivers/char/tpm/tpm-chip.c
@@
-140,7
+140,7
@@
struct tpm_chip *tpmm_chip_alloc(struct device *dev,
}
EXPORT_SYMBOL_GPL(tpmm_chip_alloc);
}
EXPORT_SYMBOL_GPL(tpmm_chip_alloc);
-static int tpm_
dev_add
_device(struct tpm_chip *chip)
+static int tpm_
add_char
_device(struct tpm_chip *chip)
{
int rc;
{
int rc;
@@
-151,7
+151,6
@@
static int tpm_dev_add_device(struct tpm_chip *chip)
chip->devname, MAJOR(chip->dev.devt),
MINOR(chip->dev.devt), rc);
chip->devname, MAJOR(chip->dev.devt),
MINOR(chip->dev.devt), rc);
- device_unregister(&chip->dev);
return rc;
}
return rc;
}
@@
-162,13
+161,14
@@
static int tpm_dev_add_device(struct tpm_chip *chip)
chip->devname, MAJOR(chip->dev.devt),
MINOR(chip->dev.devt), rc);
chip->devname, MAJOR(chip->dev.devt),
MINOR(chip->dev.devt), rc);
+ cdev_del(&chip->cdev);
return rc;
}
return rc;
}
return rc;
}
return rc;
}
-static void tpm_de
v_del
_device(struct tpm_chip *chip)
+static void tpm_de
l_char
_device(struct tpm_chip *chip)
{
cdev_del(&chip->cdev);
device_unregister(&chip->dev);
{
cdev_del(&chip->cdev);
device_unregister(&chip->dev);
@@
-222,7
+222,7
@@
int tpm_chip_register(struct tpm_chip *chip)
tpm_add_ppi(chip);
tpm_add_ppi(chip);
- rc = tpm_
dev_add
_device(chip);
+ rc = tpm_
add_char
_device(chip);
if (rc)
goto out_err;
if (rc)
goto out_err;
@@
-274,6
+274,6
@@
void tpm_chip_unregister(struct tpm_chip *chip)
sysfs_remove_link(&chip->pdev->kobj, "ppi");
tpm1_chip_unregister(chip);
sysfs_remove_link(&chip->pdev->kobj, "ppi");
tpm1_chip_unregister(chip);
- tpm_de
v_del
_device(chip);
+ tpm_de
l_char
_device(chip);
}
EXPORT_SYMBOL_GPL(tpm_chip_unregister);
}
EXPORT_SYMBOL_GPL(tpm_chip_unregister);