[media] s5p-fimc: Remove superfluous checks for buffer type
[cascardo/linux.git] / drivers / media / video / s5p-fimc / fimc-capture.c
index 7c884bb..0fd12df 100644 (file)
@@ -1,8 +1,8 @@
 /*
  * Samsung S5P/EXYNOS4 SoC series camera interface (camera capture) driver
  *
- * Copyright (C) 2010 - 2011 Samsung Electronics Co., Ltd.
- * Author: Sylwester Nawrocki, <s.nawrocki@samsung.com>
+ * Copyright (C) 2010 - 2012 Samsung Electronics Co., Ltd.
+ * Sylwester Nawrocki <s.nawrocki@samsung.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -31,7 +31,7 @@
 #include "fimc-core.h"
 #include "fimc-reg.h"
 
-static int fimc_init_capture(struct fimc_dev *fimc)
+static int fimc_capture_hw_init(struct fimc_dev *fimc)
 {
        struct fimc_ctx *ctx = fimc->vid_cap.ctx;
        struct fimc_pipeline *p = &fimc->pipeline;
@@ -62,7 +62,7 @@ static int fimc_init_capture(struct fimc_dev *fimc)
                fimc_hw_set_mainscaler(ctx);
                fimc_hw_set_target_format(ctx);
                fimc_hw_set_rotation(ctx);
-               fimc_hw_set_effect(ctx, false);
+               fimc_hw_set_effect(ctx);
                fimc_hw_set_output_path(ctx);
                fimc_hw_set_out_dma(ctx);
                if (fimc->variant->has_alpha)
@@ -73,6 +73,14 @@ static int fimc_init_capture(struct fimc_dev *fimc)
        return ret;
 }
 
+/*
+ * Reinitialize the driver so it is ready to start the streaming again.
+ * Set fimc->state to indicate stream off and the hardware shut down state.
+ * If not suspending (@suspend is false), return any buffers to videobuf2.
+ * Otherwise put any owned buffers onto the pending buffers queue, so they
+ * can be re-spun when the device is being resumed. Also perform FIMC
+ * software reset and disable streaming on the whole pipeline if required.
+ */
 static int fimc_capture_state_cleanup(struct fimc_dev *fimc, bool suspend)
 {
        struct fimc_vid_cap *cap = &fimc->vid_cap;
@@ -146,9 +154,6 @@ static int fimc_capture_config_update(struct fimc_ctx *ctx)
        struct fimc_dev *fimc = ctx->fimc_dev;
        int ret;
 
-       if (!test_bit(ST_CAPT_APPLY_CFG, &fimc->state))
-               return 0;
-
        fimc_hw_set_camera_offset(fimc, &ctx->s_frame);
 
        ret = fimc_set_scaler_info(ctx);
@@ -159,6 +164,7 @@ static int fimc_capture_config_update(struct fimc_ctx *ctx)
        fimc_hw_set_mainscaler(ctx);
        fimc_hw_set_target_format(ctx);
        fimc_hw_set_rotation(ctx);
+       fimc_hw_set_effect(ctx);
        fimc_prepare_dma_offset(ctx, &ctx->d_frame);
        fimc_hw_set_out_dma(ctx);
        if (fimc->variant->has_alpha)
@@ -220,7 +226,8 @@ void fimc_capture_irq_handler(struct fimc_dev *fimc, int deq_buf)
                set_bit(ST_CAPT_RUN, &fimc->state);
        }
 
-       fimc_capture_config_update(cap->ctx);
+       if (test_bit(ST_CAPT_APPLY_CFG, &fimc->state))
+               fimc_capture_config_update(cap->ctx);
 done:
        if (cap->active_buf_cnt == 1) {
                fimc_deactivate_capture(fimc);
@@ -242,9 +249,11 @@ static int start_streaming(struct vb2_queue *q, unsigned int count)
 
        vid_cap->frame_count = 0;
 
-       ret = fimc_init_capture(fimc);
-       if (ret)
-               goto error;
+       ret = fimc_capture_hw_init(fimc);
+       if (ret) {
+               fimc_capture_state_cleanup(fimc, false);
+               return ret;
+       }
 
        set_bit(ST_CAPT_PEND, &fimc->state);
 
@@ -259,9 +268,6 @@ static int start_streaming(struct vb2_queue *q, unsigned int count)
        }
 
        return 0;
-error:
-       fimc_capture_state_cleanup(fimc, false);
-       return ret;
 }
 
 static int stop_streaming(struct vb2_queue *q)
@@ -300,7 +306,7 @@ int fimc_capture_resume(struct fimc_dev *fimc)
        vid_cap->buf_index = 0;
        fimc_pipeline_initialize(&fimc->pipeline, &vid_cap->vfd->entity,
                                 false);
-       fimc_init_capture(fimc);
+       fimc_capture_hw_init(fimc);
 
        clear_bit(ST_CAPT_SUSPENDED, &fimc->state);
 
@@ -344,7 +350,8 @@ static int queue_setup(struct vb2_queue *vq, const struct v4l2_format *pfmt,
                if (pixm)
                        sizes[i] = max(size, pixm->plane_fmt[i].sizeimage);
                else
-                       sizes[i] = size;
+                       sizes[i] = max_t(u32, size, frame->payload[i]);
+
                allocators[i] = ctx->fimc_dev->alloc_ctx;
        }
 
@@ -457,14 +464,14 @@ int fimc_capture_ctrls_create(struct fimc_dev *fimc)
 
        if (WARN_ON(vid_cap->ctx == NULL))
                return -ENXIO;
-       if (vid_cap->ctx->ctrls_rdy)
+       if (vid_cap->ctx->ctrls.ready)
                return 0;
 
        ret = fimc_ctrls_create(vid_cap->ctx);
-       if (ret || vid_cap->user_subdev_api)
+       if (ret || vid_cap->user_subdev_api || !vid_cap->ctx->ctrls.ready)
                return ret;
 
-       return v4l2_ctrl_add_handler(&vid_cap->ctx->ctrl_handler,
+       return v4l2_ctrl_add_handler(&vid_cap->ctx->ctrls.handler,
                    fimc->pipeline.subdevs[IDX_SENSOR]->ctrl_handler);
 }
 
@@ -493,10 +500,10 @@ static int fimc_capture_open(struct file *file)
                if (ret < 0) {
                        dev_err(&fimc->pdev->dev,
                                "Video pipeline initialization failed\n");
+                       clear_bit(ST_CAPT_BUSY, &fimc->state);
                        pm_runtime_put_sync(&fimc->pdev->dev);
                        fimc->vid_cap.refcnt--;
                        v4l2_fh_release(file);
-                       clear_bit(ST_CAPT_BUSY, &fimc->state);
                        return ret;
                }
                ret = fimc_capture_ctrls_create(fimc);
@@ -563,7 +570,7 @@ static struct fimc_fmt *fimc_capture_try_format(struct fimc_ctx *ctx,
 {
        bool rotation = ctx->rotation == 90 || ctx->rotation == 270;
        struct fimc_dev *fimc = ctx->fimc_dev;
-       struct samsung_fimc_variant *var = fimc->variant;
+       struct fimc_variant *var = fimc->variant;
        struct fimc_pix_limit *pl = var->pix_limit;
        struct fimc_frame *dst = &ctx->d_frame;
        u32 depth, min_w, max_w, min_h, align_h = 3;
@@ -605,8 +612,13 @@ static struct fimc_fmt *fimc_capture_try_format(struct fimc_ctx *ctx,
        }
        /* Apply the scaler and the output DMA constraints */
        max_w = rotation ? pl->out_rot_en_w : pl->out_rot_dis_w;
-       min_w = ctx->state & FIMC_DST_CROP ? dst->width : var->min_out_pixsize;
-       min_h = ctx->state & FIMC_DST_CROP ? dst->height : var->min_out_pixsize;
+       if (ctx->state & FIMC_COMPOSE) {
+               min_w = dst->offs_h + dst->width;
+               min_h = dst->offs_v + dst->height;
+       } else {
+               min_w = var->min_out_pixsize;
+               min_h = var->min_out_pixsize;
+       }
        if (var->min_vsize_align == 1 && !rotation)
                align_h = fimc_fmt_is_rgb(ffmt->color) ? 0 : 1;
 
@@ -624,12 +636,13 @@ static struct fimc_fmt *fimc_capture_try_format(struct fimc_ctx *ctx,
        return ffmt;
 }
 
-static void fimc_capture_try_crop(struct fimc_ctx *ctx, struct v4l2_rect *r,
-                                 int pad)
+static void fimc_capture_try_selection(struct fimc_ctx *ctx,
+                                      struct v4l2_rect *r,
+                                      int target)
 {
        bool rotate = ctx->rotation == 90 || ctx->rotation == 270;
        struct fimc_dev *fimc = ctx->fimc_dev;
-       struct samsung_fimc_variant *var = fimc->variant;
+       struct fimc_variant *var = fimc->variant;
        struct fimc_pix_limit *pl = var->pix_limit;
        struct fimc_frame *sink = &ctx->s_frame;
        u32 max_w, max_h, min_w = 0, min_h = 0, min_sz;
@@ -643,7 +656,7 @@ static void fimc_capture_try_crop(struct fimc_ctx *ctx, struct v4l2_rect *r,
                r->left   = r->top = 0;
                return;
        }
-       if (pad == FIMC_SD_PAD_SOURCE) {
+       if (target == V4L2_SEL_TGT_COMPOSE_ACTIVE) {
                if (ctx->rotation != 90 && ctx->rotation != 270)
                        align_h = 1;
                max_sc_h = min(SCALER_MAX_HRATIO, 1 << (ffs(sink->width) - 3));
@@ -657,8 +670,7 @@ static void fimc_capture_try_crop(struct fimc_ctx *ctx, struct v4l2_rect *r,
                max_sc_h = max_sc_v = 1;
        }
        /*
-        * For the crop rectangle at source pad the following constraints
-        * must be met:
+        * For the compose rectangle the following constraints must be met:
         * - it must fit in the sink pad format rectangle (f_width/f_height);
         * - maximum downscaling ratio is 64;
         * - maximum crop size depends if the rotator is used or not;
@@ -670,7 +682,8 @@ static void fimc_capture_try_crop(struct fimc_ctx *ctx, struct v4l2_rect *r,
                      rotate ? pl->out_rot_en_w : pl->out_rot_dis_w,
                      rotate ? sink->f_height : sink->f_width);
        max_h = min_t(u32, FIMC_CAMIF_MAX_HEIGHT, sink->f_height);
-       if (pad == FIMC_SD_PAD_SOURCE) {
+
+       if (target == V4L2_SEL_TGT_COMPOSE_ACTIVE) {
                min_w = min_t(u32, max_w, sink->f_width / max_sc_h);
                min_h = min_t(u32, max_h, sink->f_height / max_sc_v);
                if (rotate) {
@@ -681,13 +694,13 @@ static void fimc_capture_try_crop(struct fimc_ctx *ctx, struct v4l2_rect *r,
        v4l_bound_align_image(&r->width, min_w, max_w, ffs(min_sz) - 1,
                              &r->height, min_h, max_h, align_h,
                              align_sz);
-       /* Adjust left/top if cropping rectangle is out of bounds */
+       /* Adjust left/top if crop/compose rectangle is out of bounds */
        r->left = clamp_t(u32, r->left, 0, sink->f_width - r->width);
        r->top  = clamp_t(u32, r->top, 0, sink->f_height - r->height);
        r->left = round_down(r->left, var->hor_offs_align);
 
-       dbg("pad%d: (%d,%d)/%dx%d, sink fmt: %dx%d",
-           pad, r->left, r->top, r->width, r->height,
+       dbg("target %#x: (%d,%d)/%dx%d, sink fmt: %dx%d",
+           target, r->left, r->top, r->width, r->height,
            sink->f_width, sink->f_height);
 }
 
@@ -806,9 +819,6 @@ static int fimc_cap_g_fmt_mplane(struct file *file, void *fh,
        struct fimc_dev *fimc = video_drvdata(file);
        struct fimc_ctx *ctx = fimc->vid_cap.ctx;
 
-       if (f->type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
-               return -EINVAL;
-
        return fimc_fill_format(&ctx->d_frame, f);
 }
 
@@ -821,9 +831,6 @@ static int fimc_cap_try_fmt_mplane(struct file *file, void *fh,
        struct v4l2_mbus_framefmt mf;
        struct fimc_fmt *ffmt = NULL;
 
-       if (f->type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
-               return -EINVAL;
-
        if (pix->pixelformat == V4L2_PIX_FMT_JPEG) {
                fimc_capture_try_format(ctx, &pix->width, &pix->height,
                                        NULL, &pix->pixelformat,
@@ -875,8 +882,6 @@ static int fimc_capture_set_format(struct fimc_dev *fimc, struct v4l2_format *f)
        struct fimc_fmt *s_fmt = NULL;
        int ret, i;
 
-       if (f->type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
-               return -EINVAL;
        if (vb2_is_busy(&fimc->vid_cap.vbq))
                return -EBUSY;
 
@@ -912,14 +917,14 @@ static int fimc_capture_set_format(struct fimc_dev *fimc, struct v4l2_format *f)
                pix->width  = mf->width;
                pix->height = mf->height;
        }
+
        fimc_adjust_mplane_format(ff->fmt, pix->width, pix->height, pix);
        for (i = 0; i < ff->fmt->colplanes; i++)
-               ff->payload[i] =
-                       (pix->width * pix->height * ff->fmt->depth[i]) / 8;
+               ff->payload[i] = pix->plane_fmt[i].sizeimage;
 
        set_frame_bounds(ff, pix->width, pix->height);
        /* Reset the composition rectangle if not yet configured */
-       if (!(ctx->state & FIMC_DST_CROP))
+       if (!(ctx->state & FIMC_COMPOSE))
                set_frame_crop(ff, 0, 0, pix->width, pix->height);
 
        fimc_capture_mark_jpeg_xfer(ctx, fimc_fmt_is_jpeg(ff->fmt->color));
@@ -1169,29 +1174,18 @@ static int fimc_cap_s_selection(struct file *file, void *fh,
        struct v4l2_rect rect = s->r;
        struct fimc_frame *f;
        unsigned long flags;
-       unsigned int pad;
 
        if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
                return -EINVAL;
 
-       switch (s->target) {
-       case V4L2_SEL_TGT_COMPOSE_DEFAULT:
-       case V4L2_SEL_TGT_COMPOSE_BOUNDS:
-       case V4L2_SEL_TGT_COMPOSE_ACTIVE:
+       if (s->target == V4L2_SEL_TGT_COMPOSE_ACTIVE)
                f = &ctx->d_frame;
-               pad = FIMC_SD_PAD_SOURCE;
-               break;
-       case V4L2_SEL_TGT_CROP_BOUNDS:
-       case V4L2_SEL_TGT_CROP_DEFAULT:
-       case V4L2_SEL_TGT_CROP_ACTIVE:
+       else if (s->target == V4L2_SEL_TGT_CROP_ACTIVE)
                f = &ctx->s_frame;
-               pad = FIMC_SD_PAD_SINK;
-               break;
-       default:
+       else
                return -EINVAL;
-       }
 
-       fimc_capture_try_crop(ctx, &rect, pad);
+       fimc_capture_try_selection(ctx, &rect, s->target);
 
        if (s->flags & V4L2_SEL_FLAG_LE &&
            !enclosed_rectangle(&rect, &s->r))
@@ -1403,77 +1397,122 @@ static int fimc_subdev_set_fmt(struct v4l2_subdev *sd,
        ff->fmt = ffmt;
 
        /* Reset the crop rectangle if required. */
-       if (!(fmt->pad == FIMC_SD_PAD_SOURCE && (ctx->state & FIMC_DST_CROP)))
+       if (!(fmt->pad == FIMC_SD_PAD_SOURCE && (ctx->state & FIMC_COMPOSE)))
                set_frame_crop(ff, 0, 0, mf->width, mf->height);
 
        if (fmt->pad == FIMC_SD_PAD_SINK)
-               ctx->state &= ~FIMC_DST_CROP;
+               ctx->state &= ~FIMC_COMPOSE;
        mutex_unlock(&fimc->lock);
        return 0;
 }
 
-static int fimc_subdev_get_crop(struct v4l2_subdev *sd,
-                               struct v4l2_subdev_fh *fh,
-                               struct v4l2_subdev_crop *crop)
+static int fimc_subdev_get_selection(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_fh *fh,
+                                    struct v4l2_subdev_selection *sel)
 {
        struct fimc_dev *fimc = v4l2_get_subdevdata(sd);
        struct fimc_ctx *ctx = fimc->vid_cap.ctx;
-       struct v4l2_rect *r = &crop->rect;
-       struct fimc_frame *ff;
+       struct fimc_frame *f = &ctx->s_frame;
+       struct v4l2_rect *r = &sel->r;
+       struct v4l2_rect *try_sel;
+
+       if (sel->pad != FIMC_SD_PAD_SINK)
+               return -EINVAL;
 
-       if (crop->which == V4L2_SUBDEV_FORMAT_TRY) {
-               crop->rect = *v4l2_subdev_get_try_crop(fh, crop->pad);
+       mutex_lock(&fimc->lock);
+
+       switch (sel->target) {
+       case V4L2_SUBDEV_SEL_TGT_COMPOSE_BOUNDS:
+               f = &ctx->d_frame;
+       case V4L2_SUBDEV_SEL_TGT_CROP_BOUNDS:
+               r->width = f->o_width;
+               r->height = f->o_height;
+               r->left = 0;
+               r->top = 0;
+               mutex_unlock(&fimc->lock);
                return 0;
+
+       case V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL:
+               try_sel = v4l2_subdev_get_try_crop(fh, sel->pad);
+               break;
+       case V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL:
+               try_sel = v4l2_subdev_get_try_compose(fh, sel->pad);
+               f = &ctx->d_frame;
+               break;
+       default:
+               mutex_unlock(&fimc->lock);
+               return -EINVAL;
        }
-       ff = crop->pad == FIMC_SD_PAD_SINK ?
-               &ctx->s_frame : &ctx->d_frame;
 
-       mutex_lock(&fimc->lock);
-       r->left   = ff->offs_h;
-       r->top    = ff->offs_v;
-       r->width  = ff->width;
-       r->height = ff->height;
-       mutex_unlock(&fimc->lock);
+       if (sel->which == V4L2_SUBDEV_FORMAT_TRY) {
+               sel->r = *try_sel;
+       } else {
+               r->left = f->offs_h;
+               r->top = f->offs_v;
+               r->width = f->width;
+               r->height = f->height;
+       }
 
-       dbg("ff:%p, pad%d: l:%d, t:%d, %dx%d, f_w: %d, f_h: %d",
-           ff, crop->pad, r->left, r->top, r->width, r->height,
-           ff->f_width, ff->f_height);
+       dbg("target %#x: l:%d, t:%d, %dx%d, f_w: %d, f_h: %d",
+           sel->pad, r->left, r->top, r->width, r->height,
+           f->f_width, f->f_height);
 
+       mutex_unlock(&fimc->lock);
        return 0;
 }
 
-static int fimc_subdev_set_crop(struct v4l2_subdev *sd,
-                               struct v4l2_subdev_fh *fh,
-                               struct v4l2_subdev_crop *crop)
+static int fimc_subdev_set_selection(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_fh *fh,
+                                    struct v4l2_subdev_selection *sel)
 {
        struct fimc_dev *fimc = v4l2_get_subdevdata(sd);
        struct fimc_ctx *ctx = fimc->vid_cap.ctx;
-       struct v4l2_rect *r = &crop->rect;
-       struct fimc_frame *ff;
+       struct fimc_frame *f = &ctx->s_frame;
+       struct v4l2_rect *r = &sel->r;
+       struct v4l2_rect *try_sel;
        unsigned long flags;
 
-       dbg("(%d,%d)/%dx%d", r->left, r->top, r->width, r->height);
-
-       ff = crop->pad == FIMC_SD_PAD_SOURCE ?
-               &ctx->d_frame : &ctx->s_frame;
+       if (sel->pad != FIMC_SD_PAD_SINK)
+               return -EINVAL;
 
        mutex_lock(&fimc->lock);
-       fimc_capture_try_crop(ctx, r, crop->pad);
+       fimc_capture_try_selection(ctx, r, V4L2_SEL_TGT_CROP_ACTIVE);
 
-       if (crop->which == V4L2_SUBDEV_FORMAT_TRY) {
+       switch (sel->target) {
+       case V4L2_SUBDEV_SEL_TGT_COMPOSE_BOUNDS:
+               f = &ctx->d_frame;
+       case V4L2_SUBDEV_SEL_TGT_CROP_BOUNDS:
+               r->width = f->o_width;
+               r->height = f->o_height;
+               r->left = 0;
+               r->top = 0;
                mutex_unlock(&fimc->lock);
-               *v4l2_subdev_get_try_crop(fh, crop->pad) = *r;
                return 0;
+
+       case V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL:
+               try_sel = v4l2_subdev_get_try_crop(fh, sel->pad);
+               break;
+       case V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL:
+               try_sel = v4l2_subdev_get_try_compose(fh, sel->pad);
+               f = &ctx->d_frame;
+               break;
+       default:
+               mutex_unlock(&fimc->lock);
+               return -EINVAL;
        }
-       spin_lock_irqsave(&fimc->slock, flags);
-       set_frame_crop(ff, r->left, r->top, r->width, r->height);
-       if (crop->pad == FIMC_SD_PAD_SOURCE)
-               ctx->state |= FIMC_DST_CROP;
 
-       set_bit(ST_CAPT_APPLY_CFG, &fimc->state);
-       spin_unlock_irqrestore(&fimc->slock, flags);
+       if (sel->which == V4L2_SUBDEV_FORMAT_TRY) {
+               *try_sel = sel->r;
+       } else {
+               spin_lock_irqsave(&fimc->slock, flags);
+               set_frame_crop(f, r->left, r->top, r->width, r->height);
+               set_bit(ST_CAPT_APPLY_CFG, &fimc->state);
+               spin_unlock_irqrestore(&fimc->slock, flags);
+               if (sel->target == V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL)
+                       ctx->state |= FIMC_COMPOSE;
+       }
 
-       dbg("pad%d: (%d,%d)/%dx%d", crop->pad, r->left, r->top,
+       dbg("target %#x: (%d,%d)/%dx%d", sel->target, r->left, r->top,
            r->width, r->height);
 
        mutex_unlock(&fimc->lock);
@@ -1482,10 +1521,10 @@ static int fimc_subdev_set_crop(struct v4l2_subdev *sd,
 
 static struct v4l2_subdev_pad_ops fimc_subdev_pad_ops = {
        .enum_mbus_code = fimc_subdev_enum_mbus_code,
+       .get_selection = fimc_subdev_get_selection,
+       .set_selection = fimc_subdev_set_selection,
        .get_fmt = fimc_subdev_get_fmt,
        .set_fmt = fimc_subdev_set_fmt,
-       .get_crop = fimc_subdev_get_crop,
-       .set_crop = fimc_subdev_set_crop,
 };
 
 static struct v4l2_subdev_ops fimc_subdev_ops = {
@@ -1524,8 +1563,8 @@ static int fimc_register_capture_device(struct fimc_dev *fimc,
                return -ENOMEM;
 
        ctx->fimc_dev    = fimc;
-       ctx->in_path     = FIMC_CAMERA;
-       ctx->out_path    = FIMC_DMA;
+       ctx->in_path     = FIMC_IO_CAMERA;
+       ctx->out_path    = FIMC_IO_DMA;
        ctx->state       = FIMC_CTX_CAP;
        ctx->s_frame.fmt = fimc_find_format(NULL, NULL, FMT_FLAGS_CAM, 0);
        ctx->d_frame.fmt = ctx->s_frame.fmt;
@@ -1583,7 +1622,7 @@ static int fimc_register_capture_device(struct fimc_dev *fimc,
        v4l2_info(v4l2_dev, "Registered %s as /dev/%s\n",
                  vfd->name, video_device_node_name(vfd));
 
-       vfd->ctrl_handler = &ctx->ctrl_handler;
+       vfd->ctrl_handler = &ctx->ctrls.handler;
        return 0;
 
 err_vd: