mmc: esdhc: Fix bug when writing to SDHCI_HOST_CONTROL register
[cascardo/linux.git] / drivers / mmc / host / jz4740_mmc.c
index 2391c6b..0308c9f 100644 (file)
@@ -14,6 +14,7 @@
  */
 
 #include <linux/mmc/host.h>
+#include <linux/mmc/slot-gpio.h>
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/irq.h>
@@ -120,7 +121,6 @@ struct jz4740_mmc_host {
        int irq;
        int card_detect_irq;
 
-       struct resource *mem;
        void __iomem *base;
        struct mmc_request *req;
        struct mmc_command *cmd;
@@ -231,6 +231,14 @@ static void jz4740_mmc_transfer_check_state(struct jz4740_mmc_host *host,
                        host->req->cmd->error = -EIO;
                        data->error = -EIO;
                }
+       } else if (status & JZ_MMC_STATUS_READ_ERROR_MASK) {
+               if (status & (JZ_MMC_STATUS_TIMEOUT_READ)) {
+                       host->req->cmd->error = -ETIMEDOUT;
+                       data->error = -ETIMEDOUT;
+               } else {
+                       host->req->cmd->error = -EIO;
+                       data->error = -EIO;
+               }
        }
 }
 
@@ -560,11 +568,6 @@ static irqreturn_t jz_mmc_irq(int irq, void *devid)
                                        if (cmd->data)
                                                        cmd->data->error = -EIO;
                                        cmd->error = -EIO;
-                       } else if (status & (JZ_MMC_STATUS_CRC_READ_ERROR |
-                                       JZ_MMC_STATUS_CRC_WRITE_ERROR)) {
-                                       if (cmd->data)
-                                                       cmd->data->error = -EIO;
-                                       cmd->error = -EIO;
                        }
 
                        jz4740_mmc_set_irq_enabled(host, irq_reg, false);
@@ -626,7 +629,7 @@ static void jz4740_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
                        gpio_set_value(host->pdata->gpio_power,
                                        !host->pdata->power_active_low);
                host->cmdat |= JZ_MMC_CMDAT_INIT;
-               clk_enable(host->clk);
+               clk_prepare_enable(host->clk);
                break;
        case MMC_POWER_ON:
                break;
@@ -634,7 +637,7 @@ static void jz4740_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
                if (gpio_is_valid(host->pdata->gpio_power))
                        gpio_set_value(host->pdata->gpio_power,
                                        host->pdata->power_active_low);
-               clk_disable(host->clk);
+               clk_disable_unprepare(host->clk);
                break;
        }
 
@@ -650,35 +653,6 @@ static void jz4740_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
        }
 }
 
-static int jz4740_mmc_get_ro(struct mmc_host *mmc)
-{
-       struct jz4740_mmc_host *host = mmc_priv(mmc);
-       if (!gpio_is_valid(host->pdata->gpio_read_only))
-               return -ENOSYS;
-
-       return gpio_get_value(host->pdata->gpio_read_only) ^
-               host->pdata->read_only_active_low;
-}
-
-static int jz4740_mmc_get_cd(struct mmc_host *mmc)
-{
-       struct jz4740_mmc_host *host = mmc_priv(mmc);
-       if (!gpio_is_valid(host->pdata->gpio_card_detect))
-               return -ENOSYS;
-
-       return gpio_get_value(host->pdata->gpio_card_detect) ^
-                       host->pdata->card_detect_active_low;
-}
-
-static irqreturn_t jz4740_mmc_card_detect_irq(int irq, void *devid)
-{
-       struct jz4740_mmc_host *host = devid;
-
-       mmc_detect_change(host->mmc, HZ / 2);
-
-       return IRQ_HANDLED;
-}
-
 static void jz4740_mmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
 {
        struct jz4740_mmc_host *host = mmc_priv(mmc);
@@ -688,8 +662,8 @@ static void jz4740_mmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
 static const struct mmc_host_ops jz4740_mmc_ops = {
        .request        = jz4740_mmc_request,
        .set_ios        = jz4740_mmc_set_ios,
-       .get_ro         = jz4740_mmc_get_ro,
-       .get_cd         = jz4740_mmc_get_cd,
+       .get_ro         = mmc_gpio_get_ro,
+       .get_cd         = mmc_gpio_get_cd,
        .enable_sdio_irq = jz4740_mmc_enable_sdio_irq,
 };
 
@@ -724,58 +698,34 @@ static int jz4740_mmc_request_gpio(struct device *dev, int gpio,
        return 0;
 }
 
-static int jz4740_mmc_request_gpios(struct platform_device *pdev)
+static int jz4740_mmc_request_gpios(struct mmc_host *mmc,
+       struct platform_device *pdev)
 {
-       int ret;
        struct jz4740_mmc_platform_data *pdata = pdev->dev.platform_data;
+       int ret = 0;
 
        if (!pdata)
                return 0;
 
-       ret = jz4740_mmc_request_gpio(&pdev->dev, pdata->gpio_card_detect,
-                       "MMC detect change", false, 0);
-       if (ret)
-               goto err;
-
-       ret = jz4740_mmc_request_gpio(&pdev->dev, pdata->gpio_read_only,
-                       "MMC read only", false, 0);
-       if (ret)
-               goto err_free_gpio_card_detect;
-
-       ret = jz4740_mmc_request_gpio(&pdev->dev, pdata->gpio_power,
-                       "MMC read only", true, pdata->power_active_low);
-       if (ret)
-               goto err_free_gpio_read_only;
-
-       return 0;
-
-err_free_gpio_read_only:
-       if (gpio_is_valid(pdata->gpio_read_only))
-               gpio_free(pdata->gpio_read_only);
-err_free_gpio_card_detect:
-       if (gpio_is_valid(pdata->gpio_card_detect))
-               gpio_free(pdata->gpio_card_detect);
-err:
-       return ret;
-}
-
-static int jz4740_mmc_request_cd_irq(struct platform_device *pdev,
-       struct jz4740_mmc_host *host)
-{
-       struct jz4740_mmc_platform_data *pdata = pdev->dev.platform_data;
+       if (!pdata->card_detect_active_low)
+               mmc->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
+       if (!pdata->read_only_active_low)
+               mmc->caps2 |= MMC_CAP2_RO_ACTIVE_HIGH;
 
-       if (!gpio_is_valid(pdata->gpio_card_detect))
-               return 0;
+       if (gpio_is_valid(pdata->gpio_card_detect)) {
+               ret = mmc_gpio_request_cd(mmc, pdata->gpio_card_detect);
+               if (ret)
+                       return ret;
+       }
 
-       host->card_detect_irq = gpio_to_irq(pdata->gpio_card_detect);
-       if (host->card_detect_irq < 0) {
-               dev_warn(&pdev->dev, "Failed to get card detect irq\n");
-               return 0;
+       if (gpio_is_valid(pdata->gpio_read_only)) {
+               ret = mmc_gpio_request_ro(mmc, pdata->gpio_read_only);
+               if (ret)
+                       return ret;
        }
 
-       return request_irq(host->card_detect_irq, jz4740_mmc_card_detect_irq,
-                       IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
-                       "MMC card detect", host);
+       return jz4740_mmc_request_gpio(&pdev->dev, pdata->gpio_power,
+                       "MMC read only", true, pdata->power_active_low);
 }
 
 static void jz4740_mmc_free_gpios(struct platform_device *pdev)
@@ -787,10 +737,6 @@ static void jz4740_mmc_free_gpios(struct platform_device *pdev)
 
        if (gpio_is_valid(pdata->gpio_power))
                gpio_free(pdata->gpio_power);
-       if (gpio_is_valid(pdata->gpio_read_only))
-               gpio_free(pdata->gpio_read_only);
-       if (gpio_is_valid(pdata->gpio_card_detect))
-               gpio_free(pdata->gpio_card_detect);
 }
 
 static inline size_t jz4740_mmc_num_pins(struct jz4740_mmc_host *host)
@@ -808,6 +754,7 @@ static int jz4740_mmc_probe(struct platform_device* pdev)
        struct mmc_host *mmc;
        struct jz4740_mmc_host *host;
        struct jz4740_mmc_platform_data *pdata;
+       struct resource *res;
 
        pdata = pdev->dev.platform_data;
 
@@ -827,42 +774,28 @@ static int jz4740_mmc_probe(struct platform_device* pdev)
                goto err_free_host;
        }
 
-       host->clk = clk_get(&pdev->dev, "mmc");
+       host->clk = devm_clk_get(&pdev->dev, "mmc");
        if (IS_ERR(host->clk)) {
                ret = PTR_ERR(host->clk);
                dev_err(&pdev->dev, "Failed to get mmc clock\n");
                goto err_free_host;
        }
 
-       host->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!host->mem) {
-               ret = -ENOENT;
-               dev_err(&pdev->dev, "Failed to get base platform memory\n");
-               goto err_clk_put;
-       }
-
-       host->mem = request_mem_region(host->mem->start,
-                                       resource_size(host->mem), pdev->name);
-       if (!host->mem) {
-               ret = -EBUSY;
-               dev_err(&pdev->dev, "Failed to request base memory region\n");
-               goto err_clk_put;
-       }
-
-       host->base = ioremap_nocache(host->mem->start, resource_size(host->mem));
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       host->base = devm_ioremap_resource(&pdev->dev, res);
        if (!host->base) {
                ret = -EBUSY;
                dev_err(&pdev->dev, "Failed to ioremap base memory\n");
-               goto err_release_mem_region;
+               goto err_free_host;
        }
 
        ret = jz_gpio_bulk_request(jz4740_mmc_pins, jz4740_mmc_num_pins(host));
        if (ret) {
                dev_err(&pdev->dev, "Failed to request mmc pins: %d\n", ret);
-               goto err_iounmap;
+               goto err_free_host;
        }
 
-       ret = jz4740_mmc_request_gpios(pdev);
+       ret = jz4740_mmc_request_gpios(mmc, pdev);
        if (ret)
                goto err_gpio_bulk_free;
 
@@ -885,17 +818,11 @@ static int jz4740_mmc_probe(struct platform_device* pdev)
        spin_lock_init(&host->lock);
        host->irq_mask = 0xffff;
 
-       ret = jz4740_mmc_request_cd_irq(pdev, host);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to request card detect irq\n");
-               goto err_free_gpios;
-       }
-
        ret = request_threaded_irq(host->irq, jz_mmc_irq, jz_mmc_irq_worker, 0,
                        dev_name(&pdev->dev), host);
        if (ret) {
                dev_err(&pdev->dev, "Failed to request irq: %d\n", ret);
-               goto err_free_card_detect_irq;
+               goto err_free_gpios;
        }
 
        jz4740_mmc_reset(host);
@@ -918,21 +845,11 @@ static int jz4740_mmc_probe(struct platform_device* pdev)
 
 err_free_irq:
        free_irq(host->irq, host);
-err_free_card_detect_irq:
-       if (host->card_detect_irq >= 0)
-               free_irq(host->card_detect_irq, host);
 err_free_gpios:
        jz4740_mmc_free_gpios(pdev);
 err_gpio_bulk_free:
        jz_gpio_bulk_free(jz4740_mmc_pins, jz4740_mmc_num_pins(host));
-err_iounmap:
-       iounmap(host->base);
-err_release_mem_region:
-       release_mem_region(host->mem->start, resource_size(host->mem));
-err_clk_put:
-       clk_put(host->clk);
 err_free_host:
-       platform_set_drvdata(pdev, NULL);
        mmc_free_host(mmc);
 
        return ret;
@@ -949,24 +866,16 @@ static int jz4740_mmc_remove(struct platform_device *pdev)
        mmc_remove_host(host->mmc);
 
        free_irq(host->irq, host);
-       if (host->card_detect_irq >= 0)
-               free_irq(host->card_detect_irq, host);
 
        jz4740_mmc_free_gpios(pdev);
        jz_gpio_bulk_free(jz4740_mmc_pins, jz4740_mmc_num_pins(host));
 
-       iounmap(host->base);
-       release_mem_region(host->mem->start, resource_size(host->mem));
-
-       clk_put(host->clk);
-
-       platform_set_drvdata(pdev, NULL);
        mmc_free_host(host->mmc);
 
        return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 
 static int jz4740_mmc_suspend(struct device *dev)
 {
@@ -990,13 +899,8 @@ static int jz4740_mmc_resume(struct device *dev)
        return 0;
 }
 
-const struct dev_pm_ops jz4740_mmc_pm_ops = {
-       .suspend        = jz4740_mmc_suspend,
-       .resume         = jz4740_mmc_resume,
-       .poweroff       = jz4740_mmc_suspend,
-       .restore        = jz4740_mmc_resume,
-};
-
+static SIMPLE_DEV_PM_OPS(jz4740_mmc_pm_ops, jz4740_mmc_suspend,
+       jz4740_mmc_resume);
 #define JZ4740_MMC_PM_OPS (&jz4740_mmc_pm_ops)
 #else
 #define JZ4740_MMC_PM_OPS NULL