bna: remove paused from bna_rx_config and flags from bna_rxf
[cascardo/linux.git] / drivers / net / ethernet / brocade / bna / bna_tx_rx.c
index 8ab3a5f..896aa82 100644 (file)
@@ -46,7 +46,6 @@ do {                                                                  \
 
 static int bna_rxf_cfg_apply(struct bna_rxf *rxf);
 static void bna_rxf_cfg_reset(struct bna_rxf *rxf);
-static int bna_rxf_fltr_clear(struct bna_rxf *rxf);
 static int bna_rxf_ucast_cfg_apply(struct bna_rxf *rxf);
 static int bna_rxf_promisc_cfg_apply(struct bna_rxf *rxf);
 static int bna_rxf_allmulti_cfg_apply(struct bna_rxf *rxf);
@@ -60,14 +59,10 @@ static int bna_rxf_allmulti_cfg_reset(struct bna_rxf *rxf,
 
 bfa_fsm_state_decl(bna_rxf, stopped, struct bna_rxf,
                        enum bna_rxf_event);
-bfa_fsm_state_decl(bna_rxf, paused, struct bna_rxf,
-                       enum bna_rxf_event);
 bfa_fsm_state_decl(bna_rxf, cfg_wait, struct bna_rxf,
                        enum bna_rxf_event);
 bfa_fsm_state_decl(bna_rxf, started, struct bna_rxf,
                        enum bna_rxf_event);
-bfa_fsm_state_decl(bna_rxf, fltr_clr_wait, struct bna_rxf,
-                       enum bna_rxf_event);
 bfa_fsm_state_decl(bna_rxf, last_resp_wait, struct bna_rxf,
                        enum bna_rxf_event);
 
@@ -82,11 +77,7 @@ bna_rxf_sm_stopped(struct bna_rxf *rxf, enum bna_rxf_event event)
 {
        switch (event) {
        case RXF_E_START:
-               if (rxf->flags & BNA_RXF_F_PAUSED) {
-                       bfa_fsm_set_state(rxf, bna_rxf_sm_paused);
-                       call_rxf_start_cbfn(rxf);
-               } else
-                       bfa_fsm_set_state(rxf, bna_rxf_sm_cfg_wait);
+               bfa_fsm_set_state(rxf, bna_rxf_sm_cfg_wait);
                break;
 
        case RXF_E_STOP:
@@ -101,45 +92,6 @@ bna_rxf_sm_stopped(struct bna_rxf *rxf, enum bna_rxf_event event)
                call_rxf_cam_fltr_cbfn(rxf);
                break;
 
-       case RXF_E_PAUSE:
-               rxf->flags |= BNA_RXF_F_PAUSED;
-               call_rxf_pause_cbfn(rxf);
-               break;
-
-       case RXF_E_RESUME:
-               rxf->flags &= ~BNA_RXF_F_PAUSED;
-               call_rxf_resume_cbfn(rxf);
-               break;
-
-       default:
-               bfa_sm_fault(event);
-       }
-}
-
-static void
-bna_rxf_sm_paused_entry(struct bna_rxf *rxf)
-{
-       call_rxf_pause_cbfn(rxf);
-}
-
-static void
-bna_rxf_sm_paused(struct bna_rxf *rxf, enum bna_rxf_event event)
-{
-       switch (event) {
-       case RXF_E_STOP:
-       case RXF_E_FAIL:
-               bfa_fsm_set_state(rxf, bna_rxf_sm_stopped);
-               break;
-
-       case RXF_E_CONFIG:
-               call_rxf_cam_fltr_cbfn(rxf);
-               break;
-
-       case RXF_E_RESUME:
-               rxf->flags &= ~BNA_RXF_F_PAUSED;
-               bfa_fsm_set_state(rxf, bna_rxf_sm_cfg_wait);
-               break;
-
        default:
                bfa_sm_fault(event);
        }
@@ -166,7 +118,6 @@ bna_rxf_sm_cfg_wait(struct bna_rxf *rxf, enum bna_rxf_event event)
                bna_rxf_cfg_reset(rxf);
                call_rxf_start_cbfn(rxf);
                call_rxf_cam_fltr_cbfn(rxf);
-               call_rxf_resume_cbfn(rxf);
                bfa_fsm_set_state(rxf, bna_rxf_sm_stopped);
                break;
 
@@ -174,12 +125,6 @@ bna_rxf_sm_cfg_wait(struct bna_rxf *rxf, enum bna_rxf_event event)
                /* No-op */
                break;
 
-       case RXF_E_PAUSE:
-               rxf->flags |= BNA_RXF_F_PAUSED;
-               call_rxf_start_cbfn(rxf);
-               bfa_fsm_set_state(rxf, bna_rxf_sm_fltr_clr_wait);
-               break;
-
        case RXF_E_FW_RESP:
                if (!bna_rxf_cfg_apply(rxf)) {
                        /* No more pending config updates */
@@ -197,7 +142,6 @@ bna_rxf_sm_started_entry(struct bna_rxf *rxf)
 {
        call_rxf_start_cbfn(rxf);
        call_rxf_cam_fltr_cbfn(rxf);
-       call_rxf_resume_cbfn(rxf);
 }
 
 static void
@@ -214,41 +158,6 @@ bna_rxf_sm_started(struct bna_rxf *rxf, enum bna_rxf_event event)
                bfa_fsm_set_state(rxf, bna_rxf_sm_cfg_wait);
                break;
 
-       case RXF_E_PAUSE:
-               rxf->flags |= BNA_RXF_F_PAUSED;
-               if (!bna_rxf_fltr_clear(rxf))
-                       bfa_fsm_set_state(rxf, bna_rxf_sm_paused);
-               else
-                       bfa_fsm_set_state(rxf, bna_rxf_sm_fltr_clr_wait);
-               break;
-
-       default:
-               bfa_sm_fault(event);
-       }
-}
-
-static void
-bna_rxf_sm_fltr_clr_wait_entry(struct bna_rxf *rxf)
-{
-}
-
-static void
-bna_rxf_sm_fltr_clr_wait(struct bna_rxf *rxf, enum bna_rxf_event event)
-{
-       switch (event) {
-       case RXF_E_FAIL:
-               bna_rxf_cfg_reset(rxf);
-               call_rxf_pause_cbfn(rxf);
-               bfa_fsm_set_state(rxf, bna_rxf_sm_stopped);
-               break;
-
-       case RXF_E_FW_RESP:
-               if (!bna_rxf_fltr_clear(rxf)) {
-                       /* No more pending CAM entries to clear */
-                       bfa_fsm_set_state(rxf, bna_rxf_sm_paused);
-               }
-               break;
-
        default:
                bfa_sm_fault(event);
        }
@@ -283,7 +192,7 @@ bna_bfi_ucast_req(struct bna_rxf *rxf, struct bna_mac *mac,
        bfi_msgq_mhdr_set(req->mh, BFI_MC_ENET, req_type, 0, rxf->rx->rid);
        req->mh.num_entries = htons(
        bfi_msgq_num_cmd_entries(sizeof(struct bfi_enet_ucast_req)));
-       memcpy(&req->mac_addr, &mac->addr, sizeof(mac_t));
+       ether_addr_copy(req->mac_addr, mac->addr);
        bfa_msgq_cmd_set(&rxf->msgq_cmd, NULL, NULL,
                sizeof(struct bfi_enet_ucast_req), &req->mh);
        bfa_msgq_cmd_post(&rxf->rx->bna->msgq, &rxf->msgq_cmd);
@@ -299,7 +208,7 @@ bna_bfi_mcast_add_req(struct bna_rxf *rxf, struct bna_mac *mac)
                0, rxf->rx->rid);
        req->mh.num_entries = htons(
        bfi_msgq_num_cmd_entries(sizeof(struct bfi_enet_mcast_add_req)));
-       memcpy(&req->mac_addr, &mac->addr, sizeof(mac_t));
+       ether_addr_copy(req->mac_addr, mac->addr);
        bfa_msgq_cmd_set(&rxf->msgq_cmd, NULL, NULL,
                sizeof(struct bfi_enet_mcast_add_req), &req->mh);
        bfa_msgq_cmd_post(&rxf->rx->bna->msgq, &rxf->msgq_cmd);
@@ -451,13 +360,13 @@ bna_rxf_mcmac_get(struct bna_rxf *rxf, u8 *mac_addr)
 
        list_for_each(qe, &rxf->mcast_active_q) {
                mac = (struct bna_mac *)qe;
-               if (BNA_MAC_IS_EQUAL(&mac->addr, mac_addr))
+               if (ether_addr_equal(mac->addr, mac_addr))
                        return mac;
        }
 
        list_for_each(qe, &rxf->mcast_pending_del_q) {
                mac = (struct bna_mac *)qe;
-               if (BNA_MAC_IS_EQUAL(&mac->addr, mac_addr))
+               if (ether_addr_equal(mac->addr, mac_addr))
                        return mac;
        }
 
@@ -566,7 +475,7 @@ bna_rxf_vlan_cfg_apply(struct bna_rxf *rxf)
                        block_idx++;
                        vlan_pending_bitmask >>= 1;
                }
-               rxf->vlan_pending_bitmask &= ~(1 << block_idx);
+               rxf->vlan_pending_bitmask &= ~BIT(block_idx);
                bna_bfi_rx_vlan_filter_set(rxf, block_idx);
                return 1;
        }
@@ -658,25 +567,6 @@ bna_rxf_cfg_apply(struct bna_rxf *rxf)
        return 0;
 }
 
-/* Only software reset */
-static int
-bna_rxf_fltr_clear(struct bna_rxf *rxf)
-{
-       if (bna_rxf_ucast_cfg_reset(rxf, BNA_HARD_CLEANUP))
-               return 1;
-
-       if (bna_rxf_mcast_cfg_reset(rxf, BNA_HARD_CLEANUP))
-               return 1;
-
-       if (bna_rxf_promisc_cfg_reset(rxf, BNA_HARD_CLEANUP))
-               return 1;
-
-       if (bna_rxf_allmulti_cfg_reset(rxf, BNA_HARD_CLEANUP))
-               return 1;
-
-       return 0;
-}
-
 static void
 bna_rxf_cfg_reset(struct bna_rxf *rxf)
 {
@@ -760,9 +650,6 @@ bna_rxf_init(struct bna_rxf *rxf,
        INIT_LIST_HEAD(&rxf->mcast_active_q);
        INIT_LIST_HEAD(&rxf->mcast_handle_q);
 
-       if (q_config->paused)
-               rxf->flags |= BNA_RXF_F_PAUSED;
-
        rxf->rit = (u8 *)
                res_info[BNA_RX_RES_MEM_T_RIT].res_u.mem_info.mdl[0].kva;
        bna_rit_init(rxf, q_config->num_paths);
@@ -823,8 +710,6 @@ bna_rxf_uninit(struct bna_rxf *rxf)
        rxf->rss_pending = 0;
        rxf->vlan_strip_pending = false;
 
-       rxf->flags = 0;
-
        rxf->rx = NULL;
 }
 
@@ -863,8 +748,7 @@ bna_rxf_fail(struct bna_rxf *rxf)
 }
 
 enum bna_cb_status
-bna_rx_ucast_set(struct bna_rx *rx, u8 *ucmac,
-                void (*cbfn)(struct bnad *, struct bna_rx *))
+bna_rx_ucast_set(struct bna_rx *rx, u8 *ucmac)
 {
        struct bna_rxf *rxf = &rx->rxf;
 
@@ -876,9 +760,9 @@ bna_rx_ucast_set(struct bna_rx *rx, u8 *ucmac,
                bfa_q_qe_init(&rxf->ucast_pending_mac->qe);
        }
 
-       memcpy(rxf->ucast_pending_mac->addr, ucmac, ETH_ALEN);
+       ether_addr_copy(rxf->ucast_pending_mac->addr, ucmac);
        rxf->ucast_pending_set = 1;
-       rxf->cam_fltr_cbfn = cbfn;
+       rxf->cam_fltr_cbfn = NULL;
        rxf->cam_fltr_cbarg = rx->bna->bnad;
 
        bfa_fsm_send_event(rxf, RXF_E_CONFIG);
@@ -905,7 +789,7 @@ bna_rx_mcast_add(struct bna_rx *rx, u8 *addr,
        if (mac == NULL)
                return BNA_CB_MCAST_LIST_FULL;
        bfa_q_qe_init(&mac->qe);
-       memcpy(mac->addr, addr, ETH_ALEN);
+       ether_addr_copy(mac->addr, addr);
        list_add_tail(&mac->qe, &rxf->mcast_pending_add_q);
 
        rxf->cam_fltr_cbfn = cbfn;
@@ -917,8 +801,7 @@ bna_rx_mcast_add(struct bna_rx *rx, u8 *addr,
 }
 
 enum bna_cb_status
-bna_rx_ucast_listset(struct bna_rx *rx, int count, u8 *uclist,
-                    void (*cbfn)(struct bnad *, struct bna_rx *))
+bna_rx_ucast_listset(struct bna_rx *rx, int count, u8 *uclist)
 {
        struct bna_ucam_mod *ucam_mod = &rx->bna->ucam_mod;
        struct bna_rxf *rxf = &rx->rxf;
@@ -955,7 +838,7 @@ bna_rx_ucast_listset(struct bna_rx *rx, int count, u8 *uclist,
                if (mac == NULL)
                        goto err_return;
                bfa_q_qe_init(&mac->qe);
-               memcpy(mac->addr, mcaddr, ETH_ALEN);
+               ether_addr_copy(mac->addr, mcaddr);
                list_add_tail(&mac->qe, &list_head);
                mcaddr += ETH_ALEN;
        }
@@ -968,8 +851,6 @@ bna_rx_ucast_listset(struct bna_rx *rx, int count, u8 *uclist,
                list_add_tail(&mac->qe, &rxf->ucast_pending_add_q);
        }
 
-       rxf->cam_fltr_cbfn = cbfn;
-       rxf->cam_fltr_cbarg = rx->bna->bnad;
        bfa_fsm_send_event(rxf, RXF_E_CONFIG);
 
        return BNA_CB_SUCCESS;
@@ -986,8 +867,7 @@ err_return:
 }
 
 enum bna_cb_status
-bna_rx_mcast_listset(struct bna_rx *rx, int count, u8 *mclist,
-                    void (*cbfn)(struct bnad *, struct bna_rx *))
+bna_rx_mcast_listset(struct bna_rx *rx, int count, u8 *mclist)
 {
        struct bna_mcam_mod *mcam_mod = &rx->bna->mcam_mod;
        struct bna_rxf *rxf = &rx->rxf;
@@ -1026,7 +906,7 @@ bna_rx_mcast_listset(struct bna_rx *rx, int count, u8 *mclist,
                if (mac == NULL)
                        goto err_return;
                bfa_q_qe_init(&mac->qe);
-               memcpy(mac->addr, mcaddr, ETH_ALEN);
+               ether_addr_copy(mac->addr, mcaddr);
                list_add_tail(&mac->qe, &list_head);
 
                mcaddr += ETH_ALEN;
@@ -1040,8 +920,6 @@ bna_rx_mcast_listset(struct bna_rx *rx, int count, u8 *mclist,
                list_add_tail(&mac->qe, &rxf->mcast_pending_add_q);
        }
 
-       rxf->cam_fltr_cbfn = cbfn;
-       rxf->cam_fltr_cbarg = rx->bna->bnad;
        bfa_fsm_send_event(rxf, RXF_E_CONFIG);
 
        return BNA_CB_SUCCESS;
@@ -1058,8 +936,7 @@ err_return:
 }
 
 void
-bna_rx_mcast_delall(struct bna_rx *rx,
-                   void (*cbfn)(struct bnad *, struct bna_rx *))
+bna_rx_mcast_delall(struct bna_rx *rx)
 {
        struct bna_rxf *rxf = &rx->rxf;
        struct list_head *qe;
@@ -1089,15 +966,8 @@ bna_rx_mcast_delall(struct bna_rx *rx,
                need_hw_config = 1;
        }
 
-       if (need_hw_config) {
-               rxf->cam_fltr_cbfn = cbfn;
-               rxf->cam_fltr_cbarg = rx->bna->bnad;
+       if (need_hw_config)
                bfa_fsm_send_event(rxf, RXF_E_CONFIG);
-               return;
-       }
-
-       if (cbfn)
-               (*cbfn)(rx->bna->bnad, rx);
 }
 
 void
@@ -1105,12 +975,12 @@ bna_rx_vlan_add(struct bna_rx *rx, int vlan_id)
 {
        struct bna_rxf *rxf = &rx->rxf;
        int index = (vlan_id >> BFI_VLAN_WORD_SHIFT);
-       int bit = (1 << (vlan_id & BFI_VLAN_WORD_MASK));
+       int bit = BIT((vlan_id & BFI_VLAN_WORD_MASK));
        int group_id = (vlan_id >> BFI_VLAN_BLOCK_SHIFT);
 
        rxf->vlan_filter_table[index] |= bit;
        if (rxf->vlan_filter_status == BNA_STATUS_T_ENABLED) {
-               rxf->vlan_pending_bitmask |= (1 << group_id);
+               rxf->vlan_pending_bitmask |= BIT(group_id);
                bfa_fsm_send_event(rxf, RXF_E_CONFIG);
        }
 }
@@ -1120,12 +990,12 @@ bna_rx_vlan_del(struct bna_rx *rx, int vlan_id)
 {
        struct bna_rxf *rxf = &rx->rxf;
        int index = (vlan_id >> BFI_VLAN_WORD_SHIFT);
-       int bit = (1 << (vlan_id & BFI_VLAN_WORD_MASK));
+       int bit = BIT((vlan_id & BFI_VLAN_WORD_MASK));
        int group_id = (vlan_id >> BFI_VLAN_BLOCK_SHIFT);
 
        rxf->vlan_filter_table[index] &= ~bit;
        if (rxf->vlan_filter_status == BNA_STATUS_T_ENABLED) {
-               rxf->vlan_pending_bitmask |= (1 << group_id);
+               rxf->vlan_pending_bitmask |= BIT(group_id);
                bfa_fsm_send_event(rxf, RXF_E_CONFIG);
        }
 }
@@ -1149,8 +1019,8 @@ bna_rxf_ucast_cfg_apply(struct bna_rxf *rxf)
        /* Set default unicast MAC */
        if (rxf->ucast_pending_set) {
                rxf->ucast_pending_set = 0;
-               memcpy(rxf->ucast_active_mac.addr,
-                       rxf->ucast_pending_mac->addr, ETH_ALEN);
+               ether_addr_copy(rxf->ucast_active_mac.addr,
+                               rxf->ucast_pending_mac->addr);
                rxf->ucast_active_set = 1;
                bna_bfi_ucast_req(rxf, &rxf->ucast_active_mac,
                        BFI_ENET_H2I_MAC_UCAST_SET_REQ);
@@ -2396,20 +2266,19 @@ bna_rx_res_req(struct bna_rx_config *q_cfg, struct bna_res_info *res_info)
 
        dq_depth = q_cfg->q0_depth;
        hq_depth = ((q_cfg->rxp_type == BNA_RXP_SINGLE) ? 0 : q_cfg->q1_depth);
-       cq_depth = dq_depth + hq_depth;
+       cq_depth = roundup_pow_of_two(dq_depth + hq_depth);
 
-       BNA_TO_POWER_OF_2_HIGH(cq_depth);
        cq_size = cq_depth * BFI_CQ_WI_SIZE;
        cq_size = ALIGN(cq_size, PAGE_SIZE);
        cpage_count = SIZE_TO_PAGES(cq_size);
 
-       BNA_TO_POWER_OF_2_HIGH(dq_depth);
+       dq_depth = roundup_pow_of_two(dq_depth);
        dq_size = dq_depth * BFI_RXQ_WI_SIZE;
        dq_size = ALIGN(dq_size, PAGE_SIZE);
        dpage_count = SIZE_TO_PAGES(dq_size);
 
        if (BNA_RXP_SINGLE != q_cfg->rxp_type) {
-               BNA_TO_POWER_OF_2_HIGH(hq_depth);
+               hq_depth = roundup_pow_of_two(hq_depth);
                hq_size = hq_depth * BFI_RXQ_WI_SIZE;
                hq_size = ALIGN(hq_size, PAGE_SIZE);
                hpage_count = SIZE_TO_PAGES(hq_size);
@@ -2620,7 +2489,7 @@ bna_rx_create(struct bna *bna, struct bnad *bnad,
                if (intr_info->intr_type == BNA_INTR_T_MSIX)
                        rxp->cq.ib.intr_vector = rxp->vector;
                else
-                       rxp->cq.ib.intr_vector = (1 << rxp->vector);
+                       rxp->cq.ib.intr_vector = BIT(rxp->vector);
                rxp->cq.ib.coalescing_timeo = rx_cfg->coalescing_timeo;
                rxp->cq.ib.interpkt_count = BFI_RX_INTERPKT_COUNT;
                rxp->cq.ib.interpkt_timeo = BFI_RX_INTERPKT_TIMEO;
@@ -2691,7 +2560,7 @@ bna_rx_create(struct bna *bna, struct bnad *bnad,
                /* if multi-buffer is enabled sum of q0_depth
                 * and q1_depth need not be a power of 2
                 */
-               BNA_TO_POWER_OF_2_HIGH(cq_depth);
+               cq_depth = roundup_pow_of_two(cq_depth);
                rxp->cq.ccb->q_depth = cq_depth;
                rxp->cq.ccb->cq = &rxp->cq;
                rxp->cq.ccb->rcb[0] = q0->rcb;
@@ -2725,7 +2594,7 @@ bna_rx_create(struct bna *bna, struct bnad *bnad,
 
        bfa_fsm_set_state(rx, bna_rx_sm_stopped);
 
-       rx_mod->rid_mask |= (1 << rx->rid);
+       rx_mod->rid_mask |= BIT(rx->rid);
 
        return rx;
 }
@@ -2777,7 +2646,7 @@ bna_rx_destroy(struct bna_rx *rx)
                }
        }
 
-       rx_mod->rid_mask &= ~(1 << rx->rid);
+       rx_mod->rid_mask &= ~BIT(rx->rid);
 
        rx->bna = NULL;
        rx->priv = NULL;
@@ -2844,8 +2713,7 @@ bna_rx_vlan_strip_disable(struct bna_rx *rx)
 
 enum bna_cb_status
 bna_rx_mode_set(struct bna_rx *rx, enum bna_rxmode new_mode,
-               enum bna_rxmode bitmask,
-               void (*cbfn)(struct bnad *, struct bna_rx *))
+               enum bna_rxmode bitmask)
 {
        struct bna_rxf *rxf = &rx->rxf;
        int need_hw_config = 0;
@@ -2900,11 +2768,10 @@ bna_rx_mode_set(struct bna_rx *rx, enum bna_rxmode new_mode,
        /* Trigger h/w if needed */
 
        if (need_hw_config) {
-               rxf->cam_fltr_cbfn = cbfn;
+               rxf->cam_fltr_cbfn = NULL;
                rxf->cam_fltr_cbarg = rx->bna->bnad;
                bfa_fsm_send_event(rxf, RXF_E_CONFIG);
-       } else if (cbfn)
-               (*cbfn)(rx->bna->bnad, rx);
+       }
 
        return BNA_CB_SUCCESS;
 
@@ -3024,16 +2891,6 @@ do {                                                                     \
        }                                                               \
 } while (0)
 
-#define call_tx_prio_change_cbfn(tx)                                   \
-do {                                                                   \
-       if ((tx)->prio_change_cbfn) {                                   \
-               void (*cbfn)(struct bnad *, struct bna_tx *);   \
-               cbfn = (tx)->prio_change_cbfn;                          \
-               (tx)->prio_change_cbfn = NULL;                          \
-               cbfn((tx)->bna->bnad, (tx));                            \
-       }                                                               \
-} while (0)
-
 static void bna_tx_mod_cb_tx_stopped(void *tx_mod, struct bna_tx *tx);
 static void bna_bfi_tx_enet_start(struct bna_tx *tx);
 static void bna_tx_enet_stop(struct bna_tx *tx);
@@ -3086,7 +2943,6 @@ bna_tx_sm_stopped(struct bna_tx *tx, enum bna_tx_event event)
                break;
 
        case TX_E_PRIO_CHANGE:
-               call_tx_prio_change_cbfn(tx);
                break;
 
        case TX_E_BW_UPDATE:
@@ -3256,7 +3112,6 @@ bna_tx_sm_prio_stop_wait(struct bna_tx *tx, enum bna_tx_event event)
 
        case TX_E_FAIL:
                bfa_fsm_set_state(tx, bna_tx_sm_failed);
-               call_tx_prio_change_cbfn(tx);
                tx->tx_cleanup_cbfn(tx->bna->bnad, tx);
                break;
 
@@ -3277,7 +3132,6 @@ bna_tx_sm_prio_stop_wait(struct bna_tx *tx, enum bna_tx_event event)
 static void
 bna_tx_sm_prio_cleanup_wait_entry(struct bna_tx *tx)
 {
-       call_tx_prio_change_cbfn(tx);
        tx->tx_cleanup_cbfn(tx->bna->bnad, tx);
 }
 
@@ -3779,7 +3633,7 @@ bna_tx_create(struct bna *bna, struct bnad *bnad,
                                        intr_info->idl[0].vector :
                                        intr_info->idl[i].vector;
                if (intr_info->intr_type == BNA_INTR_T_INTX)
-                       txq->ib.intr_vector = (1 <<  txq->ib.intr_vector);
+                       txq->ib.intr_vector = BIT(txq->ib.intr_vector);
                txq->ib.coalescing_timeo = tx_cfg->coalescing_timeo;
                txq->ib.interpkt_timeo = BFI_TX_INTERPKT_TIMEO;
                txq->ib.interpkt_count = BFI_TX_INTERPKT_COUNT;
@@ -3821,7 +3675,7 @@ bna_tx_create(struct bna *bna, struct bnad *bnad,
 
        bfa_fsm_set_state(tx, bna_tx_sm_stopped);
 
-       tx_mod->rid_mask |= (1 << tx->rid);
+       tx_mod->rid_mask |= BIT(tx->rid);
 
        return tx;
 
@@ -3842,7 +3696,7 @@ bna_tx_destroy(struct bna_tx *tx)
                        (tx->tcb_destroy_cbfn)(tx->bna->bnad, txq->tcb);
        }
 
-       tx->bna->tx_mod.rid_mask &= ~(1 << tx->rid);
+       tx->bna->tx_mod.rid_mask &= ~BIT(tx->rid);
        bna_tx_free(tx);
 }