edd: fix possible memory leak in edd_init() error path

[cascardo/linux.git] / drivers / s390 / net / qeth_core_main.c

diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 6d51494..3a5a18a 100644 (file)
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -3748,15 +3748,10 @@ int qeth_snmp_command(struct qeth_card *card, char __user *udata)
        /* skip 4 bytes (data_len struct member) to get req_len */
        if (copy_from_user(&req_len, udata + sizeof(int), sizeof(int)))
                return -EFAULT;
-       ureq = kmalloc(req_len+sizeof(struct qeth_snmp_ureq_hdr), GFP_KERNEL);
-       if (!ureq) {
+       ureq = memdup_user(udata, req_len + sizeof(struct qeth_snmp_ureq_hdr));
+       if (IS_ERR(ureq)) {
                QETH_CARD_TEXT(card, 2, "snmpnome");
-               return -ENOMEM;
-       }
-       if (copy_from_user(ureq, udata,
-                       req_len + sizeof(struct qeth_snmp_ureq_hdr))) {
-               kfree(ureq);
-               return -EFAULT;
+               return PTR_ERR(ureq);
        }
        qinfo.udata_len = ureq->hdr.data_len;
        qinfo.udata = kzalloc(qinfo.udata_len, GFP_KERNEL);