Merge tag 'dt-for-linus' of git://git.secretlab.ca/git/linux
[cascardo/linux.git] / drivers / staging / rtl8188eu / core / rtw_cmd.c
index 976f000..c2fb050 100644 (file)
@@ -393,13 +393,13 @@ u8 rtw_setstandby_cmd(struct adapter *padapter, uint action)
        u8 ret = _SUCCESS;
 
 
-       ph2c = (struct cmd_obj *)rtw_zmalloc(sizeof(struct cmd_obj));
+       ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
        if (ph2c == NULL) {
                ret = _FAIL;
                goto exit;
        }
 
-       psetusbsuspend = (struct usb_suspend_parm *)rtw_zmalloc(sizeof(struct usb_suspend_parm));
+       psetusbsuspend = kzalloc(sizeof(struct usb_suspend_parm), GFP_KERNEL);
        if (psetusbsuspend == NULL) {
                kfree(ph2c);
                ret = _FAIL;
@@ -432,13 +432,11 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter, struct ndis_802_11_ssid *ssid,
        struct cmd_priv         *pcmdpriv = &padapter->cmdpriv;
        struct mlme_priv        *pmlmepriv = &padapter->mlmepriv;
 
-       if (check_fwstate(pmlmepriv, _FW_LINKED) == true) {
+       if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
                rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_SCAN, 1);
-       }
 
-       if (check_fwstate(pmlmepriv, _FW_LINKED) == true) {
+       if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
                p2p_ps_wk_cmd(padapter, P2P_PS_SCAN, 1);
-       }
 
        ph2c = (struct cmd_obj *)rtw_zmalloc(sizeof(struct cmd_obj));
        if (ph2c == NULL)
@@ -466,9 +464,6 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter, struct ndis_802_11_ssid *ssid,
                        if (ssid[i].SsidLength) {
                                memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
                                psurveyPara->ssid_num++;
-                               if (0)
-                               DBG_88E(FUNC_ADPT_FMT" ssid:(%s, %d)\n", FUNC_ADPT_ARG(padapter),
-                                       psurveyPara->ssid[i].Ssid, psurveyPara->ssid[i].SsidLength);
                        }
                }
        }
@@ -480,9 +475,6 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter, struct ndis_802_11_ssid *ssid,
                        if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) {
                                memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel));
                                psurveyPara->ch_num++;
-                               if (0)
-                               DBG_88E(FUNC_ADPT_FMT" ch:%u\n", FUNC_ADPT_ARG(padapter),
-                                       psurveyPara->ch[i].hw_value);
                        }
                }
        }
@@ -844,11 +836,10 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
 
        rtw_led_control(padapter, LED_CTL_START_TO_LINK);
 
-       if (pmlmepriv->assoc_ssid.SsidLength == 0) {
+       if (pmlmepriv->assoc_ssid.SsidLength == 0)
                RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("+Join cmd: Any SSid\n"));
-       } else {
+       else
                RT_TRACE(_module_rtl871x_cmd_c_, _drv_notice_, ("+Join cmd: SSid =[%s]\n", pmlmepriv->assoc_ssid.Ssid));
-       }
 
        pcmd = (struct cmd_obj *)rtw_zmalloc(sizeof(struct cmd_obj));
        if (pcmd == NULL) {
@@ -894,11 +885,10 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
 
        psecuritypriv->authenticator_ie[0] = (unsigned char)psecnetwork->IELength;
 
-       if ((psecnetwork->IELength-12) < (256-1)) {
+       if ((psecnetwork->IELength-12) < (256-1))
                memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], psecnetwork->IELength-12);
-       } else {
+       else
                memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], (256-1));
-       }
 
        psecnetwork->IELength = 0;
        /*  Added by Albert 2009/02/18 */
@@ -1081,7 +1071,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, u8 *psta, u8 unicast_key)
        ph2c->rsp = (u8 *)psetstakey_rsp;
        ph2c->rspsz = sizeof(struct set_stakey_rsp);
 
-       memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN);
+       ether_addr_copy(psetstakey_para->addr, sta->hwaddr);
 
        if (check_fwstate(pmlmepriv, WIFI_STATION_STATE))
                psetstakey_para->algorithm = (unsigned char) psecuritypriv->dot11PrivacyAlgrthm;
@@ -1142,7 +1132,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, u8 *psta, u8 entry, u8 enqueue)
                ph2c->rsp = (u8 *)psetstakey_rsp;
                ph2c->rspsz = sizeof(struct set_stakey_rsp);
 
-               memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN);
+               ether_addr_copy(psetstakey_para->addr, sta->hwaddr);
 
                psetstakey_para->algorithm = _NO_PRIVACY_;
 
@@ -1205,8 +1195,6 @@ u8 rtw_getrttbl_cmd(struct adapter  *padapter, struct getratable_rsp *pval)
                goto exit;
        }
 
-/*     init_h2fwcmd_w_parm_no_rsp(ph2c, psetrttblparm, GEN_CMD_CODE(_SetRaTable)); */
-
        _rtw_init_listhead(&ph2c->list);
        ph2c->cmdcode = GEN_CMD_CODE(_GetRaTable);
        ph2c->parmbuf = (unsigned char *)pgetrttblparm;
@@ -1255,7 +1243,7 @@ u8 rtw_setassocsta_cmd(struct adapter  *padapter, u8 *mac_addr)
        ph2c->rsp = (u8 *)psetassocsta_rsp;
        ph2c->rspsz = sizeof(struct set_assocsta_rsp);
 
-       memcpy(psetassocsta_para->addr, mac_addr, ETH_ALEN);
+       ether_addr_copy(psetassocsta_para->addr, mac_addr);
 
        res = rtw_enqueue_cmd(pcmdpriv, ph2c);
 
@@ -1263,7 +1251,7 @@ exit:
 
 
        return res;
- }
+}
 
 u8 rtw_addbareq_cmd(struct adapter *padapter, u8 tid, u8 *addr)
 {
@@ -1651,10 +1639,6 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)
        /* struct pwrctrl_priv *pwrctrlpriv = &padapter->pwrctrlpriv; */
        u8      res = _SUCCESS;
 
-
-       /* if (!pwrctrlpriv->bLeisurePs) */
-       /*      return res; */
-
        if (enqueue) {
                ph2c = (struct cmd_obj *)rtw_zmalloc(sizeof(struct cmd_obj));
                if (ph2c == NULL) {
@@ -1801,8 +1785,8 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, int intCmdType)
        }
 
        pdrvextra_cmd_parm->ec_id = P2P_PROTO_WK_CID;
-       pdrvextra_cmd_parm->type_size = intCmdType;     /*      As the command tppe. */
-       pdrvextra_cmd_parm->pbuf = NULL;                /*      Must be NULL here */
+       pdrvextra_cmd_parm->type_size = intCmdType; /* As the command tppe. */
+       pdrvextra_cmd_parm->pbuf = NULL;            /* Must be NULL here */
 
        init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra));
 
@@ -1990,12 +1974,16 @@ static void c2h_wk_callback(struct work_struct *work)
        evtpriv->c2h_wk_alive = true;
 
        while (!rtw_cbuf_empty(evtpriv->c2h_queue)) {
-               if ((c2h_evt = (struct c2h_evt_hdr *)rtw_cbuf_pop(evtpriv->c2h_queue)) != NULL) {
+               c2h_evt = (struct c2h_evt_hdr *)
+                       rtw_cbuf_pop(evtpriv->c2h_queue);
+               if (c2h_evt != NULL)
                        /* This C2H event is read, clear it */
                        c2h_evt_clear(adapter);
-               } else if ((c2h_evt = (struct c2h_evt_hdr *)rtw_malloc(16)) != NULL) {
+               else {
+                       c2h_evt = (struct c2h_evt_hdr *)rtw_malloc(16);
                        /* This C2H event is not read, read & clear now */
-                       if (c2h_evt_read(adapter, (u8 *)c2h_evt) != _SUCCESS)
+                       if (c2h_evt != NULL &&
+                           c2h_evt_read(adapter, (u8 *)c2h_evt) != _SUCCESS)
                                continue;
                }
 
@@ -2053,8 +2041,10 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
                p2p_ps_wk_hdl(padapter, pdrvextra_cmd->type_size);
                break;
        case P2P_PROTO_WK_CID:
-               /*      Commented by Albert 2011/07/01 */
-               /*      I used the type_size as the type command */
+               /*
+                * Commented by Albert 2011/07/01
+                * I used the type_size as the type command
+                */
                p2p_protocol_wk_hdl(padapter, pdrvextra_cmd->type_size);
                break;
 #endif
@@ -2085,7 +2075,7 @@ void rtw_survey_cmd_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
                /* TODO: cancel timer and do timeout handler directly... */
                /* need to make timeout handlerOS independent */
                _set_timer(&pmlmepriv->scan_to_timer, 1);
-               } else if (pcmd->res != H2C_SUCCESS) {
+       } else if (pcmd->res != H2C_SUCCESS) {
                _set_timer(&pmlmepriv->scan_to_timer, 1);
                RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\n ********Error: MgntActrtw_set_802_11_bssid_LIST_SCAN Fail ************\n\n."));
        }
@@ -2141,7 +2131,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
        struct wlan_network *tgt_network = &(pmlmepriv->cur_network);
 
 
-       if ((pcmd->res != H2C_SUCCESS)) {
+       if (pcmd->res != H2C_SUCCESS) {
                RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\n ********Error: rtw_createbss_cmd_callback  Fail ************\n\n."));
                _set_timer(&pmlmepriv->assoc_timer, 1);
        }
@@ -2156,7 +2146,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
                        psta = rtw_alloc_stainfo(&padapter->stapriv, pnetwork->MacAddress);
                        if (psta == NULL) {
                                RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nCan't alloc sta_info when createbss_cmd_callback\n"));
-                               goto createbss_cmd_fail ;
+                               goto createbss_cmd_fail;
                        }
                }