fuse: pass iov[] to fuse_get_user_pages()
[cascardo/linux.git] / fs / fuse / file.c
index e21d4d8..542ad97 100644 (file)
@@ -25,7 +25,7 @@ static int fuse_send_open(struct fuse_conn *fc, u64 nodeid, struct file *file,
        struct fuse_req *req;
        int err;
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req))
                return PTR_ERR(req);
 
@@ -57,7 +57,7 @@ struct fuse_file *fuse_file_alloc(struct fuse_conn *fc)
                return NULL;
 
        ff->fc = fc;
-       ff->reserved_req = fuse_request_alloc();
+       ff->reserved_req = fuse_request_alloc(0);
        if (unlikely(!ff->reserved_req)) {
                kfree(ff);
                return NULL;
@@ -368,7 +368,7 @@ static int fuse_flush(struct file *file, fl_owner_t id)
        if (fc->no_flush)
                return 0;
 
-       req = fuse_get_req_nofail(fc, file);
+       req = fuse_get_req_nofail_nopages(fc, file);
        memset(&inarg, 0, sizeof(inarg));
        inarg.fh = ff->fh;
        inarg.lock_owner = fuse_lock_owner_id(fc, id);
@@ -436,7 +436,7 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end,
 
        fuse_sync_writes(inode);
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req)) {
                err = PTR_ERR(req);
                goto out;
@@ -544,7 +544,7 @@ static int fuse_readpage(struct file *file, struct page *page)
         */
        fuse_wait_on_page_writeback(inode, page->index);
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req(fc, 1);
        err = PTR_ERR(req);
        if (IS_ERR(req))
                goto out;
@@ -555,6 +555,7 @@ static int fuse_readpage(struct file *file, struct page *page)
        req->out.argpages = 1;
        req->num_pages = 1;
        req->pages[0] = page;
+       req->page_descs[0].length = count;
        num_read = fuse_send_read(req, file, pos, count, NULL);
        err = req->out.h.error;
        fuse_put_request(fc, req);
@@ -641,6 +642,7 @@ struct fuse_fill_data {
        struct fuse_req *req;
        struct file *file;
        struct inode *inode;
+       unsigned nr_pages;
 };
 
 static int fuse_readpages_fill(void *_data, struct page *page)
@@ -656,16 +658,26 @@ static int fuse_readpages_fill(void *_data, struct page *page)
            (req->num_pages == FUSE_MAX_PAGES_PER_REQ ||
             (req->num_pages + 1) * PAGE_CACHE_SIZE > fc->max_read ||
             req->pages[req->num_pages - 1]->index + 1 != page->index)) {
+               int nr_alloc = min_t(unsigned, data->nr_pages,
+                                    FUSE_MAX_PAGES_PER_REQ);
                fuse_send_readpages(req, data->file);
-               data->req = req = fuse_get_req(fc);
+               data->req = req = fuse_get_req(fc, nr_alloc);
                if (IS_ERR(req)) {
                        unlock_page(page);
                        return PTR_ERR(req);
                }
        }
+
+       if (WARN_ON(req->num_pages >= req->max_pages)) {
+               fuse_put_request(fc, req);
+               return -EIO;
+       }
+
        page_cache_get(page);
        req->pages[req->num_pages] = page;
+       req->page_descs[req->num_pages].length = PAGE_SIZE;
        req->num_pages++;
+       data->nr_pages--;
        return 0;
 }
 
@@ -676,6 +688,7 @@ static int fuse_readpages(struct file *file, struct address_space *mapping,
        struct fuse_conn *fc = get_fuse_conn(inode);
        struct fuse_fill_data data;
        int err;
+       int nr_alloc = min_t(unsigned, nr_pages, FUSE_MAX_PAGES_PER_REQ);
 
        err = -EIO;
        if (is_bad_inode(inode))
@@ -683,7 +696,8 @@ static int fuse_readpages(struct file *file, struct address_space *mapping,
 
        data.file = file;
        data.inode = inode;
-       data.req = fuse_get_req(fc);
+       data.req = fuse_get_req(fc, nr_alloc);
+       data.nr_pages = nr_pages;
        err = PTR_ERR(data.req);
        if (IS_ERR(data.req))
                goto out;
@@ -786,7 +800,7 @@ static size_t fuse_send_write_pages(struct fuse_req *req, struct file *file,
 
        res = fuse_send_write(req, file, pos, count, NULL);
 
-       offset = req->page_offset;
+       offset = req->page_descs[0].offset;
        count = res;
        for (i = 0; i < req->num_pages; i++) {
                struct page *page = req->pages[i];
@@ -817,7 +831,7 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req,
        int err;
 
        req->in.argpages = 1;
-       req->page_offset = offset;
+       req->page_descs[0].offset = offset;
 
        do {
                size_t tmp;
@@ -857,6 +871,7 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req,
 
                err = 0;
                req->pages[req->num_pages] = page;
+               req->page_descs[req->num_pages].length = tmp;
                req->num_pages++;
 
                iov_iter_advance(ii, tmp);
@@ -869,11 +884,19 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req,
                if (!fc->big_writes)
                        break;
        } while (iov_iter_count(ii) && count < fc->max_write &&
-                req->num_pages < FUSE_MAX_PAGES_PER_REQ && offset == 0);
+                req->num_pages < req->max_pages && offset == 0);
 
        return count > 0 ? count : err;
 }
 
+static inline unsigned fuse_wr_pages(loff_t pos, size_t len)
+{
+       return min_t(unsigned,
+                    ((pos + len - 1) >> PAGE_CACHE_SHIFT) -
+                    (pos >> PAGE_CACHE_SHIFT) + 1,
+                    FUSE_MAX_PAGES_PER_REQ);
+}
+
 static ssize_t fuse_perform_write(struct file *file,
                                  struct address_space *mapping,
                                  struct iov_iter *ii, loff_t pos)
@@ -889,8 +912,9 @@ static ssize_t fuse_perform_write(struct file *file,
        do {
                struct fuse_req *req;
                ssize_t count;
+               unsigned nr_pages = fuse_wr_pages(pos, iov_iter_count(ii));
 
-               req = fuse_get_req(fc);
+               req = fuse_get_req(fc, nr_pages);
                if (IS_ERR(req)) {
                        err = PTR_ERR(req);
                        break;
@@ -1023,14 +1047,27 @@ static void fuse_release_user_pages(struct fuse_req *req, int write)
        }
 }
 
-static int fuse_get_user_pages(struct fuse_req *req, const char __user *buf,
+static inline void fuse_page_descs_length_init(struct fuse_req *req)
+{
+       int i;
+
+       for (i = 0; i < req->num_pages; i++)
+               req->page_descs[i].length = PAGE_SIZE -
+                       req->page_descs[i].offset;
+}
+
+static int fuse_get_user_pages(struct fuse_req *req, struct iov_iter *ii,
                               size_t *nbytesp, int write)
 {
        size_t nbytes = *nbytesp;
-       unsigned long user_addr = (unsigned long) buf;
-       unsigned offset = user_addr & ~PAGE_MASK;
+       size_t frag_size = min(iov_iter_single_seg_count(ii), nbytes);
+       unsigned long user_addr;
+       unsigned offset;
        int npages;
 
+       user_addr = (unsigned long)ii->iov->iov_base + ii->iov_offset;
+       offset = user_addr & ~PAGE_MASK;
+
        /* Special case for kernel I/O: can copy directly into the buffer */
        if (segment_eq(get_fs(), KERNEL_DS)) {
                if (write)
@@ -1038,10 +1075,12 @@ static int fuse_get_user_pages(struct fuse_req *req, const char __user *buf,
                else
                        req->out.args[0].value = (void *) user_addr;
 
+               iov_iter_advance(ii, frag_size);
+               *nbytesp = frag_size;
                return 0;
        }
 
-       nbytes = min_t(size_t, nbytes, FUSE_MAX_PAGES_PER_REQ << PAGE_SHIFT);
+       nbytes = min_t(size_t, frag_size, FUSE_MAX_PAGES_PER_REQ << PAGE_SHIFT);
        npages = (nbytes + offset + PAGE_SIZE - 1) >> PAGE_SHIFT;
        npages = clamp(npages, 1, FUSE_MAX_PAGES_PER_REQ);
        npages = get_user_pages_fast(user_addr, npages, !write, req->pages);
@@ -1049,21 +1088,29 @@ static int fuse_get_user_pages(struct fuse_req *req, const char __user *buf,
                return npages;
 
        req->num_pages = npages;
-       req->page_offset = offset;
+       req->page_descs[0].offset = offset;
+       fuse_page_descs_length_init(req);
 
        if (write)
                req->in.argpages = 1;
        else
                req->out.argpages = 1;
 
-       nbytes = (req->num_pages << PAGE_SHIFT) - req->page_offset;
-       *nbytesp = min(*nbytesp, nbytes);
+       nbytes = (req->num_pages << PAGE_SHIFT) - req->page_descs[0].offset;
+
+       if (frag_size < nbytes)
+               req->page_descs[req->num_pages - 1].length -=
+                       nbytes - frag_size;
+
+       *nbytesp = min(frag_size, nbytes);
+       iov_iter_advance(ii, *nbytesp);
 
        return 0;
 }
 
-ssize_t fuse_direct_io(struct file *file, const char __user *buf,
-                      size_t count, loff_t *ppos, int write)
+static ssize_t __fuse_direct_io(struct file *file, const struct iovec *iov,
+                               unsigned long nr_segs, size_t count,
+                               loff_t *ppos, int write)
 {
        struct fuse_file *ff = file->private_data;
        struct fuse_conn *fc = ff->fc;
@@ -1071,8 +1118,11 @@ ssize_t fuse_direct_io(struct file *file, const char __user *buf,
        loff_t pos = *ppos;
        ssize_t res = 0;
        struct fuse_req *req;
+       struct iov_iter ii;
+
+       iov_iter_init(&ii, iov, nr_segs, count, 0);
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req(fc, FUSE_MAX_PAGES_PER_REQ);
        if (IS_ERR(req))
                return PTR_ERR(req);
 
@@ -1080,7 +1130,7 @@ ssize_t fuse_direct_io(struct file *file, const char __user *buf,
                size_t nres;
                fl_owner_t owner = current->files;
                size_t nbytes = min(count, nmax);
-               int err = fuse_get_user_pages(req, buf, &nbytes, write);
+               int err = fuse_get_user_pages(req, &ii, &nbytes, write);
                if (err) {
                        res = err;
                        break;
@@ -1103,12 +1153,11 @@ ssize_t fuse_direct_io(struct file *file, const char __user *buf,
                count -= nres;
                res += nres;
                pos += nres;
-               buf += nres;
                if (nres != nbytes)
                        break;
                if (count) {
                        fuse_put_request(fc, req);
-                       req = fuse_get_req(fc);
+                       req = fuse_get_req(fc, FUSE_MAX_PAGES_PER_REQ);
                        if (IS_ERR(req))
                                break;
                }
@@ -1120,10 +1169,17 @@ ssize_t fuse_direct_io(struct file *file, const char __user *buf,
 
        return res;
 }
+
+ssize_t fuse_direct_io(struct file *file, const char __user *buf,
+                      size_t count, loff_t *ppos, int write)
+{
+       struct iovec iov = { .iov_base = (void *)buf, .iov_len = count };
+       return __fuse_direct_io(file, &iov, 1, count, ppos, write);
+}
 EXPORT_SYMBOL_GPL(fuse_direct_io);
 
-static ssize_t fuse_direct_read(struct file *file, char __user *buf,
-                                    size_t count, loff_t *ppos)
+static ssize_t __fuse_direct_read(struct file *file, const struct iovec *iov,
+                                 unsigned long nr_segs, loff_t *ppos)
 {
        ssize_t res;
        struct inode *inode = file->f_path.dentry->d_inode;
@@ -1131,22 +1187,31 @@ static ssize_t fuse_direct_read(struct file *file, char __user *buf,
        if (is_bad_inode(inode))
                return -EIO;
 
-       res = fuse_direct_io(file, buf, count, ppos, 0);
+       res = __fuse_direct_io(file, iov, nr_segs, iov_length(iov, nr_segs),
+                              ppos, 0);
 
        fuse_invalidate_attr(inode);
 
        return res;
 }
 
-static ssize_t __fuse_direct_write(struct file *file, const char __user *buf,
-                                  size_t count, loff_t *ppos)
+static ssize_t fuse_direct_read(struct file *file, char __user *buf,
+                                    size_t count, loff_t *ppos)
+{
+       struct iovec iov = { .iov_base = (void *)buf, .iov_len = count };
+       return __fuse_direct_read(file, &iov, 1, ppos);
+}
+
+static ssize_t __fuse_direct_write(struct file *file, const struct iovec *iov,
+                                  unsigned long nr_segs, loff_t *ppos)
 {
        struct inode *inode = file->f_path.dentry->d_inode;
+       size_t count = iov_length(iov, nr_segs);
        ssize_t res;
 
        res = generic_write_checks(file, ppos, &count, 0);
        if (!res) {
-               res = fuse_direct_io(file, buf, count, ppos, 1);
+               res = __fuse_direct_io(file, iov, nr_segs, count, ppos, 1);
                if (res > 0)
                        fuse_write_update_size(inode, *ppos);
        }
@@ -1159,6 +1224,7 @@ static ssize_t __fuse_direct_write(struct file *file, const char __user *buf,
 static ssize_t fuse_direct_write(struct file *file, const char __user *buf,
                                 size_t count, loff_t *ppos)
 {
+       struct iovec iov = { .iov_base = (void *)buf, .iov_len = count };
        struct inode *inode = file->f_path.dentry->d_inode;
        ssize_t res;
 
@@ -1167,7 +1233,7 @@ static ssize_t fuse_direct_write(struct file *file, const char __user *buf,
 
        /* Don't allow parallel writes to the same file */
        mutex_lock(&inode->i_mutex);
-       res = __fuse_direct_write(file, buf, count, ppos);
+       res = __fuse_direct_write(file, &iov, 1, ppos);
        mutex_unlock(&inode->i_mutex);
 
        return res;
@@ -1272,7 +1338,7 @@ static int fuse_writepage_locked(struct page *page)
 
        set_page_writeback(page);
 
-       req = fuse_request_alloc_nofs();
+       req = fuse_request_alloc_nofs(1);
        if (!req)
                goto err;
 
@@ -1293,7 +1359,8 @@ static int fuse_writepage_locked(struct page *page)
        req->in.argpages = 1;
        req->num_pages = 1;
        req->pages[0] = tmp_page;
-       req->page_offset = 0;
+       req->page_descs[0].offset = 0;
+       req->page_descs[0].length = PAGE_SIZE;
        req->end = fuse_writepage_end;
        req->inode = inode;
 
@@ -1471,7 +1538,7 @@ static int fuse_getlk(struct file *file, struct file_lock *fl)
        struct fuse_lk_out outarg;
        int err;
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req))
                return PTR_ERR(req);
 
@@ -1506,7 +1573,7 @@ static int fuse_setlk(struct file *file, struct file_lock *fl, int flock)
        if (fl->fl_flags & FL_CLOSE)
                return 0;
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req))
                return PTR_ERR(req);
 
@@ -1575,7 +1642,7 @@ static sector_t fuse_bmap(struct address_space *mapping, sector_t block)
        if (!inode->i_sb->s_bdev || fc->no_bmap)
                return 0;
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req))
                return 0;
 
@@ -1873,7 +1940,7 @@ long fuse_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg,
                num_pages++;
        }
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req(fc, num_pages);
        if (IS_ERR(req)) {
                err = PTR_ERR(req);
                req = NULL;
@@ -1881,6 +1948,7 @@ long fuse_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg,
        }
        memcpy(req->pages, pages, sizeof(req->pages[0]) * num_pages);
        req->num_pages = num_pages;
+       fuse_page_descs_length_init(req);
 
        /* okay, let's send it to the client */
        req->in.h.opcode = FUSE_IOCTL;
@@ -2076,7 +2144,7 @@ unsigned fuse_file_poll(struct file *file, poll_table *wait)
                fuse_register_polled_file(fc, ff);
        }
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req))
                return POLLERR;
 
@@ -2126,41 +2194,6 @@ int fuse_notify_poll_wakeup(struct fuse_conn *fc,
        return 0;
 }
 
-static ssize_t fuse_loop_dio(struct file *filp, const struct iovec *iov,
-                            unsigned long nr_segs, loff_t *ppos, int rw)
-{
-       const struct iovec *vector = iov;
-       ssize_t ret = 0;
-
-       while (nr_segs > 0) {
-               void __user *base;
-               size_t len;
-               ssize_t nr;
-
-               base = vector->iov_base;
-               len = vector->iov_len;
-               vector++;
-               nr_segs--;
-
-               if (rw == WRITE)
-                       nr = __fuse_direct_write(filp, base, len, ppos);
-               else
-                       nr = fuse_direct_read(filp, base, len, ppos);
-
-               if (nr < 0) {
-                       if (!ret)
-                               ret = nr;
-                       break;
-               }
-               ret += nr;
-               if (nr != len)
-                       break;
-       }
-
-       return ret;
-}
-
-
 static ssize_t
 fuse_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov,
                        loff_t offset, unsigned long nr_segs)
@@ -2172,13 +2205,16 @@ fuse_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov,
        file = iocb->ki_filp;
        pos = offset;
 
-       ret = fuse_loop_dio(file, iov, nr_segs, &pos, rw);
+       if (rw == WRITE)
+               ret = __fuse_direct_write(file, iov, nr_segs, &pos);
+       else
+               ret = __fuse_direct_read(file, iov, nr_segs, &pos);
 
        return ret;
 }
 
-long fuse_file_fallocate(struct file *file, int mode, loff_t offset,
-                           loff_t length)
+static long fuse_file_fallocate(struct file *file, int mode, loff_t offset,
+                               loff_t length)
 {
        struct fuse_file *ff = file->private_data;
        struct fuse_conn *fc = ff->fc;
@@ -2194,7 +2230,7 @@ long fuse_file_fallocate(struct file *file, int mode, loff_t offset,
        if (fc->no_fallocate)
                return -EOPNOTSUPP;
 
-       req = fuse_get_req(fc);
+       req = fuse_get_req_nopages(fc);
        if (IS_ERR(req))
                return PTR_ERR(req);
 
@@ -2213,7 +2249,6 @@ long fuse_file_fallocate(struct file *file, int mode, loff_t offset,
 
        return err;
 }
-EXPORT_SYMBOL_GPL(fuse_file_fallocate);
 
 static const struct file_operations fuse_file_operations = {
        .llseek         = fuse_file_llseek,