/*
- * Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
+ * Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc.
* Copyright (c) 2013 Simon Horman
*
* Licensed under the Apache License, Version 2.0 (the "License");
#include <config.h>
#include "odp-execute.h"
#include <arpa/inet.h>
+#include <netinet/in.h>
+#include <netinet/icmp6.h>
#include <netinet/ip6.h>
#include <stdlib.h>
#include <string.h>
+#include "dp-packet.h"
#include "dpif.h"
#include "netlink.h"
-#include "ofpbuf.h"
#include "odp-netlink.h"
#include "odp-util.h"
-#include "packet-dpif.h"
#include "packets.h"
#include "flow.h"
#include "unaligned.h"
/* Masked copy of an ethernet address. 'src' is already properly masked. */
static void
-ether_addr_copy_masked(uint8_t *dst, const uint8_t *src,
- const uint8_t *mask)
+ether_addr_copy_masked(struct eth_addr *dst, const struct eth_addr src,
+ const struct eth_addr mask)
{
int i;
- for (i = 0; i < ETH_ADDR_LEN; i++) {
- dst[i] = src[i] | (dst[i] & ~mask[i]);
+ for (i = 0; i < ARRAY_SIZE(dst->be16); i++) {
+ dst->be16[i] = src.be16[i] | (dst->be16[i] & ~mask.be16[i]);
}
}
static void
-odp_eth_set_addrs(struct ofpbuf *packet, const struct ovs_key_ethernet *key,
+odp_eth_set_addrs(struct dp_packet *packet, const struct ovs_key_ethernet *key,
const struct ovs_key_ethernet *mask)
{
- struct eth_header *eh = ofpbuf_l2(packet);
+ struct eth_header *eh = dp_packet_l2(packet);
if (eh) {
if (!mask) {
- memcpy(eh->eth_src, key->eth_src, sizeof eh->eth_src);
- memcpy(eh->eth_dst, key->eth_dst, sizeof eh->eth_dst);
+ eh->eth_src = key->eth_src;
+ eh->eth_dst = key->eth_dst;
} else {
- ether_addr_copy_masked(eh->eth_src, key->eth_src, mask->eth_src);
- ether_addr_copy_masked(eh->eth_dst, key->eth_dst, mask->eth_dst);
+ ether_addr_copy_masked(&eh->eth_src, key->eth_src, mask->eth_src);
+ ether_addr_copy_masked(&eh->eth_dst, key->eth_dst, mask->eth_dst);
}
}
}
static void
-odp_set_ipv4(struct ofpbuf *packet, const struct ovs_key_ipv4 *key,
+odp_set_ipv4(struct dp_packet *packet, const struct ovs_key_ipv4 *key,
const struct ovs_key_ipv4 *mask)
{
- struct ip_header *nh = ofpbuf_l3(packet);
+ struct ip_header *nh = dp_packet_l3(packet);
packet_set_ipv4(
packet,
}
static void
-odp_set_ipv6(struct ofpbuf *packet, const struct ovs_key_ipv6 *key,
+odp_set_ipv6(struct dp_packet *packet, const struct ovs_key_ipv6 *key,
const struct ovs_key_ipv6 *mask)
{
- struct ovs_16aligned_ip6_hdr *nh = ofpbuf_l3(packet);
+ struct ovs_16aligned_ip6_hdr *nh = dp_packet_l3(packet);
ovs_be32 sbuf[4], dbuf[4];
uint8_t old_tc = ntohl(get_16aligned_be32(&nh->ip6_flow)) >> 20;
ovs_be32 old_fl = get_16aligned_be32(&nh->ip6_flow) & htonl(0xfffff);
}
static void
-odp_set_tcp(struct ofpbuf *packet, const struct ovs_key_tcp *key,
+odp_set_tcp(struct dp_packet *packet, const struct ovs_key_tcp *key,
const struct ovs_key_tcp *mask)
{
- struct tcp_header *th = ofpbuf_l4(packet);
+ struct tcp_header *th = dp_packet_l4(packet);
- packet_set_tcp_port(packet,
- key->tcp_src | (th->tcp_src & ~mask->tcp_src),
- key->tcp_dst | (th->tcp_dst & ~mask->tcp_dst));
+ if (OVS_LIKELY(th && dp_packet_get_tcp_payload(packet))) {
+ packet_set_tcp_port(packet,
+ key->tcp_src | (th->tcp_src & ~mask->tcp_src),
+ key->tcp_dst | (th->tcp_dst & ~mask->tcp_dst));
+ }
}
static void
-odp_set_udp(struct ofpbuf *packet, const struct ovs_key_udp *key,
+odp_set_udp(struct dp_packet *packet, const struct ovs_key_udp *key,
const struct ovs_key_udp *mask)
{
- struct udp_header *uh = ofpbuf_l4(packet);
+ struct udp_header *uh = dp_packet_l4(packet);
- packet_set_udp_port(packet,
- key->udp_src | (uh->udp_src & ~mask->udp_src),
- key->udp_dst | (uh->udp_dst & ~mask->udp_dst));
+ if (OVS_LIKELY(uh && dp_packet_get_udp_payload(packet))) {
+ packet_set_udp_port(packet,
+ key->udp_src | (uh->udp_src & ~mask->udp_src),
+ key->udp_dst | (uh->udp_dst & ~mask->udp_dst));
+ }
}
static void
-odp_set_sctp(struct ofpbuf *packet, const struct ovs_key_sctp *key,
+odp_set_sctp(struct dp_packet *packet, const struct ovs_key_sctp *key,
const struct ovs_key_sctp *mask)
{
- struct sctp_header *sh = ofpbuf_l4(packet);
+ struct sctp_header *sh = dp_packet_l4(packet);
- packet_set_sctp_port(packet,
- key->sctp_src | (sh->sctp_src & ~mask->sctp_src),
- key->sctp_dst | (sh->sctp_dst & ~mask->sctp_dst));
+ if (OVS_LIKELY(sh && dp_packet_get_sctp_payload(packet))) {
+ packet_set_sctp_port(packet,
+ key->sctp_src | (sh->sctp_src & ~mask->sctp_src),
+ key->sctp_dst | (sh->sctp_dst & ~mask->sctp_dst));
+ }
}
static void
{
enum odp_key_fitness fitness;
- fitness = odp_tun_key_from_attr(a, tun_key);
+ fitness = odp_tun_key_from_attr(a, true, tun_key);
ovs_assert(fitness != ODP_FIT_ERROR);
}
static void
-set_arp(struct ofpbuf *packet, const struct ovs_key_arp *key,
+set_arp(struct dp_packet *packet, const struct ovs_key_arp *key,
const struct ovs_key_arp *mask)
{
- struct arp_eth_header *arp = ofpbuf_l3(packet);
+ struct arp_eth_header *arp = dp_packet_l3(packet);
if (!mask) {
arp->ar_op = key->arp_op;
- memcpy(arp->ar_sha, key->arp_sha, ETH_ADDR_LEN);
+ arp->ar_sha = key->arp_sha;
put_16aligned_be32(&arp->ar_spa, key->arp_sip);
- memcpy(arp->ar_tha, key->arp_tha, ETH_ADDR_LEN);
+ arp->ar_tha = key->arp_tha;
put_16aligned_be32(&arp->ar_tpa, key->arp_tip);
} else {
ovs_be32 ar_spa = get_16aligned_be32(&arp->ar_spa);
ovs_be32 ar_tpa = get_16aligned_be32(&arp->ar_tpa);
arp->ar_op = key->arp_op | (arp->ar_op & ~mask->arp_op);
- ether_addr_copy_masked(arp->ar_sha, key->arp_sha, mask->arp_sha);
+ ether_addr_copy_masked(&arp->ar_sha, key->arp_sha, mask->arp_sha);
put_16aligned_be32(&arp->ar_spa,
key->arp_sip | (ar_spa & ~mask->arp_sip));
- ether_addr_copy_masked(arp->ar_tha, key->arp_tha, mask->arp_tha);
+ ether_addr_copy_masked(&arp->ar_tha, key->arp_tha, mask->arp_tha);
put_16aligned_be32(&arp->ar_tpa,
key->arp_tip | (ar_tpa & ~mask->arp_tip));
}
}
static void
-odp_execute_set_action(struct dpif_packet *packet, const struct nlattr *a,
- struct pkt_metadata *md)
+odp_set_nd(struct dp_packet *packet, const struct ovs_key_nd *key,
+ const struct ovs_key_nd *mask)
+{
+ const struct ovs_nd_msg *ns = dp_packet_l4(packet);
+ const struct ovs_nd_opt *nd_opt = dp_packet_get_nd_payload(packet);
+
+ if (OVS_LIKELY(ns && nd_opt)) {
+ int bytes_remain = dp_packet_l4_size(packet) - sizeof(*ns);
+ ovs_be32 tgt_buf[4];
+ struct eth_addr sll_buf = eth_addr_zero;
+ struct eth_addr tll_buf = eth_addr_zero;
+
+ while (bytes_remain >= ND_OPT_LEN && nd_opt->nd_opt_len != 0) {
+ if (nd_opt->nd_opt_type == ND_OPT_SOURCE_LINKADDR
+ && nd_opt->nd_opt_len == 1) {
+ sll_buf = nd_opt->nd_opt_mac;
+ ether_addr_copy_masked(&sll_buf, key->nd_sll, mask->nd_sll);
+
+ /* A packet can only contain one SLL or TLL option */
+ break;
+ } else if (nd_opt->nd_opt_type == ND_OPT_TARGET_LINKADDR
+ && nd_opt->nd_opt_len == 1) {
+ tll_buf = nd_opt->nd_opt_mac;
+ ether_addr_copy_masked(&tll_buf, key->nd_tll, mask->nd_tll);
+
+ /* A packet can only contain one SLL or TLL option */
+ break;
+ }
+
+ nd_opt += nd_opt->nd_opt_len;
+ bytes_remain -= nd_opt->nd_opt_len * ND_OPT_LEN;
+ }
+
+ packet_set_nd(packet,
+ mask_ipv6_addr(ns->target.be32,
+ key->nd_target, mask->nd_target, tgt_buf),
+ sll_buf,
+ tll_buf);
+ }
+}
+
+static void
+odp_execute_set_action(struct dp_packet *packet, const struct nlattr *a)
{
enum ovs_key_attr type = nl_attr_type(a);
const struct ovs_key_ipv4 *ipv4_key;
const struct ovs_key_ipv6 *ipv6_key;
- const struct ovs_key_tcp *tcp_key;
- const struct ovs_key_udp *udp_key;
- const struct ovs_key_sctp *sctp_key;
+ struct pkt_metadata *md = &packet->md;
switch (type) {
case OVS_KEY_ATTR_PRIORITY:
break;
case OVS_KEY_ATTR_ETHERNET:
- odp_eth_set_addrs(&packet->ofpbuf, nl_attr_get(a), NULL);
+ odp_eth_set_addrs(packet, nl_attr_get(a), NULL);
break;
case OVS_KEY_ATTR_IPV4:
ipv4_key = nl_attr_get_unspec(a, sizeof(struct ovs_key_ipv4));
- packet_set_ipv4(&packet->ofpbuf, ipv4_key->ipv4_src,
+ packet_set_ipv4(packet, ipv4_key->ipv4_src,
ipv4_key->ipv4_dst, ipv4_key->ipv4_tos,
ipv4_key->ipv4_ttl);
break;
case OVS_KEY_ATTR_IPV6:
ipv6_key = nl_attr_get_unspec(a, sizeof(struct ovs_key_ipv6));
- packet_set_ipv6(&packet->ofpbuf, ipv6_key->ipv6_proto,
+ packet_set_ipv6(packet, ipv6_key->ipv6_proto,
ipv6_key->ipv6_src, ipv6_key->ipv6_dst,
ipv6_key->ipv6_tclass, ipv6_key->ipv6_label,
ipv6_key->ipv6_hlimit);
break;
case OVS_KEY_ATTR_TCP:
- tcp_key = nl_attr_get_unspec(a, sizeof(struct ovs_key_tcp));
- packet_set_tcp_port(&packet->ofpbuf, tcp_key->tcp_src,
- tcp_key->tcp_dst);
+ if (OVS_LIKELY(dp_packet_get_tcp_payload(packet))) {
+ const struct ovs_key_tcp *tcp_key
+ = nl_attr_get_unspec(a, sizeof(struct ovs_key_tcp));
+
+ packet_set_tcp_port(packet, tcp_key->tcp_src,
+ tcp_key->tcp_dst);
+ }
break;
case OVS_KEY_ATTR_UDP:
- udp_key = nl_attr_get_unspec(a, sizeof(struct ovs_key_udp));
- packet_set_udp_port(&packet->ofpbuf, udp_key->udp_src,
- udp_key->udp_dst);
+ if (OVS_LIKELY(dp_packet_get_udp_payload(packet))) {
+ const struct ovs_key_udp *udp_key
+ = nl_attr_get_unspec(a, sizeof(struct ovs_key_udp));
+
+ packet_set_udp_port(packet, udp_key->udp_src,
+ udp_key->udp_dst);
+ }
break;
case OVS_KEY_ATTR_SCTP:
- sctp_key = nl_attr_get_unspec(a, sizeof(struct ovs_key_sctp));
- packet_set_sctp_port(&packet->ofpbuf, sctp_key->sctp_src,
- sctp_key->sctp_dst);
+ if (OVS_LIKELY(dp_packet_get_sctp_payload(packet))) {
+ const struct ovs_key_sctp *sctp_key
+ = nl_attr_get_unspec(a, sizeof(struct ovs_key_sctp));
+
+ packet_set_sctp_port(packet, sctp_key->sctp_src,
+ sctp_key->sctp_dst);
+ }
break;
case OVS_KEY_ATTR_MPLS:
- set_mpls_lse(&packet->ofpbuf, nl_attr_get_be32(a));
+ set_mpls_lse(packet, nl_attr_get_be32(a));
break;
case OVS_KEY_ATTR_ARP:
- set_arp(&packet->ofpbuf, nl_attr_get(a), NULL);
+ set_arp(packet, nl_attr_get(a), NULL);
+ break;
+
+ case OVS_KEY_ATTR_ICMP:
+ case OVS_KEY_ATTR_ICMPV6:
+ if (OVS_LIKELY(dp_packet_get_icmp_payload(packet))) {
+ const struct ovs_key_icmp *icmp_key
+ = nl_attr_get_unspec(a, sizeof(struct ovs_key_icmp));
+
+ packet_set_icmp(packet, icmp_key->icmp_type, icmp_key->icmp_code);
+ }
+ break;
+
+ case OVS_KEY_ATTR_ND:
+ if (OVS_LIKELY(dp_packet_get_nd_payload(packet))) {
+ const struct ovs_key_nd *nd_key
+ = nl_attr_get_unspec(a, sizeof(struct ovs_key_nd));
+ packet_set_nd(packet, nd_key->nd_target, nd_key->nd_sll,
+ nd_key->nd_tll);
+ }
break;
case OVS_KEY_ATTR_DP_HASH:
md->dp_hash = nl_attr_get_u32(a);
- dpif_packet_set_dp_hash(packet, md->dp_hash);
break;
case OVS_KEY_ATTR_RECIRC_ID:
case OVS_KEY_ATTR_ETHERTYPE:
case OVS_KEY_ATTR_IN_PORT:
case OVS_KEY_ATTR_VLAN:
- case OVS_KEY_ATTR_ICMP:
- case OVS_KEY_ATTR_ICMPV6:
- case OVS_KEY_ATTR_ND:
case OVS_KEY_ATTR_TCP_FLAGS:
+ case OVS_KEY_ATTR_CT_STATE:
+ case OVS_KEY_ATTR_CT_ZONE:
+ case OVS_KEY_ATTR_CT_MARK:
+ case OVS_KEY_ATTR_CT_LABELS:
case __OVS_KEY_ATTR_MAX:
default:
OVS_NOT_REACHED();
#define get_mask(a, type) ((const type *)(const void *)(a + 1) + 1)
static void
-odp_execute_masked_set_action(struct dpif_packet *packet,
- const struct nlattr *a, struct pkt_metadata *md)
+odp_execute_masked_set_action(struct dp_packet *packet,
+ const struct nlattr *a)
{
+ struct pkt_metadata *md = &packet->md;
enum ovs_key_attr type = nl_attr_type(a);
struct mpls_hdr *mh;
break;
case OVS_KEY_ATTR_ETHERNET:
- odp_eth_set_addrs(&packet->ofpbuf, nl_attr_get(a),
+ odp_eth_set_addrs(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_ethernet));
break;
case OVS_KEY_ATTR_IPV4:
- odp_set_ipv4(&packet->ofpbuf, nl_attr_get(a),
+ odp_set_ipv4(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_ipv4));
break;
case OVS_KEY_ATTR_IPV6:
- odp_set_ipv6(&packet->ofpbuf, nl_attr_get(a),
+ odp_set_ipv6(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_ipv6));
break;
case OVS_KEY_ATTR_TCP:
- odp_set_tcp(&packet->ofpbuf, nl_attr_get(a),
+ odp_set_tcp(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_tcp));
break;
case OVS_KEY_ATTR_UDP:
- odp_set_udp(&packet->ofpbuf, nl_attr_get(a),
+ odp_set_udp(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_udp));
break;
case OVS_KEY_ATTR_SCTP:
- odp_set_sctp(&packet->ofpbuf, nl_attr_get(a),
+ odp_set_sctp(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_sctp));
break;
case OVS_KEY_ATTR_MPLS:
- mh = ofpbuf_l2_5(&packet->ofpbuf);
+ mh = dp_packet_l2_5(packet);
if (mh) {
put_16aligned_be32(&mh->mpls_lse, nl_attr_get_be32(a)
| (get_16aligned_be32(&mh->mpls_lse)
break;
case OVS_KEY_ATTR_ARP:
- set_arp(&packet->ofpbuf, nl_attr_get(a),
+ set_arp(packet, nl_attr_get(a),
get_mask(a, struct ovs_key_arp));
break;
+ case OVS_KEY_ATTR_ND:
+ odp_set_nd(packet, nl_attr_get(a),
+ get_mask(a, struct ovs_key_nd));
+ break;
+
case OVS_KEY_ATTR_DP_HASH:
md->dp_hash = nl_attr_get_u32(a)
- | (dpif_packet_get_dp_hash(packet) & ~*get_mask(a, uint32_t));
- dpif_packet_set_dp_hash(packet, md->dp_hash);
+ | (md->dp_hash & ~*get_mask(a, uint32_t));
break;
case OVS_KEY_ATTR_RECIRC_ID:
case OVS_KEY_ATTR_TUNNEL: /* Masked data not supported for tunnel. */
case OVS_KEY_ATTR_UNSPEC:
+ case OVS_KEY_ATTR_CT_STATE:
+ case OVS_KEY_ATTR_CT_ZONE:
+ case OVS_KEY_ATTR_CT_MARK:
+ case OVS_KEY_ATTR_CT_LABELS:
case OVS_KEY_ATTR_ENCAP:
case OVS_KEY_ATTR_ETHERTYPE:
case OVS_KEY_ATTR_IN_PORT:
case OVS_KEY_ATTR_VLAN:
case OVS_KEY_ATTR_ICMP:
case OVS_KEY_ATTR_ICMPV6:
- case OVS_KEY_ATTR_ND:
case OVS_KEY_ATTR_TCP_FLAGS:
case __OVS_KEY_ATTR_MAX:
default:
}
static void
-odp_execute_actions__(void *dp, struct dpif_packet **packets, int cnt,
- bool steal, struct pkt_metadata *,
- const struct nlattr *actions, size_t actions_len,
- odp_execute_cb dp_execute_action, bool more_actions);
-
-static void
-odp_execute_sample(void *dp, struct dpif_packet *packet, bool steal,
- struct pkt_metadata *md, const struct nlattr *action,
- odp_execute_cb dp_execute_action, bool more_actions)
+odp_execute_sample(void *dp, struct dp_packet *packet, bool steal,
+ const struct nlattr *action,
+ odp_execute_cb dp_execute_action)
{
const struct nlattr *subactions = NULL;
const struct nlattr *a;
switch ((enum ovs_sample_attr) type) {
case OVS_SAMPLE_ATTR_PROBABILITY:
if (random_uint32() >= nl_attr_get_u32(a)) {
+ if (steal) {
+ dp_packet_delete(packet);
+ }
return;
}
break;
}
}
- odp_execute_actions__(dp, &packet, 1, steal, md, nl_attr_get(subactions),
- nl_attr_get_size(subactions), dp_execute_action,
- more_actions);
+ odp_execute_actions(dp, &packet, 1, steal, nl_attr_get(subactions),
+ nl_attr_get_size(subactions), dp_execute_action);
}
-static void
-odp_execute_actions__(void *dp, struct dpif_packet **packets, int cnt,
- bool steal, struct pkt_metadata *md,
- const struct nlattr *actions, size_t actions_len,
- odp_execute_cb dp_execute_action, bool more_actions)
+static bool
+requires_datapath_assistance(const struct nlattr *a)
+{
+ enum ovs_action_attr type = nl_attr_type(a);
+
+ switch (type) {
+ /* These only make sense in the context of a datapath. */
+ case OVS_ACTION_ATTR_OUTPUT:
+ case OVS_ACTION_ATTR_TUNNEL_PUSH:
+ case OVS_ACTION_ATTR_TUNNEL_POP:
+ case OVS_ACTION_ATTR_USERSPACE:
+ case OVS_ACTION_ATTR_RECIRC:
+ case OVS_ACTION_ATTR_CT:
+ return true;
+
+ case OVS_ACTION_ATTR_SET:
+ case OVS_ACTION_ATTR_SET_MASKED:
+ case OVS_ACTION_ATTR_PUSH_VLAN:
+ case OVS_ACTION_ATTR_POP_VLAN:
+ case OVS_ACTION_ATTR_SAMPLE:
+ case OVS_ACTION_ATTR_HASH:
+ case OVS_ACTION_ATTR_PUSH_MPLS:
+ case OVS_ACTION_ATTR_POP_MPLS:
+ return false;
+
+ case OVS_ACTION_ATTR_UNSPEC:
+ case __OVS_ACTION_ATTR_MAX:
+ OVS_NOT_REACHED();
+ }
+
+ return false;
+}
+
+void
+odp_execute_actions(void *dp, struct dp_packet **packets, int cnt, bool steal,
+ const struct nlattr *actions, size_t actions_len,
+ odp_execute_cb dp_execute_action)
{
const struct nlattr *a;
unsigned int left;
-
int i;
NL_ATTR_FOR_EACH_UNSAFE (a, left, actions, actions_len) {
int type = nl_attr_type(a);
+ bool last_action = (left <= NLA_ALIGN(a->nla_len));
- switch ((enum ovs_action_attr) type) {
- /* These only make sense in the context of a datapath. */
- case OVS_ACTION_ATTR_OUTPUT:
- case OVS_ACTION_ATTR_USERSPACE:
- case OVS_ACTION_ATTR_RECIRC:
+ if (requires_datapath_assistance(a)) {
if (dp_execute_action) {
/* Allow 'dp_execute_action' to steal the packet data if we do
* not need it any more. */
- bool may_steal = steal && (!more_actions
- && left <= NLA_ALIGN(a->nla_len)
- && type != OVS_ACTION_ATTR_RECIRC);
- dp_execute_action(dp, packets, cnt, md, a, may_steal);
+ bool may_steal = steal && last_action;
+
+ dp_execute_action(dp, packets, cnt, a, may_steal);
+
+ if (last_action) {
+ /* We do not need to free the packets. dp_execute_actions()
+ * has stolen them */
+ return;
+ }
}
- break;
+ continue;
+ }
+ switch ((enum ovs_action_attr) type) {
case OVS_ACTION_ATTR_HASH: {
const struct ovs_action_hash *hash_act = nl_attr_get(a);
uint32_t hash;
for (i = 0; i < cnt; i++) {
- struct ofpbuf *buf = &packets[i]->ofpbuf;
-
- flow_extract(buf, md, &flow);
+ flow_extract(packets[i], &flow);
hash = flow_hash_5tuple(&flow, hash_act->hash_basis);
- /* The hash of the first packet is in shared metadata */
- if (i == 0) {
- md->dp_hash = hash ? hash : 1;
- }
-
- /* We also store the hash value with each packet */
- dpif_packet_set_dp_hash(packets[i], hash ? hash : 1);
+ packets[i]->md.dp_hash = hash;
}
} else {
/* Assert on unknown hash algorithm. */
const struct ovs_action_push_vlan *vlan = nl_attr_get(a);
for (i = 0; i < cnt; i++) {
- struct ofpbuf *buf = &packets[i]->ofpbuf;
-
- eth_push_vlan(buf, htons(ETH_TYPE_VLAN), vlan->vlan_tci);
+ eth_push_vlan(packets[i], vlan->vlan_tpid, vlan->vlan_tci);
}
break;
}
case OVS_ACTION_ATTR_POP_VLAN:
for (i = 0; i < cnt; i++) {
- struct ofpbuf *buf = &packets[i]->ofpbuf;
-
- eth_pop_vlan(buf);
+ eth_pop_vlan(packets[i]);
}
break;
const struct ovs_action_push_mpls *mpls = nl_attr_get(a);
for (i = 0; i < cnt; i++) {
- struct ofpbuf *buf = &packets[i]->ofpbuf;
-
- push_mpls(buf, mpls->mpls_ethertype, mpls->mpls_lse);
+ push_mpls(packets[i], mpls->mpls_ethertype, mpls->mpls_lse);
}
break;
}
case OVS_ACTION_ATTR_POP_MPLS:
for (i = 0; i < cnt; i++) {
- struct ofpbuf *buf = &packets[i]->ofpbuf;
-
- pop_mpls(buf, nl_attr_get_be16(a));
+ pop_mpls(packets[i], nl_attr_get_be16(a));
}
break;
case OVS_ACTION_ATTR_SET:
for (i = 0; i < cnt; i++) {
- odp_execute_set_action(packets[i], nl_attr_get(a), md);
+ odp_execute_set_action(packets[i], nl_attr_get(a));
}
break;
case OVS_ACTION_ATTR_SET_MASKED:
for (i = 0; i < cnt; i++) {
- odp_execute_masked_set_action(packets[i], nl_attr_get(a), md);
+ odp_execute_masked_set_action(packets[i], nl_attr_get(a));
}
break;
case OVS_ACTION_ATTR_SAMPLE:
for (i = 0; i < cnt; i++) {
- odp_execute_sample(dp, packets[i], steal, md, a,
- dp_execute_action,
- more_actions ||
- left > NLA_ALIGN(a->nla_len));
+ odp_execute_sample(dp, packets[i], steal && last_action, a,
+ dp_execute_action);
+ }
+
+ if (last_action) {
+ /* We do not need to free the packets. odp_execute_sample() has
+ * stolen them*/
+ return;
}
break;
+ case OVS_ACTION_ATTR_OUTPUT:
+ case OVS_ACTION_ATTR_TUNNEL_PUSH:
+ case OVS_ACTION_ATTR_TUNNEL_POP:
+ case OVS_ACTION_ATTR_USERSPACE:
+ case OVS_ACTION_ATTR_RECIRC:
+ case OVS_ACTION_ATTR_CT:
case OVS_ACTION_ATTR_UNSPEC:
case __OVS_ACTION_ATTR_MAX:
OVS_NOT_REACHED();
}
}
-}
-
-void
-odp_execute_actions(void *dp, struct dpif_packet **packets, int cnt,
- bool steal, struct pkt_metadata *md,
- const struct nlattr *actions, size_t actions_len,
- odp_execute_cb dp_execute_action)
-{
- odp_execute_actions__(dp, packets, cnt, steal, md, actions, actions_len,
- dp_execute_action, false);
-
- if (!actions_len && steal) {
- /* Drop action. */
- int i;
+ if (steal) {
for (i = 0; i < cnt; i++) {
- dpif_packet_delete(packets[i]);
+ dp_packet_delete(packets[i]);
}
}
}