Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
[cascardo/linux.git] / net / irda / irlap_event.c
index ccd214f..0e1b4d7 100644 (file)
@@ -78,8 +78,7 @@ static int irlap_state_sclose (struct irlap_cb *self, IRLAP_EVENT event,
 static int irlap_state_reset_check(struct irlap_cb *, IRLAP_EVENT event,
                                   struct sk_buff *, struct irlap_info *);
 
-#ifdef CONFIG_IRDA_DEBUG
-static const char *const irlap_event[] = {
+static const char *const irlap_event[] __maybe_unused = {
        "DISCOVERY_REQUEST",
        "CONNECT_REQUEST",
        "CONNECT_RESPONSE",
@@ -119,7 +118,6 @@ static const char *const irlap_event[] = {
        "BACKOFF_TIMER_EXPIRED",
        "MEDIA_BUSY_TIMER_EXPIRED",
 };
-#endif /* CONFIG_IRDA_DEBUG */
 
 const char *const irlap_state[] = {
        "LAP_NDM",
@@ -218,7 +216,7 @@ static void irlap_start_poll_timer(struct irlap_cb *self, int timeout)
        } else
                self->fast_RR = FALSE;
 
-       IRDA_DEBUG(3, "%s(), timeout=%d (%ld)\n", __func__, timeout, jiffies);
+       pr_debug("%s(), timeout=%d (%ld)\n", __func__, timeout, jiffies);
 #endif /* CONFIG_IRDA_FAST_RR */
 
        if (timeout == 0)
@@ -242,8 +240,8 @@ void irlap_do_event(struct irlap_cb *self, IRLAP_EVENT event,
        if (!self || self->magic != LAP_MAGIC)
                return;
 
-       IRDA_DEBUG(3, "%s(), event = %s, state = %s\n", __func__,
-                  irlap_event[event], irlap_state[self->state]);
+       pr_debug("%s(), event = %s, state = %s\n", __func__,
+                irlap_event[event], irlap_state[self->state]);
 
        ret = (*state[self->state])(self, event, skb, info);
 
@@ -260,8 +258,8 @@ void irlap_do_event(struct irlap_cb *self, IRLAP_EVENT event,
                 * try to disconnect link if we send any data frames, since
                 * that will change the state away form XMIT
                 */
-               IRDA_DEBUG(2, "%s() : queue len = %d\n", __func__,
-                          skb_queue_len(&self->txq));
+               pr_debug("%s() : queue len = %d\n", __func__,
+                        skb_queue_len(&self->txq));
 
                if (!skb_queue_empty(&self->txq)) {
                        /* Prevent race conditions with irlap_data_request() */
@@ -340,8 +338,8 @@ static int irlap_state_ndm(struct irlap_cb *self, IRLAP_EVENT event,
                        /* Note : this will never happen, because we test
                         * media busy in irlap_connect_request() and
                         * postpone the event... - Jean II */
-                       IRDA_DEBUG(0, "%s(), CONNECT_REQUEST: media busy!\n",
-                                  __func__);
+                       pr_debug("%s(), CONNECT_REQUEST: media busy!\n",
+                                __func__);
 
                        /* Always switch state before calling upper layers */
                        irlap_next_state(self, LAP_NDM);
@@ -367,16 +365,16 @@ static int irlap_state_ndm(struct irlap_cb *self, IRLAP_EVENT event,
 
                        irlap_connect_indication(self, skb);
                } else {
-                       IRDA_DEBUG(0, "%s(), SNRM frame does not "
-                                  "contain an I field!\n", __func__);
+                       pr_debug("%s(), SNRM frame does not contain an I field!\n",
+                                __func__);
                }
                break;
        case DISCOVERY_REQUEST:
                IRDA_ASSERT(info != NULL, return -1;);
 
                if (self->media_busy) {
-                       IRDA_DEBUG(1, "%s(), DISCOVERY_REQUEST: media busy!\n",
-                                  __func__);
+                       pr_debug("%s(), DISCOVERY_REQUEST: media busy!\n",
+                                __func__);
                        /* irlap->log.condition = MEDIA_BUSY; */
 
                        /* This will make IrLMP try again */
@@ -442,7 +440,8 @@ static int irlap_state_ndm(struct irlap_cb *self, IRLAP_EVENT event,
                 * those cases...
                 * Jean II
                 */
-                       IRDA_DEBUG(1, "%s(), Receiving final discovery request, missed the discovery slots :-(\n", __func__);
+                       pr_debug("%s(), Receiving final discovery request, missed the discovery slots :-(\n",
+                                __func__);
 
                        /* Last discovery request -> in the log */
                        irlap_discovery_indication(self, info->discovery);
@@ -520,8 +519,8 @@ static int irlap_state_ndm(struct irlap_cb *self, IRLAP_EVENT event,
        case RECV_UI_FRAME:
                /* Only accept broadcast frames in NDM mode */
                if (info->caddr != CBROADCAST) {
-                       IRDA_DEBUG(0, "%s(), not a broadcast frame!\n",
-                                  __func__);
+                       pr_debug("%s(), not a broadcast frame!\n",
+                                __func__);
                } else
                        irlap_unitdata_indication(self, skb);
                break;
@@ -537,11 +536,11 @@ static int irlap_state_ndm(struct irlap_cb *self, IRLAP_EVENT event,
                irlap_send_test_frame(self, CBROADCAST, info->daddr, skb);
                break;
        case RECV_TEST_RSP:
-               IRDA_DEBUG(0, "%s() not implemented!\n", __func__);
+               pr_debug("%s() not implemented!\n", __func__);
                break;
        default:
-               IRDA_DEBUG(2, "%s(), Unknown event %s\n", __func__,
-                          irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n", __func__,
+                        irlap_event[event]);
 
                ret = -1;
                break;
@@ -568,13 +567,12 @@ static int irlap_state_query(struct irlap_cb *self, IRLAP_EVENT event,
                IRDA_ASSERT(info != NULL, return -1;);
                IRDA_ASSERT(info->discovery != NULL, return -1;);
 
-               IRDA_DEBUG(4, "%s(), daddr=%08x\n", __func__,
-                          info->discovery->data.daddr);
+               pr_debug("%s(), daddr=%08x\n", __func__,
+                        info->discovery->data.daddr);
 
                if (!self->discovery_log) {
-                       IRDA_WARNING("%s: discovery log is gone! "
-                                    "maybe the discovery timeout has been set"
-                                    " too short?\n", __func__);
+                       net_warn_ratelimited("%s: discovery log is gone! maybe the discovery timeout has been set too short?\n",
+                                            __func__);
                        break;
                }
                hashbin_insert(self->discovery_log,
@@ -599,7 +597,8 @@ static int irlap_state_query(struct irlap_cb *self, IRLAP_EVENT event,
 
                IRDA_ASSERT(info != NULL, return -1;);
 
-               IRDA_DEBUG(1, "%s(), Receiving discovery request (s = %d) while performing discovery :-(\n", __func__, info->s);
+               pr_debug("%s(), Receiving discovery request (s = %d) while performing discovery :-(\n",
+                        __func__, info->s);
 
                /* Last discovery request ? */
                if (info->s == 0xff)
@@ -613,8 +612,8 @@ static int irlap_state_query(struct irlap_cb *self, IRLAP_EVENT event,
                 * timing requirements.
                 */
                if (irda_device_is_receiving(self->netdev) && !self->add_wait) {
-                       IRDA_DEBUG(2, "%s(), device is slow to answer, "
-                                  "waiting some more!\n", __func__);
+                       pr_debug("%s(), device is slow to answer, waiting some more!\n",
+                                __func__);
                        irlap_start_slot_timer(self, msecs_to_jiffies(10));
                        self->add_wait = TRUE;
                        return ret;
@@ -650,8 +649,8 @@ static int irlap_state_query(struct irlap_cb *self, IRLAP_EVENT event,
                }
                break;
        default:
-               IRDA_DEBUG(2, "%s(), Unknown event %s\n", __func__,
-                          irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n", __func__,
+                        irlap_event[event]);
 
                ret = -1;
                break;
@@ -672,15 +671,13 @@ static int irlap_state_reply(struct irlap_cb *self, IRLAP_EVENT event,
        discovery_t *discovery_rsp;
        int ret=0;
 
-       IRDA_DEBUG(4, "%s()\n", __func__);
-
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
 
        switch (event) {
        case QUERY_TIMER_EXPIRED:
-               IRDA_DEBUG(0, "%s(), QUERY_TIMER_EXPIRED <%ld>\n",
-                          __func__, jiffies);
+               pr_debug("%s(), QUERY_TIMER_EXPIRED <%ld>\n",
+                        __func__, jiffies);
                irlap_next_state(self, LAP_NDM);
                break;
        case RECV_DISCOVERY_XID_CMD:
@@ -718,8 +715,8 @@ static int irlap_state_reply(struct irlap_cb *self, IRLAP_EVENT event,
                }
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %d, %s\n", __func__,
-                          event, irlap_event[event]);
+               pr_debug("%s(), Unknown event %d, %s\n", __func__,
+                        event, irlap_event[event]);
 
                ret = -1;
                break;
@@ -739,7 +736,7 @@ static int irlap_state_conn(struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(4, "%s(), event=%s\n", __func__, irlap_event[ event]);
+       pr_debug("%s(), event=%s\n", __func__, irlap_event[event]);
 
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
@@ -799,20 +796,20 @@ static int irlap_state_conn(struct irlap_cb *self, IRLAP_EVENT event,
 
                break;
        case RECV_DISCOVERY_XID_CMD:
-               IRDA_DEBUG(3, "%s(), event RECV_DISCOVER_XID_CMD!\n",
-                          __func__);
+               pr_debug("%s(), event RECV_DISCOVER_XID_CMD!\n",
+                        __func__);
                irlap_next_state(self, LAP_NDM);
 
                break;
        case DISCONNECT_REQUEST:
-               IRDA_DEBUG(0, "%s(), Disconnect request!\n", __func__);
+               pr_debug("%s(), Disconnect request!\n", __func__);
                irlap_send_dm_frame(self);
                irlap_next_state( self, LAP_NDM);
                irlap_disconnect_indication(self, LAP_DISC_INDICATION);
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %d, %s\n", __func__,
-                          event, irlap_event[event]);
+               pr_debug("%s(), Unknown event %d, %s\n", __func__,
+                        event, irlap_event[event]);
 
                ret = -1;
                break;
@@ -833,8 +830,6 @@ static int irlap_state_setup(struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(4, "%s()\n", __func__);
-
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
 
@@ -862,7 +857,7 @@ static int irlap_state_setup(struct irlap_cb *self, IRLAP_EVENT event,
                self->retry_count++;
                break;
        case RECV_SNRM_CMD:
-               IRDA_DEBUG(4, "%s(), SNRM battle!\n", __func__);
+               pr_debug("%s(), SNRM battle!\n", __func__);
 
                IRDA_ASSERT(skb != NULL, return 0;);
                IRDA_ASSERT(info != NULL, return 0;);
@@ -949,8 +944,8 @@ static int irlap_state_setup(struct irlap_cb *self, IRLAP_EVENT event,
                irlap_disconnect_indication(self, LAP_DISC_INDICATION);
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %d, %s\n", __func__,
-                          event, irlap_event[event]);
+               pr_debug("%s(), Unknown event %d, %s\n", __func__,
+                        event, irlap_event[event]);
 
                ret = -1;
                break;
@@ -967,7 +962,7 @@ static int irlap_state_setup(struct irlap_cb *self, IRLAP_EVENT event,
 static int irlap_state_offline(struct irlap_cb *self, IRLAP_EVENT event,
                               struct sk_buff *skb, struct irlap_info *info)
 {
-       IRDA_DEBUG( 0, "%s(), Unknown event\n", __func__);
+       pr_debug("%s(), Unknown event\n", __func__);
 
        return -1;
 }
@@ -1030,8 +1025,8 @@ static int irlap_state_xmit_p(struct irlap_cb *self, IRLAP_EVENT event,
                         *  speed and turn-around-time.
                         */
                        if((!nextfit) && (skb->len > self->bytes_left)) {
-                               IRDA_DEBUG(0, "%s(), Not allowed to transmit"
-                                          " more bytes!\n", __func__);
+                               pr_debug("%s(), Not allowed to transmit more bytes!\n",
+                                        __func__);
                                /* Requeue the skb */
                                skb_queue_head(&self->txq, skb_get(skb));
                                /*
@@ -1082,8 +1077,8 @@ static int irlap_state_xmit_p(struct irlap_cb *self, IRLAP_EVENT event,
                        self->fast_RR = FALSE;
 #endif /* CONFIG_IRDA_FAST_RR */
                } else {
-                       IRDA_DEBUG(4, "%s(), Unable to send! remote busy?\n",
-                                  __func__);
+                       pr_debug("%s(), Unable to send! remote busy?\n",
+                                __func__);
                        skb_queue_head(&self->txq, skb_get(skb));
 
                        /*
@@ -1094,8 +1089,8 @@ static int irlap_state_xmit_p(struct irlap_cb *self, IRLAP_EVENT event,
                }
                break;
        case POLL_TIMER_EXPIRED:
-               IRDA_DEBUG(3, "%s(), POLL_TIMER_EXPIRED <%ld>\n",
-                           __func__, jiffies);
+               pr_debug("%s(), POLL_TIMER_EXPIRED <%ld>\n",
+                        __func__, jiffies);
                irlap_send_rr_frame(self, CMD_FRAME);
                /* Return to NRM properly - Jean II  */
                self->window = self->window_size;
@@ -1120,8 +1115,8 @@ static int irlap_state_xmit_p(struct irlap_cb *self, IRLAP_EVENT event,
                 * when we return... - Jean II */
                break;
        default:
-               IRDA_DEBUG(0, "%s(), Unknown event %s\n",
-                          __func__, irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n",
+                        __func__, irlap_event[event]);
 
                ret = -EINVAL;
                break;
@@ -1139,8 +1134,6 @@ static int irlap_state_pclose(struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(1, "%s()\n", __func__);
-
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
 
@@ -1174,7 +1167,7 @@ static int irlap_state_pclose(struct irlap_cb *self, IRLAP_EVENT event,
                }
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %d\n", __func__, event);
+               pr_debug("%s(), Unknown event %d\n", __func__, event);
 
                ret = -1;
                break;
@@ -1296,9 +1289,8 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                                /* Keep state */
                                irlap_next_state(self, LAP_NRM_P);
                        } else {
-                               IRDA_DEBUG(4,
-                                      "%s(), missing or duplicate frame!\n",
-                                          __func__);
+                               pr_debug("%s(), missing or duplicate frame!\n",
+                                        __func__);
 
                                /* Update Nr received */
                                irlap_update_nr_received(self, info->nr);
@@ -1367,8 +1359,8 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                if ((ns_status == NS_UNEXPECTED) &&
                    (nr_status == NR_UNEXPECTED))
                {
-                       IRDA_DEBUG(4, "%s(), unexpected nr and ns!\n",
-                                  __func__);
+                       pr_debug("%s(), unexpected nr and ns!\n",
+                                __func__);
                        if (info->pf) {
                                /* Resend rejected frames */
                                irlap_resend_rejected_frames(self, CMD_FRAME);
@@ -1408,9 +1400,9 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                        }
                        break;
                }
-               IRDA_DEBUG(1, "%s(), Not implemented!\n", __func__);
-               IRDA_DEBUG(1, "%s(), event=%s, ns_status=%d, nr_status=%d\n",
-                      __func__, irlap_event[event], ns_status, nr_status);
+               pr_debug("%s(), Not implemented!\n", __func__);
+               pr_debug("%s(), event=%s, ns_status=%d, nr_status=%d\n",
+                        __func__, irlap_event[event], ns_status, nr_status);
                break;
        case RECV_UI_FRAME:
                /* Poll bit cleared? */
@@ -1421,7 +1413,8 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                        del_timer(&self->final_timer);
                        irlap_data_indication(self, skb, TRUE);
                        irlap_next_state(self, LAP_XMIT_P);
-                       IRDA_DEBUG(1, "%s: RECV_UI_FRAME: next state %s\n", __func__, irlap_state[self->state]);
+                       pr_debug("%s: RECV_UI_FRAME: next state %s\n",
+                                __func__, irlap_state[self->state]);
                        irlap_start_poll_timer(self, self->poll_timeout);
                }
                break;
@@ -1464,10 +1457,9 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                        /* Update Nr received */
                        irlap_update_nr_received(self, info->nr);
 
-                       IRDA_DEBUG(4, "RECV_RR_FRAME: Retrans:%d, nr=%d, va=%d, "
-                             "vs=%d, vr=%d\n",
-                             self->retry_count, info->nr, self->va,
-                             self->vs, self->vr);
+                       pr_debug("RECV_RR_FRAME: Retrans:%d, nr=%d, va=%d, vs=%d, vr=%d\n",
+                                self->retry_count, info->nr, self->va,
+                                self->vs, self->vr);
 
                        /* Resend rejected frames */
                        irlap_resend_rejected_frames(self, CMD_FRAME);
@@ -1475,8 +1467,8 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
 
                        irlap_next_state(self, LAP_NRM_P);
                } else if (ret == NR_INVALID) {
-                       IRDA_DEBUG(1, "%s(), Received RR with "
-                                  "invalid nr !\n", __func__);
+                       pr_debug("%s(), Received RR with invalid nr !\n",
+                                __func__);
 
                        irlap_next_state(self, LAP_RESET_WAIT);
 
@@ -1512,8 +1504,7 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                 *  we only do this once for each frame.
                 */
                if (irda_device_is_receiving(self->netdev) && !self->add_wait) {
-                       IRDA_DEBUG(1, "FINAL_TIMER_EXPIRED when receiving a "
-                             "frame! Waiting a little bit more!\n");
+                       pr_debug("FINAL_TIMER_EXPIRED when receiving a frame! Waiting a little bit more!\n");
                        irlap_start_final_timer(self, msecs_to_jiffies(300));
 
                        /*
@@ -1530,18 +1521,18 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                if (self->retry_count < self->N2) {
                        if (skb_peek(&self->wx_list) == NULL) {
                                /* Retry sending the pf bit to the secondary */
-                               IRDA_DEBUG(4, "nrm_p: resending rr");
+                               pr_debug("nrm_p: resending rr");
                                irlap_wait_min_turn_around(self, &self->qos_tx);
                                irlap_send_rr_frame(self, CMD_FRAME);
                        } else {
-                               IRDA_DEBUG(4, "nrm_p: resend frames");
+                               pr_debug("nrm_p: resend frames");
                                irlap_resend_rejected_frames(self, CMD_FRAME);
                        }
 
                        irlap_start_final_timer(self, self->final_timeout);
                        self->retry_count++;
-                       IRDA_DEBUG(4, "irlap_state_nrm_p: FINAL_TIMER_EXPIRED:"
-                                  " retry_count=%d\n", self->retry_count);
+                       pr_debug("irlap_state_nrm_p: FINAL_TIMER_EXPIRED: retry_count=%d\n",
+                                self->retry_count);
 
                        /* Early warning event. I'm using a pretty liberal
                         * interpretation of the spec and generate an event
@@ -1581,7 +1572,7 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                irlap_start_final_timer(self, 2 * self->final_timeout);
                break;
        case RECV_RD_RSP:
-               IRDA_DEBUG(1, "%s(), RECV_RD_RSP\n", __func__);
+               pr_debug("%s(), RECV_RD_RSP\n", __func__);
 
                irlap_flush_all_queues(self);
                irlap_next_state(self, LAP_XMIT_P);
@@ -1589,8 +1580,8 @@ static int irlap_state_nrm_p(struct irlap_cb *self, IRLAP_EVENT event,
                irlap_disconnect_request(self);
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %s\n",
-                           __func__, irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n",
+                        __func__, irlap_event[event]);
 
                ret = -1;
                break;
@@ -1610,7 +1601,7 @@ static int irlap_state_reset_wait(struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(3, "%s(), event = %s\n", __func__, irlap_event[event]);
+       pr_debug("%s(), event = %s\n", __func__, irlap_event[event]);
 
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
@@ -1636,8 +1627,8 @@ static int irlap_state_reset_wait(struct irlap_cb *self, IRLAP_EVENT event,
                irlap_next_state( self, LAP_PCLOSE);
                break;
        default:
-               IRDA_DEBUG(2, "%s(), Unknown event %s\n", __func__,
-                          irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n", __func__,
+                        irlap_event[event]);
 
                ret = -1;
                break;
@@ -1657,7 +1648,7 @@ static int irlap_state_reset(struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(3, "%s(), event = %s\n", __func__, irlap_event[event]);
+       pr_debug("%s(), event = %s\n", __func__, irlap_event[event]);
 
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
@@ -1715,7 +1706,7 @@ static int irlap_state_reset(struct irlap_cb *self, IRLAP_EVENT event,
                 * state
                 */
                if (!info) {
-                       IRDA_DEBUG(3, "%s(), RECV_SNRM_CMD\n", __func__);
+                       pr_debug("%s(), RECV_SNRM_CMD\n", __func__);
                        irlap_initiate_connection_state(self);
                        irlap_wait_min_turn_around(self, &self->qos_tx);
                        irlap_send_ua_response_frame(self, &self->qos_rx);
@@ -1723,14 +1714,13 @@ static int irlap_state_reset(struct irlap_cb *self, IRLAP_EVENT event,
                        irlap_start_wd_timer(self, self->wd_timeout);
                        irlap_next_state(self, LAP_NDM);
                } else {
-                       IRDA_DEBUG(0,
-                                  "%s(), SNRM frame contained an I field!\n",
-                                  __func__);
+                       pr_debug("%s(), SNRM frame contained an I field!\n",
+                                __func__);
                }
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %s\n",
-                          __func__, irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n",
+                        __func__, irlap_event[event]);
 
                ret = -1;
                break;
@@ -1750,7 +1740,7 @@ static int irlap_state_xmit_s(struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(4, "%s(), event=%s\n", __func__, irlap_event[event]);
+       pr_debug("%s(), event=%s\n", __func__, irlap_event[event]);
 
        IRDA_ASSERT(self != NULL, return -ENODEV;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -EBADR;);
@@ -1786,8 +1776,8 @@ static int irlap_state_xmit_s(struct irlap_cb *self, IRLAP_EVENT event,
                         *  speed and turn-around-time.
                         */
                        if((!nextfit) && (skb->len > self->bytes_left)) {
-                               IRDA_DEBUG(0, "%s(), Not allowed to transmit"
-                                          " more bytes!\n", __func__);
+                               pr_debug("%s(), Not allowed to transmit more bytes!\n",
+                                        __func__);
                                /* Requeue the skb */
                                skb_queue_head(&self->txq, skb_get(skb));
 
@@ -1833,7 +1823,7 @@ static int irlap_state_xmit_s(struct irlap_cb *self, IRLAP_EVENT event,
                                ret = -EPROTO;
                        }
                } else {
-                       IRDA_DEBUG(2, "%s(), Unable to send!\n", __func__);
+                       pr_debug("%s(), Unable to send!\n", __func__);
                        skb_queue_head(&self->txq, skb_get(skb));
                        ret = -EPROTO;
                }
@@ -1849,8 +1839,8 @@ static int irlap_state_xmit_s(struct irlap_cb *self, IRLAP_EVENT event,
                 * when we return... - Jean II */
                break;
        default:
-               IRDA_DEBUG(2, "%s(), Unknown event %s\n", __func__,
-                          irlap_event[event]);
+               pr_debug("%s(), Unknown event %s\n", __func__,
+                        irlap_event[event]);
 
                ret = -EINVAL;
                break;
@@ -1872,7 +1862,7 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
        int nr_status;
        int ret = 0;
 
-       IRDA_DEBUG(4, "%s(), event=%s\n", __func__, irlap_event[ event]);
+       pr_debug("%s(), event=%s\n", __func__, irlap_event[event]);
 
        IRDA_ASSERT(self != NULL, return -1;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -1;);
@@ -1880,10 +1870,9 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
        switch (event) {
        case RECV_I_CMD: /* Optimize for the common case */
                /* FIXME: must check for remote_busy below */
-               IRDA_DEBUG(4, "%s(), event=%s nr=%d, vs=%d, ns=%d, "
-                          "vr=%d, pf=%d\n", __func__,
-                          irlap_event[event], info->nr,
-                          self->vs, info->ns, self->vr, info->pf);
+               pr_debug("%s(), event=%s nr=%d, vs=%d, ns=%d, vr=%d, pf=%d\n",
+                        __func__, irlap_event[event], info->nr,
+                        self->vs, info->ns, self->vr, info->pf);
 
                self->retry_count = 0;
 
@@ -1983,7 +1972,7 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
                if ((ns_status == NS_EXPECTED) && (nr_status == NR_UNEXPECTED))
                {
                        if (info->pf) {
-                               IRDA_DEBUG(4, "RECV_I_RSP: frame(s) lost\n");
+                               pr_debug("RECV_I_RSP: frame(s) lost\n");
 
                                self->vr = (self->vr + 1) % 8;
 
@@ -2020,10 +2009,10 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
                }
 
                if (ret == NR_INVALID) {
-                       IRDA_DEBUG(0, "NRM_S, NR_INVALID not implemented!\n");
+                       pr_debug("NRM_S, NR_INVALID not implemented!\n");
                }
                if (ret == NS_INVALID) {
-                       IRDA_DEBUG(0, "NRM_S, NS_INVALID not implemented!\n");
+                       pr_debug("NRM_S, NS_INVALID not implemented!\n");
                }
                break;
        case RECV_UI_FRAME:
@@ -2112,22 +2101,21 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
                        /* Keep state */
                        irlap_next_state(self, LAP_NRM_S);
                } else {
-                       IRDA_DEBUG(1, "%s(), invalid nr not implemented!\n",
-                                  __func__);
+                       pr_debug("%s(), invalid nr not implemented!\n",
+                                __func__);
                }
                break;
        case RECV_SNRM_CMD:
                /* SNRM frame is not allowed to contain an I-field */
                if (!info) {
                        del_timer(&self->wd_timer);
-                       IRDA_DEBUG(1, "%s(), received SNRM cmd\n", __func__);
+                       pr_debug("%s(), received SNRM cmd\n", __func__);
                        irlap_next_state(self, LAP_RESET_CHECK);
 
                        irlap_reset_indication(self);
                } else {
-                       IRDA_DEBUG(0,
-                                  "%s(), SNRM frame contained an I-field!\n",
-                                  __func__);
+                       pr_debug("%s(), SNRM frame contained an I-field!\n",
+                                __func__);
 
                }
                break;
@@ -2159,8 +2147,8 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
                 *   which explain why we use (self->N2 / 2) here !!!
                 * Jean II
                 */
-               IRDA_DEBUG(1, "%s(), retry_count = %d\n", __func__,
-                          self->retry_count);
+               pr_debug("%s(), retry_count = %d\n", __func__,
+                        self->retry_count);
 
                if (self->retry_count < (self->N2 / 2)) {
                        /* No retry, just wait for primary */
@@ -2212,8 +2200,8 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
                irlap_send_test_frame(self, self->caddr, info->daddr, skb);
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %d, (%s)\n", __func__,
-                          event, irlap_event[event]);
+               pr_debug("%s(), Unknown event %d, (%s)\n", __func__,
+                        event, irlap_event[event]);
 
                ret = -EINVAL;
                break;
@@ -2227,8 +2215,6 @@ static int irlap_state_nrm_s(struct irlap_cb *self, IRLAP_EVENT event,
 static int irlap_state_sclose(struct irlap_cb *self, IRLAP_EVENT event,
                              struct sk_buff *skb, struct irlap_info *info)
 {
-       IRDA_DEBUG(1, "%s()\n", __func__);
-
        IRDA_ASSERT(self != NULL, return -ENODEV;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -EBADR;);
 
@@ -2284,8 +2270,8 @@ static int irlap_state_sclose(struct irlap_cb *self, IRLAP_EVENT event,
                        break;          /* stay in SCLOSE */
                }
 
-               IRDA_DEBUG(1, "%s(), Unknown event %d, (%s)\n", __func__,
-                          event, irlap_event[event]);
+               pr_debug("%s(), Unknown event %d, (%s)\n", __func__,
+                        event, irlap_event[event]);
 
                break;
        }
@@ -2299,7 +2285,7 @@ static int irlap_state_reset_check( struct irlap_cb *self, IRLAP_EVENT event,
 {
        int ret = 0;
 
-       IRDA_DEBUG(1, "%s(), event=%s\n", __func__, irlap_event[event]);
+       pr_debug("%s(), event=%s\n", __func__, irlap_event[event]);
 
        IRDA_ASSERT(self != NULL, return -ENODEV;);
        IRDA_ASSERT(self->magic == LAP_MAGIC, return -EBADR;);
@@ -2320,8 +2306,8 @@ static int irlap_state_reset_check( struct irlap_cb *self, IRLAP_EVENT event,
                irlap_next_state(self, LAP_SCLOSE);
                break;
        default:
-               IRDA_DEBUG(1, "%s(), Unknown event %d, (%s)\n", __func__,
-                          event, irlap_event[event]);
+               pr_debug("%s(), Unknown event %d, (%s)\n", __func__,
+                        event, irlap_event[event]);
 
                ret = -EINVAL;
                break;