compiler: Define NO_RETURN for MSVC.
[cascardo/ovs.git] / utilities / ovs-ofctl.c
index 3b78ca5..4a90155 100644 (file)
@@ -91,6 +91,10 @@ static int verbosity;
  * "snoop" command? */
 static bool timestamp;
 
+/* --unixctl-path: Path to use for unixctl server, for "monitor" and "snoop"
+     commands. */
+static char *unixctl_path;
+
 /* --sort, --rsort: Sort order. */
 enum sort_order { SORT_ASC, SORT_DESC };
 struct sort_criterion {
@@ -102,7 +106,7 @@ static size_t n_criteria, allocated_criteria;
 
 static const struct command *get_all_commands(void);
 
-static void usage(void) NO_RETURN;
+NO_RETURN static void usage(void);
 static void parse_options(int argc, char *argv[]);
 
 static bool recv_flow_stats_reply(struct vconn *, ovs_be32 send_xid,
@@ -113,6 +117,7 @@ int
 main(int argc, char *argv[])
 {
     set_program_name(argv[0]);
+    service_start(&argc, &argv);
     parse_options(argc, argv);
     fatal_ignore_sigpipe();
     run_command(argc - optind, argv + optind, get_all_commands());
@@ -149,6 +154,7 @@ parse_options(int argc, char *argv[])
         OPT_TIMESTAMP,
         OPT_SORT,
         OPT_RSORT,
+        OPT_UNIXCTL,
         DAEMON_OPTION_ENUMS,
         OFP_VERSION_OPTION_ENUMS,
         VLOG_OPTION_ENUMS
@@ -163,6 +169,7 @@ parse_options(int argc, char *argv[])
         {"timestamp", no_argument, NULL, OPT_TIMESTAMP},
         {"sort", optional_argument, NULL, OPT_SORT},
         {"rsort", optional_argument, NULL, OPT_RSORT},
+        {"unixctl",     required_argument, NULL, OPT_UNIXCTL},
         {"help", no_argument, NULL, 'h'},
         DAEMON_LONG_OPTIONS,
         OFP_VERSION_LONG_OPTIONS,
@@ -253,6 +260,10 @@ parse_options(int argc, char *argv[])
             add_sort_criterion(SORT_DESC, optarg);
             break;
 
+        case OPT_UNIXCTL:
+            unixctl_path = optarg;
+            break;
+
         DAEMON_OPTION_HANDLERS
         OFP_VERSION_OPTION_HANDLERS
         VLOG_OPTION_HANDLERS
@@ -305,7 +316,7 @@ usage(void)
            "  get-frags SWITCH            print fragment handling behavior\n"
            "  set-frags SWITCH FRAG_MODE  set fragment handling behavior\n"
            "  dump-ports SWITCH [PORT]    print port statistics\n"
-           "  dump-ports-desc SWITCH      print port descriptions\n"
+           "  dump-ports-desc SWITCH [PORT]  print port descriptions\n"
            "  dump-flows SWITCH           print all flow entries\n"
            "  dump-flows SWITCH FLOW      print matching FLOWs\n"
            "  dump-aggregate SWITCH       print aggregate flow statistics\n"
@@ -361,6 +372,7 @@ usage(void)
            "  -t, --timeout=SECS          give up after SECS seconds\n"
            "  --sort[=field]              sort in ascending order\n"
            "  --rsort[=field]             sort in descending order\n"
+           "  --unixctl=SOCKET            set control socket name\n"
            "  -h, --help                  display this help message\n"
            "  -V, --version               display version information\n");
     exit(EXIT_SUCCESS);
@@ -648,7 +660,7 @@ ofctl_show(int argc OVS_UNUSED, char *argv[])
     ofpbuf_delete(reply);
 
     if (!has_ports) {
-        request = ofpraw_alloc(OFPRAW_OFPST_PORT_DESC_REQUEST, version, 0);
+        request = ofputil_encode_port_desc_stats_request(version, OFPP_ANY);
         dump_stats_transaction(vconn, request);
     }
     dump_trivial_transaction(vconn_name, OFPRAW_OFPT_GET_CONFIG_REQUEST);
@@ -761,8 +773,8 @@ fetch_port_by_stats(struct vconn *vconn,
     bool done = false;
     bool found = false;
 
-    request = ofpraw_alloc(OFPRAW_OFPST_PORT_DESC_REQUEST,
-                           vconn_get_version(vconn), 0);
+    request = ofputil_encode_port_desc_stats_request(vconn_get_version(vconn),
+                                                     port_no);
     send_xid = ((struct ofp_header *) ofpbuf_data(request))->xid;
 
     send_openflow_buffer(vconn, request);
@@ -1006,7 +1018,8 @@ static void
 ofctl_dump_flows(int argc, char *argv[])
 {
     if (!n_criteria) {
-        return ofctl_dump_flows__(argc, argv, false);
+        ofctl_dump_flows__(argc, argv, false);
+        return;
     } else {
         struct ofputil_flow_stats *fses;
         size_t n_fses, allocated_fses;
@@ -1065,7 +1078,7 @@ ofctl_dump_flows(int argc, char *argv[])
 static void
 ofctl_dump_aggregate(int argc, char *argv[])
 {
-    return ofctl_dump_flows__(argc, argv, true);
+    ofctl_dump_flows__(argc, argv, true);
 }
 
 static void
@@ -1437,7 +1450,7 @@ monitor_vconn(struct vconn *vconn, bool reply_to_echo_requests)
 
     daemon_save_fd(STDERR_FILENO);
     daemonize_start();
-    error = unixctl_server_create(NULL, &server);
+    error = unixctl_server_create(unixctl_path, &server);
     if (error) {
         ovs_fatal(error, "failed to create unixctl server");
     }
@@ -1479,6 +1492,7 @@ monitor_vconn(struct vconn *vconn, bool reply_to_echo_requests)
 
             ofptype_decode(&type, ofpbuf_data(b));
             ofp_print(stderr, ofpbuf_data(b), ofpbuf_size(b), verbosity + 2);
+            fflush(stderr);
 
             switch ((int) type) {
             case OFPTYPE_BARRIER_REPLY:
@@ -1552,6 +1566,7 @@ ofctl_monitor(int argc, char *argv[])
             msg = ofpbuf_new(0);
             ofputil_append_flow_monitor_request(&fmr, msg);
             dump_stats_transaction(vconn, msg);
+            fflush(stdout);
         } else {
             ovs_fatal(0, "%s: unsupported \"monitor\" argument", arg);
         }
@@ -1620,7 +1635,16 @@ ofctl_dump_ports(int argc, char *argv[])
 static void
 ofctl_dump_ports_desc(int argc OVS_UNUSED, char *argv[])
 {
-    dump_trivial_stats_transaction(argv[1], OFPRAW_OFPST_PORT_DESC_REQUEST);
+    struct ofpbuf *request;
+    struct vconn *vconn;
+    ofp_port_t port;
+
+    open_vconn(argv[1], &vconn);
+    port = argc > 2 ? str_to_port_no(argv[1], argv[2]) : OFPP_ANY;
+    request = ofputil_encode_port_desc_stats_request(vconn_get_version(vconn),
+                                                     port);
+    dump_stats_transaction(vconn, request);
+    vconn_close(vconn);
 }
 
 static void
@@ -1652,7 +1676,7 @@ ofctl_packet_out(int argc, char *argv[])
     enum ofputil_protocol usable_protocols; /* XXX: Use in proto selection */
 
     ofpbuf_init(&ofpacts, 64);
-    error = parse_ofpacts(argv[3], &ofpacts, &usable_protocols);
+    error = ofpacts_parse_actions(argv[3], &ofpacts, &usable_protocols);
     if (error) {
         ovs_fatal(0, "%s", error);
     }
@@ -2304,16 +2328,12 @@ fte_free(struct fte *fte)
 static void
 fte_free_all(struct classifier *cls)
 {
-    struct cls_cursor cursor;
-    struct fte *fte, *next;
+    struct fte *fte;
 
-    fat_rwlock_wrlock(&cls->rwlock);
-    cls_cursor_init(&cursor, cls, NULL);
-    CLS_CURSOR_FOR_EACH_SAFE (fte, next, rule, &cursor) {
+    CLS_FOR_EACH_SAFE (fte, rule, cls) {
         classifier_remove(cls, &fte->rule);
         fte_free(fte);
     }
-    fat_rwlock_unlock(&cls->rwlock);
     classifier_destroy(cls);
 }
 
@@ -2332,9 +2352,7 @@ fte_insert(struct classifier *cls, const struct match *match,
     cls_rule_init(&fte->rule, match, priority);
     fte->versions[index] = version;
 
-    fat_rwlock_wrlock(&cls->rwlock);
     old = fte_from_cls_rule(classifier_replace(cls, &fte->rule));
-    fat_rwlock_unlock(&cls->rwlock);
     if (old) {
         fte_version_free(old->versions[index]);
         fte->versions[!index] = old->versions[!index];
@@ -2518,6 +2536,7 @@ fte_make_flow_mod(const struct fte *fte, int index, uint16_t command,
         fm.ofpacts = NULL;
         fm.ofpacts_len = 0;
     }
+    fm.delete_reason = OFPRR_DELETE;
 
     ofm = ofputil_encode_flow_mod(&fm, protocol);
     list_push_back(packets, &ofm->list_node);
@@ -2528,7 +2547,6 @@ ofctl_replace_flows(int argc OVS_UNUSED, char *argv[])
 {
     enum { FILE_IDX = 0, SWITCH_IDX = 1 };
     enum ofputil_protocol usable_protocols, protocol;
-    struct cls_cursor cursor;
     struct classifier cls;
     struct list requests;
     struct vconn *vconn;
@@ -2545,9 +2563,7 @@ ofctl_replace_flows(int argc OVS_UNUSED, char *argv[])
     list_init(&requests);
 
     /* Delete flows that exist on the switch but not in the file. */
-    fat_rwlock_rdlock(&cls.rwlock);
-    cls_cursor_init(&cursor, &cls, NULL);
-    CLS_CURSOR_FOR_EACH (fte, rule, &cursor) {
+    CLS_FOR_EACH (fte, rule, &cls) {
         struct fte_version *file_ver = fte->versions[FILE_IDX];
         struct fte_version *sw_ver = fte->versions[SWITCH_IDX];
 
@@ -2559,8 +2575,7 @@ ofctl_replace_flows(int argc OVS_UNUSED, char *argv[])
 
     /* Add flows that exist in the file but not on the switch.
      * Update flows that exist in both places but differ. */
-    cls_cursor_init(&cursor, &cls, NULL);
-    CLS_CURSOR_FOR_EACH (fte, rule, &cursor) {
+    CLS_FOR_EACH (fte, rule, &cls) {
         struct fte_version *file_ver = fte->versions[FILE_IDX];
         struct fte_version *sw_ver = fte->versions[SWITCH_IDX];
 
@@ -2569,7 +2584,6 @@ ofctl_replace_flows(int argc OVS_UNUSED, char *argv[])
             fte_make_flow_mod(fte, FILE_IDX, OFPFC_ADD, protocol, &requests);
         }
     }
-    fat_rwlock_unlock(&cls.rwlock);
     transact_multiple_noreply(vconn, &requests);
     vconn_close(vconn);
 
@@ -2599,7 +2613,6 @@ static void
 ofctl_diff_flows(int argc OVS_UNUSED, char *argv[])
 {
     bool differences = false;
-    struct cls_cursor cursor;
     struct classifier cls;
     struct ds a_s, b_s;
     struct fte *fte;
@@ -2611,9 +2624,7 @@ ofctl_diff_flows(int argc OVS_UNUSED, char *argv[])
     ds_init(&a_s);
     ds_init(&b_s);
 
-    fat_rwlock_rdlock(&cls.rwlock);
-    cls_cursor_init(&cursor, &cls, NULL);
-    CLS_CURSOR_FOR_EACH (fte, rule, &cursor) {
+    CLS_FOR_EACH (fte, rule, &cls) {
         struct fte_version *a = fte->versions[0];
         struct fte_version *b = fte->versions[1];
 
@@ -2631,7 +2642,6 @@ ofctl_diff_flows(int argc OVS_UNUSED, char *argv[])
             }
         }
     }
-    fat_rwlock_unlock(&cls.rwlock);
 
     ds_destroy(&a_s);
     ds_destroy(&b_s);
@@ -2814,7 +2824,7 @@ ofctl_parse_flows(int argc OVS_UNUSED, char *argv[])
 }
 
 static void
-ofctl_parse_nxm__(bool oxm)
+ofctl_parse_nxm__(bool oxm, enum ofp_version version)
 {
     struct ds in;
 
@@ -2859,7 +2869,7 @@ ofctl_parse_nxm__(bool oxm)
             ofpbuf_uninit(&nx_match);
             ofpbuf_init(&nx_match, 0);
             if (oxm) {
-                match_len = oxm_put_match(&nx_match, &match);
+                match_len = oxm_put_match(&nx_match, &match, version);
                 out = oxm_match_to_string(&nx_match, match_len);
             } else {
                 match_len = nx_put_match(&nx_match, &match,
@@ -2885,16 +2895,22 @@ ofctl_parse_nxm__(bool oxm)
 static void
 ofctl_parse_nxm(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
 {
-    return ofctl_parse_nxm__(false);
+    ofctl_parse_nxm__(false, 0);
 }
 
-/* "parse-oxm": reads a series of OXM nx_match specifications as strings from
- * stdin, does some internal fussing with them, and then prints them back as
- * strings on stdout. */
+/* "parse-oxm VERSION": reads a series of OXM nx_match specifications as
+ * strings from stdin, does some internal fussing with them, and then prints
+ * them back as strings on stdout.  VERSION must specify an OpenFlow version,
+ * e.g. "OpenFlow12". */
 static void
-ofctl_parse_oxm(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
+ofctl_parse_oxm(int argc OVS_UNUSED, char *argv[])
 {
-    return ofctl_parse_nxm__(true);
+    enum ofp_version version = ofputil_version_from_string(argv[1]);
+    if (version < OFP12_VERSION) {
+        ovs_fatal(0, "%s: not a valid version for OXM", argv[1]);
+    }
+
+    ofctl_parse_nxm__(true, version);
 }
 
 static void
@@ -2920,42 +2936,71 @@ print_differences(const char *prefix,
     }
 }
 
-/* "parse-ofp10-actions": reads a series of OpenFlow 1.0 action specifications
- * as hex bytes from stdin, converts them to ofpacts, prints them as strings
- * on stdout, and then converts them back to hex bytes and prints any
- * differences from the input. */
 static void
-ofctl_parse_ofp10_actions(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
+ofctl_parse_actions__(const char *version_s, bool instructions)
 {
+    enum ofp_version version;
     struct ds in;
 
+    version = ofputil_version_from_string(version_s);
+    if (!version) {
+        ovs_fatal(0, "%s: not a valid OpenFlow version", version_s);
+    }
+
     ds_init(&in);
     while (!ds_get_preprocessed_line(&in, stdin, NULL)) {
-        struct ofpbuf of10_out;
-        struct ofpbuf of10_in;
+        struct ofpbuf of_out;
+        struct ofpbuf of_in;
         struct ofpbuf ofpacts;
+        const char *table_id;
+        char *actions;
         enum ofperr error;
         size_t size;
         struct ds s;
 
+        /* Parse table_id separated with the follow-up actions by ",", if
+         * any. */
+        actions = ds_cstr(&in);
+        table_id = NULL;
+        if (strstr(actions, ",")) {
+            table_id = strsep(&actions, ",");
+        }
+
         /* Parse hex bytes. */
-        ofpbuf_init(&of10_in, 0);
-        if (ofpbuf_put_hex(&of10_in, ds_cstr(&in), NULL)[0] != '\0') {
+        ofpbuf_init(&of_in, 0);
+        if (ofpbuf_put_hex(&of_in, actions, NULL)[0] != '\0') {
             ovs_fatal(0, "Trailing garbage in hex data");
         }
 
         /* Convert to ofpacts. */
         ofpbuf_init(&ofpacts, 0);
-        size = ofpbuf_size(&of10_in);
-        error = ofpacts_pull_openflow_actions(&of10_in, ofpbuf_size(&of10_in),
-                                              OFP10_VERSION, &ofpacts);
+        size = ofpbuf_size(&of_in);
+        error = (instructions
+                 ? ofpacts_pull_openflow_instructions
+                 : ofpacts_pull_openflow_actions)(
+                     &of_in, ofpbuf_size(&of_in), version, &ofpacts);
+        if (!error && instructions) {
+            /* Verify actions, enforce consistency. */
+            enum ofputil_protocol protocol;
+            struct flow flow;
+
+            memset(&flow, 0, sizeof flow);
+            protocol = ofputil_protocols_from_ofp_version(version);
+            error = ofpacts_check_consistency(ofpbuf_data(&ofpacts),
+                                              ofpbuf_size(&ofpacts),
+                                              &flow, OFPP_MAX,
+                                              table_id ? atoi(table_id) : 0,
+                                              255, protocol);
+        }
         if (error) {
-            printf("bad OF1.1 actions: %s\n\n", ofperr_get_name(error));
+            printf("bad %s %s: %s\n\n",
+                   version_s, instructions ? "instructions" : "actions",
+                   ofperr_get_name(error));
             ofpbuf_uninit(&ofpacts);
-            ofpbuf_uninit(&of10_in);
+            ofpbuf_uninit(&of_in);
             continue;
         }
-        ofpbuf_push_uninit(&of10_in, size);
+        ofpbuf_push_uninit(&of_in, size);
 
         /* Print cls_rule. */
         ds_init(&s);
@@ -2965,21 +3010,48 @@ ofctl_parse_ofp10_actions(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
         ds_destroy(&s);
 
         /* Convert back to ofp10 actions and print differences from input. */
-        ofpbuf_init(&of10_out, 0);
-        ofpacts_put_openflow_actions(ofpbuf_data(&ofpacts), ofpbuf_size(&ofpacts), &of10_out,
-                                     OFP10_VERSION);
+        ofpbuf_init(&of_out, 0);
+        if (instructions) {
+           ofpacts_put_openflow_instructions( ofpbuf_data(&ofpacts),
+                                              ofpbuf_size(&ofpacts),
+                                              &of_out, version);
+        } else {
+           ofpacts_put_openflow_actions( ofpbuf_data(&ofpacts),
+                                         ofpbuf_size(&ofpacts),
+                                         &of_out, version);
+        }
 
-        print_differences("", ofpbuf_data(&of10_in), ofpbuf_size(&of10_in),
-                          ofpbuf_data(&of10_out), ofpbuf_size(&of10_out));
+        print_differences("", ofpbuf_data(&of_in), ofpbuf_size(&of_in),
+                          ofpbuf_data(&of_out), ofpbuf_size(&of_out));
         putchar('\n');
 
         ofpbuf_uninit(&ofpacts);
-        ofpbuf_uninit(&of10_in);
-        ofpbuf_uninit(&of10_out);
+        ofpbuf_uninit(&of_in);
+        ofpbuf_uninit(&of_out);
     }
     ds_destroy(&in);
 }
 
+/* "parse-actions VERSION": reads a series of action specifications for the
+ * given OpenFlow VERSION as hex bytes from stdin, converts them to ofpacts,
+ * prints them as strings on stdout, and then converts them back to hex bytes
+ * and prints any differences from the input. */
+static void
+ofctl_parse_actions(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
+{
+    ofctl_parse_actions__(argv[1], false);
+}
+
+/* "parse-actions VERSION": reads a series of instruction specifications for
+ * the given OpenFlow VERSION as hex bytes from stdin, converts them to
+ * ofpacts, prints them as strings on stdout, and then converts them back to
+ * hex bytes and prints any differences from the input. */
+static void
+ofctl_parse_instructions(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
+{
+    ofctl_parse_actions__(argv[1], true);
+}
+
 /* "parse-ofp10-match": reads a series of ofp10_match specifications as hex
  * bytes from stdin, converts them to cls_rules, prints them as strings on
  * stdout, and then converts them back to hex bytes and prints any differences
@@ -3108,146 +3180,6 @@ ofctl_parse_ofp11_match(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
     ds_destroy(&in);
 }
 
-/* "parse-ofp11-actions": reads a series of OpenFlow 1.1 action specifications
- * as hex bytes from stdin, converts them to ofpacts, prints them as strings
- * on stdout, and then converts them back to hex bytes and prints any
- * differences from the input. */
-static void
-ofctl_parse_ofp11_actions(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
-{
-    struct ds in;
-
-    ds_init(&in);
-    while (!ds_get_preprocessed_line(&in, stdin, NULL)) {
-        struct ofpbuf of11_out;
-        struct ofpbuf of11_in;
-        struct ofpbuf ofpacts;
-        enum ofperr error;
-        size_t size;
-        struct ds s;
-
-        /* Parse hex bytes. */
-        ofpbuf_init(&of11_in, 0);
-        if (ofpbuf_put_hex(&of11_in, ds_cstr(&in), NULL)[0] != '\0') {
-            ovs_fatal(0, "Trailing garbage in hex data");
-        }
-
-        /* Convert to ofpacts. */
-        ofpbuf_init(&ofpacts, 0);
-        size = ofpbuf_size(&of11_in);
-        error = ofpacts_pull_openflow_actions(&of11_in, ofpbuf_size(&of11_in),
-                                              OFP11_VERSION, &ofpacts);
-        if (error) {
-            printf("bad OF1.1 actions: %s\n\n", ofperr_get_name(error));
-            ofpbuf_uninit(&ofpacts);
-            ofpbuf_uninit(&of11_in);
-            continue;
-        }
-        ofpbuf_push_uninit(&of11_in, size);
-
-        /* Print cls_rule. */
-        ds_init(&s);
-        ds_put_cstr(&s, "actions=");
-        ofpacts_format(ofpbuf_data(&ofpacts), ofpbuf_size(&ofpacts), &s);
-        puts(ds_cstr(&s));
-        ds_destroy(&s);
-
-        /* Convert back to ofp11 actions and print differences from input. */
-        ofpbuf_init(&of11_out, 0);
-        ofpacts_put_openflow_actions(ofpbuf_data(&ofpacts), ofpbuf_size(&ofpacts), &of11_out,
-                                     OFP11_VERSION);
-
-        print_differences("", ofpbuf_data(&of11_in), ofpbuf_size(&of11_in),
-                          ofpbuf_data(&of11_out), ofpbuf_size(&of11_out));
-        putchar('\n');
-
-        ofpbuf_uninit(&ofpacts);
-        ofpbuf_uninit(&of11_in);
-        ofpbuf_uninit(&of11_out);
-    }
-    ds_destroy(&in);
-}
-
-/* "parse-ofp11-instructions": reads a series of OpenFlow 1.1 instruction
- * specifications as hex bytes from stdin, converts them to ofpacts, prints
- * them as strings on stdout, and then converts them back to hex bytes and
- * prints any differences from the input. */
-static void
-ofctl_parse_ofp11_instructions(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
-{
-    struct ds in;
-
-    ds_init(&in);
-    while (!ds_get_preprocessed_line(&in, stdin, NULL)) {
-        struct ofpbuf of11_out;
-        struct ofpbuf of11_in;
-        struct ofpbuf ofpacts;
-        enum ofperr error;
-        size_t size;
-        struct ds s;
-        const char *table_id;
-        char *instructions;
-
-        /* Parse table_id separated with the follow-up instructions by ",", if
-         * any. */
-        instructions = ds_cstr(&in);
-        table_id = NULL;
-        if (strstr(instructions, ",")) {
-            table_id = strsep(&instructions, ",");
-        }
-
-        /* Parse hex bytes. */
-        ofpbuf_init(&of11_in, 0);
-        if (ofpbuf_put_hex(&of11_in, instructions, NULL)[0] != '\0') {
-            ovs_fatal(0, "Trailing garbage in hex data");
-        }
-
-        /* Convert to ofpacts. */
-        ofpbuf_init(&ofpacts, 0);
-        size = ofpbuf_size(&of11_in);
-        error = ofpacts_pull_openflow_instructions(&of11_in, ofpbuf_size(&of11_in),
-                                                   OFP11_VERSION, &ofpacts);
-        if (!error) {
-            /* Verify actions, enforce consistency. */
-            struct flow flow;
-            memset(&flow, 0, sizeof flow);
-            error = ofpacts_check_consistency(ofpbuf_data(&ofpacts), ofpbuf_size(&ofpacts),
-                                              &flow, OFPP_MAX,
-                                              table_id ? atoi(table_id) : 0,
-                                              255, OFPUTIL_P_OF11_STD);
-        }
-        if (error) {
-            printf("bad OF1.1 instructions: %s\n\n", ofperr_get_name(error));
-            ofpbuf_uninit(&ofpacts);
-            ofpbuf_uninit(&of11_in);
-            continue;
-        }
-        ofpbuf_push_uninit(&of11_in, size);
-
-        /* Print cls_rule. */
-        ds_init(&s);
-        ds_put_cstr(&s, "actions=");
-        ofpacts_format(ofpbuf_data(&ofpacts), ofpbuf_size(&ofpacts), &s);
-        puts(ds_cstr(&s));
-        ds_destroy(&s);
-
-        /* Convert back to ofp11 instructions and print differences from
-         * input. */
-        ofpbuf_init(&of11_out, 0);
-        ofpacts_put_openflow_instructions(ofpbuf_data(&ofpacts), ofpbuf_size(&ofpacts),
-                                          &of11_out, OFP13_VERSION);
-
-        print_differences("", ofpbuf_data(&of11_in), ofpbuf_size(&of11_in),
-                          ofpbuf_data(&of11_out), ofpbuf_size(&of11_out));
-        putchar('\n');
-
-        ofpbuf_uninit(&ofpacts);
-        ofpbuf_uninit(&of11_in);
-        ofpbuf_uninit(&of11_out);
-    }
-    ds_destroy(&in);
-}
-
 /* "parse-pcap PCAP": read packets from PCAP and print their flows. */
 static void
 ofctl_parse_pcap(int argc OVS_UNUSED, char *argv[])
@@ -3340,7 +3272,7 @@ ofctl_check_vlan(int argc OVS_UNUSED, char *argv[])
 
     /* Convert to and from OXM. */
     ofpbuf_init(&nxm, 0);
-    nxm_match_len = oxm_put_match(&nxm, &match);
+    nxm_match_len = oxm_put_match(&nxm, &match, OFP12_VERSION);
     nxm_s = oxm_match_to_string(&nxm, nxm_match_len);
     error = oxm_pull_match(&nxm, &nxm_match);
     printf("OXM: %s -> ", nxm_s);
@@ -3449,18 +3381,41 @@ ofctl_encode_error_reply(int argc OVS_UNUSED, char *argv[])
 
 /* "ofp-print HEXSTRING [VERBOSITY]": Converts the hex digits in HEXSTRING into
  * binary data, interpreting them as an OpenFlow message, and prints the
- * OpenFlow message on stdout, at VERBOSITY (level 2 by default).  */
+ * OpenFlow message on stdout, at VERBOSITY (level 2 by default).
+ *
+ * Alternative usage: "ofp-print [VERBOSITY] - < HEXSTRING_FILE", where
+ * HEXSTRING_FILE contains the HEXSTRING. */
 static void
 ofctl_ofp_print(int argc, char *argv[])
 {
     struct ofpbuf packet;
+    char *buffer;
+    int verbosity = 2;
+    struct ds line;
+
+    ds_init(&line);
+
+    if (!strcmp(argv[argc-1], "-")) {
+        if (ds_get_line(&line, stdin)) {
+           VLOG_FATAL("Failed to read stdin");
+        }
+
+        buffer = line.string;
+        verbosity = argc > 2 ? atoi(argv[1]) : verbosity;
+    } else if (argc > 2) {
+        buffer = argv[1];
+        verbosity = atoi(argv[2]);
+    } else {
+        buffer = argv[1];
+    }
 
-    ofpbuf_init(&packet, strlen(argv[1]) / 2);
-    if (ofpbuf_put_hex(&packet, argv[1], NULL)[0] != '\0') {
+    ofpbuf_init(&packet, strlen(buffer) / 2);
+    if (ofpbuf_put_hex(&packet, buffer, NULL)[0] != '\0') {
         ovs_fatal(0, "trailing garbage following hex bytes");
     }
-    ofp_print(stdout, ofpbuf_data(&packet), ofpbuf_size(&packet), argc > 2 ? atoi(argv[2]) : 2);
+    ofp_print(stdout, ofpbuf_data(&packet), ofpbuf_size(&packet), verbosity);
     ofpbuf_uninit(&packet);
+    ds_destroy(&line);
 }
 
 /* "encode-hello BITMAP...": Encodes each BITMAP as an OpenFlow hello message
@@ -3504,7 +3459,7 @@ static const struct command all_commands[] = {
     { "meter-features", 1, 1, ofctl_meter_features },
     { "packet-out", 4, INT_MAX, ofctl_packet_out },
     { "dump-ports", 1, 2, ofctl_dump_ports },
-    { "dump-ports-desc", 1, 1, ofctl_dump_ports_desc },
+    { "dump-ports-desc", 1, 2, ofctl_dump_ports_desc },
     { "mod-port", 3, 3, ofctl_mod_port },
     { "mod-table", 3, 3, ofctl_mod_table },
     { "get-frags", 1, 1, ofctl_get_frags },
@@ -3530,12 +3485,11 @@ static const struct command all_commands[] = {
     { "parse-flows", 1, 1, ofctl_parse_flows },
     { "parse-nx-match", 0, 0, ofctl_parse_nxm },
     { "parse-nxm", 0, 0, ofctl_parse_nxm },
-    { "parse-oxm", 0, 0, ofctl_parse_oxm },
-    { "parse-ofp10-actions", 0, 0, ofctl_parse_ofp10_actions },
+    { "parse-oxm", 1, 1, ofctl_parse_oxm },
+    { "parse-actions", 1, 1, ofctl_parse_actions },
+    { "parse-instructions", 1, 1, ofctl_parse_instructions },
     { "parse-ofp10-match", 0, 0, ofctl_parse_ofp10_match },
     { "parse-ofp11-match", 0, 0, ofctl_parse_ofp11_match },
-    { "parse-ofp11-actions", 0, 0, ofctl_parse_ofp11_actions },
-    { "parse-ofp11-instructions", 0, 0, ofctl_parse_ofp11_instructions },
     { "parse-pcap", 1, 1, ofctl_parse_pcap },
     { "check-vlan", 2, 2, ofctl_check_vlan },
     { "print-error", 1, 1, ofctl_print_error },