X-Git-Url: http://git.cascardo.eti.br/?a=blobdiff_plain;f=lib%2Fmeta-flow.c;h=463e01ccf179c5fcf46f25a015387b19661503a7;hb=ba4aaf6ae71ad674fc10a2b7ac69c444c2038afa;hp=b37f7816e283e432308aba89ef54aa6b2a09c05e;hpb=c2c28dfd68eeb4744edb1375eae6ccc74201e812;p=cascardo%2Fovs.git diff --git a/lib/meta-flow.c b/lib/meta-flow.c index b37f7816e..463e01ccf 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -37,6 +37,9 @@ VLOG_DEFINE_THIS_MODULE(meta_flow); +#define FLOW_U32OFS(FIELD) \ + offsetof(struct flow, FIELD) % 4 ? -1 : offsetof(struct flow, FIELD) / 4 + #define MF_FIELD_SIZES(MEMBER) \ sizeof ((union mf_value *)0)->MEMBER, \ 8 * sizeof ((union mf_value *)0)->MEMBER @@ -59,6 +62,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_TUNNEL_ID, "OXM_OF_TUNNEL_ID", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + FLOW_U32OFS(tunnel.tun_id), }, { MFF_TUN_SRC, "tun_src", NULL, MF_FIELD_SIZES(be32), @@ -70,6 +74,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_NX_TUN_IPV4_SRC, "NXM_NX_TUN_IPV4_SRC", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + FLOW_U32OFS(tunnel.ip_src), }, { MFF_TUN_DST, "tun_dst", NULL, MF_FIELD_SIZES(be32), @@ -81,6 +86,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_NX_TUN_IPV4_DST, "NXM_NX_TUN_IPV4_DST", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + FLOW_U32OFS(tunnel.ip_dst), }, { MFF_TUN_FLAGS, "tun_flags", NULL, MF_FIELD_SIZES(be16), @@ -92,6 +98,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { 0, NULL, OFPUTIL_P_NONE, OFPUTIL_P_NONE, + -1, }, { MFF_TUN_TTL, "tun_ttl", NULL, MF_FIELD_SIZES(u8), @@ -103,6 +110,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { 0, NULL, OFPUTIL_P_NONE, OFPUTIL_P_NONE, + -1, }, { MFF_TUN_TOS, "tun_tos", NULL, MF_FIELD_SIZES(u8), @@ -114,6 +122,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { 0, NULL, OFPUTIL_P_NONE, OFPUTIL_P_NONE, + -1, }, { MFF_METADATA, "metadata", NULL, MF_FIELD_SIZES(be64), @@ -125,6 +134,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_METADATA, "OXM_OF_METADATA", OFPUTIL_P_NXM_OF11_UP, OFPUTIL_P_NXM_OF11_UP, + -1, }, { MFF_IN_PORT, "in_port", NULL, MF_FIELD_SIZES(be16), @@ -136,6 +146,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_OF_IN_PORT, "NXM_OF_IN_PORT", OFPUTIL_P_ANY, /* OF11+ via mapping to 32 bits. */ OFPUTIL_P_NONE, + -1, }, { MFF_IN_PORT_OXM, "in_port_oxm", NULL, MF_FIELD_SIZES(be32), @@ -147,6 +158,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IN_PORT, "OXM_OF_IN_PORT", OFPUTIL_P_OF11_UP, OFPUTIL_P_NONE, + -1, }, { MFF_SKB_PRIORITY, "skb_priority", NULL, MF_FIELD_SIZES(be32), @@ -158,6 +170,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { 0, NULL, OFPUTIL_P_NONE, OFPUTIL_P_NONE, + -1, }, { MFF_PKT_MARK, "pkt_mark", NULL, MF_FIELD_SIZES(be32), @@ -169,6 +182,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_NX_PKT_MARK, "NXM_NX_PKT_MARK", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, #define REGISTER(IDX) \ @@ -183,6 +197,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_NX_REG(IDX), "NXM_NX_REG" #IDX, \ OFPUTIL_P_NXM_OXM_ANY, \ OFPUTIL_P_NXM_OXM_ANY, \ + -1, \ } #if FLOW_N_REGS > 0 REGISTER(0), @@ -227,6 +242,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ETH_SRC, "OXM_OF_ETH_SRC", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OF11_UP, /* Bitwise masking only with NXM and OF11+! */ + -1, }, { MFF_ETH_DST, "eth_dst", "dl_dst", MF_FIELD_SIZES(mac), @@ -238,6 +254,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ETH_DST, "OXM_OF_ETH_DST", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OF11_UP, /* Bitwise masking only with NXM and OF11+! */ + -1, }, { MFF_ETH_TYPE, "eth_type", "dl_type", MF_FIELD_SIZES(be16), @@ -249,6 +266,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ETH_TYPE, "OXM_OF_ETH_TYPE", OFPUTIL_P_ANY, OFPUTIL_P_NONE, + -1, }, { @@ -262,6 +280,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_OF_VLAN_TCI, "NXM_OF_VLAN_TCI", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_DL_VLAN, "dl_vlan", NULL, sizeof(ovs_be16), 12, @@ -273,6 +292,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { 0, NULL, OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_VLAN_VID, "vlan_vid", NULL, sizeof(ovs_be16), 12, @@ -284,6 +304,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_VLAN_VID, "OXM_OF_VLAN_VID", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_DL_VLAN_PCP, "dl_vlan_pcp", NULL, 1, 3, @@ -295,6 +316,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { 0, NULL, OFPUTIL_P_ANY, /* Will be mapped to NXM and OXM. */ OFPUTIL_P_NONE, + -1, }, { MFF_VLAN_PCP, "vlan_pcp", NULL, 1, 3, @@ -306,6 +328,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_VLAN_PCP, "OXM_OF_VLAN_PCP", OFPUTIL_P_ANY, /* Will be mapped to OF10 and NXM. */ OFPUTIL_P_NONE, + -1, }, /* ## ---- ## */ @@ -322,6 +345,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_MPLS_LABEL, "OXM_OF_MPLS_LABEL", OFPUTIL_P_NXM_OF11_UP, OFPUTIL_P_NONE, + -1, }, { MFF_MPLS_TC, "mpls_tc", NULL, 1, 3, @@ -333,6 +357,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_MPLS_TC, "OXM_OF_MPLS_TC", OFPUTIL_P_NXM_OF11_UP, OFPUTIL_P_NONE, + -1, }, { MFF_MPLS_BOS, "mpls_bos", NULL, 1, 1, @@ -344,6 +369,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_MPLS_BOS, "OXM_OF_MPLS_BOS", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NONE, + -1, }, /* ## -- ## */ @@ -361,6 +387,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV4_SRC, "OXM_OF_IPV4_SRC", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OF11_UP, + FLOW_U32OFS(nw_src), }, { MFF_IPV4_DST, "ip_dst", "nw_dst", MF_FIELD_SIZES(be32), @@ -372,6 +399,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV4_DST, "OXM_OF_IPV4_DST", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OF11_UP, + FLOW_U32OFS(nw_dst), }, { @@ -385,6 +413,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV6_SRC, "OXM_OF_IPV6_SRC", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + FLOW_U32OFS(ipv6_src), }, { MFF_IPV6_DST, "ipv6_dst", NULL, MF_FIELD_SIZES(ipv6), @@ -396,6 +425,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV6_DST, "OXM_OF_IPV6_DST", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + FLOW_U32OFS(ipv6_dst), }, { MFF_IPV6_LABEL, "ipv6_label", NULL, @@ -408,6 +438,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV6_FLABEL, "OXM_OF_IPV6_FLABEL", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { @@ -421,6 +452,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IP_PROTO, "OXM_OF_IP_PROTO", OFPUTIL_P_ANY, OFPUTIL_P_NONE, + -1, }, { MFF_IP_DSCP, "nw_tos", NULL, MF_FIELD_SIZES(u8), @@ -432,6 +464,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_OF_IP_TOS, "NXM_OF_IP_TOS", OFPUTIL_P_ANY, /* Will be shifted for OXM. */ OFPUTIL_P_NONE, + -1, }, { MFF_IP_DSCP_SHIFTED, "ip_dscp", NULL, 1, 6, @@ -443,6 +476,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IP_DSCP, "OXM_OF_IP_DSCP", OFPUTIL_P_ANY, /* Will be shifted for non-OXM. */ OFPUTIL_P_NONE, + -1, }, { MFF_IP_ECN, "nw_ecn", "ip_ecn", 1, 2, @@ -454,6 +488,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IP_ECN, "OXM_OF_IP_ECN", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NONE, + -1, }, { MFF_IP_TTL, "nw_ttl", NULL, MF_FIELD_SIZES(u8), @@ -465,6 +500,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_NX_IP_TTL, "NXM_NX_IP_TTL", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NONE, + -1, }, { MFF_IP_FRAG, "ip_frag", NULL, 1, 2, @@ -476,6 +512,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { NXM_NX_IP_FRAG, "NXM_NX_IP_FRAG", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { @@ -489,6 +526,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ARP_OP, "OXM_OF_ARP_OP", OFPUTIL_P_ANY, OFPUTIL_P_NONE, + -1, }, { MFF_ARP_SPA, "arp_spa", NULL, MF_FIELD_SIZES(be32), @@ -500,6 +538,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ARP_SPA, "OXM_OF_ARP_SPA", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OF11_UP, + -1, }, { MFF_ARP_TPA, "arp_tpa", NULL, MF_FIELD_SIZES(be32), @@ -511,6 +550,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ARP_TPA, "OXM_OF_ARP_TPA", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OF11_UP, + -1, }, { MFF_ARP_SHA, "arp_sha", NULL, MF_FIELD_SIZES(mac), @@ -522,6 +562,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ARP_SHA, "OXM_OF_ARP_SHA", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_ARP_THA, "arp_tha", NULL, MF_FIELD_SIZES(mac), @@ -533,6 +574,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ARP_THA, "OXM_OF_ARP_THA", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, /* ## -- ## */ @@ -550,6 +592,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_TCP_SRC, "OXM_OF_TCP_SRC", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_TCP_DST, "tcp_dst", "tp_dst", MF_FIELD_SIZES(be16), @@ -561,17 +604,19 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_TCP_DST, "OXM_OF_TCP_DST", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_TCP_FLAGS, "tcp_flags", NULL, 2, 12, MFM_FULLY, - MFS_HEXADECIMAL, + MFS_TCP_FLAGS, MFP_TCP, false, NXM_NX_TCP_FLAGS, "NXM_NX_TCP_FLAGS", NXM_NX_TCP_FLAGS, "NXM_NX_TCP_FLAGS", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { @@ -585,6 +630,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_UDP_SRC, "OXM_OF_UDP_SRC", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_UDP_DST, "udp_dst", NULL, MF_FIELD_SIZES(be16), @@ -596,6 +642,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_UDP_DST, "OXM_OF_UDP_DST", OFPUTIL_P_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { @@ -609,6 +656,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_SCTP_SRC, "OXM_OF_SCTP_SRC", OFPUTIL_P_NXM_OF11_UP, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_SCTP_DST, "sctp_dst", NULL, MF_FIELD_SIZES(be16), @@ -620,6 +668,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_SCTP_DST, "OXM_OF_SCTP_DST", OFPUTIL_P_NXM_OF11_UP, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { @@ -633,6 +682,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ICMPV4_TYPE, "OXM_OF_ICMPV4_TYPE", OFPUTIL_P_ANY, OFPUTIL_P_NONE, + -1, }, { MFF_ICMPV4_CODE, "icmp_code", NULL, MF_FIELD_SIZES(u8), @@ -644,6 +694,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ICMPV4_CODE, "OXM_OF_ICMPV4_CODE", OFPUTIL_P_ANY, OFPUTIL_P_NONE, + -1, }, { @@ -657,6 +708,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ICMPV6_TYPE, "OXM_OF_ICMPV6_TYPE", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NONE, + -1, }, { MFF_ICMPV6_CODE, "icmpv6_code", NULL, MF_FIELD_SIZES(u8), @@ -668,6 +720,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_ICMPV6_CODE, "OXM_OF_ICMPV6_CODE", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NONE, + -1, }, /* ## ---- ## */ @@ -685,6 +738,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV6_ND_TARGET, "OXM_OF_IPV6_ND_TARGET", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_ND_SLL, "nd_sll", NULL, MF_FIELD_SIZES(mac), @@ -696,6 +750,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV6_ND_SLL, "OXM_OF_IPV6_ND_SLL", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, }, { MFF_ND_TLL, "nd_tll", NULL, MF_FIELD_SIZES(mac), @@ -707,6 +762,7 @@ const struct mf_field mf_fields[MFF_N_IDS] = { OXM_OF_IPV6_ND_TLL, "OXM_OF_IPV6_ND_TLL", OFPUTIL_P_NXM_OXM_ANY, OFPUTIL_P_NXM_OXM_ANY, + -1, } }; @@ -929,7 +985,7 @@ mf_is_all_wild(const struct mf_field *mf, const struct flow_wildcards *wc) case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } } @@ -960,21 +1016,7 @@ mf_is_mask_valid(const struct mf_field *mf, const union mf_value *mask) return true; } - NOT_REACHED(); -} - -static bool -is_icmpv4(const struct flow *flow) -{ - return (flow->dl_type == htons(ETH_TYPE_IP) - && flow->nw_proto == IPPROTO_ICMP); -} - -static bool -is_icmpv6(const struct flow *flow) -{ - return (flow->dl_type == htons(ETH_TYPE_IPV6) - && flow->nw_proto == IPPROTO_ICMPV6); + OVS_NOT_REACHED(); } /* Returns true if 'flow' meets the prerequisites for 'mf', false otherwise. */ @@ -1025,7 +1067,7 @@ mf_are_prereqs_ok(const struct mf_field *mf, const struct flow *flow) && (flow->tp_src == htons(ND_NEIGHBOR_ADVERT))); } - NOT_REACHED(); + OVS_NOT_REACHED(); } /* Set field and it's prerequisities in the mask. @@ -1164,7 +1206,7 @@ mf_is_value_valid(const struct mf_field *mf, const union mf_value *value) case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } } @@ -1355,7 +1397,7 @@ mf_get_value(const struct mf_field *mf, const struct flow *flow, case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } } @@ -1551,7 +1593,7 @@ mf_set_value(const struct mf_field *mf, case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } } @@ -1767,7 +1809,7 @@ mf_set_flow_value(const struct mf_field *mf, case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } } @@ -1975,7 +2017,7 @@ mf_set_wild(const struct mf_field *mf, struct match *match) case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } } @@ -2143,7 +2185,7 @@ mf_set(const struct mf_field *mf, case MFF_N_IDS: default: - NOT_REACHED(); + OVS_NOT_REACHED(); } return mf->usable_protocols_bitwise; @@ -2215,115 +2257,6 @@ mf_get(const struct mf_field *mf, const struct match *match, mf_get_mask(mf, &match->wc, mask); } -/* Assigns a random value for field 'mf' to 'value'. */ -void -mf_random_value(const struct mf_field *mf, union mf_value *value) -{ - random_bytes(value, mf->n_bytes); - - switch (mf->id) { - case MFF_TUN_ID: - case MFF_TUN_SRC: - case MFF_TUN_DST: - case MFF_TUN_TOS: - case MFF_TUN_TTL: - case MFF_TUN_FLAGS: - case MFF_METADATA: - case MFF_IN_PORT: - case MFF_PKT_MARK: - case MFF_SKB_PRIORITY: - CASE_MFF_REGS: - case MFF_ETH_SRC: - case MFF_ETH_DST: - case MFF_ETH_TYPE: - case MFF_VLAN_TCI: - case MFF_IPV4_SRC: - case MFF_IPV4_DST: - case MFF_IPV6_SRC: - case MFF_IPV6_DST: - case MFF_IP_PROTO: - case MFF_IP_TTL: - case MFF_ARP_SPA: - case MFF_ARP_TPA: - case MFF_ARP_SHA: - case MFF_ARP_THA: - case MFF_TCP_SRC: - case MFF_TCP_DST: - case MFF_UDP_SRC: - case MFF_UDP_DST: - case MFF_SCTP_SRC: - case MFF_SCTP_DST: - case MFF_ICMPV4_TYPE: - case MFF_ICMPV4_CODE: - case MFF_ICMPV6_TYPE: - case MFF_ICMPV6_CODE: - case MFF_ND_TARGET: - case MFF_ND_SLL: - case MFF_ND_TLL: - break; - - case MFF_TCP_FLAGS: - value->be16 &= htons(0x0fff); - break; - - case MFF_IN_PORT_OXM: - value->be32 = ofputil_port_to_ofp11(u16_to_ofp(ntohs(value->be16))); - break; - - case MFF_IPV6_LABEL: - value->be32 &= htonl(IPV6_LABEL_MASK); - break; - - case MFF_IP_DSCP: - value->u8 &= IP_DSCP_MASK; - break; - - case MFF_IP_DSCP_SHIFTED: - value->u8 &= IP_DSCP_MASK >> 2; - break; - - case MFF_IP_ECN: - value->u8 &= IP_ECN_MASK; - break; - - case MFF_IP_FRAG: - value->u8 &= FLOW_NW_FRAG_MASK; - break; - - case MFF_ARP_OP: - value->be16 &= htons(0xff); - break; - - case MFF_DL_VLAN: - value->be16 &= htons(VLAN_VID_MASK); - break; - case MFF_VLAN_VID: - value->be16 &= htons(VLAN_VID_MASK | VLAN_CFI); - break; - - case MFF_DL_VLAN_PCP: - case MFF_VLAN_PCP: - value->u8 &= 0x07; - break; - - case MFF_MPLS_LABEL: - value->be32 &= htonl(MPLS_LABEL_MASK >> MPLS_LABEL_SHIFT); - break; - - case MFF_MPLS_TC: - value->u8 &= MPLS_TC_MASK >> MPLS_TC_SHIFT; - break; - - case MFF_MPLS_BOS: - value->u8 &= MPLS_BOS_MASK >> MPLS_BOS_SHIFT; - break; - - case MFF_N_IDS: - default: - NOT_REACHED(); - } -} - static char * mf_from_integer_string(const struct mf_field *mf, const char *s, uint8_t *valuep, uint8_t *maskp) @@ -2595,6 +2528,81 @@ mf_from_tun_flags_string(const char *s, ovs_be16 *valuep, ovs_be16 *maskp) "\"csum\", \"key\")", s); } +static char * +mf_from_tcp_flags_string(const char *s, ovs_be16 *flagsp, ovs_be16 *maskp) +{ + uint16_t flags = 0; + uint16_t mask = 0; + uint16_t bit; + int n; + + if (ovs_scan(s, "%"SCNi16"/%"SCNi16"%n", &flags, &mask, &n) && !s[n]) { + *flagsp = htons(flags); + *maskp = htons(mask); + return NULL; + } + if (ovs_scan(s, "%"SCNi16"%n", &flags, &n) && !s[n]) { + *flagsp = htons(flags); + *maskp = OVS_BE16_MAX; + return NULL; + } + + while (*s != '\0') { + bool set; + int name_len; + + switch (*s) { + case '+': + set = true; + break; + case '-': + set = false; + break; + default: + return xasprintf("%s: TCP flag must be preceded by '+' (for SET) " + "or '-' (NOT SET)", s); + } + s++; + + name_len = strcspn(s,"+-"); + + for (bit = 1; bit; bit <<= 1) { + const char *fname = packet_tcp_flag_to_string(bit); + size_t len; + + if (!fname) { + continue; + } + + len = strlen(fname); + if (len != name_len) { + continue; + } + if (!strncmp(s, fname, len)) { + if (mask & bit) { + return xasprintf("%s: Each TCP flag can be specified only " + "once", s); + } + if (set) { + flags |= bit; + } + mask |= bit; + break; + } + } + + if (!bit) { + return xasprintf("%s: unknown TCP flag(s)", s); + } + s += name_len; + } + + *flagsp = htons(flags); + *maskp = htons(mask); + return NULL; +} + + /* Parses 's', a string value for field 'mf', into 'value' and 'mask'. Returns * NULL if successful, otherwise a malloc()'d string describing the error. */ char * @@ -2645,8 +2653,13 @@ mf_parse(const struct mf_field *mf, const char *s, error = mf_from_tun_flags_string(s, &value->be16, &mask->be16); break; + case MFS_TCP_FLAGS: + ovs_assert(mf->n_bytes == sizeof(ovs_be16)); + error = mf_from_tcp_flags_string(s, &value->be16, &mask->be16); + break; + default: - NOT_REACHED(); + OVS_NOT_REACHED(); } if (!error && !mf_is_mask_valid(mf, mask)) { @@ -2731,6 +2744,13 @@ mf_format_tnl_flags_string(const ovs_be16 *valuep, struct ds *s) format_flags(s, flow_tun_flag_to_string, ntohs(*valuep), '|'); } +static void +mf_format_tcp_flags_string(ovs_be16 value, ovs_be16 mask, struct ds *s) +{ + format_flags_masked(s, NULL, packet_tcp_flag_to_string, ntohs(value), + TCP_FLAGS(mask)); +} + /* Appends to 's' a string representation of field 'mf' whose value is in * 'value' and 'mask'. 'mask' may be NULL to indicate an exact match. */ void @@ -2787,8 +2807,13 @@ mf_format(const struct mf_field *mf, mf_format_tnl_flags_string(&value->be16, s); break; + case MFS_TCP_FLAGS: + mf_format_tcp_flags_string(value->be16, + mask ? mask->be16 : OVS_BE16_MAX, s); + break; + default: - NOT_REACHED(); + OVS_NOT_REACHED(); } }