X-Git-Url: http://git.cascardo.eti.br/?a=blobdiff_plain;f=lib%2Fofp-print.c;h=271b095b7f250c7a5a7cef97a1a5e047666246be;hb=6c6eedc5d6730835a0d9724e2e8cfe9cdf03b07d;hp=b280a3738b833948e8e48dfd674334bad04ee17f;hpb=db09e4308a18f12d93191d057dc9e2b938ff4649;p=cascardo%2Fovs.git diff --git a/lib/ofp-print.c b/lib/ofp-print.c index b280a3738..271b095b7 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc. + * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -37,48 +37,56 @@ #include "netdev.h" #include "nx-match.h" #include "ofp-actions.h" +#include "ofpbuf.h" #include "ofp-errors.h" #include "ofp-msgs.h" #include "ofp-util.h" -#include "ofpbuf.h" #include "openflow/openflow.h" #include "openflow/nicira-ext.h" #include "packets.h" +#include "dp-packet.h" #include "type-props.h" #include "unaligned.h" +#include "odp-util.h" #include "util.h" static void ofp_print_queue_name(struct ds *string, uint32_t port); static void ofp_print_error(struct ds *, enum ofperr); - /* Returns a string that represents the contents of the Ethernet frame in the * 'len' bytes starting at 'data'. The caller must free the returned string.*/ char * ofp_packet_to_string(const void *data, size_t len) { struct ds ds = DS_EMPTY_INITIALIZER; - struct ofpbuf buf; + struct dp_packet buf; struct flow flow; + size_t l4_size; - ofpbuf_use_const(&buf, data, len); - flow_extract(&buf, 0, 0, NULL, NULL, &flow); + dp_packet_use_const(&buf, data, len); + flow_extract(&buf, &flow); flow_format(&ds, &flow); - if (buf.l7) { - if (flow.nw_proto == IPPROTO_TCP) { - struct tcp_header *th = buf.l4; - ds_put_format(&ds, " tcp_csum:%"PRIx16, - ntohs(th->tcp_csum)); - } else if (flow.nw_proto == IPPROTO_UDP) { - struct udp_header *uh = buf.l4; - ds_put_format(&ds, " udp_csum:%"PRIx16, - ntohs(uh->udp_csum)); - } else if (flow.nw_proto == IPPROTO_SCTP) { - struct sctp_header *sh = buf.l4; - ds_put_format(&ds, " sctp_csum:%"PRIx32, - ntohl(sh->sctp_csum)); - } + l4_size = dp_packet_l4_size(&buf); + + if (flow.nw_proto == IPPROTO_TCP && l4_size >= TCP_HEADER_LEN) { + struct tcp_header *th = dp_packet_l4(&buf); + ds_put_format(&ds, " tcp_csum:%"PRIx16, ntohs(th->tcp_csum)); + } else if (flow.nw_proto == IPPROTO_UDP && l4_size >= UDP_HEADER_LEN) { + struct udp_header *uh = dp_packet_l4(&buf); + ds_put_format(&ds, " udp_csum:%"PRIx16, ntohs(uh->udp_csum)); + } else if (flow.nw_proto == IPPROTO_SCTP && l4_size >= SCTP_HEADER_LEN) { + struct sctp_header *sh = dp_packet_l4(&buf); + ds_put_format(&ds, " sctp_csum:%"PRIx32, + ntohl(get_16aligned_be32(&sh->sctp_csum))); + } else if (flow.nw_proto == IPPROTO_ICMP && l4_size >= ICMP_HEADER_LEN) { + struct icmp_header *icmph = dp_packet_l4(&buf); + ds_put_format(&ds, " icmp_csum:%"PRIx16, + ntohs(icmph->icmp_csum)); + } else if (flow.nw_proto == IPPROTO_ICMPV6 && l4_size >= ICMP6_HEADER_LEN) { + struct icmp6_header *icmp6h = dp_packet_l4(&buf); + ds_put_format(&ds, " icmp6_csum:%"PRIx16, + ntohs(icmp6h->icmp6_cksum)); } ds_put_char(&ds, '\n'); @@ -86,84 +94,119 @@ ofp_packet_to_string(const void *data, size_t len) return ds_cstr(&ds); } +static void +format_hex_arg(struct ds *s, const uint8_t *data, size_t len) +{ + for (size_t i = 0; i < len; i++) { + if (i) { + ds_put_char(s, '.'); + } + ds_put_format(s, "%02"PRIx8, data[i]); + } +} + static void ofp_print_packet_in(struct ds *string, const struct ofp_header *oh, int verbosity) { char reasonbuf[OFPUTIL_PACKET_IN_REASON_BUFSIZE]; - struct ofputil_packet_in pin; - int error; - int i; + struct ofputil_packet_in_private pin; + const struct ofputil_packet_in *public = &pin.public; + uint32_t buffer_id; + size_t total_len; + enum ofperr error; - error = ofputil_decode_packet_in(&pin, oh); + error = ofputil_decode_packet_in_private(oh, true, + &pin, &total_len, &buffer_id); if (error) { ofp_print_error(string, error); return; } - if (pin.table_id) { - ds_put_format(string, " table_id=%"PRIu8, pin.table_id); + if (public->table_id) { + ds_put_format(string, " table_id=%"PRIu8, public->table_id); } - if (pin.cookie) { - ds_put_format(string, " cookie=0x%"PRIx64, ntohll(pin.cookie)); + if (public->cookie != OVS_BE64_MAX) { + ds_put_format(string, " cookie=0x%"PRIx64, ntohll(public->cookie)); } - ds_put_format(string, " total_len=%"PRIu16" in_port=", pin.total_len); - ofputil_format_port(pin.fmd.in_port, string); + ds_put_format(string, " total_len=%"PRIuSIZE" ", total_len); - if (pin.fmd.tun_id != htonll(0)) { - ds_put_format(string, " tun_id=0x%"PRIx64, ntohll(pin.fmd.tun_id)); - } + match_format(&public->flow_metadata, string, OFP_DEFAULT_PRIORITY); + + ds_put_format(string, " (via %s)", + ofputil_packet_in_reason_to_string(public->reason, + reasonbuf, + sizeof reasonbuf)); - if (pin.fmd.tun_src != htonl(0)) { - ds_put_format(string, " tun_src="IP_FMT, IP_ARGS(pin.fmd.tun_src)); + ds_put_format(string, " data_len=%"PRIuSIZE, public->packet_len); + if (buffer_id == UINT32_MAX) { + ds_put_format(string, " (unbuffered)"); + if (total_len != public->packet_len) { + ds_put_format(string, " (***total_len != data_len***)"); + } + } else { + ds_put_format(string, " buffer=0x%08"PRIx32, buffer_id); + if (total_len < public->packet_len) { + ds_put_format(string, " (***total_len < data_len***)"); + } } + ds_put_char(string, '\n'); - if (pin.fmd.tun_dst != htonl(0)) { - ds_put_format(string, " tun_dst="IP_FMT, IP_ARGS(pin.fmd.tun_dst)); + if (public->userdata_len) { + ds_put_cstr(string, " userdata="); + format_hex_arg(string, pin.public.userdata, pin.public.userdata_len); + ds_put_char(string, '\n'); } - if (pin.fmd.metadata != htonll(0)) { - ds_put_format(string, " metadata=0x%"PRIx64, ntohll(pin.fmd.metadata)); + if (!uuid_is_zero(&pin.bridge)) { + ds_put_format(string, " continuation.bridge="UUID_FMT"\n", + UUID_ARGS(&pin.bridge)); } - for (i = 0; i < FLOW_N_REGS; i++) { - if (pin.fmd.regs[i]) { - ds_put_format(string, " reg%d=0x%"PRIx32, i, pin.fmd.regs[i]); + if (pin.n_stack) { + ds_put_cstr(string, " continuation.stack="); + for (size_t i = 0; i < pin.n_stack; i++) { + if (i) { + ds_put_char(string, ' '); + } + mf_subvalue_format(&pin.stack[i], string); } } - if (pin.fmd.pkt_mark != 0) { - ds_put_format(string, " pkt_mark=0x%"PRIx32, pin.fmd.pkt_mark); + if (pin.mirrors) { + ds_put_format(string, " continuation.mirrors=0x%"PRIx32"\n", + pin.mirrors); } - ds_put_format(string, " (via %s)", - ofputil_packet_in_reason_to_string(pin.reason, reasonbuf, - sizeof reasonbuf)); + if (pin.conntracked) { + ds_put_cstr(string, " continuation.conntracked=true\n"); + } - ds_put_format(string, " data_len=%zu", pin.packet_len); - if (pin.buffer_id == UINT32_MAX) { - ds_put_format(string, " (unbuffered)"); - if (pin.total_len != pin.packet_len) { - ds_put_format(string, " (***total_len != data_len***)"); - } - } else { - ds_put_format(string, " buffer=0x%08"PRIx32, pin.buffer_id); - if (pin.total_len < pin.packet_len) { - ds_put_format(string, " (***total_len < data_len***)"); - } + if (pin.actions_len) { + ds_put_cstr(string, " continuation.actions="); + ofpacts_format(pin.actions, pin.actions_len, string); + ds_put_char(string, '\n'); + } + + if (pin.action_set_len) { + ds_put_cstr(string, " continuation.action_set="); + ofpacts_format(pin.action_set, pin.action_set_len, string); + ds_put_char(string, '\n'); } - ds_put_char(string, '\n'); if (verbosity > 0) { - char *packet = ofp_packet_to_string(pin.packet, pin.packet_len); + char *packet = ofp_packet_to_string(public->packet, + public->packet_len); ds_put_cstr(string, packet); free(packet); } if (verbosity > 2) { - ds_put_hex_dump(string, pin.packet, pin.packet_len, 0, false); + ds_put_hex_dump(string, public->packet, public->packet_len, 0, false); } + + ofputil_packet_in_private_destroy(&pin); } static void @@ -185,11 +228,11 @@ ofp_print_packet_out(struct ds *string, const struct ofp_header *oh, ds_put_cstr(string, " in_port="); ofputil_format_port(po.in_port, string); - ds_put_char(string, ' '); + ds_put_cstr(string, " actions="); ofpacts_format(po.ofpacts, po.ofpacts_len, string); if (po.buffer_id == UINT32_MAX) { - ds_put_format(string, " data_len=%zu", po.packet_len); + ds_put_format(string, " data_len=%"PRIuSIZE, po.packet_len); if (verbosity > 0 && po.packet_len > 0) { char *packet = ofp_packet_to_string(po.packet, po.packet_len); ds_put_char(string, '\n'); @@ -417,28 +460,33 @@ static void ofp_print_phy_ports(struct ds *string, uint8_t ofp_version, struct ofpbuf *b) { - size_t n_ports; struct ofputil_phy_port *ports; - enum ofperr error; + size_t allocated_ports, n_ports; + int retval; size_t i; - n_ports = ofputil_count_phy_ports(ofp_version, b); + ports = NULL; + allocated_ports = 0; + for (n_ports = 0; ; n_ports++) { + if (n_ports >= allocated_ports) { + ports = x2nrealloc(ports, &allocated_ports, sizeof *ports); + } - ports = xmalloc(n_ports * sizeof *ports); - for (i = 0; i < n_ports; i++) { - error = ofputil_pull_phy_port(ofp_version, b, &ports[i]); - if (error) { - ofp_print_error(string, error); - goto exit; + retval = ofputil_pull_phy_port(ofp_version, b, &ports[n_ports]); + if (retval) { + break; } } + qsort(ports, n_ports, sizeof *ports, compare_ports); for (i = 0; i < n_ports; i++) { ofp_print_phy_port(string, &ports[i]); } - -exit: free(ports); + + if (retval != EOF) { + ofp_print_error(string, retval); + } } static const char * @@ -461,53 +509,12 @@ ofputil_capabilities_to_name(uint32_t bit) return NULL; } -static const char * -ofputil_action_bitmap_to_name(uint32_t bit) -{ - enum ofputil_action_bitmap action = bit; - - switch (action) { - case OFPUTIL_A_OUTPUT: return "OUTPUT"; - case OFPUTIL_A_SET_VLAN_VID: return "SET_VLAN_VID"; - case OFPUTIL_A_SET_VLAN_PCP: return "SET_VLAN_PCP"; - case OFPUTIL_A_STRIP_VLAN: return "STRIP_VLAN"; - case OFPUTIL_A_SET_DL_SRC: return "SET_DL_SRC"; - case OFPUTIL_A_SET_DL_DST: return "SET_DL_DST"; - case OFPUTIL_A_SET_NW_SRC: return "SET_NW_SRC"; - case OFPUTIL_A_SET_NW_DST: return "SET_NW_DST"; - case OFPUTIL_A_SET_NW_ECN: return "SET_NW_ECN"; - case OFPUTIL_A_SET_NW_TOS: return "SET_NW_TOS"; - case OFPUTIL_A_SET_TP_SRC: return "SET_TP_SRC"; - case OFPUTIL_A_SET_TP_DST: return "SET_TP_DST"; - case OFPUTIL_A_SET_FIELD: return "SET_FIELD"; - case OFPUTIL_A_ENQUEUE: return "ENQUEUE"; - case OFPUTIL_A_COPY_TTL_OUT: return "COPY_TTL_OUT"; - case OFPUTIL_A_COPY_TTL_IN: return "COPY_TTL_IN"; - case OFPUTIL_A_SET_MPLS_LABEL: return "SET_MPLS_LABEL"; - case OFPUTIL_A_SET_MPLS_TC: return "SET_MPLS_TC"; - case OFPUTIL_A_SET_MPLS_TTL: return "SET_MPLS_TTL"; - case OFPUTIL_A_DEC_MPLS_TTL: return "DEC_MPLS_TTL"; - case OFPUTIL_A_PUSH_VLAN: return "PUSH_VLAN"; - case OFPUTIL_A_POP_VLAN: return "POP_VLAN"; - case OFPUTIL_A_PUSH_MPLS: return "PUSH_MPLS"; - case OFPUTIL_A_POP_MPLS: return "POP_MPLS"; - case OFPUTIL_A_SET_QUEUE: return "SET_QUEUE"; - case OFPUTIL_A_GROUP: return "GROUP"; - case OFPUTIL_A_SET_NW_TTL: return "SET_NW_TTL"; - case OFPUTIL_A_DEC_NW_TTL: return "DEC_NW_TTL"; - } - - return NULL; -} - static void ofp_print_switch_features(struct ds *string, const struct ofp_header *oh) { struct ofputil_switch_features features; - enum ofperr error; - struct ofpbuf b; - - error = ofputil_decode_switch_features(oh, &features, &b); + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); + enum ofperr error = ofputil_pull_switch_features(&b, &features); if (error) { ofp_print_error(string, error); return; @@ -530,47 +537,62 @@ ofp_print_switch_features(struct ds *string, const struct ofp_header *oh) switch ((enum ofp_version)oh->version) { case OFP10_VERSION: ds_put_cstr(string, "actions: "); - ofp_print_bit_names(string, features.actions, - ofputil_action_bitmap_to_name, ' '); + ofpact_bitmap_format(features.ofpacts, string); ds_put_char(string, '\n'); break; case OFP11_VERSION: case OFP12_VERSION: break; case OFP13_VERSION: + case OFP14_VERSION: + case OFP15_VERSION: return; /* no ports in ofp13_switch_features */ default: - NOT_REACHED(); + OVS_NOT_REACHED(); } ofp_print_phy_ports(string, oh->version, &b); } static void -ofp_print_switch_config(struct ds *string, const struct ofp_switch_config *osc) +ofp_print_switch_config(struct ds *string, + const struct ofputil_switch_config *config) { - enum ofp_config_flags flags; + ds_put_format(string, " frags=%s", + ofputil_frag_handling_to_string(config->frag)); - flags = ntohs(osc->flags); - - ds_put_format(string, " frags=%s", ofputil_frag_handling_to_string(flags)); - flags &= ~OFPC_FRAG_MASK; - - if (flags & OFPC_INVALID_TTL_TO_CONTROLLER) { + if (config->invalid_ttl_to_controller > 0) { ds_put_format(string, " invalid_ttl_to_controller"); - flags &= ~OFPC_INVALID_TTL_TO_CONTROLLER; } - if (flags) { - ds_put_format(string, " ***unknown flags 0x%04"PRIx16"***", flags); + ds_put_format(string, " miss_send_len=%"PRIu16"\n", config->miss_send_len); +} + +static void +ofp_print_set_config(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_switch_config config; + enum ofperr error; + + error = ofputil_decode_set_config(oh, &config); + if (error) { + ofp_print_error(string, error); + return; } + ofp_print_switch_config(string, &config); +} - ds_put_format(string, " miss_send_len=%"PRIu16"\n", ntohs(osc->miss_send_len)); +static void +ofp_print_get_config_reply(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_switch_config config; + ofputil_decode_get_config_reply(oh, &config); + ofp_print_switch_config(string, &config); } static void print_wild(struct ds *string, const char *leader, int is_wild, int verbosity, const char *format, ...) - __attribute__((format(printf, 5, 6))); + OVS_PRINTF_FORMAT(5, 6); static void print_wild(struct ds *string, const char *leader, int is_wild, int verbosity, const char *format, ...) @@ -717,9 +739,7 @@ ofp10_match_to_string(const struct ofp10_match *om, int verbosity) print_wild(&f, "tp_dst=", w & OFPFW10_TP_DST, verbosity, "%d", ntohs(om->tp_dst)); } - if (ds_last(&f) == ',') { - f.length--; - } + ds_chomp(&f, ','); return ds_cstr(&f); } @@ -741,6 +761,12 @@ ofp_print_flow_flags(struct ds *s, enum ofputil_flow_mod_flags flags) if (flags & OFPUTIL_FF_NO_BYT_COUNTS) { ds_put_cstr(s, "no_byte_counts "); } + if (flags & OFPUTIL_FF_HIDDEN_FIELDS) { + ds_put_cstr(s, "allow_hidden_fields "); + } + if (flags & OFPUTIL_FF_NO_READONLY) { + ds_put_cstr(s, "no_readonly_table "); + } } static void @@ -757,7 +783,8 @@ ofp_print_flow_mod(struct ds *s, const struct ofp_header *oh, int verbosity) protocol = ofputil_protocol_set_tid(protocol, true); ofpbuf_init(&ofpacts, 64); - error = ofputil_decode_flow_mod(&fm, oh, protocol, &ofpacts); + error = ofputil_decode_flow_mod(&fm, oh, protocol, &ofpacts, + OFPP_MAX, 255); if (error) { ofpbuf_uninit(&ofpacts); ofp_print_error(s, error); @@ -817,7 +844,7 @@ ofp_print_flow_mod(struct ds *s, const struct ofp_header *oh, int verbosity) if (ds_last(s) != ' ') { ds_put_char(s, ' '); } - if (fm.new_cookie != htonll(0) && fm.new_cookie != htonll(UINT64_MAX)) { + if (fm.new_cookie != htonll(0) && fm.new_cookie != OVS_BE64_MAX) { ds_put_format(s, "cookie:0x%"PRIx64" ", ntohll(fm.new_cookie)); } if (fm.cookie_mask != htonll(0)) { @@ -830,6 +857,9 @@ ofp_print_flow_mod(struct ds *s, const struct ofp_header *oh, int verbosity) if (fm.hard_timeout != OFP_FLOW_PERMANENT) { ds_put_format(s, "hard:%"PRIu16" ", fm.hard_timeout); } + if (fm.importance != 0) { + ds_put_format(s, "importance:%"PRIu16" ", fm.importance); + } if (fm.priority != OFP_DEFAULT_PRIORITY && need_priority) { ds_put_format(s, "pri:%"PRIu16" ", fm.priority); } @@ -850,6 +880,7 @@ ofp_print_flow_mod(struct ds *s, const struct ofp_header *oh, int verbosity) } ofp_print_flow_flags(s, fm.flags); + ds_put_cstr(s, "actions="); ofpacts_format(fm.ofpacts, fm.ofpacts_len, s); ofpbuf_uninit(&ofpacts); } @@ -858,10 +889,26 @@ static void ofp_print_duration(struct ds *string, unsigned int sec, unsigned int nsec) { ds_put_format(string, "%u", sec); + + /* If there are no fractional seconds, don't print any decimals. + * + * If the fractional seconds can be expressed exactly as milliseconds, + * print 3 decimals. Open vSwitch provides millisecond precision for most + * time measurements, so printing 3 decimals every time makes it easier to + * spot real changes in flow dumps that refresh themselves quickly. + * + * If the fractional seconds are more precise than milliseconds, print the + * number of decimals needed to express them exactly. + */ if (nsec > 0) { - ds_put_format(string, ".%09u", nsec); - while (string->string[string->length - 1] == '0') { - string->length--; + unsigned int msec = nsec / 1000000; + if (msec * 1000000 == nsec) { + ds_put_format(string, ".%03u", msec); + } else { + ds_put_format(string, ".%09u", nsec); + while (string->string[string->length - 1] == '0') { + string->length--; + } } } ds_put_char(string, 's'); @@ -888,6 +935,7 @@ ofp_flow_removed_reason_to_string(enum ofp_flow_removed_reason reason, return "eviction"; case OFPRR_METER_DELETE: return "meter_delete"; + case OVS_OFPRR_NONE: default: snprintf(reasonbuf, bufsize, "%d", (int) reason); return reasonbuf; @@ -939,13 +987,13 @@ ofp_print_port_mod(struct ds *string, const struct ofp_header *oh) struct ofputil_port_mod pm; enum ofperr error; - error = ofputil_decode_port_mod(oh, &pm); + error = ofputil_decode_port_mod(oh, &pm, true); if (error) { ofp_print_error(string, error); return; } - ds_put_cstr(string, "port: "); + ds_put_cstr(string, " port: "); ofputil_format_port(pm.port_no, string); ds_put_format(string, ": addr:"ETH_ADDR_FMT"\n", ETH_ADDR_ARGS(pm.hw_addr)); @@ -964,6 +1012,224 @@ ofp_print_port_mod(struct ds *string, const struct ofp_header *oh) } } +static const char * +ofputil_table_miss_to_string(enum ofputil_table_miss miss) +{ + switch (miss) { + case OFPUTIL_TABLE_MISS_DEFAULT: return "default"; + case OFPUTIL_TABLE_MISS_CONTROLLER: return "controller"; + case OFPUTIL_TABLE_MISS_CONTINUE: return "continue"; + case OFPUTIL_TABLE_MISS_DROP: return "drop"; + default: return "***error***"; + } +} + +static const char * +ofputil_table_eviction_to_string(enum ofputil_table_eviction eviction) +{ + switch (eviction) { + case OFPUTIL_TABLE_EVICTION_DEFAULT: return "default"; + case OFPUTIL_TABLE_EVICTION_ON: return "on"; + case OFPUTIL_TABLE_EVICTION_OFF: return "off"; + default: return "***error***"; + } + +} + +static const char * +ofputil_eviction_flag_to_string(uint32_t bit) +{ + enum ofp14_table_mod_prop_eviction_flag eviction_flag = bit; + + switch (eviction_flag) { + case OFPTMPEF14_OTHER: return "OTHER"; + case OFPTMPEF14_IMPORTANCE: return "IMPORTANCE"; + case OFPTMPEF14_LIFETIME: return "LIFETIME"; + } + + return NULL; +} + +/* Appends to 'string' a description of the bitmap of OFPTMPEF14_* values in + * 'eviction_flags'. */ +static void +ofputil_put_eviction_flags(struct ds *string, uint32_t eviction_flags) +{ + if (eviction_flags != UINT32_MAX) { + ofp_print_bit_names(string, eviction_flags, + ofputil_eviction_flag_to_string, '|'); + } else { + ds_put_cstr(string, "(default)"); + } +} + +static const char * +ofputil_table_vacancy_to_string(enum ofputil_table_vacancy vacancy) +{ + switch (vacancy) { + case OFPUTIL_TABLE_VACANCY_DEFAULT: return "default"; + case OFPUTIL_TABLE_VACANCY_ON: return "on"; + case OFPUTIL_TABLE_VACANCY_OFF: return "off"; + default: return "***error***"; + } + +} + +static void +ofp_print_table_mod(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_table_mod pm; + enum ofperr error; + + error = ofputil_decode_table_mod(oh, &pm); + if (error) { + ofp_print_error(string, error); + return; + } + + if (pm.table_id == 0xff) { + ds_put_cstr(string, " table_id: ALL_TABLES"); + } else { + ds_put_format(string, " table_id=%"PRIu8, pm.table_id); + } + + if (pm.miss != OFPUTIL_TABLE_MISS_DEFAULT) { + ds_put_format(string, ", flow_miss_config=%s", + ofputil_table_miss_to_string(pm.miss)); + } + if (pm.eviction != OFPUTIL_TABLE_EVICTION_DEFAULT) { + ds_put_format(string, ", eviction=%s", + ofputil_table_eviction_to_string(pm.eviction)); + } + if (pm.eviction_flags != UINT32_MAX) { + ds_put_cstr(string, "eviction_flags="); + ofputil_put_eviction_flags(string, pm.eviction_flags); + } + if (pm.vacancy != OFPUTIL_TABLE_VACANCY_DEFAULT) { + ds_put_format(string, ", vacancy=%s", + ofputil_table_vacancy_to_string(pm.vacancy)); + if (pm.vacancy == OFPUTIL_TABLE_VACANCY_ON) { + ds_put_format(string, " vacancy:%"PRIu8"" + ",%"PRIu8"", pm.table_vacancy.vacancy_down, + pm.table_vacancy.vacancy_up); + } + } +} + +/* This function will print the Table description properties. */ +static void +ofp_print_table_desc(struct ds *string, const struct ofputil_table_desc *td) +{ + ds_put_format(string, "\n table %"PRIu8, td->table_id); + ds_put_cstr(string, ":\n"); + ds_put_format(string, " eviction=%s eviction_flags=", + ofputil_table_eviction_to_string(td->eviction)); + ofputil_put_eviction_flags(string, td->eviction_flags); + ds_put_char(string, '\n'); + ds_put_format(string, " vacancy=%s", + ofputil_table_vacancy_to_string(td->vacancy)); + if (td->vacancy == OFPUTIL_TABLE_VACANCY_ON) { + ds_put_format(string, " vacancy_down=%"PRIu8"%%", + td->table_vacancy.vacancy_down); + ds_put_format(string, " vacancy_up=%"PRIu8"%%", + td->table_vacancy.vacancy_up); + ds_put_format(string, " vacancy=%"PRIu8"%%", + td->table_vacancy.vacancy); + } + ds_put_char(string, '\n'); +} + +static void +ofp_print_table_status_message(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_table_status ts; + enum ofperr error; + + error = ofputil_decode_table_status(oh, &ts); + if (error) { + ofp_print_error(string, error); + return; + } + + if (ts.reason == OFPTR_VACANCY_DOWN) { + ds_put_format(string, " reason=VACANCY_DOWN"); + } else if (ts.reason == OFPTR_VACANCY_UP) { + ds_put_format(string, " reason=VACANCY_UP"); + } + + ds_put_format(string, "\ntable_desc:-"); + ofp_print_table_desc(string, &ts.desc); +} + +static void +ofp_print_queue_get_config_request(struct ds *string, + const struct ofp_header *oh) +{ + enum ofperr error; + ofp_port_t port; + uint32_t queue; + + error = ofputil_decode_queue_get_config_request(oh, &port, &queue); + if (error) { + ofp_print_error(string, error); + return; + } + + ds_put_cstr(string, " port="); + ofputil_format_port(port, string); + + if (queue != OFPQ_ALL) { + ds_put_cstr(string, " queue="); + ofp_print_queue_name(string, queue); + } +} + +static void +print_queue_rate(struct ds *string, const char *name, unsigned int rate) +{ + if (rate <= 1000) { + ds_put_format(string, " %s:%u.%u%%", name, rate / 10, rate % 10); + } else if (rate < UINT16_MAX) { + ds_put_format(string, " %s:(disabled)", name); + } +} + +static void +ofp_print_queue_get_config_reply(struct ds *string, + const struct ofp_header *oh) +{ + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); + ofp_port_t port = 0; + + ds_put_char(string, ' '); + for (;;) { + struct ofputil_queue_config queue; + int retval; + + retval = ofputil_pull_queue_get_config_reply(&b, &queue); + if (retval) { + if (retval != EOF) { + ofp_print_error(string, retval); + } + ds_chomp(string, ' '); + break; + } + + if (queue.port != port) { + port = queue.port; + + ds_put_cstr(string, "port="); + ofputil_format_port(port, string); + ds_put_char(string, '\n'); + } + + ds_put_format(string, "queue %"PRIu32":", queue.queue); + print_queue_rate(string, "min_rate", queue.min_rate); + print_queue_rate(string, "max_rate", queue.max_rate); + ds_put_char(string, '\n'); + } +} + static void ofp_print_meter_flags(struct ds *s, uint16_t flags) { @@ -1050,21 +1316,9 @@ ofp_print_meter_config(struct ds *s, const struct ofputil_meter_config *mc) } static void -ofp_print_meter_mod(struct ds *s, const struct ofp_header *oh) +ofp_print_meter_mod__(struct ds *s, const struct ofputil_meter_mod *mm) { - struct ofputil_meter_mod mm; - struct ofpbuf bands; - enum ofperr error; - - ofpbuf_init(&bands, 64); - error = ofputil_decode_meter_mod(oh, &mm, &bands); - if (error) { - ofpbuf_uninit(&bands); - ofp_print_error(s, error); - return; - } - - switch (mm.command) { + switch (mm->command) { case OFPMC13_ADD: ds_put_cstr(s, " ADD "); break; @@ -1075,10 +1329,26 @@ ofp_print_meter_mod(struct ds *s, const struct ofp_header *oh) ds_put_cstr(s, " DEL "); break; default: - ds_put_format(s, " cmd:%d ", mm.command); + ds_put_format(s, " cmd:%d ", mm->command); } - ofp_print_meter_config(s, &mm.meter); + ofp_print_meter_config(s, &mm->meter); +} + +static void +ofp_print_meter_mod(struct ds *s, const struct ofp_header *oh) +{ + struct ofputil_meter_mod mm; + struct ofpbuf bands; + enum ofperr error; + + ofpbuf_init(&bands, 64); + error = ofputil_decode_meter_mod(oh, &mm, &bands); + if (error) { + ofp_print_error(s, error); + } else { + ofp_print_meter_mod__(s, &mm); + } ofpbuf_uninit(&bands); } @@ -1143,10 +1413,9 @@ ofp_print_meter_features_reply(struct ds *s, const struct ofp_header *oh) static void ofp_print_meter_config_reply(struct ds *s, const struct ofp_header *oh) { + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); struct ofpbuf bands; - struct ofpbuf b; - ofpbuf_use_const(&b, oh, ntohs(oh->length)); ofpbuf_init(&bands, 64); for (;;) { struct ofputil_meter_config mc; @@ -1168,10 +1437,9 @@ ofp_print_meter_config_reply(struct ds *s, const struct ofp_header *oh) static void ofp_print_meter_stats_reply(struct ds *s, const struct ofp_header *oh) { + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); struct ofpbuf bands; - struct ofpbuf b; - ofpbuf_use_const(&b, oh, ntohs(oh->length)); ofpbuf_init(&bands, 64); for (;;) { struct ofputil_meter_stats ms; @@ -1240,6 +1508,7 @@ ofp_print_error_msg(struct ds *string, const struct ofp_header *oh) ds_put_cstr(string, s); free(s); } + ofpbuf_uninit(&payload); } static void @@ -1327,6 +1596,9 @@ ofp_print_flow_stats(struct ds *string, struct ofputil_flow_stats *fs) if (fs->flags) { ofp_print_flow_flags(string, fs->flags); } + if (fs->importance != 0) { + ds_put_format(string, "importance=%"PRIu16", ", fs->importance); + } if (fs->idle_age >= 0) { ds_put_format(string, "idle_age=%d, ", fs->idle_age); } @@ -1339,16 +1611,16 @@ ofp_print_flow_stats(struct ds *string, struct ofputil_flow_stats *fs) ds_put_char(string, ' '); } + ds_put_cstr(string, "actions="); ofpacts_format(fs->ofpacts, fs->ofpacts_len, string); } static void ofp_print_flow_stats_reply(struct ds *string, const struct ofp_header *oh) { + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); struct ofpbuf ofpacts; - struct ofpbuf b; - ofpbuf_use_const(&b, oh, ntohs(oh->length)); ofpbuf_init(&ofpacts, 64); for (;;) { struct ofputil_flow_stats fs; @@ -1420,14 +1692,12 @@ static void ofp_print_ofpst_port_reply(struct ds *string, const struct ofp_header *oh, int verbosity) { - struct ofpbuf b; - - ds_put_format(string, " %zu ports\n", ofputil_count_port_stats(oh)); + ds_put_format(string, " %"PRIuSIZE" ports\n", ofputil_count_port_stats(oh)); if (verbosity < 1) { return; } - ofpbuf_use_const(&b, oh, ntohs(oh->length)); + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); for (;;) { struct ofputil_port_stats ps; int retval; @@ -1471,240 +1741,58 @@ ofp_print_ofpst_port_reply(struct ds *string, const struct ofp_header *oh, } static void -ofp_print_one_ofpst_table_reply(struct ds *string, enum ofp_version ofp_version, - const char *name, struct ofp12_table_stats *ts) +ofp_print_table_stats_reply(struct ds *string, const struct ofp_header *oh) { - char name_[OFP_MAX_TABLE_NAME_LEN + 1]; - - /* ofp13_table_stats is different */ - if (ofp_version > OFP12_VERSION) { - return; - } + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); + ofpraw_pull_assert(&b); - ovs_strlcpy(name_, name, sizeof name_); + struct ofputil_table_features prev_features; + struct ofputil_table_stats prev_stats; + for (int i = 0;; i++) { + struct ofputil_table_features features; + struct ofputil_table_stats stats; + int retval; - ds_put_format(string, " %d: %-8s: ", ts->table_id, name_); - ds_put_format(string, "wild=0x%05"PRIx64", ", ntohll(ts->wildcards)); - ds_put_format(string, "max=%6"PRIu32", ", ntohl(ts->max_entries)); - ds_put_format(string, "active=%"PRIu32"\n", ntohl(ts->active_count)); - ds_put_cstr(string, " "); - ds_put_format(string, "lookup=%"PRIu64", ", ntohll(ts->lookup_count)); - ds_put_format(string, "matched=%"PRIu64"\n", ntohll(ts->matched_count)); + retval = ofputil_decode_table_stats_reply(&b, &stats, &features); + if (retval) { + if (retval != EOF) { + ofp_print_error(string, retval); + } + return; + } - if (ofp_version < OFP11_VERSION) { - return; + ds_put_char(string, '\n'); + ofp_print_table_features(string, + &features, i ? &prev_features : NULL, + &stats, i ? &prev_stats : NULL); + prev_features = features; + prev_stats = stats; } +} - ds_put_cstr(string, " "); - ds_put_format(string, "match=0x%08"PRIx64", ", ntohll(ts->match)); - ds_put_format(string, "instructions=0x%08"PRIx32", ", - ntohl(ts->instructions)); - ds_put_format(string, "config=0x%08"PRIx32"\n", ntohl(ts->config)); - ds_put_cstr(string, " "); - ds_put_format(string, "write_actions=0x%08"PRIx32", ", - ntohl(ts->write_actions)); - ds_put_format(string, "apply_actions=0x%08"PRIx32"\n", - ntohl(ts->apply_actions)); - - if (ofp_version < OFP12_VERSION) { - return; +static void +ofp_print_queue_name(struct ds *string, uint32_t queue_id) +{ + if (queue_id == OFPQ_ALL) { + ds_put_cstr(string, "ALL"); + } else { + ds_put_format(string, "%"PRIu32, queue_id); } - - ds_put_cstr(string, " "); - ds_put_format(string, "write_setfields=0x%016"PRIx64"\n", - ntohll(ts->write_setfields)); - ds_put_cstr(string, " "); - ds_put_format(string, "apply_setfields=0x%016"PRIx64"\n", - ntohll(ts->apply_setfields)); - ds_put_cstr(string, " "); - ds_put_format(string, "metadata_match=0x%016"PRIx64"\n", - ntohll(ts->metadata_match)); - ds_put_cstr(string, " "); - ds_put_format(string, "metadata_write=0x%016"PRIx64"\n", - ntohll(ts->metadata_write)); } static void -ofp_print_ofpst_table_reply13(struct ds *string, const struct ofp_header *oh, - int verbosity) +ofp_print_ofpst_queue_request(struct ds *string, const struct ofp_header *oh) { - struct ofp13_table_stats *ts; - struct ofpbuf b; - size_t n; - - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - ofpraw_pull_assert(&b); + struct ofputil_queue_stats_request oqsr; + enum ofperr error; - n = b.size / sizeof *ts; - ds_put_format(string, " %zu tables\n", n); - if (verbosity < 1) { + error = ofputil_decode_queue_stats_request(oh, &oqsr); + if (error) { + ds_put_format(string, "***decode error: %s***\n", ofperr_get_name(error)); return; } - for (;;) { - ts = ofpbuf_try_pull(&b, sizeof *ts); - if (!ts) { - return; - } - ds_put_format(string, - " %d: active=%"PRIu32", lookup=%"PRIu64 \ - ", matched=%"PRIu64"\n", - ts->table_id, ntohl(ts->active_count), - ntohll(ts->lookup_count), ntohll(ts->matched_count)); - } -} - -static void -ofp_print_ofpst_table_reply12(struct ds *string, const struct ofp_header *oh, - int verbosity) -{ - struct ofp12_table_stats *ts; - struct ofpbuf b; - size_t n; - - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - ofpraw_pull_assert(&b); - - n = b.size / sizeof *ts; - ds_put_format(string, " %zu tables\n", n); - if (verbosity < 1) { - return; - } - - for (;;) { - ts = ofpbuf_try_pull(&b, sizeof *ts); - if (!ts) { - return; - } - - ofp_print_one_ofpst_table_reply(string, OFP12_VERSION, ts->name, ts); - } -} - -static void -ofp_print_ofpst_table_reply11(struct ds *string, const struct ofp_header *oh, - int verbosity) -{ - struct ofp11_table_stats *ts; - struct ofpbuf b; - size_t n; - - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - ofpraw_pull_assert(&b); - - n = b.size / sizeof *ts; - ds_put_format(string, " %zu tables\n", n); - if (verbosity < 1) { - return; - } - - for (;;) { - struct ofp12_table_stats ts12; - - ts = ofpbuf_try_pull(&b, sizeof *ts); - if (!ts) { - return; - } - - ts12.table_id = ts->table_id; - ts12.wildcards = htonll(ntohl(ts->wildcards)); - ts12.max_entries = ts->max_entries; - ts12.active_count = ts->active_count; - ts12.lookup_count = ts->lookup_count; - ts12.matched_count = ts->matched_count; - ts12.match = htonll(ntohl(ts->match)); - ts12.instructions = ts->instructions; - ts12.config = ts->config; - ts12.write_actions = ts->write_actions; - ts12.apply_actions = ts->apply_actions; - ofp_print_one_ofpst_table_reply(string, OFP11_VERSION, ts->name, &ts12); - } -} - -static void -ofp_print_ofpst_table_reply10(struct ds *string, const struct ofp_header *oh, - int verbosity) -{ - struct ofp10_table_stats *ts; - struct ofpbuf b; - size_t n; - - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - ofpraw_pull_assert(&b); - - n = b.size / sizeof *ts; - ds_put_format(string, " %zu tables\n", n); - if (verbosity < 1) { - return; - } - - for (;;) { - struct ofp12_table_stats ts12; - - ts = ofpbuf_try_pull(&b, sizeof *ts); - if (!ts) { - return; - } - - ts12.table_id = ts->table_id; - ts12.wildcards = htonll(ntohl(ts->wildcards)); - ts12.max_entries = ts->max_entries; - ts12.active_count = ts->active_count; - ts12.lookup_count = get_32aligned_be64(&ts->lookup_count); - ts12.matched_count = get_32aligned_be64(&ts->matched_count); - ofp_print_one_ofpst_table_reply(string, OFP10_VERSION, ts->name, &ts12); - } -} - -static void -ofp_print_ofpst_table_reply(struct ds *string, const struct ofp_header *oh, - int verbosity) -{ - switch ((enum ofp_version)oh->version) { - case OFP13_VERSION: - ofp_print_ofpst_table_reply13(string, oh, verbosity); - break; - - case OFP12_VERSION: - ofp_print_ofpst_table_reply12(string, oh, verbosity); - break; - - case OFP11_VERSION: - ofp_print_ofpst_table_reply11(string, oh, verbosity); - break; - - case OFP10_VERSION: - ofp_print_ofpst_table_reply10(string, oh, verbosity); - break; - - default: - NOT_REACHED(); - } -} - -static void -ofp_print_queue_name(struct ds *string, uint32_t queue_id) -{ - if (queue_id == OFPQ_ALL) { - ds_put_cstr(string, "ALL"); - } else { - ds_put_format(string, "%"PRIu32, queue_id); - } -} - -static void -ofp_print_ofpst_queue_request(struct ds *string, const struct ofp_header *oh) -{ - struct ofputil_queue_stats_request oqsr; - enum ofperr error; - - error = ofputil_decode_queue_stats_request(oh, &oqsr); - if (error) { - ds_put_format(string, "***decode error: %s***\n", ofperr_get_name(error)); - return; - } - - ds_put_cstr(string, "port="); + ds_put_cstr(string, " port="); ofputil_format_port(oqsr.port_no, string); ds_put_cstr(string, " queue="); @@ -1715,14 +1803,12 @@ static void ofp_print_ofpst_queue_reply(struct ds *string, const struct ofp_header *oh, int verbosity) { - struct ofpbuf b; - - ds_put_format(string, " %zu queues\n", ofputil_count_queue_stats(oh)); + ds_put_format(string, " %"PRIuSIZE" queues\n", ofputil_count_queue_stats(oh)); if (verbosity < 1) { return; } - ofpbuf_use_const(&b, oh, ntohs(oh->length)); + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); for (;;) { struct ofputil_queue_stats qs; int retval; @@ -1756,35 +1842,41 @@ ofp_print_ofpst_queue_reply(struct ds *string, const struct ofp_header *oh, } static void -ofp_print_ofpst_port_desc_reply(struct ds *string, - const struct ofp_header *oh) +ofp_print_ofpst_port_desc_request(struct ds *string, + const struct ofp_header *oh) { - struct ofpbuf b; + enum ofperr error; + ofp_port_t port; - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - ofpraw_pull_assert(&b); - ds_put_char(string, '\n'); - ofp_print_phy_ports(string, oh->version, &b); + error = ofputil_decode_port_desc_stats_request(oh, &port); + if (error) { + ofp_print_error(string, error); + return; + } + + ds_put_cstr(string, " port="); + ofputil_format_port(port, string); } static void -ofp_print_stats_request(struct ds *string, const struct ofp_header *oh) +ofp_print_ofpst_port_desc_reply(struct ds *string, + const struct ofp_header *oh) { - uint16_t flags = ofpmp_flags(oh); - - if (flags) { - ds_put_format(string, " ***unknown flags 0x%04"PRIx16"***", flags); - } + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); + ofpraw_pull_assert(&b); + ds_put_char(string, '\n'); + ofp_print_phy_ports(string, oh->version, &b); } static void -ofp_print_stats_reply(struct ds *string, const struct ofp_header *oh) +ofp_print_stats(struct ds *string, const struct ofp_header *oh) { uint16_t flags = ofpmp_flags(oh); if (flags) { ds_put_cstr(string, " flags="); - if (flags & OFPSF_REPLY_MORE) { + if ((!ofpmsg_is_stat_request(oh) || oh->version >= OFP13_VERSION) + && (flags & OFPSF_REPLY_MORE)) { ds_put_cstr(string, "[more]"); flags &= ~OFPSF_REPLY_MORE; } @@ -1800,27 +1892,19 @@ ofp_print_echo(struct ds *string, const struct ofp_header *oh, int verbosity) { size_t len = ntohs(oh->length); - ds_put_format(string, " %zu bytes of payload\n", len - sizeof *oh); + ds_put_format(string, " %"PRIuSIZE" bytes of payload\n", len - sizeof *oh); if (verbosity > 1) { ds_put_hex_dump(string, oh + 1, len - sizeof *oh, 0, true); } } static void -ofp_print_role_message(struct ds *string, const struct ofp_header *oh) +ofp_print_role_generic(struct ds *string, enum ofp12_controller_role role, + uint64_t generation_id) { - struct ofputil_role_request rr; - enum ofperr error; - - error = ofputil_decode_role_message(oh, &rr); - if (error) { - ofp_print_error(string, error); - return; - } - ds_put_cstr(string, " role="); - switch (rr.role) { + switch (role) { case OFPCR12_ROLE_NOCHANGE: ds_put_cstr(string, "nochange"); break; @@ -1834,11 +1918,58 @@ ofp_print_role_message(struct ds *string, const struct ofp_header *oh) ds_put_cstr(string, "slave"); break; default: - NOT_REACHED(); + OVS_NOT_REACHED(); + } + + if (generation_id != UINT64_MAX) { + ds_put_format(string, " generation_id=%"PRIu64, generation_id); + } +} + +static void +ofp_print_role_message(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_role_request rr; + enum ofperr error; + + error = ofputil_decode_role_message(oh, &rr); + if (error) { + ofp_print_error(string, error); + return; + } + + ofp_print_role_generic(string, rr.role, rr.have_generation_id ? rr.generation_id : UINT64_MAX); +} + +static void +ofp_print_role_status_message(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_role_status rs; + enum ofperr error; + + error = ofputil_decode_role_status(oh, &rs); + if (error) { + ofp_print_error(string, error); + return; } - if (rr.have_generation_id) { - ds_put_format(string, " generation_id=%"PRIu64, rr.generation_id); + ofp_print_role_generic(string, rs.role, rs.generation_id); + + ds_put_cstr(string, " reason="); + + switch (rs.reason) { + case OFPCRR_MASTER_REQUEST: + ds_put_cstr(string, "master_request"); + break; + case OFPCRR_CONFIG: + ds_put_cstr(string, "configuration_changed"); + break; + case OFPCRR_EXPERIMENTER: + ds_put_cstr(string, "experimenter_data_changed"); + break; + case OFPCRR_N_REASONS: + default: + OVS_NOT_REACHED(); } } @@ -1895,70 +2026,149 @@ ofp_port_reason_to_string(enum ofp_port_reason reason, case OFPPR_MODIFY: return "modify"; + case OFPPR_N_REASONS: default: snprintf(reasonbuf, bufsize, "%d", (int) reason); return reasonbuf; } } -static void -ofp_print_nxt_set_async_config(struct ds *string, - const struct nx_async_config *nac) +/* Returns a string form of 'reason'. The return value is either a statically + * allocated constant string or the 'bufsize'-byte buffer 'reasonbuf'. + * 'bufsize' should be at least OFP_ASYNC_CONFIG_REASON_BUFSIZE. */ +static const char* +ofp_role_reason_to_string(enum ofp14_controller_role_reason reason, + char *reasonbuf, size_t bufsize) { - int i; + switch (reason) { + case OFPCRR_MASTER_REQUEST: + return "master_request"; - for (i = 0; i < 2; i++) { - int j; + case OFPCRR_CONFIG: + return "configuration_changed"; - ds_put_format(string, "\n %s:\n", i == 0 ? "master" : "slave"); + case OFPCRR_EXPERIMENTER: + return "experimenter_data_changed"; - ds_put_cstr(string, " PACKET_IN:"); - for (j = 0; j < 32; j++) { - if (nac->packet_in_mask[i] & htonl(1u << j)) { - char reasonbuf[OFPUTIL_PACKET_IN_REASON_BUFSIZE]; - const char *reason; + case OFPCRR_N_REASONS: + default: + snprintf(reasonbuf, bufsize, "%d", (int) reason); + return reasonbuf; + } +} - reason = ofputil_packet_in_reason_to_string(j, reasonbuf, - sizeof reasonbuf); - ds_put_format(string, " %s", reason); - } - } - if (!nac->packet_in_mask[i]) { - ds_put_cstr(string, " (off)"); - } - ds_put_char(string, '\n'); +/* Returns a string form of 'reason'. The return value is either a statically + * allocated constant string or the 'bufsize'-byte buffer 'reasonbuf'. + * 'bufsize' should be at least OFP_ASYNC_CONFIG_REASON_BUFSIZE. */ +static const char* +ofp_table_reason_to_string(enum ofp14_table_reason reason, + char *reasonbuf, size_t bufsize) +{ + switch (reason) { + case OFPTR_VACANCY_DOWN: + return "vacancy_down"; - ds_put_cstr(string, " PORT_STATUS:"); - for (j = 0; j < 32; j++) { - if (nac->port_status_mask[i] & htonl(1u << j)) { - char reasonbuf[OFP_PORT_REASON_BUFSIZE]; - const char *reason; + case OFPTR_VACANCY_UP: + return "vacancy_up"; - reason = ofp_port_reason_to_string(j, reasonbuf, - sizeof reasonbuf); - ds_put_format(string, " %s", reason); - } - } - if (!nac->port_status_mask[i]) { - ds_put_cstr(string, " (off)"); - } - ds_put_char(string, '\n'); + default: + snprintf(reasonbuf, bufsize, "%d", (int) reason); + return reasonbuf; + } +} + +/* Returns a string form of 'reason'. The return value is either a statically + * allocated constant string or the 'bufsize'-byte buffer 'reasonbuf'. + * 'bufsize' should be at least OFP_ASYNC_CONFIG_REASON_BUFSIZE. */ +static const char* +ofp_requestforward_reason_to_string(enum ofp14_requestforward_reason reason, + char *reasonbuf, size_t bufsize) +{ + switch (reason) { + case OFPRFR_GROUP_MOD: + return "group_mod_request"; + + case OFPRFR_METER_MOD: + return "meter_mod_request"; + + case OFPRFR_N_REASONS: + default: + snprintf(reasonbuf, bufsize, "%d", (int) reason); + return reasonbuf; + } +} + +static const char * +ofp_async_config_reason_to_string(uint32_t reason, + enum ofputil_async_msg_type type, + char *reasonbuf, size_t bufsize) +{ + switch (type) { + case OAM_PACKET_IN: + return ofputil_packet_in_reason_to_string(reason, reasonbuf, bufsize); + + case OAM_PORT_STATUS: + return ofp_port_reason_to_string(reason, reasonbuf, bufsize); - ds_put_cstr(string, " FLOW_REMOVED:"); - for (j = 0; j < 32; j++) { - if (nac->flow_removed_mask[i] & htonl(1u << j)) { - char reasonbuf[OFP_FLOW_REMOVED_REASON_BUFSIZE]; - const char *reason; + case OAM_FLOW_REMOVED: + return ofp_flow_removed_reason_to_string(reason, reasonbuf, bufsize); + + case OAM_ROLE_STATUS: + return ofp_role_reason_to_string(reason, reasonbuf, bufsize); + + case OAM_TABLE_STATUS: + return ofp_table_reason_to_string(reason, reasonbuf, bufsize); + + case OAM_REQUESTFORWARD: + return ofp_requestforward_reason_to_string(reason, reasonbuf, bufsize); + + case OAM_N_TYPES: + default: + return "Unknown asynchronous configuration message type"; + } +} + + +#define OFP_ASYNC_CONFIG_REASON_BUFSIZE (INT_STRLEN(int) + 1) +static void +ofp_print_set_async_config(struct ds *string, const struct ofp_header *oh, + enum ofptype type) +{ + struct ofputil_async_cfg basis = OFPUTIL_ASYNC_CFG_INIT; + struct ofputil_async_cfg ac; + + bool is_reply = type == OFPTYPE_GET_ASYNC_REPLY; + enum ofperr error = ofputil_decode_set_async_config(oh, is_reply, + &basis, &ac); + if (error) { + ofp_print_error(string, error); + return; + } - reason = ofp_flow_removed_reason_to_string(j, reasonbuf, - sizeof reasonbuf); - ds_put_format(string, " %s", reason); + for (int i = 0; i < 2; i++) { + ds_put_format(string, "\n %s:\n", i == 0 ? "master" : "slave"); + for (uint32_t type = 0; type < OAM_N_TYPES; type++) { + ds_put_format(string, "%16s:", + ofputil_async_msg_type_to_string(type)); + + uint32_t role = i == 0 ? ac.master[type] : ac.slave[type]; + for (int j = 0; j < 32; j++) { + if (role & (1u << j)) { + char reasonbuf[OFP_ASYNC_CONFIG_REASON_BUFSIZE]; + const char *reason; + + reason = ofp_async_config_reason_to_string( + j, type, reasonbuf, sizeof reasonbuf); + if (reason[0]) { + ds_put_format(string, " %s", reason); + } + } } + if (!role) { + ds_put_cstr(string, " (off)"); + } + ds_put_char(string, '\n'); } - if (!nac->flow_removed_mask[i]) { - ds_put_cstr(string, " (off)"); - } - ds_put_char(string, '\n'); } } @@ -1998,9 +2208,7 @@ static void ofp_print_nxst_flow_monitor_request(struct ds *string, const struct ofp_header *oh) { - struct ofpbuf b; - - ofpbuf_use_const(&b, oh, ntohs(oh->length)); + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); for (;;) { struct ofputil_flow_monitor_request request; int retval; @@ -2037,11 +2245,9 @@ ofp_print_nxst_flow_monitor_reply(struct ds *string, const struct ofp_header *oh) { uint64_t ofpacts_stub[1024 / 8]; - struct ofpbuf ofpacts; - struct ofpbuf b; + struct ofpbuf ofpacts = OFPBUF_STUB_INITIALIZER(ofpacts_stub); + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - ofpbuf_use_stub(&ofpacts, ofpacts_stub, sizeof ofpacts_stub); for (;;) { char reasonbuf[OFP_FLOW_REMOVED_REASON_BUFSIZE]; struct ofputil_flow_update update; @@ -2098,6 +2304,7 @@ ofp_print_nxst_flow_monitor_reply(struct ds *string, if (string->string[string->length - 1] != ' ') { ds_put_char(string, ' '); } + ds_put_cstr(string, "actions="); ofpacts_format(update.ofpacts, update.ofpacts_len, string); } } @@ -2119,6 +2326,12 @@ ofp_print_version(const struct ofp_header *oh, case OFP13_VERSION: ds_put_cstr(string, " (OF1.3)"); break; + case OFP14_VERSION: + ds_put_cstr(string, " (OF1.4)"); + break; + case OFP15_VERSION: + ds_put_cstr(string, " (OF1.5)"); + break; default: ds_put_format(string, " (OF 0x%02"PRIx8")", oh->version); break; @@ -2135,53 +2348,113 @@ ofp_header_to_string__(const struct ofp_header *oh, enum ofpraw raw, } static void -ofp_print_not_implemented(struct ds *string) +ofp_print_bucket_id(struct ds *s, const char *label, uint32_t bucket_id, + enum ofp_version ofp_version) { - ds_put_cstr(string, "NOT IMPLEMENTED YET!\n"); + if (ofp_version < OFP15_VERSION) { + return; + } + + ds_put_cstr(s, label); + + switch (bucket_id) { + case OFPG15_BUCKET_FIRST: + ds_put_cstr(s, "first"); + break; + case OFPG15_BUCKET_LAST: + ds_put_cstr(s, "last"); + break; + case OFPG15_BUCKET_ALL: + ds_put_cstr(s, "all"); + break; + default: + ds_put_format(s, "%"PRIu32, bucket_id); + break; + } + + ds_put_char(s, ','); } static void ofp_print_group(struct ds *s, uint32_t group_id, uint8_t type, - struct list *p_buckets) + const struct ovs_list *p_buckets, + const struct ofputil_group_props *props, + enum ofp_version ofp_version, bool suppress_type) { - static const char *type_str[] = { "all", "select", "indirect", - "ff", "unknown" }; struct ofputil_bucket *bucket; - ds_put_format(s, "group_id=%"PRIu32",type=%s", - group_id, type_str[type > 4 ? 4 : type]); + ds_put_format(s, "group_id=%"PRIu32, group_id); + + if (!suppress_type) { + static const char *type_str[] = { "all", "select", "indirect", + "ff", "unknown" }; + ds_put_format(s, ",type=%s", type_str[type > 4 ? 4 : type]); + } + + if (props->selection_method[0]) { + ds_put_format(s, ",selection_method=%s", props->selection_method); + if (props->selection_method_param) { + ds_put_format(s, ",selection_method_param=%"PRIu64, + props->selection_method_param); + } + + size_t n = bitmap_count1(props->fields.used.bm, MFF_N_IDS); + if (n == 1) { + ds_put_cstr(s, ",fields="); + oxm_format_field_array(s, &props->fields); + } else if (n > 1) { + ds_put_cstr(s, ",fields("); + oxm_format_field_array(s, &props->fields); + ds_put_char(s, ')'); + } + } + if (!p_buckets) { return; } + ds_put_char(s, ','); + LIST_FOR_EACH (bucket, list_node, p_buckets) { - ds_put_cstr(s, ",bucket="); + ds_put_cstr(s, "bucket="); - if (bucket->weight != 1) { + ofp_print_bucket_id(s, "bucket_id:", bucket->bucket_id, ofp_version); + if (bucket->weight != (type == OFPGT11_SELECT ? 1 : 0)) { ds_put_format(s, "weight:%"PRIu16",", bucket->weight); } if (bucket->watch_port != OFPP_NONE) { ds_put_format(s, "watch_port:%"PRIu32",", bucket->watch_port); } - if (bucket->watch_group != OFPG11_ANY) { + if (bucket->watch_group != OFPG_ANY) { ds_put_format(s, "watch_group:%"PRIu32",", bucket->watch_group); } + ds_put_cstr(s, "actions="); ofpacts_format(bucket->ofpacts, bucket->ofpacts_len, s); + ds_put_char(s, ','); } + + ds_chomp(s, ','); } static void -ofp_print_group_desc(struct ds *s, const struct ofp_header *oh) +ofp_print_ofpst_group_desc_request(struct ds *string, + const struct ofp_header *oh) { - struct ofpbuf b; + uint32_t group_id = ofputil_decode_group_desc_request(oh); + ds_put_cstr(string, " group_id="); + ofputil_format_group(group_id, string); +} - ofpbuf_use_const(&b, oh, ntohs(oh->length)); +static void +ofp_print_group_desc(struct ds *s, const struct ofp_header *oh) +{ + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); for (;;) { struct ofputil_group_desc gd; int retval; - retval = ofputil_decode_group_desc_reply(&gd, &b); + retval = ofputil_decode_group_desc_reply(&gd, &b, oh->version); if (retval) { if (retval != EOF) { ds_put_cstr(s, " ***parse error***"); @@ -2191,7 +2464,9 @@ ofp_print_group_desc(struct ds *s, const struct ofp_header *oh) ds_put_char(s, '\n'); ds_put_char(s, ' '); - ofp_print_group(s, gd.group_id, gd.type, &gd.buckets); + ofp_print_group(s, gd.group_id, gd.type, &gd.buckets, &gd.props, + oh->version, false); + ofputil_bucket_list_destroy(&gd.buckets); } } @@ -2214,11 +2489,7 @@ ofp_print_ofpst_group_request(struct ds *string, const struct ofp_header *oh) static void ofp_print_group_stats(struct ds *s, const struct ofp_header *oh) { - struct ofpbuf b; - uint32_t bucket_i; - - ofpbuf_use_const(&b, oh, ntohs(oh->length)); - + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); for (;;) { struct ofputil_group_stats gs; int retval; @@ -2245,7 +2516,7 @@ ofp_print_group_stats(struct ds *s, const struct ofp_header *oh) ds_put_format(s, "packet_count=%"PRIu64",", gs.packet_count); ds_put_format(s, "byte_count=%"PRIu64"", gs.byte_count); - for (bucket_i = 0; bucket_i < gs.n_buckets; bucket_i++) { + for (uint32_t bucket_i = 0; bucket_i < gs.n_buckets; bucket_i++) { if (gs.bucket_stats[bucket_i].packet_count != UINT64_MAX) { ds_put_format(s, ",bucket%"PRIu32":", bucket_i); ds_put_format(s, "packet_count=%"PRIu64",", gs.bucket_stats[bucket_i].packet_count); @@ -2257,10 +2528,23 @@ ofp_print_group_stats(struct ds *s, const struct ofp_header *oh) } } +static const char * +group_type_to_string(enum ofp11_group_type type) +{ + switch (type) { + case OFPGT11_ALL: return "all"; + case OFPGT11_SELECT: return "select"; + case OFPGT11_INDIRECT: return "indirect"; + case OFPGT11_FF: return "fast failover"; + default: OVS_NOT_REACHED(); + } +} + static void ofp_print_group_features(struct ds *string, const struct ofp_header *oh) { struct ofputil_group_features features; + int i; ofputil_decode_group_features_reply(oh, &features); @@ -2269,33 +2553,62 @@ ofp_print_group_features(struct ds *string, const struct ofp_header *oh) ds_put_format(string, " Capabilities: 0x%"PRIx32"\n", features.capabilities); - if (features.types & (1u << OFPGT11_ALL)) { - ds_put_format(string, " All group :\n"); - ds_put_format(string, - " max_groups = %#"PRIx32" actions=0x%08"PRIx32"\n", - features.max_groups[0], features.actions[0]); + for (i = 0; i < OFPGT12_N_TYPES; i++) { + if (features.types & (1u << i)) { + ds_put_format(string, " %s group:\n", group_type_to_string(i)); + ds_put_format(string, " max_groups=%#"PRIx32"\n", + features.max_groups[i]); + ds_put_format(string, " actions: "); + ofpact_bitmap_format(features.ofpacts[i], string); + ds_put_char(string, '\n'); + } } +} - if (features.types & (1u << OFPGT11_SELECT)) { - ds_put_format(string, " Select group :\n"); - ds_put_format(string, " max_groups = %#"PRIx32" " - "actions=0x%08"PRIx32"\n", - features.max_groups[1], features.actions[1]); - } +static void +ofp_print_group_mod__(struct ds *s, enum ofp_version ofp_version, + const struct ofputil_group_mod *gm) +{ + bool bucket_command = false; + + ds_put_char(s, '\n'); + + ds_put_char(s, ' '); + switch (gm->command) { + case OFPGC11_ADD: + ds_put_cstr(s, "ADD"); + break; + + case OFPGC11_MODIFY: + ds_put_cstr(s, "MOD"); + break; + + case OFPGC11_DELETE: + ds_put_cstr(s, "DEL"); + break; + + case OFPGC15_INSERT_BUCKET: + ds_put_cstr(s, "INSERT_BUCKET"); + bucket_command = true; + break; - if (features.types & (1u << OFPGT11_INDIRECT)) { - ds_put_format(string, " Indirect group :\n"); - ds_put_format(string, " max_groups = %#"PRIx32" " - "actions=0x%08"PRIx32"\n", - features.max_groups[2], features.actions[2]); + case OFPGC15_REMOVE_BUCKET: + ds_put_cstr(s, "REMOVE_BUCKET"); + bucket_command = true; + break; + + default: + ds_put_format(s, "cmd:%"PRIu16"", gm->command); } + ds_put_char(s, ' '); - if (features.types & (1u << OFPGT11_FF)) { - ds_put_format(string, " Fast Failover group :\n"); - ds_put_format(string, " max_groups = %#"PRIx32" " - "actions=0x%08"PRIx32"\n", - features.max_groups[3], features.actions[3]); + if (bucket_command) { + ofp_print_bucket_id(s, "command_bucket_id:", + gm->command_bucket_id, ofp_version); } + + ofp_print_group(s, gm->group_id, gm->type, &gm->buckets, &gm->props, + ofp_version, bucket_command); } static void @@ -2309,29 +2622,501 @@ ofp_print_group_mod(struct ds *s, const struct ofp_header *oh) ofp_print_error(s, error); return; } + ofp_print_group_mod__(s, oh->version, &gm); + ofputil_bucket_list_destroy(&gm.buckets); +} + +static void +print_table_action_features(struct ds *s, + const struct ofputil_table_action_features *taf) +{ + if (taf->ofpacts) { + ds_put_cstr(s, " actions: "); + ofpact_bitmap_format(taf->ofpacts, s); + ds_put_char(s, '\n'); + } + + if (!bitmap_is_all_zeros(taf->set_fields.bm, MFF_N_IDS)) { + int i; + + ds_put_cstr(s, " supported on Set-Field:"); + BITMAP_FOR_EACH_1 (i, MFF_N_IDS, taf->set_fields.bm) { + ds_put_format(s, " %s", mf_from_id(i)->name); + } + ds_put_char(s, '\n'); + } +} + +static bool +table_action_features_equal(const struct ofputil_table_action_features *a, + const struct ofputil_table_action_features *b) +{ + return (a->ofpacts == b->ofpacts + && bitmap_equal(a->set_fields.bm, b->set_fields.bm, MFF_N_IDS)); +} + +static bool +table_action_features_empty(const struct ofputil_table_action_features *taf) +{ + return !taf->ofpacts && bitmap_is_all_zeros(taf->set_fields.bm, MFF_N_IDS); +} + +static void +print_table_instruction_features( + struct ds *s, + const struct ofputil_table_instruction_features *tif, + const struct ofputil_table_instruction_features *prev_tif) +{ + int start, end; + + if (!bitmap_is_all_zeros(tif->next, 255)) { + ds_put_cstr(s, " next tables: "); + for (start = bitmap_scan(tif->next, 1, 0, 255); start < 255; + start = bitmap_scan(tif->next, 1, end, 255)) { + end = bitmap_scan(tif->next, 0, start + 1, 255); + if (end == start + 1) { + ds_put_format(s, "%d,", start); + } else { + ds_put_format(s, "%d-%d,", start, end - 1); + } + } + ds_chomp(s, ','); + if (ds_last(s) == ' ') { + ds_put_cstr(s, "none"); + } + ds_put_char(s, '\n'); + } + + if (tif->instructions) { + if (prev_tif && tif->instructions == prev_tif->instructions) { + ds_put_cstr(s, " (same instructions)\n"); + } else { + ds_put_cstr(s, " instructions: "); + int i; + + for (i = 0; i < 32; i++) { + if (tif->instructions & (1u << i)) { + ds_put_format(s, "%s,", ovs_instruction_name_from_type(i)); + } + } + ds_chomp(s, ','); + ds_put_char(s, '\n'); + } + } + + if (prev_tif + && table_action_features_equal(&tif->write, &prev_tif->write) + && table_action_features_equal(&tif->apply, &prev_tif->apply) + && !bitmap_is_all_zeros(tif->write.set_fields.bm, MFF_N_IDS)) { + ds_put_cstr(s, " (same actions)\n"); + } else if (!table_action_features_equal(&tif->write, &tif->apply)) { + ds_put_cstr(s, " Write-Actions features:\n"); + print_table_action_features(s, &tif->write); + ds_put_cstr(s, " Apply-Actions features:\n"); + print_table_action_features(s, &tif->apply); + } else if (tif->write.ofpacts + || !bitmap_is_all_zeros(tif->write.set_fields.bm, MFF_N_IDS)) { + ds_put_cstr(s, " Write-Actions and Apply-Actions features:\n"); + print_table_action_features(s, &tif->write); + } +} +static bool +table_instruction_features_equal( + const struct ofputil_table_instruction_features *a, + const struct ofputil_table_instruction_features *b) +{ + return (bitmap_equal(a->next, b->next, 255) + && a->instructions == b->instructions + && table_action_features_equal(&a->write, &b->write) + && table_action_features_equal(&a->apply, &b->apply)); +} + +static bool +table_instruction_features_empty( + const struct ofputil_table_instruction_features *tif) +{ + return (bitmap_is_all_zeros(tif->next, 255) + && !tif->instructions + && table_action_features_empty(&tif->write) + && table_action_features_empty(&tif->apply)); +} + +static bool +table_features_equal(const struct ofputil_table_features *a, + const struct ofputil_table_features *b) +{ + return (a->metadata_match == b->metadata_match + && a->metadata_write == b->metadata_write + && a->miss_config == b->miss_config + && a->supports_eviction == b->supports_eviction + && a->supports_vacancy_events == b->supports_vacancy_events + && a->max_entries == b->max_entries + && table_instruction_features_equal(&a->nonmiss, &b->nonmiss) + && table_instruction_features_equal(&a->miss, &b->miss) + && bitmap_equal(a->match.bm, b->match.bm, MFF_N_IDS)); +} + +static bool +table_features_empty(const struct ofputil_table_features *tf) +{ + return (!tf->metadata_match + && !tf->metadata_write + && tf->miss_config == OFPUTIL_TABLE_MISS_DEFAULT + && tf->supports_eviction < 0 + && tf->supports_vacancy_events < 0 + && !tf->max_entries + && table_instruction_features_empty(&tf->nonmiss) + && table_instruction_features_empty(&tf->miss) + && bitmap_is_all_zeros(tf->match.bm, MFF_N_IDS)); +} + +static bool +table_stats_equal(const struct ofputil_table_stats *a, + const struct ofputil_table_stats *b) +{ + return (a->active_count == b->active_count + && a->lookup_count == b->lookup_count + && a->matched_count == b->matched_count); +} + +void +ofp_print_table_features(struct ds *s, + const struct ofputil_table_features *features, + const struct ofputil_table_features *prev_features, + const struct ofputil_table_stats *stats, + const struct ofputil_table_stats *prev_stats) +{ + int i; + + ds_put_format(s, " table %"PRIu8, features->table_id); + if (features->name[0]) { + ds_put_format(s, " (\"%s\")", features->name); + } + ds_put_char(s, ':'); + + bool same_stats = prev_stats && table_stats_equal(stats, prev_stats); + bool same_features = prev_features && table_features_equal(features, + prev_features); + if ((!stats || same_stats) && same_features) { + ds_put_cstr(s, " ditto"); + return; + } ds_put_char(s, '\n'); + if (stats) { + ds_put_format(s, " active=%"PRIu32", ", stats->active_count); + ds_put_format(s, "lookup=%"PRIu64", ", stats->lookup_count); + ds_put_format(s, "matched=%"PRIu64"\n", stats->matched_count); + } + if (same_features) { + if (!table_features_empty(features)) { + ds_put_cstr(s, " (same features)\n"); + } + return; + } + if (features->metadata_match || features->metadata_write) { + ds_put_format(s, " metadata: match=%#"PRIx64" write=%#"PRIx64"\n", + ntohll(features->metadata_match), + ntohll(features->metadata_write)); + } - ds_put_char(s, ' '); - switch (gm.command) { - case OFPGC11_ADD: - ds_put_cstr(s, "ADD"); - break; + if (features->miss_config != OFPUTIL_TABLE_MISS_DEFAULT) { + ds_put_format(s, " config=%s\n", + ofputil_table_miss_to_string(features->miss_config)); + } - case OFPGC11_MODIFY: - ds_put_cstr(s, "MOD"); + if (features->supports_eviction >= 0) { + ds_put_format(s, " eviction: %ssupported\n", + features->supports_eviction ? "" : "not "); + + } + if (features->supports_vacancy_events >= 0) { + ds_put_format(s, " vacancy events: %ssupported\n", + features->supports_vacancy_events ? "" : "not "); + + } + + if (features->max_entries) { + ds_put_format(s, " max_entries=%"PRIu32"\n", features->max_entries); + } + + const struct ofputil_table_instruction_features *prev_nonmiss + = prev_features ? &prev_features->nonmiss : NULL; + const struct ofputil_table_instruction_features *prev_miss + = prev_features ? &prev_features->miss : NULL; + if (prev_features + && table_instruction_features_equal(&features->nonmiss, prev_nonmiss) + && table_instruction_features_equal(&features->miss, prev_miss)) { + if (!table_instruction_features_empty(&features->nonmiss)) { + ds_put_cstr(s, " (same instructions)\n"); + } + } else if (!table_instruction_features_equal(&features->nonmiss, + &features->miss)) { + ds_put_cstr(s, " instructions (other than table miss):\n"); + print_table_instruction_features(s, &features->nonmiss, prev_nonmiss); + ds_put_cstr(s, " instructions (table miss):\n"); + print_table_instruction_features(s, &features->miss, prev_miss); + } else if (!table_instruction_features_empty(&features->nonmiss)) { + ds_put_cstr(s, " instructions (table miss and others):\n"); + print_table_instruction_features(s, &features->nonmiss, prev_nonmiss); + } + + if (!bitmap_is_all_zeros(features->match.bm, MFF_N_IDS)) { + if (prev_features + && bitmap_equal(features->match.bm, prev_features->match.bm, + MFF_N_IDS)) { + ds_put_cstr(s, " (same matching)\n"); + } else { + ds_put_cstr(s, " matching:\n"); + BITMAP_FOR_EACH_1 (i, MFF_N_IDS, features->match.bm) { + const struct mf_field *f = mf_from_id(i); + bool mask = bitmap_is_set(features->mask.bm, i); + bool wildcard = bitmap_is_set(features->wildcard.bm, i); + + ds_put_format(s, " %s: %s\n", + f->name, + (mask ? "arbitrary mask" + : wildcard ? "exact match or wildcard" + : "must exact match")); + } + } + } +} + +static void +ofp_print_table_features_reply(struct ds *s, const struct ofp_header *oh) +{ + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); + + struct ofputil_table_features prev; + for (int i = 0; ; i++) { + struct ofputil_table_features tf; + int retval; + + retval = ofputil_decode_table_features(&b, &tf, true); + if (retval) { + if (retval != EOF) { + ofp_print_error(s, retval); + } + return; + } + + ds_put_char(s, '\n'); + ofp_print_table_features(s, &tf, i ? &prev : NULL, NULL, NULL); + prev = tf; + } +} + +static void +ofp_print_table_desc_reply(struct ds *s, const struct ofp_header *oh) +{ + struct ofpbuf b = ofpbuf_const_initializer(oh, ntohs(oh->length)); + for (;;) { + struct ofputil_table_desc td; + int retval; + + retval = ofputil_decode_table_desc(&b, &td, oh->version); + if (retval) { + if (retval != EOF) { + ofp_print_error(s, retval); + } + return; + } + ofp_print_table_desc(s, &td); + } +} + +static const char * +bundle_flags_to_name(uint32_t bit) +{ + switch (bit) { + case OFPBF_ATOMIC: + return "atomic"; + case OFPBF_ORDERED: + return "ordered"; + default: + return NULL; + } +} + +static void +ofp_print_bundle_ctrl(struct ds *s, const struct ofp_header *oh) +{ + int error; + struct ofputil_bundle_ctrl_msg bctrl; + + error = ofputil_decode_bundle_ctrl(oh, &bctrl); + if (error) { + ofp_print_error(s, error); + return; + } + + ds_put_char(s, '\n'); + + ds_put_format(s, " bundle_id=%#"PRIx32" type=", bctrl.bundle_id); + switch (bctrl.type) { + case OFPBCT_OPEN_REQUEST: + ds_put_cstr(s, "OPEN_REQUEST"); + break; + case OFPBCT_OPEN_REPLY: + ds_put_cstr(s, "OPEN_REPLY"); + break; + case OFPBCT_CLOSE_REQUEST: + ds_put_cstr(s, "CLOSE_REQUEST"); + break; + case OFPBCT_CLOSE_REPLY: + ds_put_cstr(s, "CLOSE_REPLY"); + break; + case OFPBCT_COMMIT_REQUEST: + ds_put_cstr(s, "COMMIT_REQUEST"); break; + case OFPBCT_COMMIT_REPLY: + ds_put_cstr(s, "COMMIT_REPLY"); + break; + case OFPBCT_DISCARD_REQUEST: + ds_put_cstr(s, "DISCARD_REQUEST"); + break; + case OFPBCT_DISCARD_REPLY: + ds_put_cstr(s, "DISCARD_REPLY"); + break; + } - case OFPGC11_DELETE: + ds_put_cstr(s, " flags="); + ofp_print_bit_names(s, bctrl.flags, bundle_flags_to_name, ' '); +} + +static void +ofp_print_bundle_add(struct ds *s, const struct ofp_header *oh, int verbosity) +{ + int error; + struct ofputil_bundle_add_msg badd; + + error = ofputil_decode_bundle_add(oh, &badd, NULL); + if (error) { + ofp_print_error(s, error); + return; + } + + ds_put_char(s, '\n'); + ds_put_format(s, " bundle_id=%#"PRIx32, badd.bundle_id); + ds_put_cstr(s, " flags="); + ofp_print_bit_names(s, badd.flags, bundle_flags_to_name, ' '); + + ds_put_char(s, '\n'); + char *msg = ofp_to_string(badd.msg, ntohs(badd.msg->length), verbosity); + ds_put_and_free_cstr(s, msg); +} + +static void +print_tlv_table(struct ds *s, struct ovs_list *mappings) +{ + struct ofputil_tlv_map *map; + + ds_put_cstr(s, " mapping table:\n"); + ds_put_cstr(s, " class\ttype\tlength\tmatch field\n"); + ds_put_cstr(s, " -----\t----\t------\t-----------"); + + LIST_FOR_EACH (map, list_node, mappings) { + ds_put_char(s, '\n'); + ds_put_format(s, " 0x%"PRIx16"\t0x%"PRIx8"\t%"PRIu8"\ttun_metadata%"PRIu16, + map->option_class, map->option_type, map->option_len, + map->index); + } +} + +static void +ofp_print_tlv_table_mod(struct ds *s, const struct ofp_header *oh) +{ + int error; + struct ofputil_tlv_table_mod ttm; + + error = ofputil_decode_tlv_table_mod(oh, &ttm); + if (error) { + ofp_print_error(s, error); + return; + } + + ds_put_cstr(s, "\n "); + + switch (ttm.command) { + case NXTTMC_ADD: + ds_put_cstr(s, "ADD"); + break; + case NXTTMC_DELETE: ds_put_cstr(s, "DEL"); break; + case NXTTMC_CLEAR: + ds_put_cstr(s, "CLEAR"); + break; + } - default: - ds_put_format(s, "cmd:%"PRIu16"", gm.command); + if (ttm.command != NXTTMC_CLEAR) { + print_tlv_table(s, &ttm.mappings); } - ds_put_char(s, ' '); - ofp_print_group(s, gm.group_id, gm.type, &gm.buckets); + ofputil_uninit_tlv_table(&ttm.mappings); +} + +static void +ofp_print_tlv_table_reply(struct ds *s, const struct ofp_header *oh) +{ + int error; + struct ofputil_tlv_table_reply ttr; + struct ofputil_tlv_map *map; + int allocated_space = 0; + + error = ofputil_decode_tlv_table_reply(oh, &ttr); + if (error) { + ofp_print_error(s, error); + return; + } + + ds_put_char(s, '\n'); + + LIST_FOR_EACH (map, list_node, &ttr.mappings) { + allocated_space += map->option_len; + } + + ds_put_format(s, " max option space=%"PRIu32" max fields=%"PRIu16"\n", + ttr.max_option_space, ttr.max_fields); + ds_put_format(s, " allocated option space=%d\n", allocated_space); + ds_put_char(s, '\n'); + print_tlv_table(s, &ttr.mappings); + + ofputil_uninit_tlv_table(&ttr.mappings); +} + +/* This function will print the request forward message. The reason for + * request forward is taken from rf.request.type */ +static void +ofp_print_requestforward(struct ds *string, const struct ofp_header *oh) +{ + struct ofputil_requestforward rf; + enum ofperr error; + + error = ofputil_decode_requestforward(oh, &rf); + if (error) { + ofp_print_error(string, error); + return; + } + + ds_put_cstr(string, " reason="); + + switch (rf.reason) { + case OFPRFR_GROUP_MOD: + ds_put_cstr(string, "group_mod"); + ofp_print_group_mod__(string, oh->version, rf.group_mod); + break; + + case OFPRFR_METER_MOD: + ds_put_cstr(string, "meter_mod"); + ofp_print_meter_mod__(string, rf.meter_mod); + break; + + case OFPRFR_N_REASONS: + OVS_NOT_REACHED(); + } + ofputil_destroy_requestforward(&rf); } static void @@ -2341,10 +3126,11 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, const void *msg = oh; ofp_header_to_string__(oh, raw, string); - switch (ofptype_from_ofpraw(raw)) { + enum ofptype type = ofptype_from_ofpraw(raw); + switch (type) { case OFPTYPE_GROUP_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_group_request(string, oh); break; @@ -2353,7 +3139,8 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, break; case OFPTYPE_GROUP_DESC_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); + ofp_print_ofpst_group_desc_request(string, oh); break; case OFPTYPE_GROUP_DESC_STATS_REPLY: @@ -2361,7 +3148,7 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, break; case OFPTYPE_GROUP_FEATURES_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); break; case OFPTYPE_GROUP_FEATURES_STATS_REPLY: @@ -2372,11 +3159,14 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, ofp_print_group_mod(string, oh); break; - case OFPTYPE_QUEUE_GET_CONFIG_REQUEST: - case OFPTYPE_QUEUE_GET_CONFIG_REPLY: case OFPTYPE_TABLE_FEATURES_STATS_REQUEST: case OFPTYPE_TABLE_FEATURES_STATS_REPLY: - ofp_print_not_implemented(string); + ofp_print_table_features_reply(string, oh); + break; + + case OFPTYPE_TABLE_DESC_REQUEST: + case OFPTYPE_TABLE_DESC_REPLY: + ofp_print_table_desc_reply(string, oh); break; case OFPTYPE_HELLO: @@ -2403,8 +3193,11 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, break; case OFPTYPE_GET_CONFIG_REPLY: + ofp_print_get_config_reply(string, oh); + break; + case OFPTYPE_SET_CONFIG: - ofp_print_switch_config(string, ofpmsg_body(oh)); + ofp_print_set_config(string, oh); break; case OFPTYPE_PACKET_IN: @@ -2431,6 +3224,10 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, ofp_print_port_mod(string, oh); break; + case OFPTYPE_TABLE_MOD: + ofp_print_table_mod(string, oh); + break; + case OFPTYPE_METER_MOD: ofp_print_meter_mod(string, oh); break; @@ -2439,90 +3236,113 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, case OFPTYPE_BARRIER_REPLY: break; + case OFPTYPE_QUEUE_GET_CONFIG_REQUEST: + ofp_print_queue_get_config_request(string, oh); + break; + + case OFPTYPE_QUEUE_GET_CONFIG_REPLY: + ofp_print_queue_get_config_reply(string, oh); + break; + case OFPTYPE_ROLE_REQUEST: case OFPTYPE_ROLE_REPLY: ofp_print_role_message(string, oh); break; + case OFPTYPE_ROLE_STATUS: + ofp_print_role_status_message(string, oh); + break; + + case OFPTYPE_REQUESTFORWARD: + ofp_print_requestforward(string, oh); + break; + + case OFPTYPE_TABLE_STATUS: + ofp_print_table_status_message(string, oh); + break; case OFPTYPE_METER_STATS_REQUEST: case OFPTYPE_METER_CONFIG_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); ofp_print_meter_stats_request(string, oh); break; case OFPTYPE_METER_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_meter_stats_reply(string, oh); break; case OFPTYPE_METER_CONFIG_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_meter_config_reply(string, oh); break; case OFPTYPE_METER_FEATURES_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_meter_features_reply(string, oh); break; case OFPTYPE_DESC_STATS_REQUEST: - case OFPTYPE_PORT_DESC_STATS_REQUEST: case OFPTYPE_METER_FEATURES_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); break; case OFPTYPE_FLOW_STATS_REQUEST: case OFPTYPE_AGGREGATE_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); ofp_print_flow_stats_request(string, oh); break; case OFPTYPE_TABLE_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); break; case OFPTYPE_PORT_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_port_request(string, oh); break; case OFPTYPE_QUEUE_STATS_REQUEST: - ofp_print_stats_request(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_queue_request(string, oh); break; case OFPTYPE_DESC_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_desc_reply(string, oh); break; case OFPTYPE_FLOW_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_flow_stats_reply(string, oh); break; case OFPTYPE_QUEUE_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_queue_reply(string, oh, verbosity); break; case OFPTYPE_PORT_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_port_reply(string, oh, verbosity); break; case OFPTYPE_TABLE_STATS_REPLY: - ofp_print_stats_reply(string, oh); - ofp_print_ofpst_table_reply(string, oh, verbosity); + ofp_print_stats(string, oh); + ofp_print_table_stats_reply(string, oh); break; case OFPTYPE_AGGREGATE_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_aggregate_stats_reply(string, oh); break; + case OFPTYPE_PORT_DESC_STATS_REQUEST: + ofp_print_stats(string, oh); + ofp_print_ofpst_port_desc_request(string, oh); + break; + case OFPTYPE_PORT_DESC_STATS_REPLY: - ofp_print_stats_reply(string, oh); + ofp_print_stats(string, oh); ofp_print_ofpst_port_desc_reply(string, oh); break; @@ -2547,7 +3367,7 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, case OFPTYPE_GET_ASYNC_REPLY: case OFPTYPE_SET_ASYNC_CONFIG: - ofp_print_nxt_set_async_config(string, ofpmsg_body(oh)); + ofp_print_set_async_config(string, oh, type); break; case OFPTYPE_GET_ASYNC_REQUEST: break; @@ -2566,6 +3386,29 @@ ofp_to_string__(const struct ofp_header *oh, enum ofpraw raw, case OFPTYPE_FLOW_MONITOR_STATS_REPLY: ofp_print_nxst_flow_monitor_reply(string, msg); break; + + case OFPTYPE_BUNDLE_CONTROL: + ofp_print_bundle_ctrl(string, msg); + break; + + case OFPTYPE_BUNDLE_ADD_MESSAGE: + ofp_print_bundle_add(string, msg, verbosity); + break; + + case OFPTYPE_NXT_TLV_TABLE_MOD: + ofp_print_tlv_table_mod(string, msg); + break; + + case OFPTYPE_NXT_TLV_TABLE_REQUEST: + break; + + case OFPTYPE_NXT_TLV_TABLE_REPLY: + ofp_print_tlv_table_reply(string, msg); + break; + + case OFPTYPE_NXT_RESUME: + ofp_print_packet_in(string, msg, verbosity); + break; } } @@ -2582,7 +3425,7 @@ ofp_to_string(const void *oh_, size_t len, int verbosity) if (!len) { ds_put_cstr(&string, "OpenFlow message is empty\n"); } else if (len < sizeof(struct ofp_header)) { - ds_put_format(&string, "OpenFlow packet too short (only %zu bytes):\n", + ds_put_format(&string, "OpenFlow packet too short (only %"PRIuSIZE" bytes):\n", len); } else if (ntohs(oh->length) > len) { enum ofperr error; @@ -2595,11 +3438,11 @@ ofp_to_string(const void *oh_, size_t len, int verbosity) } ds_put_format(&string, - "(***truncated to %zu bytes from %"PRIu16"***)\n", + "(***truncated to %"PRIuSIZE" bytes from %"PRIu16"***)\n", len, ntohs(oh->length)); } else if (ntohs(oh->length) < len) { ds_put_format(&string, - "(***only uses %"PRIu16" bytes out of %zu***)\n", + "(***only uses %"PRIu16" bytes out of %"PRIuSIZE"***)\n", ntohs(oh->length), len); } else { enum ofperr error;