X-Git-Url: http://git.cascardo.eti.br/?a=blobdiff_plain;f=lib%2Fovs-thread.c;h=b0e10ee898789d64ed1c92c4e5fb9c03483e0bd0;hb=29100ef2ba237a198b9cf85241107589af7b51d4;hp=6ebda07e8bbcad3a20184f29bb4d967dedd9dafd;hpb=fa20477465538a9789343b2d12cca16a9ca5b237;p=cascardo%2Fovs.git diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c index 6ebda07e8..b0e10ee89 100644 --- a/lib/ovs-thread.c +++ b/lib/ovs-thread.c @@ -340,6 +340,25 @@ ovsthread_wrapper(void *aux_) return aux.start(aux.arg); } +static void +set_min_stack_size(pthread_attr_t *attr, size_t min_stacksize) +{ + size_t stacksize; + int error; + + error = pthread_attr_getstacksize(attr, &stacksize); + if (error) { + ovs_abort(error, "pthread_attr_getstacksize failed"); + } + + if (stacksize < min_stacksize) { + error = pthread_attr_setstacksize(attr, min_stacksize); + if (error) { + ovs_abort(error, "pthread_attr_setstacksize failed"); + } + } +} + /* Starts a thread that calls 'start(arg)'. Sets the thread's name to 'name' * (suffixed by its ovsthread_id()). Returns the new thread's pthread_t. */ pthread_t @@ -358,10 +377,20 @@ ovs_thread_create(const char *name, void *(*start)(void *), void *arg) aux->arg = arg; ovs_strlcpy(aux->name, name, sizeof aux->name); + /* Some small systems use a default stack size as small as 80 kB, but OVS + * requires approximately 384 kB according to the following analysis: + * http://openvswitch.org/pipermail/dev/2016-January/065049.html + * + * We use 512 kB to give us some margin of error. */ + pthread_attr_t attr; + pthread_attr_init(&attr); + set_min_stack_size(&attr, 512 * 1024); + error = pthread_create(&thread, NULL, ovsthread_wrapper, aux); if (error) { ovs_abort(error, "pthread_create failed"); } + pthread_attr_destroy(&attr); return thread; }