X-Git-Url: http://git.cascardo.eti.br/?a=blobdiff_plain;f=ofproto%2Fofproto-dpif-xlate.c;h=a0a10b86bf9fe0a62266dd27c00888bae5190446;hb=9d078ec2f17adc7cceb2793687f8faa1f1c6f4f3;hp=f31ed41f89a5c0112117d6fe0211481ceb340b02;hpb=8cbf4f479b6f31becc48c9f0247e8783036ac805;p=cascardo%2Fovs.git diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index f31ed41f8..a0a10b86b 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc. +/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,7 +17,12 @@ #include "ofproto/ofproto-dpif-xlate.h" #include +#include +#include +#include +#include +#include "tnl-arp-cache.h" #include "bfd.h" #include "bitmap.h" #include "bond.h" @@ -33,6 +38,7 @@ #include "learn.h" #include "list.h" #include "mac-learning.h" +#include "mcast-snooping.h" #include "meta-flow.h" #include "multipath.h" #include "netdev-vport.h" @@ -47,12 +53,14 @@ #include "ofproto/ofproto-dpif.h" #include "ofproto/ofproto-provider.h" #include "packet-dpif.h" +#include "ovs-router.h" +#include "tnl-ports.h" #include "tunnel.h" -#include "vlog.h" +#include "openvswitch/vlog.h" COVERAGE_DEFINE(xlate_actions); COVERAGE_DEFINE(xlate_actions_oversize); -COVERAGE_DEFINE(xlate_actions_mpls_overflow); +COVERAGE_DEFINE(xlate_actions_too_many_output); VLOG_DEFINE_THIS_MODULE(ofproto_dpif_xlate); @@ -62,6 +70,9 @@ VLOG_DEFINE_THIS_MODULE(ofproto_dpif_xlate); #define MAX_INTERNAL_RESUBMITS 1 /* Max resbmits allowed using rules in internal table. */ +/* Timeout for internal rules created to handle recirculation */ +#define RECIRC_TIMEOUT 60 + /* Maximum number of resubmit actions in a flow translation, whether they are * recursive or not. */ #define MAX_RESUBMITS (MAX_RESUBMIT_RECURSION * MAX_RESUBMIT_RECURSION) @@ -70,23 +81,20 @@ struct xbridge { struct hmap_node hmap_node; /* Node in global 'xbridges' map. */ struct ofproto_dpif *ofproto; /* Key in global 'xbridges' map. */ - struct list xbundles; /* Owned xbundles. */ + struct ovs_list xbundles; /* Owned xbundles. */ struct hmap xports; /* Indexed by ofp_port. */ char *name; /* Name used in log messages. */ struct dpif *dpif; /* Datapath interface. */ struct mac_learning *ml; /* Mac learning handle. */ + struct mcast_snooping *ms; /* Multicast Snooping handle. */ struct mbridge *mbridge; /* Mirroring. */ struct dpif_sflow *sflow; /* SFlow handle, or null. */ struct dpif_ipfix *ipfix; /* Ipfix handle, or null. */ struct netflow *netflow; /* Netflow handle, or null. */ struct stp *stp; /* STP or null if disabled. */ + struct rstp *rstp; /* RSTP or null if disabled. */ - /* Special rules installed by ofproto-dpif. */ - struct rule_dpif *miss_rule; - struct rule_dpif *no_packet_in_rule; - - enum ofp_config_flags frag; /* Fragmentation handling. */ bool has_in_band; /* Bridge has in band control? */ bool forward_bpdu; /* Bridge forwards STP BPDUs? */ @@ -101,16 +109,20 @@ struct xbridge { /* Number of MPLS label stack entries that the datapath supports * in matches. */ size_t max_mpls_depth; + + /* True if the datapath supports masked data in OVS_ACTION_ATTR_SET + * actions. */ + bool masked_set_action; }; struct xbundle { struct hmap_node hmap_node; /* In global 'xbundles' map. */ struct ofbundle *ofbundle; /* Key in global 'xbundles' map. */ - struct list list_node; /* In parent 'xbridges' list. */ + struct ovs_list list_node; /* In parent 'xbridges' list. */ struct xbridge *xbridge; /* Parent xbridge. */ - struct list xports; /* Contains "struct xport"s. */ + struct ovs_list xports; /* Contains "struct xport"s. */ char *name; /* Name used in log messages. */ struct bond *bond; /* Nonnull iff more than one port. */ @@ -133,7 +145,7 @@ struct xport { odp_port_t odp_port; /* Datapath port number or ODPP_NONE. */ - struct list bundle_node; /* In parent xbundle (if it exists). */ + struct ovs_list bundle_node; /* In parent xbundle (if it exists). */ struct xbundle *xbundle; /* Parent xbundle or null. */ struct netdev *netdev; /* 'ofport''s netdev. */ @@ -144,6 +156,7 @@ struct xport { enum ofputil_port_config config; /* OpenFlow port configuration. */ enum ofputil_port_state state; /* OpenFlow port state. */ int stp_port_no; /* STP port number or -1 if not in use. */ + struct rstp_port *rstp_port; /* RSTP port or null. */ struct hmap skb_priorities; /* Map of 'skb_priority_to_dscp's. */ @@ -183,6 +196,7 @@ struct xlate_ctx { int recurse; /* Current resubmit nesting depth. */ int resubmits; /* Total number of resubmits. */ bool in_group; /* Currently translating ofgroup, if true. */ + bool in_action_set; /* Currently translating action_set, if true. */ uint32_t orig_skb_priority; /* Priority when packet arrived. */ uint8_t table_id; /* OpenFlow table ID where flow was found. */ @@ -195,12 +209,19 @@ struct xlate_ctx { struct xlate_recirc recirc; /* Information used for generating * recirculation actions */ + /* True if a packet was but is no longer MPLS (due to an MPLS pop action). + * This is a trigger for recirculation in cases where translating an action + * or looking up a flow requires access to the fields of the packet after + * the MPLS label stack that was originally present. */ + bool was_mpls; + /* OpenFlow 1.1+ action set. * * 'action_set' accumulates "struct ofpact"s added by OFPACT_WRITE_ACTIONS. * When translation is otherwise complete, ofpacts_execute_action_set() * converts it to a set of "struct ofpact"s that can be translated into * datapath actions. */ + bool action_set_has_group; /* Action set contains OFPACT_GROUP? */ struct ofpbuf action_set; /* Action set. */ uint64_t action_set_stub[1024 / 8]; }; @@ -235,6 +256,7 @@ enum xc_type { XC_NORMAL, XC_FIN_TIMEOUT, XC_GROUP, + XC_TNL_ARP, }; /* xlate_cache entries hold enough information to perform the side effects of @@ -284,6 +306,10 @@ struct xc_entry { struct group_dpif *group; struct ofputil_bucket *bucket; } group; + struct { + char br_name[IFNAMSIZ]; + ovs_be32 d_ip; + } tnl_arp_cache; } u; }; @@ -307,14 +333,14 @@ struct xlate_cfg { struct hmap xbundles; struct hmap xports; }; -static OVSRCU_TYPE(struct xlate_cfg *) xcfgp = OVSRCU_TYPE_INITIALIZER; +static OVSRCU_TYPE(struct xlate_cfg *) xcfgp = OVSRCU_INITIALIZER(NULL); static struct xlate_cfg *new_xcfg = NULL; static bool may_receive(const struct xport *, struct xlate_ctx *); static void do_xlate_actions(const struct ofpact *, size_t ofpacts_len, struct xlate_ctx *); static void xlate_normal(struct xlate_ctx *); -static void xlate_report(struct xlate_ctx *, const char *); +static inline void xlate_report(struct xlate_ctx *, const char *); static void xlate_table_action(struct xlate_ctx *, ofp_port_t in_port, uint8_t table_id, bool may_packet_in, bool honor_table_miss); @@ -334,6 +360,7 @@ static struct xport *get_ofp_port(const struct xbridge *, ofp_port_t ofp_port); static struct skb_priority_to_dscp *get_skb_priority(const struct xport *, uint32_t skb_priority); static void clear_skb_priorities(struct xport *); +static size_t count_skb_priorities(const struct xport *); static bool dscp_from_skb_priority(const struct xport *, uint32_t skb_priority, uint8_t *dscp); @@ -342,20 +369,18 @@ static struct xc_entry *xlate_cache_add_entry(struct xlate_cache *xc, static void xlate_xbridge_init(struct xlate_cfg *, struct xbridge *); static void xlate_xbundle_init(struct xlate_cfg *, struct xbundle *); static void xlate_xport_init(struct xlate_cfg *, struct xport *); -static void xlate_xbridge_set(struct xbridge *xbridge, - struct dpif *dpif, - struct rule_dpif *miss_rule, - struct rule_dpif *no_packet_in_rule, - const struct mac_learning *ml, struct stp *stp, - const struct mbridge *mbridge, - const struct dpif_sflow *sflow, - const struct dpif_ipfix *ipfix, - const struct netflow *netflow, - enum ofp_config_flags frag, +static void xlate_xbridge_set(struct xbridge *, struct dpif *, + const struct mac_learning *, struct stp *, + struct rstp *, const struct mcast_snooping *, + const struct mbridge *, + const struct dpif_sflow *, + const struct dpif_ipfix *, + const struct netflow *, bool forward_bpdu, bool has_in_band, bool enable_recirc, bool variable_length_userdata, - size_t max_mpls_depth); + size_t max_mpls_depth, + bool masked_set_action); static void xlate_xbundle_set(struct xbundle *xbundle, enum port_vlan_mode vlan_mode, int vlan, unsigned long *trunks, bool use_priority_tags, @@ -364,6 +389,7 @@ static void xlate_xbundle_set(struct xbundle *xbundle, static void xlate_xport_set(struct xport *xport, odp_port_t odp_port, const struct netdev *netdev, const struct cfm *cfm, const struct bfd *bfd, int stp_port_no, + const struct rstp_port *rstp_port, enum ofputil_port_config config, enum ofputil_port_state state, bool is_tunnel, bool may_enable); @@ -376,6 +402,13 @@ static void xlate_xport_copy(struct xbridge *, struct xbundle *, struct xport *); static void xlate_xcfg_free(struct xlate_cfg *); +static inline void +xlate_report(struct xlate_ctx *ctx, const char *s) +{ + if (OVS_UNLIKELY(ctx->xin->report_hook)) { + ctx->xin->report_hook(ctx->xin, s, ctx->recurse); + } +} static void xlate_xbridge_init(struct xlate_cfg *xcfg, struct xbridge *xbridge) @@ -408,23 +441,28 @@ xlate_xport_init(struct xlate_cfg *xcfg, struct xport *xport) static void xlate_xbridge_set(struct xbridge *xbridge, struct dpif *dpif, - struct rule_dpif *miss_rule, - struct rule_dpif *no_packet_in_rule, const struct mac_learning *ml, struct stp *stp, + struct rstp *rstp, const struct mcast_snooping *ms, const struct mbridge *mbridge, const struct dpif_sflow *sflow, const struct dpif_ipfix *ipfix, - const struct netflow *netflow, enum ofp_config_flags frag, + const struct netflow *netflow, bool forward_bpdu, bool has_in_band, bool enable_recirc, bool variable_length_userdata, - size_t max_mpls_depth) + size_t max_mpls_depth, + bool masked_set_action) { if (xbridge->ml != ml) { mac_learning_unref(xbridge->ml); xbridge->ml = mac_learning_ref(ml); } + if (xbridge->ms != ms) { + mcast_snooping_unref(xbridge->ms); + xbridge->ms = mcast_snooping_ref(ms); + } + if (xbridge->mbridge != mbridge) { mbridge_unref(xbridge->mbridge); xbridge->mbridge = mbridge_ref(mbridge); @@ -445,6 +483,11 @@ xlate_xbridge_set(struct xbridge *xbridge, xbridge->stp = stp_ref(stp); } + if (xbridge->rstp != rstp) { + rstp_unref(xbridge->rstp); + xbridge->rstp = rstp_ref(rstp); + } + if (xbridge->netflow != netflow) { netflow_unref(xbridge->netflow); xbridge->netflow = netflow_ref(netflow); @@ -453,12 +496,10 @@ xlate_xbridge_set(struct xbridge *xbridge, xbridge->dpif = dpif; xbridge->forward_bpdu = forward_bpdu; xbridge->has_in_band = has_in_band; - xbridge->frag = frag; - xbridge->miss_rule = miss_rule; - xbridge->no_packet_in_rule = no_packet_in_rule; xbridge->enable_recirc = enable_recirc; xbridge->variable_length_userdata = variable_length_userdata; xbridge->max_mpls_depth = max_mpls_depth; + xbridge->masked_set_action = masked_set_action; } static void @@ -491,6 +532,7 @@ static void xlate_xport_set(struct xport *xport, odp_port_t odp_port, const struct netdev *netdev, const struct cfm *cfm, const struct bfd *bfd, int stp_port_no, + const struct rstp_port* rstp_port, enum ofputil_port_config config, enum ofputil_port_state state, bool is_tunnel, bool may_enable) { @@ -501,6 +543,11 @@ xlate_xport_set(struct xport *xport, odp_port_t odp_port, xport->may_enable = may_enable; xport->odp_port = odp_port; + if (xport->rstp_port != rstp_port) { + rstp_port_unref(xport->rstp_port); + xport->rstp_port = rstp_port_ref(rstp_port); + } + if (xport->cfm != cfm) { cfm_unref(xport->cfm); xport->cfm = cfm_ref(cfm); @@ -528,13 +575,13 @@ xlate_xbridge_copy(struct xbridge *xbridge) xlate_xbridge_init(new_xcfg, new_xbridge); xlate_xbridge_set(new_xbridge, - xbridge->dpif, xbridge->miss_rule, - xbridge->no_packet_in_rule, xbridge->ml, xbridge->stp, - xbridge->mbridge, xbridge->sflow, xbridge->ipfix, - xbridge->netflow, xbridge->frag, xbridge->forward_bpdu, + xbridge->dpif, xbridge->ml, xbridge->stp, + xbridge->rstp, xbridge->ms, xbridge->mbridge, + xbridge->sflow, xbridge->ipfix, xbridge->netflow, + xbridge->forward_bpdu, xbridge->has_in_band, xbridge->enable_recirc, xbridge->variable_length_userdata, - xbridge->max_mpls_depth); + xbridge->max_mpls_depth, xbridge->masked_set_action); LIST_FOR_EACH (xbundle, list_node, &xbridge->xbundles) { xlate_xbundle_copy(new_xbridge, xbundle); } @@ -578,8 +625,9 @@ xlate_xport_copy(struct xbridge *xbridge, struct xbundle *xbundle, xlate_xport_init(new_xcfg, new_xport); xlate_xport_set(new_xport, xport->odp_port, xport->netdev, xport->cfm, - xport->bfd, xport->stp_port_no, xport->config, xport->state, - xport->is_tunnel, xport->may_enable); + xport->bfd, xport->stp_port_no, xport->rstp_port, + xport->config, xport->state, xport->is_tunnel, + xport->may_enable); if (xport->peer) { struct xport *peer = xport_lookup(new_xcfg, xport->peer->ofport); @@ -624,8 +672,8 @@ xlate_txn_commit(void) struct xlate_cfg *xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); ovsrcu_set(&xcfgp, new_xcfg); - ovsrcu_postpone(xlate_xcfg_free, xcfg); - + ovsrcu_synchronize(); + xlate_xcfg_free(xcfg); new_xcfg = NULL; } @@ -677,17 +725,16 @@ xlate_xcfg_free(struct xlate_cfg *xcfg) void xlate_ofproto_set(struct ofproto_dpif *ofproto, const char *name, - struct dpif *dpif, struct rule_dpif *miss_rule, - struct rule_dpif *no_packet_in_rule, + struct dpif *dpif, const struct mac_learning *ml, struct stp *stp, + struct rstp *rstp, const struct mcast_snooping *ms, const struct mbridge *mbridge, const struct dpif_sflow *sflow, const struct dpif_ipfix *ipfix, - const struct netflow *netflow, enum ofp_config_flags frag, - bool forward_bpdu, bool has_in_band, - bool enable_recirc, - bool variable_length_userdata, - size_t max_mpls_depth) + const struct netflow *netflow, + bool forward_bpdu, bool has_in_band, bool enable_recirc, + bool variable_length_userdata, size_t max_mpls_depth, + bool masked_set_action) { struct xbridge *xbridge; @@ -704,10 +751,10 @@ xlate_ofproto_set(struct ofproto_dpif *ofproto, const char *name, free(xbridge->name); xbridge->name = xstrdup(name); - xlate_xbridge_set(xbridge, dpif, miss_rule, no_packet_in_rule, ml, stp, - mbridge, sflow, ipfix, netflow, frag, forward_bpdu, - has_in_band, enable_recirc, variable_length_userdata, - max_mpls_depth); + xlate_xbridge_set(xbridge, dpif, ml, stp, rstp, ms, mbridge, sflow, ipfix, + netflow, forward_bpdu, has_in_band, enable_recirc, + variable_length_userdata, max_mpls_depth, + masked_set_action); } static void @@ -730,10 +777,12 @@ xlate_xbridge_remove(struct xlate_cfg *xcfg, struct xbridge *xbridge) hmap_remove(&xcfg->xbridges, &xbridge->hmap_node); mac_learning_unref(xbridge->ml); + mcast_snooping_unref(xbridge->ms); mbridge_unref(xbridge->mbridge); dpif_sflow_unref(xbridge->sflow); dpif_ipfix_unref(xbridge->ipfix); stp_unref(xbridge->stp); + rstp_unref(xbridge->rstp); hmap_destroy(&xbridge->xports); free(xbridge->name); free(xbridge); @@ -816,6 +865,7 @@ xlate_ofport_set(struct ofproto_dpif *ofproto, struct ofbundle *ofbundle, odp_port_t odp_port, const struct netdev *netdev, const struct cfm *cfm, const struct bfd *bfd, struct ofport_dpif *peer, int stp_port_no, + const struct rstp_port *rstp_port, const struct ofproto_port_queue *qdscp_list, size_t n_qdscp, enum ofputil_port_config config, enum ofputil_port_state state, bool is_tunnel, @@ -838,8 +888,8 @@ xlate_ofport_set(struct ofproto_dpif *ofproto, struct ofbundle *ofbundle, ovs_assert(xport->ofp_port == ofp_port); - xlate_xport_set(xport, odp_port, netdev, cfm, bfd, stp_port_no, config, - state, is_tunnel, may_enable); + xlate_xport_set(xport, odp_port, netdev, cfm, bfd, stp_port_no, + rstp_port, config, state, is_tunnel, may_enable); if (xport->peer) { xport->peer->peer = NULL; @@ -898,6 +948,7 @@ xlate_xport_remove(struct xlate_cfg *xcfg, struct xport *xport) hmap_remove(&xport->xbridge->xports, &xport->ofp_node); netdev_close(xport->netdev); + rstp_port_unref(xport->rstp_port); cfm_unref(xport->cfm); bfd_unref(xport->bfd); free(xport); @@ -914,85 +965,118 @@ xlate_ofport_remove(struct ofport_dpif *ofport) xlate_xport_remove(new_xcfg, xport); } -/* Given a datpath, packet, and flow metadata ('backer', 'packet', and 'key' - * respectively), populates 'flow' with the result of odp_flow_key_to_flow(). - * Optionally populates 'ofproto' with the ofproto_dpif, 'odp_in_port' with - * the datapath in_port, that 'packet' ingressed, and 'ipfix', 'sflow', and - * 'netflow' with the appropriate handles for those protocols if they're - * enabled. Caller is responsible for unrefing them. - * - * If 'ofproto' is nonnull, requires 'flow''s in_port to exist. Otherwise sets - * 'flow''s in_port to OFPP_NONE. - * - * This function does post-processing on data returned from - * odp_flow_key_to_flow() to help make VLAN splinters transparent to the rest - * of the upcall processing logic. In particular, if the extracted in_port is - * a VLAN splinter port, it replaces flow->in_port by the "real" port, sets - * flow->vlan_tci correctly for the VLAN of the VLAN splinter port, and pushes - * a VLAN header onto 'packet' (if it is nonnull). - * - * Similarly, this function also includes some logic to help with tunnels. It - * may modify 'flow' as necessary to make the tunneling implementation - * transparent to the upcall processing logic. - * - * Returns 0 if successful, ENODEV if the parsed flow has no associated ofport, - * or some other positive errno if there are other problems. */ -int -xlate_receive(const struct dpif_backer *backer, struct ofpbuf *packet, - const struct nlattr *key, size_t key_len, struct flow *flow, - struct ofproto_dpif **ofproto, struct dpif_ipfix **ipfix, - struct dpif_sflow **sflow, struct netflow **netflow, - odp_port_t *odp_in_port) +/* Given a datapath and flow metadata ('backer', and 'flow' respectively) + * returns the corresponding struct xport, or NULL if none is found. */ +static struct xport * +xlate_lookup_xport(const struct dpif_backer *backer, const struct flow *flow) { struct xlate_cfg *xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); - int error = ENODEV; + + return xport_lookup(xcfg, tnl_port_should_receive(flow) + ? tnl_port_receive(flow) + : odp_port_to_ofport(backer, flow->in_port.odp_port)); +} + +static struct ofproto_dpif * +xlate_lookup_ofproto_(const struct dpif_backer *backer, const struct flow *flow, + ofp_port_t *ofp_in_port, const struct xport **xportp) +{ + struct ofproto_dpif *recv_ofproto = NULL; + struct ofproto_dpif *recirc_ofproto = NULL; const struct xport *xport; + ofp_port_t in_port = OFPP_NONE; - if (odp_flow_key_to_flow(key, key_len, flow) == ODP_FIT_ERROR) { - error = EINVAL; - return error; - } + *xportp = xport = xlate_lookup_xport(backer, flow); - if (odp_in_port) { - *odp_in_port = flow->in_port.odp_port; + if (xport) { + recv_ofproto = xport->xbridge->ofproto; + in_port = xport->ofp_port; } - xport = xport_lookup(xcfg, tnl_port_should_receive(flow) - ? tnl_port_receive(flow) - : odp_port_to_ofport(backer, flow->in_port.odp_port)); + /* When recirc_id is set in 'flow', checks whether the ofproto_dpif that + * corresponds to the recirc_id is same as the receiving bridge. If they + * are the same, uses the 'recv_ofproto' and keeps the 'ofp_in_port' as + * assigned. Otherwise, uses the 'recirc_ofproto' that owns recirc_id and + * assigns OFPP_NONE to 'ofp_in_port'. Doing this is in that, the + * recirculated flow must be processced by the ofproto which originates + * the recirculation, and as bridges can only see their own ports, the + * in_port of the 'recv_ofproto' should not be passed to the + * 'recirc_ofproto'. + * + * Admittedly, setting the 'ofp_in_port' to OFPP_NONE limits the + * 'recirc_ofproto' from meaningfully matching on in_port of recirculated + * flow, and should be fixed in the near future. + * + * TODO: Restore the original patch port. + */ + if (recv_ofproto && flow->recirc_id) { + recirc_ofproto = ofproto_dpif_recirc_get_ofproto(backer, + flow->recirc_id); + if (recv_ofproto != recirc_ofproto) { + *xportp = xport = NULL; + in_port = OFPP_NONE; + } + } - flow->in_port.ofp_port = xport ? xport->ofp_port : OFPP_NONE; - if (!xport) { - return error; + if (ofp_in_port) { + *ofp_in_port = in_port; } - if (vsp_adjust_flow(xport->xbridge->ofproto, flow)) { - if (packet) { - /* Make the packet resemble the flow, so that it gets sent to - * an OpenFlow controller properly, so that it looks correct - * for sFlow, and so that flow_extract() will get the correct - * vlan_tci if it is called on 'packet'. */ - eth_push_vlan(packet, htons(ETH_TYPE_VLAN), flow->vlan_tci); - } + return xport ? recv_ofproto : recirc_ofproto; +} + +/* Given a datapath and flow metadata ('backer', and 'flow' respectively) + * returns the corresponding struct ofproto_dpif and OpenFlow port number. */ +struct ofproto_dpif * +xlate_lookup_ofproto(const struct dpif_backer *backer, const struct flow *flow, + ofp_port_t *ofp_in_port) +{ + const struct xport *xport; + + return xlate_lookup_ofproto_(backer, flow, ofp_in_port, &xport); +} + +/* Given a datapath and flow metadata ('backer', and 'flow' respectively), + * optionally populates 'ofproto' with the ofproto_dpif, 'ofp_in_port' with the + * openflow in_port, and 'ipfix', 'sflow', and 'netflow' with the appropriate + * handles for those protocols if they're enabled. Caller may use the returned + * pointers until quiescing, for longer term use additional references must + * be taken. + * + * Returns 0 if successful, ENODEV if the parsed flow has no associated ofproto. + */ +int +xlate_lookup(const struct dpif_backer *backer, const struct flow *flow, + struct ofproto_dpif **ofprotop, struct dpif_ipfix **ipfix, + struct dpif_sflow **sflow, struct netflow **netflow, + ofp_port_t *ofp_in_port) +{ + struct ofproto_dpif *ofproto; + const struct xport *xport; + + ofproto = xlate_lookup_ofproto_(backer, flow, ofp_in_port, &xport); + + if (!ofproto) { + return ENODEV; } - error = 0; - if (ofproto) { - *ofproto = xport->xbridge->ofproto; + if (ofprotop) { + *ofprotop = ofproto; } if (ipfix) { - *ipfix = dpif_ipfix_ref(xport->xbridge->ipfix); + *ipfix = xport ? xport->xbridge->ipfix : NULL; } if (sflow) { - *sflow = dpif_sflow_ref(xport->xbridge->sflow); + *sflow = xport ? xport->xbridge->sflow : NULL; } if (netflow) { - *netflow = netflow_ref(xport->xbridge->netflow); + *netflow = xport ? xport->xbridge->netflow : NULL; } - return error; + + return 0; } static struct xbridge * @@ -1070,21 +1154,25 @@ static bool xport_stp_learn_state(const struct xport *xport) { struct stp_port *sp = xport_get_stp_port(xport); - return stp_learn_in_state(sp ? stp_port_get_state(sp) : STP_DISABLED); + return sp + ? stp_learn_in_state(stp_port_get_state(sp)) + : true; } static bool xport_stp_forward_state(const struct xport *xport) { struct stp_port *sp = xport_get_stp_port(xport); - return stp_forward_in_state(sp ? stp_port_get_state(sp) : STP_DISABLED); + return sp + ? stp_forward_in_state(stp_port_get_state(sp)) + : true; } static bool -xport_stp_listen_state(const struct xport *xport) +xport_stp_should_forward_bpdu(const struct xport *xport) { struct stp_port *sp = xport_get_stp_port(xport); - return stp_listen_in_state(sp ? stp_port_get_state(sp) : STP_DISABLED); + return stp_should_forward_bpdu(sp ? stp_port_get_state(sp) : STP_DISABLED); } /* Returns true if STP should process 'flow'. Sets fields in 'wc' that @@ -1120,6 +1208,58 @@ stp_process_packet(const struct xport *xport, const struct ofpbuf *packet) } } +static enum rstp_state +xport_get_rstp_port_state(const struct xport *xport) +{ + return xport->rstp_port + ? rstp_port_get_state(xport->rstp_port) + : RSTP_DISABLED; +} + +static bool +xport_rstp_learn_state(const struct xport *xport) +{ + return xport->xbridge->rstp && xport->rstp_port + ? rstp_learn_in_state(xport_get_rstp_port_state(xport)) + : true; +} + +static bool +xport_rstp_forward_state(const struct xport *xport) +{ + return xport->xbridge->rstp && xport->rstp_port + ? rstp_forward_in_state(xport_get_rstp_port_state(xport)) + : true; +} + +static bool +xport_rstp_should_manage_bpdu(const struct xport *xport) +{ + return rstp_should_manage_bpdu(xport_get_rstp_port_state(xport)); +} + +static void +rstp_process_packet(const struct xport *xport, const struct ofpbuf *packet) +{ + struct ofpbuf payload = *packet; + struct eth_header *eth = ofpbuf_data(&payload); + + /* Sink packets on ports that have no RSTP. */ + if (!xport->rstp_port) { + return; + } + + /* Trim off padding on payload. */ + if (ofpbuf_size(&payload) > ntohs(eth->eth_type) + ETH_HEADER_LEN) { + ofpbuf_set_size(&payload, ntohs(eth->eth_type) + ETH_HEADER_LEN); + } + + if (ofpbuf_try_pull(&payload, ETH_HEADER_LEN + LLC_HEADER_LEN)) { + rstp_port_received_bpdu(xport->rstp_port, ofpbuf_data(&payload), + ofpbuf_size(&payload)); + } +} + static struct xport * get_ofp_port(const struct xbridge *xbridge, ofp_port_t ofp_port) { @@ -1144,15 +1284,8 @@ ofp_port_to_odp_port(const struct xbridge *xbridge, ofp_port_t ofp_port) static bool odp_port_is_alive(const struct xlate_ctx *ctx, ofp_port_t ofp_port) { - struct xport *xport; - - xport = get_ofp_port(ctx->xbridge, ofp_port); - if (!xport || xport->config & OFPUTIL_PC_PORT_DOWN || - xport->state & OFPUTIL_PS_LINK_DOWN) { - return false; - } - - return true; + struct xport *xport = get_ofp_port(ctx->xbridge, ofp_port); + return xport && xport->may_enable; } static struct ofputil_bucket * @@ -1201,7 +1334,7 @@ group_first_live_bucket(const struct xlate_ctx *ctx, const struct group_dpif *group, int depth) { struct ofputil_bucket *bucket; - const struct list *buckets; + const struct ovs_list *buckets; group_dpif_get_buckets(group, &buckets); LIST_FOR_EACH (bucket, list_node, buckets) { @@ -1223,7 +1356,7 @@ group_best_live_bucket(const struct xlate_ctx *ctx, int i = 0; struct ofputil_bucket *bucket; - const struct list *buckets; + const struct ovs_list *buckets; group_dpif_get_buckets(group, &buckets); LIST_FOR_EACH (bucket, list_node, buckets) { @@ -1348,7 +1481,7 @@ add_mirror_actions(struct xlate_ctx *ctx, const struct flow *orig_flow) "%s, which is reserved exclusively for mirroring", ctx->xbridge->name, in_xbundle->name); } - ofpbuf_clear(&ctx->xout->odp_actions); + ofpbuf_clear(ctx->xout->odp_actions); return; } @@ -1669,9 +1802,10 @@ is_admissible(struct xlate_ctx *ctx, struct xport *in_port, case BV_DROP_IF_MOVED: ovs_rwlock_rdlock(&xbridge->ml->rwlock); mac = mac_learning_lookup(xbridge->ml, flow->dl_src, vlan); - if (mac && mac->port.p != in_xbundle->ofbundle && - (!is_gratuitous_arp(flow, &ctx->xout->wc) - || mac_entry_is_grat_arp_locked(mac))) { + if (mac + && mac_entry_get_port(xbridge->ml, mac) != in_xbundle->ofbundle + && (!is_gratuitous_arp(flow, &ctx->xout->wc) + || mac_entry_is_grat_arp_locked(mac))) { ovs_rwlock_unlock(&xbridge->ml->rwlock); xlate_report(ctx, "SLB bond thinks this packet looped back, " "dropping"); @@ -1723,7 +1857,7 @@ OVS_REQ_RDLOCK(ml->rwlock) } } - return mac->port.p != in_xbundle->ofbundle; + return mac_entry_get_port(ml, mac) != in_xbundle->ofbundle; } @@ -1759,7 +1893,7 @@ OVS_REQ_WRLOCK(xbridge->ml->rwlock) } } - if (mac->port.p != in_xbundle->ofbundle) { + if (mac_entry_get_port(xbridge->ml, mac) != in_xbundle->ofbundle) { /* The log messages here could actually be useful in debugging, * so keep the rate limit relatively high. */ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(30, 300); @@ -1769,8 +1903,7 @@ OVS_REQ_WRLOCK(xbridge->ml->rwlock) xbridge->name, ETH_ADDR_ARGS(flow->dl_src), in_xbundle->name, vlan); - mac->port.p = in_xbundle->ofbundle; - mac_learning_changed(xbridge->ml); + mac_entry_set_port(xbridge->ml, mac, in_xbundle->ofbundle); } } @@ -1800,6 +1933,182 @@ update_learning_table(const struct xbridge *xbridge, } } +/* Updates multicast snooping table 'ms' given that a packet matching 'flow' + * was received on 'in_xbundle' in 'vlan' and is either Report or Query. */ +static void +update_mcast_snooping_table__(const struct xbridge *xbridge, + const struct flow *flow, + struct mcast_snooping *ms, + ovs_be32 ip4, int vlan, + struct xbundle *in_xbundle) + OVS_REQ_WRLOCK(ms->rwlock) +{ + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(60, 30); + + switch (ntohs(flow->tp_src)) { + case IGMP_HOST_MEMBERSHIP_REPORT: + case IGMPV2_HOST_MEMBERSHIP_REPORT: + if (mcast_snooping_add_group(ms, ip4, vlan, in_xbundle->ofbundle)) { + VLOG_DBG_RL(&rl, "bridge %s: multicast snooping learned that " + IP_FMT" is on port %s in VLAN %d", + xbridge->name, IP_ARGS(ip4), in_xbundle->name, vlan); + } + break; + case IGMP_HOST_LEAVE_MESSAGE: + if (mcast_snooping_leave_group(ms, ip4, vlan, in_xbundle->ofbundle)) { + VLOG_DBG_RL(&rl, "bridge %s: multicast snooping leaving " + IP_FMT" is on port %s in VLAN %d", + xbridge->name, IP_ARGS(ip4), in_xbundle->name, vlan); + } + break; + case IGMP_HOST_MEMBERSHIP_QUERY: + if (flow->nw_src && mcast_snooping_add_mrouter(ms, vlan, + in_xbundle->ofbundle)) { + VLOG_DBG_RL(&rl, "bridge %s: multicast snooping query from " + IP_FMT" is on port %s in VLAN %d", + xbridge->name, IP_ARGS(flow->nw_src), + in_xbundle->name, vlan); + } + break; + } +} + +/* Updates multicast snooping table 'ms' given that a packet matching 'flow' + * was received on 'in_xbundle' in 'vlan'. */ +static void +update_mcast_snooping_table(const struct xbridge *xbridge, + const struct flow *flow, int vlan, + struct xbundle *in_xbundle) +{ + struct mcast_snooping *ms = xbridge->ms; + struct xlate_cfg *xcfg; + struct xbundle *mcast_xbundle; + struct mcast_port_bundle *fport; + + /* Don't learn the OFPP_NONE port. */ + if (in_xbundle == &ofpp_none_bundle) { + return; + } + + /* Don't learn from flood ports */ + mcast_xbundle = NULL; + ovs_rwlock_wrlock(&ms->rwlock); + xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + LIST_FOR_EACH(fport, node, &ms->fport_list) { + mcast_xbundle = xbundle_lookup(xcfg, fport->port); + if (mcast_xbundle == in_xbundle) { + break; + } + } + + if (!mcast_xbundle || mcast_xbundle != in_xbundle) { + update_mcast_snooping_table__(xbridge, flow, ms, flow->igmp_group_ip4, + vlan, in_xbundle); + } + ovs_rwlock_unlock(&ms->rwlock); +} + +/* send the packet to ports having the multicast group learned */ +static void +xlate_normal_mcast_send_group(struct xlate_ctx *ctx, + struct mcast_snooping *ms OVS_UNUSED, + struct mcast_group *grp, + struct xbundle *in_xbundle, uint16_t vlan) + OVS_REQ_RDLOCK(ms->rwlock) +{ + struct xlate_cfg *xcfg; + struct mcast_group_bundle *b; + struct xbundle *mcast_xbundle; + + xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + LIST_FOR_EACH(b, bundle_node, &grp->bundle_lru) { + mcast_xbundle = xbundle_lookup(xcfg, b->port); + if (mcast_xbundle && mcast_xbundle != in_xbundle) { + xlate_report(ctx, "forwarding to mcast group port"); + output_normal(ctx, mcast_xbundle, vlan); + } else if (!mcast_xbundle) { + xlate_report(ctx, "mcast group port is unknown, dropping"); + } else { + xlate_report(ctx, "mcast group port is input port, dropping"); + } + } +} + +/* send the packet to ports connected to multicast routers */ +static void +xlate_normal_mcast_send_mrouters(struct xlate_ctx *ctx, + struct mcast_snooping *ms, + struct xbundle *in_xbundle, uint16_t vlan) + OVS_REQ_RDLOCK(ms->rwlock) +{ + struct xlate_cfg *xcfg; + struct mcast_mrouter_bundle *mrouter; + struct xbundle *mcast_xbundle; + + xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + LIST_FOR_EACH(mrouter, mrouter_node, &ms->mrouter_lru) { + mcast_xbundle = xbundle_lookup(xcfg, mrouter->port); + if (mcast_xbundle && mcast_xbundle != in_xbundle) { + xlate_report(ctx, "forwarding to mcast router port"); + output_normal(ctx, mcast_xbundle, vlan); + } else if (!mcast_xbundle) { + xlate_report(ctx, "mcast router port is unknown, dropping"); + } else { + xlate_report(ctx, "mcast router port is input port, dropping"); + } + } +} + +/* send the packet to ports flagged to be flooded */ +static void +xlate_normal_mcast_send_fports(struct xlate_ctx *ctx, + struct mcast_snooping *ms, + struct xbundle *in_xbundle, uint16_t vlan) + OVS_REQ_RDLOCK(ms->rwlock) +{ + struct xlate_cfg *xcfg; + struct mcast_port_bundle *fport; + struct xbundle *mcast_xbundle; + + xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + LIST_FOR_EACH(fport, node, &ms->fport_list) { + mcast_xbundle = xbundle_lookup(xcfg, fport->port); + if (mcast_xbundle && mcast_xbundle != in_xbundle) { + xlate_report(ctx, "forwarding to mcast flood port"); + output_normal(ctx, mcast_xbundle, vlan); + } else if (!mcast_xbundle) { + xlate_report(ctx, "mcast flood port is unknown, dropping"); + } else { + xlate_report(ctx, "mcast flood port is input port, dropping"); + } + } +} + +/* forward the Reports to configured ports */ +static void +xlate_normal_mcast_send_rports(struct xlate_ctx *ctx, + struct mcast_snooping *ms, + struct xbundle *in_xbundle, uint16_t vlan) + OVS_REQ_RDLOCK(ms->rwlock) +{ + struct xlate_cfg *xcfg; + struct mcast_port_bundle *rport; + struct xbundle *mcast_xbundle; + + xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + LIST_FOR_EACH(rport, node, &ms->rport_list) { + mcast_xbundle = xbundle_lookup(xcfg, rport->port); + if (mcast_xbundle && mcast_xbundle != in_xbundle) { + xlate_report(ctx, "forwarding Report to mcast flagged port"); + output_normal(ctx, mcast_xbundle, vlan); + } else if (!mcast_xbundle) { + xlate_report(ctx, "mcast port is unknown, dropping the Report"); + } else { + xlate_report(ctx, "mcast port is input port, dropping the Report"); + } + } +} + static void xlate_normal_flood(struct xlate_ctx *ctx, struct xbundle *in_xbundle, uint16_t vlan) @@ -1895,25 +2204,89 @@ xlate_normal(struct xlate_ctx *ctx) } /* Determine output bundle. */ - ovs_rwlock_rdlock(&ctx->xbridge->ml->rwlock); - mac = mac_learning_lookup(ctx->xbridge->ml, flow->dl_dst, vlan); - mac_port = mac ? mac->port.p : NULL; - ovs_rwlock_unlock(&ctx->xbridge->ml->rwlock); + if (mcast_snooping_enabled(ctx->xbridge->ms) + && !eth_addr_is_broadcast(flow->dl_dst) + && eth_addr_is_multicast(flow->dl_dst) + && flow->dl_type == htons(ETH_TYPE_IP)) { + struct mcast_snooping *ms = ctx->xbridge->ms; + struct mcast_group *grp; + + if (flow->nw_proto == IPPROTO_IGMP) { + if (ctx->xin->may_learn) { + if (mcast_snooping_is_membership(flow->tp_src) || + mcast_snooping_is_query(flow->tp_src)) { + update_mcast_snooping_table(ctx->xbridge, flow, vlan, + in_xbundle); + } + } - if (mac_port) { - struct xlate_cfg *xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); - struct xbundle *mac_xbundle = xbundle_lookup(xcfg, mac_port); - if (mac_xbundle && mac_xbundle != in_xbundle) { - xlate_report(ctx, "forwarding to learned port"); - output_normal(ctx, mac_xbundle, vlan); - } else if (!mac_xbundle) { - xlate_report(ctx, "learned port is unknown, dropping"); + if (mcast_snooping_is_membership(flow->tp_src)) { + ovs_rwlock_rdlock(&ms->rwlock); + xlate_normal_mcast_send_mrouters(ctx, ms, in_xbundle, vlan); + /* RFC4541: section 2.1.1, item 1: A snooping switch should + * forward IGMP Membership Reports only to those ports where + * multicast routers are attached. Alternatively stated: a + * snooping switch should not forward IGMP Membership Reports + * to ports on which only hosts are attached. + * An administrative control may be provided to override this + * restriction, allowing the report messages to be flooded to + * other ports. */ + xlate_normal_mcast_send_rports(ctx, ms, in_xbundle, vlan); + ovs_rwlock_unlock(&ms->rwlock); + } else { + xlate_report(ctx, "multicast traffic, flooding"); + xlate_normal_flood(ctx, in_xbundle, vlan); + } + return; } else { - xlate_report(ctx, "learned port is input port, dropping"); + if (ip_is_local_multicast(flow->nw_dst)) { + /* RFC4541: section 2.1.2, item 2: Packets with a dst IP + * address in the 224.0.0.x range which are not IGMP must + * be forwarded on all ports */ + xlate_report(ctx, "RFC4541: section 2.1.2, item 2, flooding"); + xlate_normal_flood(ctx, in_xbundle, vlan); + return; + } } + + /* forwarding to group base ports */ + ovs_rwlock_rdlock(&ms->rwlock); + grp = mcast_snooping_lookup(ms, flow->nw_dst, vlan); + if (grp) { + xlate_normal_mcast_send_group(ctx, ms, grp, in_xbundle, vlan); + xlate_normal_mcast_send_fports(ctx, ms, in_xbundle, vlan); + xlate_normal_mcast_send_mrouters(ctx, ms, in_xbundle, vlan); + } else { + if (mcast_snooping_flood_unreg(ms)) { + xlate_report(ctx, "unregistered multicast, flooding"); + xlate_normal_flood(ctx, in_xbundle, vlan); + } else { + xlate_normal_mcast_send_mrouters(ctx, ms, in_xbundle, vlan); + xlate_normal_mcast_send_fports(ctx, ms, in_xbundle, vlan); + } + } + ovs_rwlock_unlock(&ms->rwlock); } else { - xlate_report(ctx, "no learned MAC for destination, flooding"); - xlate_normal_flood(ctx, in_xbundle, vlan); + ovs_rwlock_rdlock(&ctx->xbridge->ml->rwlock); + mac = mac_learning_lookup(ctx->xbridge->ml, flow->dl_dst, vlan); + mac_port = mac ? mac_entry_get_port(ctx->xbridge->ml, mac) : NULL; + ovs_rwlock_unlock(&ctx->xbridge->ml->rwlock); + + if (mac_port) { + struct xlate_cfg *xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + struct xbundle *mac_xbundle = xbundle_lookup(xcfg, mac_port); + if (mac_xbundle && mac_xbundle != in_xbundle) { + xlate_report(ctx, "forwarding to learned port"); + output_normal(ctx, mac_xbundle, vlan); + } else if (!mac_xbundle) { + xlate_report(ctx, "learned port is unknown, dropping"); + } else { + xlate_report(ctx, "learned port is input port, dropping"); + } + } else { + xlate_report(ctx, "no learned MAC for destination, flooding"); + xlate_normal_flood(ctx, in_xbundle, vlan); + } } } @@ -1927,7 +2300,8 @@ compose_sample_action(const struct xbridge *xbridge, const struct flow *flow, const uint32_t probability, const union user_action_cookie *cookie, - const size_t cookie_size) + const size_t cookie_size, + const odp_port_t tunnel_out_port) { size_t sample_offset, actions_offset; odp_port_t odp_port; @@ -1944,7 +2318,7 @@ compose_sample_action(const struct xbridge *xbridge, pid = dpif_port_get_pid(xbridge->dpif, odp_port, flow_hash_5tuple(flow, 0)); cookie_offset = odp_put_userspace_action(pid, cookie, cookie_size, - odp_actions); + tunnel_out_port, odp_actions); nl_msg_end_nested(odp_actions, actions_offset); nl_msg_end_nested(odp_actions, sample_offset); @@ -2002,7 +2376,7 @@ compose_sflow_action(const struct xbridge *xbridge, odp_port == ODPP_NONE ? 0 : 1, &cookie); return compose_sample_action(xbridge, odp_actions, flow, probability, - &cookie, sizeof cookie.sflow); + &cookie, sizeof cookie.sflow, ODPP_NONE); } static void @@ -2018,29 +2392,54 @@ compose_flow_sample_cookie(uint16_t probability, uint32_t collector_set_id, } static void -compose_ipfix_cookie(union user_action_cookie *cookie) +compose_ipfix_cookie(union user_action_cookie *cookie, + odp_port_t output_odp_port) { cookie->type = USER_ACTION_COOKIE_IPFIX; + cookie->ipfix.output_odp_port = output_odp_port; } /* Compose SAMPLE action for IPFIX bridge sampling. */ static void compose_ipfix_action(const struct xbridge *xbridge, struct ofpbuf *odp_actions, - const struct flow *flow) + const struct flow *flow, + odp_port_t output_odp_port) { uint32_t probability; union user_action_cookie cookie; + odp_port_t tunnel_out_port = ODPP_NONE; if (!xbridge->ipfix || flow->in_port.ofp_port == OFPP_NONE) { return; } + /* For input case, output_odp_port is ODPP_NONE, which is an invalid port + * number. */ + if (output_odp_port == ODPP_NONE && + !dpif_ipfix_get_bridge_exporter_input_sampling(xbridge->ipfix)) { + return; + } + + /* For output case, output_odp_port is valid*/ + if (output_odp_port != ODPP_NONE) { + if (!dpif_ipfix_get_bridge_exporter_output_sampling(xbridge->ipfix)) { + return; + } + /* If tunnel sampling is enabled, put an additional option attribute: + * OVS_USERSPACE_ATTR_TUNNEL_OUT_PORT + */ + if (dpif_ipfix_get_bridge_exporter_tunnel_sampling(xbridge->ipfix) && + dpif_ipfix_get_tunnel_port(xbridge->ipfix, output_odp_port) ) { + tunnel_out_port = output_odp_port; + } + } + probability = dpif_ipfix_get_bridge_exporter_probability(xbridge->ipfix); - compose_ipfix_cookie(&cookie); + compose_ipfix_cookie(&cookie, output_odp_port); compose_sample_action(xbridge, odp_actions, flow, probability, - &cookie, sizeof cookie.ipfix); + &cookie, sizeof cookie.ipfix, tunnel_out_port); } /* SAMPLE action for sFlow must be first action in any given list of @@ -2050,7 +2449,7 @@ static void add_sflow_action(struct xlate_ctx *ctx) { ctx->user_cookie_offset = compose_sflow_action(ctx->xbridge, - &ctx->xout->odp_actions, + ctx->xout->odp_actions, &ctx->xin->flow, ODPP_NONE); ctx->sflow_odp_port = 0; ctx->sflow_n_outputs = 0; @@ -2061,8 +2460,15 @@ add_sflow_action(struct xlate_ctx *ctx) static void add_ipfix_action(struct xlate_ctx *ctx) { - compose_ipfix_action(ctx->xbridge, &ctx->xout->odp_actions, - &ctx->xin->flow); + compose_ipfix_action(ctx->xbridge, ctx->xout->odp_actions, + &ctx->xin->flow, ODPP_NONE); +} + +static void +add_ipfix_output_action(struct xlate_ctx *ctx, odp_port_t port) +{ + compose_ipfix_action(ctx->xbridge, ctx->xout->odp_actions, + &ctx->xin->flow, port); } /* Fix SAMPLE action according to data collected while composing ODP actions. @@ -2078,7 +2484,7 @@ fix_sflow_action(struct xlate_ctx *ctx) return; } - cookie = ofpbuf_at(&ctx->xout->odp_actions, ctx->user_cookie_offset, + cookie = ofpbuf_at(ctx->xout->odp_actions, ctx->user_cookie_offset, sizeof cookie->sflow); ovs_assert(cookie->type == USER_ACTION_COOKIE_SFLOW); @@ -2115,9 +2521,12 @@ process_special(struct xlate_ctx *ctx, const struct flow *flow, lacp_process_packet(xport->xbundle->lacp, xport->ofport, packet); } return SLOW_LACP; - } else if (xbridge->stp && stp_should_process_flow(flow, wc)) { + } else if ((xbridge->stp || xbridge->rstp) && + stp_should_process_flow(flow, wc)) { if (packet) { - stp_process_packet(xport, packet); + xbridge->stp + ? stp_process_packet(xport, packet) + : rstp_process_packet(xport, packet); } return SLOW_STP; } else { @@ -2125,6 +2534,125 @@ process_special(struct xlate_ctx *ctx, const struct flow *flow, } } +static int +tnl_route_lookup_flow(const struct flow *oflow, + ovs_be32 *ip, struct xport **out_port) +{ + char out_dev[IFNAMSIZ]; + struct xbridge *xbridge; + struct xlate_cfg *xcfg; + ovs_be32 gw; + + if (!ovs_router_lookup(oflow->tunnel.ip_dst, out_dev, &gw)) { + return -ENOENT; + } + + if (gw) { + *ip = gw; + } else { + *ip = oflow->tunnel.ip_dst; + } + + xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); + ovs_assert(xcfg); + + HMAP_FOR_EACH (xbridge, hmap_node, &xcfg->xbridges) { + if (!strncmp(xbridge->name, out_dev, IFNAMSIZ)) { + struct xport *port; + + HMAP_FOR_EACH (port, ofp_node, &xbridge->xports) { + if (!strncmp(netdev_get_name(port->netdev), out_dev, IFNAMSIZ)) { + *out_port = port; + return 0; + } + } + } + } + return -ENOENT; +} + +static int +xlate_flood_packet(struct xbridge *xbridge, struct ofpbuf *packet) +{ + struct ofpact_output output; + struct flow flow; + + ofpact_init(&output.ofpact, OFPACT_OUTPUT, sizeof output); + /* Use OFPP_NONE as the in_port to avoid special packet processing. */ + flow_extract(packet, NULL, &flow); + flow.in_port.ofp_port = OFPP_NONE; + output.port = OFPP_FLOOD; + output.max_len = 0; + + return ofproto_dpif_execute_actions(xbridge->ofproto, &flow, NULL, + &output.ofpact, sizeof output, + packet); +} + +static void +tnl_send_arp_request(const struct xport *out_dev, const uint8_t eth_src[ETH_ADDR_LEN], + ovs_be32 ip_src, ovs_be32 ip_dst) +{ + struct xbridge *xbridge = out_dev->xbridge; + struct ofpbuf packet; + + ofpbuf_init(&packet, 0); + compose_arp(&packet, eth_src, ip_src, ip_dst); + + xlate_flood_packet(xbridge, &packet); + ofpbuf_uninit(&packet); +} + +static int +build_tunnel_send(const struct xlate_ctx *ctx, const struct xport *xport, + const struct flow *flow, odp_port_t tunnel_odp_port) +{ + struct ovs_action_push_tnl tnl_push_data; + struct xport *out_dev = NULL; + ovs_be32 s_ip, d_ip = 0; + uint8_t smac[ETH_ADDR_LEN]; + uint8_t dmac[ETH_ADDR_LEN]; + int err; + + err = tnl_route_lookup_flow(flow, &d_ip, &out_dev); + if (err) { + return err; + } + + /* Use mac addr of bridge port of the peer. */ + err = netdev_get_etheraddr(out_dev->netdev, smac); + if (err) { + return err; + } + + err = netdev_get_in4(out_dev->netdev, (struct in_addr *) &s_ip, NULL); + if (err) { + return err; + } + + err = tnl_arp_lookup(out_dev->xbridge->name, d_ip, dmac); + if (err) { + tnl_send_arp_request(out_dev, smac, s_ip, d_ip); + return err; + } + if (ctx->xin->xcache) { + struct xc_entry *entry; + + entry = xlate_cache_add_entry(ctx->xin->xcache, XC_TNL_ARP); + strncpy(entry->u.tnl_arp_cache.br_name, out_dev->xbridge->name, IFNAMSIZ); + entry->u.tnl_arp_cache.d_ip = d_ip; + } + err = tnl_port_build_header(xport->ofport, flow, + dmac, smac, s_ip, &tnl_push_data); + if (err) { + return err; + } + tnl_push_data.tnl_port = odp_to_u32(tunnel_odp_port); + tnl_push_data.out_port = odp_to_u32(out_dev->odp_port); + odp_put_tnl_push_action(ctx->xout->odp_actions, &tnl_push_data); + return 0; +} + static void compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, bool check_stp) @@ -2132,15 +2660,18 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, const struct xport *xport = get_ofp_port(ctx->xbridge, ofp_port); struct flow_wildcards *wc = &ctx->xout->wc; struct flow *flow = &ctx->xin->flow; + struct flow_tnl flow_tnl; ovs_be16 flow_vlan_tci; uint32_t flow_pkt_mark; uint8_t flow_nw_tos; odp_port_t out_port, odp_port; + bool tnl_push_pop_send = false; uint8_t dscp; /* If 'struct flow' gets additional metadata, we'll need to zero it out * before traversing a patch port. */ - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 26); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 30); + memset(&flow_tnl, 0, sizeof flow_tnl); if (!xport) { xlate_report(ctx, "Nonexistent output port"); @@ -2150,14 +2681,26 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, return; } else if (check_stp) { if (is_stp(&ctx->base_flow)) { - if (!xport_stp_listen_state(xport)) { - xlate_report(ctx, "STP not in listening state, " - "skipping bpdu output"); + if (!xport_stp_should_forward_bpdu(xport) && + !xport_rstp_should_manage_bpdu(xport)) { + if (ctx->xbridge->stp != NULL) { + xlate_report(ctx, "STP not in listening state, " + "skipping bpdu output"); + } else if (ctx->xbridge->rstp != NULL) { + xlate_report(ctx, "RSTP not managing BPDU in this state, " + "skipping bpdu output"); + } return; } - } else if (!xport_stp_forward_state(xport)) { - xlate_report(ctx, "STP not in forwarding state, " - "skipping output"); + } else if (!xport_stp_forward_state(xport) || + !xport_rstp_forward_state(xport)) { + if (ctx->xbridge->stp != NULL) { + xlate_report(ctx, "STP not in forwarding state, " + "skipping output"); + } else if (ctx->xbridge->rstp != NULL) { + xlate_report(ctx, "RSTP not in forwarding state, " + "skipping output"); + } return; } } @@ -2171,30 +2714,34 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, const struct xport *peer = xport->peer; struct flow old_flow = ctx->xin->flow; enum slow_path_reason special; + uint8_t table_id = rule_dpif_lookup_get_init_table_id(&ctx->xin->flow); ctx->xbridge = peer->xbridge; flow->in_port.ofp_port = peer->ofp_port; flow->metadata = htonll(0); memset(&flow->tunnel, 0, sizeof flow->tunnel); memset(flow->regs, 0, sizeof flow->regs); + flow->actset_output = OFPP_UNSET; special = process_special(ctx, &ctx->xin->flow, peer, ctx->xin->packet); if (special) { ctx->xout->slow |= special; } else if (may_receive(peer, ctx)) { - if (xport_stp_forward_state(peer)) { - xlate_table_action(ctx, flow->in_port.ofp_port, 0, true, true); + if (xport_stp_forward_state(peer) && xport_rstp_forward_state(peer)) { + xlate_table_action(ctx, flow->in_port.ofp_port, table_id, + true, true); } else { - /* Forwarding is disabled by STP. Let OFPP_NORMAL and the - * learning action look at the packet, then drop it. */ + /* Forwarding is disabled by STP and RSTP. Let OFPP_NORMAL and + * the learning action look at the packet, then drop it. */ struct flow old_base_flow = ctx->base_flow; - size_t old_size = ofpbuf_size(&ctx->xout->odp_actions); + size_t old_size = ofpbuf_size(ctx->xout->odp_actions); mirror_mask_t old_mirrors = ctx->xout->mirrors; - xlate_table_action(ctx, flow->in_port.ofp_port, 0, true, true); + xlate_table_action(ctx, flow->in_port.ofp_port, table_id, + true, true); ctx->xout->mirrors = old_mirrors; ctx->base_flow = old_base_flow; - ofpbuf_set_size(&ctx->xout->odp_actions, old_size); + ofpbuf_set_size(ctx->xout->odp_actions, old_size); } } @@ -2223,10 +2770,13 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, flow_pkt_mark = flow->pkt_mark; flow_nw_tos = flow->nw_tos; - if (dscp_from_skb_priority(xport, flow->skb_priority, &dscp)) { - wc->masks.nw_tos |= IP_DSCP_MASK; - flow->nw_tos &= ~IP_DSCP_MASK; - flow->nw_tos |= dscp; + if (count_skb_priorities(xport)) { + memset(&wc->masks.skb_priority, 0xff, sizeof wc->masks.skb_priority); + if (dscp_from_skb_priority(xport, flow->skb_priority, &dscp)) { + wc->masks.nw_tos |= IP_DSCP_MASK; + flow->nw_tos &= ~IP_DSCP_MASK; + flow->nw_tos |= dscp; + } } if (xport->is_tunnel) { @@ -2234,7 +2784,7 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, * the Logical (tunnel) Port are not visible for any further * matches, while explicit set actions on tunnel metadata are. */ - struct flow_tnl flow_tnl = flow->tunnel; + flow_tnl = flow->tunnel; odp_port = tnl_port_send(xport->ofport, flow, &ctx->xout->wc); if (odp_port == ODPP_NONE) { xlate_report(ctx, "Tunneling decided against output"); @@ -2254,9 +2804,13 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, entry->u.dev.tx = netdev_ref(xport->netdev); } out_port = odp_port; - commit_odp_tunnel_action(flow, &ctx->base_flow, - &ctx->xout->odp_actions); - flow->tunnel = flow_tnl; /* Restore tunnel metadata */ + if (ovs_native_tunneling_is_on(ctx->xbridge->ofproto)) { + tnl_push_pop_send = true; + } else { + commit_odp_tunnel_action(flow, &ctx->base_flow, + ctx->xout->odp_actions); + flow->tunnel = flow_tnl; /* Restore tunnel metadata */ + } } else { odp_port = xport->odp_port; out_port = odp_port; @@ -2275,26 +2829,53 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, if (out_port != ODPP_NONE) { ctx->xout->slow |= commit_odp_actions(flow, &ctx->base_flow, - &ctx->xout->odp_actions, - &ctx->xout->wc); + ctx->xout->odp_actions, + wc, + ctx->xbridge->masked_set_action); if (ctx->use_recirc) { struct ovs_action_hash *act_hash; struct xlate_recirc *xr = &ctx->recirc; /* Hash action. */ - act_hash = nl_msg_put_unspec_uninit(&ctx->xout->odp_actions, + act_hash = nl_msg_put_unspec_uninit(ctx->xout->odp_actions, OVS_ACTION_ATTR_HASH, sizeof *act_hash); act_hash->hash_alg = xr->hash_alg; act_hash->hash_basis = xr->hash_basis; /* Recirc action. */ - nl_msg_put_u32(&ctx->xout->odp_actions, OVS_ACTION_ATTR_RECIRC, + nl_msg_put_u32(ctx->xout->odp_actions, OVS_ACTION_ATTR_RECIRC, xr->recirc_id); } else { - nl_msg_put_odp_port(&ctx->xout->odp_actions, OVS_ACTION_ATTR_OUTPUT, - out_port); + + if (tnl_push_pop_send) { + build_tunnel_send(ctx, xport, flow, odp_port); + flow->tunnel = flow_tnl; /* Restore tunnel metadata */ + } else { + odp_port_t odp_tnl_port = ODPP_NONE; + + /* XXX: Write better Filter for tunnel port. We can use inport + * int tunnel-port flow to avoid these checks completely. */ + if (ofp_port == OFPP_LOCAL && + ovs_native_tunneling_is_on(ctx->xbridge->ofproto)) { + + odp_tnl_port = tnl_port_map_lookup(flow, wc); + } + + if (odp_tnl_port != ODPP_NONE) { + nl_msg_put_odp_port(ctx->xout->odp_actions, + OVS_ACTION_ATTR_TUNNEL_POP, + odp_tnl_port); + } else { + /* Tunnel push-pop action is not compatible with + * IPFIX action. */ + add_ipfix_output_action(ctx, out_port); + nl_msg_put_odp_port(ctx->xout->odp_actions, + OVS_ACTION_ATTR_OUTPUT, + out_port); + } + } } ctx->sflow_odp_port = odp_port; @@ -2344,7 +2925,7 @@ xlate_resubmit_resource_check(struct xlate_ctx *ctx) MAX_RESUBMIT_RECURSION); } else if (ctx->resubmits >= MAX_RESUBMITS + MAX_INTERNAL_RESUBMITS) { VLOG_ERR_RL(&rl, "over %d resubmit actions", MAX_RESUBMITS); - } else if (ofpbuf_size(&ctx->xout->odp_actions) > UINT16_MAX) { + } else if (ofpbuf_size(ctx->xout->odp_actions) > UINT16_MAX) { VLOG_ERR_RL(&rl, "resubmits yielded over 64 kB of actions"); } else if (ofpbuf_size(&ctx->stack) >= 65536) { VLOG_ERR_RL(&rl, "resubmits yielded over 64 kB of stack"); @@ -2360,63 +2941,24 @@ xlate_table_action(struct xlate_ctx *ctx, ofp_port_t in_port, uint8_t table_id, bool may_packet_in, bool honor_table_miss) { if (xlate_resubmit_resource_check(ctx)) { - ofp_port_t old_in_port = ctx->xin->flow.in_port.ofp_port; - bool skip_wildcards = ctx->xin->skip_wildcards; + struct flow_wildcards *wc; uint8_t old_table_id = ctx->table_id; struct rule_dpif *rule; - enum rule_dpif_lookup_verdict verdict; - enum ofputil_port_config config = 0; ctx->table_id = table_id; + wc = (ctx->xin->skip_wildcards) ? NULL : &ctx->xout->wc; - /* Look up a flow with 'in_port' as the input port. Then restore the - * original input port (otherwise OFPP_NORMAL and OFPP_IN_PORT will - * have surprising behavior). */ - ctx->xin->flow.in_port.ofp_port = in_port; - verdict = rule_dpif_lookup_from_table(ctx->xbridge->ofproto, - &ctx->xin->flow, - !skip_wildcards - ? &ctx->xout->wc : NULL, - honor_table_miss, - &ctx->table_id, &rule, - ctx->xin->xcache != NULL, - ctx->xin->resubmit_stats); - ctx->xin->flow.in_port.ofp_port = old_in_port; - - if (ctx->xin->resubmit_hook) { - ctx->xin->resubmit_hook(ctx->xin, rule, ctx->recurse); - } - - switch (verdict) { - case RULE_DPIF_LOOKUP_VERDICT_MATCH: - goto match; - case RULE_DPIF_LOOKUP_VERDICT_CONTROLLER: - if (may_packet_in) { - struct xport *xport; - - xport = get_ofp_port(ctx->xbridge, - ctx->xin->flow.in_port.ofp_port); - config = xport ? xport->config : 0; - break; - } - /* Fall through to drop */ - case RULE_DPIF_LOOKUP_VERDICT_DROP: - config = OFPUTIL_PC_NO_PACKET_IN; - break; - case RULE_DPIF_LOOKUP_VERDICT_DEFAULT: - if (!ofproto_dpif_wants_packet_in_on_miss(ctx->xbridge->ofproto)) { - config = OFPUTIL_PC_NO_PACKET_IN; - } - break; - default: - OVS_NOT_REACHED(); - } + rule = rule_dpif_lookup_from_table(ctx->xbridge->ofproto, + &ctx->xin->flow, wc, + ctx->xin->xcache != NULL, + ctx->xin->resubmit_stats, + &ctx->table_id, in_port, + may_packet_in, honor_table_miss); - choose_miss_rule(config, ctx->xbridge->miss_rule, - ctx->xbridge->no_packet_in_rule, &rule, - ctx->xin->xcache != NULL); + if (OVS_UNLIKELY(ctx->xin->resubmit_hook)) { + ctx->xin->resubmit_hook(ctx->xin, rule, ctx->recurse + 1); + } -match: if (rule) { /* Fill in the cache entry here instead of xlate_recursively * to make the reference counting more explicit. We take a @@ -2476,7 +3018,7 @@ static void xlate_all_group(struct xlate_ctx *ctx, struct group_dpif *group) { struct ofputil_bucket *bucket; - const struct list *buckets; + const struct ovs_list *buckets; struct flow old_flow = ctx->xin->flow; group_dpif_get_buckets(group, &buckets); @@ -2513,10 +3055,19 @@ xlate_select_group(struct xlate_ctx *ctx, struct group_dpif *group) struct ofputil_bucket *bucket; uint32_t basis; - basis = hash_mac(ctx->xin->flow.dl_dst, 0, 0); + basis = flow_hash_symmetric_l4(&ctx->xin->flow, 0); bucket = group_best_live_bucket(ctx, group, basis); if (bucket) { memset(&wc->masks.dl_dst, 0xff, sizeof wc->masks.dl_dst); + memset(&wc->masks.dl_src, 0xff, sizeof wc->masks.dl_src); + memset(&wc->masks.dl_type, 0xff, sizeof wc->masks.dl_type); + memset(&wc->masks.nw_dst, 0xff, sizeof wc->masks.nw_dst); + memset(&wc->masks.nw_proto, 0xff, sizeof wc->masks.nw_proto); + memset(&wc->masks.nw_src, 0xff, sizeof wc->masks.nw_src); + memset(&wc->masks.tp_dst, 0xff, sizeof wc->masks.tp_dst); + memset(&wc->masks.tp_src, 0xff, sizeof wc->masks.tp_src); + memset(&wc->masks.vlan_tci, 0xff, sizeof wc->masks.vlan_tci); + xlate_group_bucket(ctx, bucket); xlate_group_stats(ctx, group, bucket); } @@ -2645,7 +3196,6 @@ execute_controller_action(struct xlate_ctx *ctx, int len, { struct ofproto_packet_in *pin; struct dpif_packet *packet; - struct pkt_metadata md = PKT_METADATA_INITIALIZER(0); ctx->xout->slow |= SLOW_CONTROLLER; if (!ctx->xin->packet) { @@ -2655,12 +3205,13 @@ execute_controller_action(struct xlate_ctx *ctx, int len, packet = dpif_packet_clone_from_ofpbuf(ctx->xin->packet); ctx->xout->slow |= commit_odp_actions(&ctx->xin->flow, &ctx->base_flow, - &ctx->xout->odp_actions, - &ctx->xout->wc); + ctx->xout->odp_actions, + &ctx->xout->wc, + ctx->xbridge->masked_set_action); - odp_execute_actions(NULL, &packet, 1, false, &md, - ofpbuf_data(&ctx->xout->odp_actions), - ofpbuf_size(&ctx->xout->odp_actions), NULL); + odp_execute_actions(NULL, &packet, 1, false, + ofpbuf_data(ctx->xout->odp_actions), + ofpbuf_size(ctx->xout->odp_actions), NULL); pin = xmalloc(sizeof *pin); pin->up.packet_len = ofpbuf_size(&packet->ofpbuf); @@ -2695,6 +3246,68 @@ execute_controller_action(struct xlate_ctx *ctx, int len, dpif_packet_delete(packet); } +static void +compose_recirculate_action(struct xlate_ctx *ctx, + const struct ofpact *ofpacts_base, + const struct ofpact *ofpact_current, + size_t ofpacts_base_len) +{ + uint32_t id; + int error; + unsigned ofpacts_len; + struct match match; + struct rule *rule; + struct ofpbuf ofpacts; + + ctx->exit = true; + + ofpacts_len = ofpacts_base_len - + ((uint8_t *)ofpact_current - (uint8_t *)ofpacts_base); + + if (ctx->rule) { + id = rule_dpif_get_recirc_id(ctx->rule); + } else { + /* In the case where ctx has no rule then allocate a recirc id. + * The life-cycle of this recirc id is managed by associating it + * with the internal rule that is created to to handle + * recirculation below. + * + * The known use-case of this is packet_out which + * translates actions without a rule */ + id = ofproto_dpif_alloc_recirc_id(ctx->xbridge->ofproto); + } + if (!id) { + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); + VLOG_ERR_RL(&rl, "Failed to allocate recirculation id"); + return; + } + + match_init_catchall(&match); + match_set_recirc_id(&match, id); + ofpbuf_use_const(&ofpacts, ofpact_current, ofpacts_len); + error = ofproto_dpif_add_internal_flow(ctx->xbridge->ofproto, &match, + RECIRC_RULE_PRIORITY, + RECIRC_TIMEOUT, &ofpacts, &rule); + if (error) { + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); + VLOG_ERR_RL(&rl, "Failed to add post recirculation flow %s", + match_to_string(&match, 0)); + return; + } + /* If ctx has no rule then associate the recirc id, which + * was allocated above, with the internal rule. This allows + * the recirc id to be released when the internal rule times out. */ + if (!ctx->rule) { + rule_set_recirc_id(rule, id); + } + + ctx->xout->slow |= commit_odp_actions(&ctx->xin->flow, &ctx->base_flow, + ctx->xout->odp_actions, + &ctx->xout->wc, + ctx->xbridge->masked_set_action); + nl_msg_put_u32(ctx->xout->odp_actions, OVS_ACTION_ATTR_RECIRC, id); +} + static void compose_mpls_push_action(struct xlate_ctx *ctx, struct ofpact_push_mpls *mpls) { @@ -2707,8 +3320,9 @@ compose_mpls_push_action(struct xlate_ctx *ctx, struct ofpact_push_mpls *mpls) n = flow_count_mpls_labels(flow, wc); if (!n) { ctx->xout->slow |= commit_odp_actions(flow, &ctx->base_flow, - &ctx->xout->odp_actions, - &ctx->xout->wc); + ctx->xout->odp_actions, + &ctx->xout->wc, + ctx->xbridge->masked_set_action); } else if (n >= FLOW_MAX_MPLS_LABELS) { if (ctx->xin->packet != NULL) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); @@ -2719,9 +3333,6 @@ compose_mpls_push_action(struct xlate_ctx *ctx, struct ofpact_push_mpls *mpls) } ctx->exit = true; return; - } else if (n >= ctx->xbridge->max_mpls_depth) { - COVERAGE_INC(xlate_actions_mpls_overflow); - ctx->xout->slow |= SLOW_ACTION; } flow_push_mpls(flow, n, mpls->ethertype, wc); @@ -2734,7 +3345,11 @@ compose_mpls_pop_action(struct xlate_ctx *ctx, ovs_be16 eth_type) struct flow *flow = &ctx->xin->flow; int n = flow_count_mpls_labels(flow, wc); - if (!flow_pop_mpls(flow, n, eth_type, wc) && n >= FLOW_MAX_MPLS_LABELS) { + if (flow_pop_mpls(flow, n, eth_type, wc)) { + if (ctx->xbridge->enable_recirc) { + ctx->was_mpls = true; + } + } else if (n >= FLOW_MAX_MPLS_LABELS) { if (ctx->xin->packet != NULL) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); VLOG_WARN_RL(&rl, "bridge %s: dropping packet on which an " @@ -2743,7 +3358,7 @@ compose_mpls_pop_action(struct xlate_ctx *ctx, ovs_be16 eth_type) ctx->xbridge->name, FLOW_MAX_MPLS_LABELS); } ctx->exit = true; - ofpbuf_clear(&ctx->xout->odp_actions); + ofpbuf_clear(ctx->xout->odp_actions); } } @@ -2804,24 +3419,23 @@ static bool compose_dec_mpls_ttl_action(struct xlate_ctx *ctx) { struct flow *flow = &ctx->xin->flow; - uint8_t ttl = mpls_lse_to_ttl(flow->mpls_lse[0]); struct flow_wildcards *wc = &ctx->xout->wc; - memset(&wc->masks.mpls_lse, 0xff, sizeof wc->masks.mpls_lse); if (eth_type_mpls(flow->dl_type)) { + uint8_t ttl = mpls_lse_to_ttl(flow->mpls_lse[0]); + + wc->masks.mpls_lse[0] |= htonl(MPLS_TTL_MASK); if (ttl > 1) { ttl--; set_mpls_lse_ttl(&flow->mpls_lse[0], ttl); return false; } else { execute_controller_action(ctx, UINT16_MAX, OFPR_INVALID_TTL, 0); - - /* Stop processing for current table. */ - return true; } - } else { - return true; } + + /* Stop processing for current table. */ + return true; } static void @@ -2850,7 +3464,11 @@ xlate_output_action(struct xlate_ctx *ctx, flood_packets(ctx, true); break; case OFPP_CONTROLLER: - execute_controller_action(ctx, max_len, OFPR_ACTION, 0); + execute_controller_action(ctx, max_len, + (ctx->in_group ? OFPR_GROUP + : ctx->in_action_set ? OFPR_ACTION_SET + : OFPR_ACTION), + 0); break; case OFPP_NONE: break; @@ -3063,13 +3681,15 @@ xlate_sample_action(struct xlate_ctx *ctx, } ctx->xout->slow |= commit_odp_actions(&ctx->xin->flow, &ctx->base_flow, - &ctx->xout->odp_actions, - &ctx->xout->wc); + ctx->xout->odp_actions, + &ctx->xout->wc, + ctx->xbridge->masked_set_action); compose_flow_sample_cookie(os->probability, os->collector_set_id, os->obs_domain_id, os->obs_point_id, &cookie); - compose_sample_action(ctx->xbridge, &ctx->xout->odp_actions, &ctx->xin->flow, - probability, &cookie, sizeof cookie.flow_sample); + compose_sample_action(ctx->xbridge, ctx->xout->odp_actions, &ctx->xin->flow, + probability, &cookie, sizeof cookie.flow_sample, + ODPP_NONE); } static bool @@ -3085,7 +3705,8 @@ may_receive(const struct xport *xport, struct xlate_ctx *ctx) * disabled. If just learning is enabled, we need to have * OFPP_NORMAL and the learning action have a look at the packet * before we can drop it. */ - if (!xport_stp_forward_state(xport) && !xport_stp_learn_state(xport)) { + if ((!xport_stp_forward_state(xport) && !xport_stp_learn_state(xport)) || + (!xport_rstp_forward_state(xport) && !xport_rstp_learn_state(xport))) { return false; } @@ -3095,8 +3716,31 @@ may_receive(const struct xport *xport, struct xlate_ctx *ctx) static void xlate_write_actions(struct xlate_ctx *ctx, const struct ofpact *a) { - struct ofpact_nest *on = ofpact_get_WRITE_ACTIONS(a); - ofpbuf_put(&ctx->action_set, on->actions, ofpact_nest_get_action_len(on)); + const struct ofpact_nest *on = ofpact_get_WRITE_ACTIONS(a); + size_t on_len = ofpact_nest_get_action_len(on); + const struct ofpact *inner; + + /* Maintain actset_output depending on the contents of the action set: + * + * - OFPP_UNSET, if there is no "output" action. + * + * - The output port, if there is an "output" action and no "group" + * action. + * + * - OFPP_UNSET, if there is a "group" action. + */ + if (!ctx->action_set_has_group) { + OFPACT_FOR_EACH (inner, on->actions, on_len) { + if (inner->type == OFPACT_OUTPUT) { + ctx->xin->flow.actset_output = ofpact_get_OUTPUT(inner)->port; + } else if (inner->type == OFPACT_GROUP) { + ctx->xin->flow.actset_output = OFPP_UNSET; + ctx->action_set_has_group = true; + } + } + } + + ofpbuf_put(&ctx->action_set, on->actions, on_len); ofpact_pad(&ctx->action_set); } @@ -3106,12 +3750,92 @@ xlate_action_set(struct xlate_ctx *ctx) uint64_t action_list_stub[1024 / 64]; struct ofpbuf action_list; + ctx->in_action_set = true; ofpbuf_use_stub(&action_list, action_list_stub, sizeof action_list_stub); ofpacts_execute_action_set(&action_list, &ctx->action_set); do_xlate_actions(ofpbuf_data(&action_list), ofpbuf_size(&action_list), ctx); + ctx->in_action_set = false; ofpbuf_uninit(&action_list); } +static bool +ofpact_needs_recirculation_after_mpls(const struct ofpact *a, struct xlate_ctx *ctx) +{ + struct flow_wildcards *wc = &ctx->xout->wc; + struct flow *flow = &ctx->xin->flow; + + if (!ctx->was_mpls) { + return false; + } + + switch (a->type) { + case OFPACT_OUTPUT: + case OFPACT_GROUP: + case OFPACT_CONTROLLER: + case OFPACT_STRIP_VLAN: + case OFPACT_SET_VLAN_PCP: + case OFPACT_SET_VLAN_VID: + case OFPACT_ENQUEUE: + case OFPACT_PUSH_VLAN: + case OFPACT_SET_ETH_SRC: + case OFPACT_SET_ETH_DST: + case OFPACT_SET_TUNNEL: + case OFPACT_SET_QUEUE: + case OFPACT_POP_QUEUE: + case OFPACT_CONJUNCTION: + case OFPACT_NOTE: + case OFPACT_OUTPUT_REG: + case OFPACT_EXIT: + case OFPACT_METER: + case OFPACT_WRITE_METADATA: + case OFPACT_WRITE_ACTIONS: + case OFPACT_CLEAR_ACTIONS: + case OFPACT_SAMPLE: + return false; + + case OFPACT_POP_MPLS: + case OFPACT_DEC_MPLS_TTL: + case OFPACT_SET_MPLS_TTL: + case OFPACT_SET_MPLS_TC: + case OFPACT_SET_MPLS_LABEL: + case OFPACT_SET_IPV4_SRC: + case OFPACT_SET_IPV4_DST: + case OFPACT_SET_IP_DSCP: + case OFPACT_SET_IP_ECN: + case OFPACT_SET_IP_TTL: + case OFPACT_SET_L4_SRC_PORT: + case OFPACT_SET_L4_DST_PORT: + case OFPACT_RESUBMIT: + case OFPACT_STACK_PUSH: + case OFPACT_STACK_POP: + case OFPACT_DEC_TTL: + case OFPACT_MULTIPATH: + case OFPACT_BUNDLE: + case OFPACT_LEARN: + case OFPACT_FIN_TIMEOUT: + case OFPACT_GOTO_TABLE: + return true; + + case OFPACT_REG_MOVE: + return (mf_is_l3_or_higher(ofpact_get_REG_MOVE(a)->dst.field) || + mf_is_l3_or_higher(ofpact_get_REG_MOVE(a)->src.field)); + + case OFPACT_SET_FIELD: + return mf_is_l3_or_higher(ofpact_get_SET_FIELD(a)->field); + + case OFPACT_PUSH_MPLS: + /* Recirculate if it is an IP packet with a zero ttl. This may + * indicate that the packet was previously MPLS and an MPLS pop action + * converted it to IP. In this case recirculating should reveal the IP + * TTL which is used as the basis for a new MPLS LSE. */ + return (!flow_count_mpls_labels(flow, wc) + && flow->nw_ttl == 0 + && is_ip_any(flow)); + } + + OVS_NOT_REACHED(); +} + static void do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, struct xlate_ctx *ctx) @@ -3120,6 +3844,9 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, struct flow *flow = &ctx->xin->flow; const struct ofpact *a; + if (ovs_native_tunneling_is_on(ctx->xbridge->ofproto)) { + tnl_arp_snoop(flow, wc, ctx->xbridge->name); + } /* dl_type already in the mask, not set below. */ OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) { @@ -3132,6 +3859,11 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, break; } + if (ofpact_needs_recirculation_after_mpls(a, ctx)) { + compose_recirculate_action(ctx, ofpacts, a, ofpacts_len); + return; + } + switch (a->type) { case OFPACT_OUTPUT: xlate_output_action(ctx, ofpact_get_OUTPUT(a)->port, @@ -3152,6 +3884,8 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, break; case OFPACT_ENQUEUE: + memset(&wc->masks.skb_priority, 0xff, + sizeof wc->masks.skb_priority); xlate_enqueue_action(ctx, ofpact_get_ENQUEUE(a)); break; @@ -3234,7 +3968,7 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, break; case OFPACT_SET_L4_SRC_PORT: - if (is_ip_any(flow)) { + if (is_ip_any(flow) && !(flow->nw_frag & FLOW_NW_FRAG_LATER)) { memset(&wc->masks.nw_proto, 0xff, sizeof wc->masks.nw_proto); memset(&wc->masks.tp_src, 0xff, sizeof wc->masks.tp_src); flow->tp_src = htons(ofpact_get_SET_L4_SRC_PORT(a)->port); @@ -3242,7 +3976,7 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, break; case OFPACT_SET_L4_DST_PORT: - if (is_ip_any(flow)) { + if (is_ip_any(flow) && !(flow->nw_frag & FLOW_NW_FRAG_LATER)) { memset(&wc->masks.nw_proto, 0xff, sizeof wc->masks.nw_proto); memset(&wc->masks.tp_dst, 0xff, sizeof wc->masks.tp_dst); flow->tp_dst = htons(ofpact_get_SET_L4_DST_PORT(a)->port); @@ -3258,10 +3992,14 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, break; case OFPACT_SET_QUEUE: + memset(&wc->masks.skb_priority, 0xff, + sizeof wc->masks.skb_priority); xlate_set_queue_action(ctx, ofpact_get_SET_QUEUE(a)->queue_id); break; case OFPACT_POP_QUEUE: + memset(&wc->masks.skb_priority, 0xff, + sizeof wc->masks.skb_priority); flow->skb_priority = ctx->orig_skb_priority; break; @@ -3269,10 +4007,6 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, nxm_execute_reg_move(ofpact_get_REG_MOVE(a), flow, wc); break; - case OFPACT_REG_LOAD: - nxm_execute_reg_load(ofpact_get_REG_LOAD(a), flow, wc); - break; - case OFPACT_SET_FIELD: set_field = ofpact_get_SET_FIELD(a); mf = set_field->field; @@ -3289,9 +4023,13 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, && !eth_type_mpls(flow->dl_type)) { break; } - + /* A flow may wildcard nw_frag. Do nothing if setting a trasport + * header field on a packet that does not have them. */ mf_mask_field_and_prereqs(mf, &wc->masks); - mf_set_flow_value(mf, &set_field->value, flow); + if (mf_are_prereqs_ok(mf, flow)) { + mf_set_flow_value_masked(mf, &set_field->value, + &set_field->mask, flow); + } break; case OFPACT_STACK_PUSH: @@ -3358,6 +4096,16 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, xlate_learn_action(ctx, ofpact_get_LEARN(a)); break; + case OFPACT_CONJUNCTION: { + /* A flow with a "conjunction" action represents part of a special + * kind of "set membership match". Such a flow should not actually + * get executed, but it could via, say, a "packet-out", even though + * that wouldn't be useful. Log it to help debugging. */ + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); + VLOG_INFO_RL(&rl, "executing no-op conjunction action"); + break; + } + case OFPACT_EXIT: ctx->exit = true; break; @@ -3370,6 +4118,8 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, case OFPACT_CLEAR_ACTIONS: ofpbuf_clear(&ctx->action_set); + ctx->xin->flow.actset_output = OFPP_UNSET; + ctx->action_set_has_group = false; break; case OFPACT_WRITE_ACTIONS: @@ -3389,7 +4139,12 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, case OFPACT_GOTO_TABLE: { struct ofpact_goto_table *ogt = ofpact_get_GOTO_TABLE(a); - ovs_assert(ctx->table_id < ogt->table_id); + /* Allow ctx->table_id == TBL_INTERNAL, which will be greater + * than ogt->table_id. This is to allow goto_table actions that + * triggered recirculation: ctx->table_id will be TBL_INTERNAL + * after recirculation. */ + ovs_assert(ctx->table_id == TBL_INTERNAL + || ctx->table_id < ogt->table_id); xlate_table_action(ctx, ctx->xin->flow.in_port.ofp_port, ogt->table_id, true, true); break; @@ -3404,11 +4159,14 @@ do_xlate_actions(const struct ofpact *ofpacts, size_t ofpacts_len, void xlate_in_init(struct xlate_in *xin, struct ofproto_dpif *ofproto, - const struct flow *flow, struct rule_dpif *rule, - uint16_t tcp_flags, const struct ofpbuf *packet) + const struct flow *flow, ofp_port_t in_port, + struct rule_dpif *rule, uint16_t tcp_flags, + const struct ofpbuf *packet) { xin->ofproto = ofproto; xin->flow = *flow; + xin->flow.in_port.ofp_port = in_port; + xin->flow.actset_output = OFPP_UNSET; xin->packet = packet; xin->may_learn = packet != NULL; xin->rule = rule; @@ -3420,13 +4178,14 @@ xlate_in_init(struct xlate_in *xin, struct ofproto_dpif *ofproto, xin->report_hook = NULL; xin->resubmit_stats = NULL; xin->skip_wildcards = false; + xin->odp_actions = NULL; } void xlate_out_uninit(struct xlate_out *xout) { - if (xout) { - ofpbuf_uninit(&xout->odp_actions); + if (xout && xout->odp_actions == &xout->odp_actions_buf) { + ofpbuf_uninit(xout->odp_actions); } } @@ -3441,14 +4200,6 @@ xlate_actions_for_side_effects(struct xlate_in *xin) xlate_out_uninit(&xout); } -static void -xlate_report(struct xlate_ctx *ctx, const char *s) -{ - if (ctx->xin->report_hook) { - ctx->xin->report_hook(ctx->xin, s, ctx->recurse); - } -} - void xlate_out_copy(struct xlate_out *dst, const struct xlate_out *src) { @@ -3460,10 +4211,11 @@ xlate_out_copy(struct xlate_out *dst, const struct xlate_out *src) dst->nf_output_iface = src->nf_output_iface; dst->mirrors = src->mirrors; - ofpbuf_use_stub(&dst->odp_actions, dst->odp_actions_stub, + dst->odp_actions = &dst->odp_actions_buf; + ofpbuf_use_stub(dst->odp_actions, dst->odp_actions_stub, sizeof dst->odp_actions_stub); - ofpbuf_put(&dst->odp_actions, ofpbuf_data(&src->odp_actions), - ofpbuf_size(&src->odp_actions)); + ofpbuf_put(dst->odp_actions, ofpbuf_data(src->odp_actions), + ofpbuf_size(src->odp_actions)); } static struct skb_priority_to_dscp * @@ -3490,6 +4242,12 @@ dscp_from_skb_priority(const struct xport *xport, uint32_t skb_priority, return pdscp != NULL; } +static size_t +count_skb_priorities(const struct xport *xport) +{ + return hmap_count(&xport->skb_priorities); +} + static void clear_skb_priorities(struct xport *xport) { @@ -3508,8 +4266,8 @@ actions_output_to_local_port(const struct xlate_ctx *ctx) const struct nlattr *a; unsigned int left; - NL_ATTR_FOR_EACH_UNSAFE (a, left, ofpbuf_data(&ctx->xout->odp_actions), - ofpbuf_size(&ctx->xout->odp_actions)) { + NL_ATTR_FOR_EACH_UNSAFE (a, left, ofpbuf_data(ctx->xout->odp_actions), + ofpbuf_size(ctx->xout->odp_actions)) { if (nl_attr_type(a) == OVS_ACTION_ATTR_OUTPUT && nl_attr_get_odp_port(a) == local_odp_port) { return true; @@ -3518,6 +4276,79 @@ actions_output_to_local_port(const struct xlate_ctx *ctx) return false; } +#if defined(__linux__) +/* Returns the maximum number of packets that the Linux kernel is willing to + * queue up internally to certain kinds of software-implemented ports, or the + * default (and rarely modified) value if it cannot be determined. */ +static int +netdev_max_backlog(void) +{ + static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER; + static int max_backlog = 1000; /* The normal default value. */ + + if (ovsthread_once_start(&once)) { + static const char filename[] = "/proc/sys/net/core/netdev_max_backlog"; + FILE *stream; + int n; + + stream = fopen(filename, "r"); + if (!stream) { + VLOG_WARN("%s: open failed (%s)", filename, ovs_strerror(errno)); + } else { + if (fscanf(stream, "%d", &n) != 1) { + VLOG_WARN("%s: read error", filename); + } else if (n <= 100) { + VLOG_WARN("%s: unexpectedly small value %d", filename, n); + } else { + max_backlog = n; + } + fclose(stream); + } + ovsthread_once_done(&once); + + VLOG_DBG("%s: using %d max_backlog", filename, max_backlog); + } + + return max_backlog; +} + +/* Counts and returns the number of OVS_ACTION_ATTR_OUTPUT actions in + * 'odp_actions'. */ +static int +count_output_actions(const struct ofpbuf *odp_actions) +{ + const struct nlattr *a; + size_t left; + int n = 0; + + NL_ATTR_FOR_EACH_UNSAFE (a, left, ofpbuf_data(odp_actions), + ofpbuf_size(odp_actions)) { + if (a->nla_type == OVS_ACTION_ATTR_OUTPUT) { + n++; + } + } + return n; +} +#endif /* defined(__linux__) */ + +/* Returns true if 'odp_actions' contains more output actions than the datapath + * can reliably handle in one go. On Linux, this is the value of the + * net.core.netdev_max_backlog sysctl, which limits the maximum number of + * packets that the kernel is willing to queue up for processing while the + * datapath is processing a set of actions. */ +static bool +too_many_output_actions(const struct ofpbuf *odp_actions OVS_UNUSED) +{ +#ifdef __linux__ + return (ofpbuf_size(odp_actions) / NL_A_U32_SIZE > netdev_max_backlog() + && count_output_actions(odp_actions) > netdev_max_backlog()); +#else + /* OSes other than Linux might have similar limits, but we don't know how + * to determine them.*/ + return false; +#endif +} + /* Translates the 'ofpacts_len' bytes of "struct ofpacts" starting at 'ofpacts' * into datapath actions in 'odp_actions', using 'ctx'. * @@ -3531,7 +4362,6 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) struct flow *flow = &xin->flow; struct rule_dpif *rule = NULL; - const struct rule_actions *actions = NULL; enum slow_path_reason special; const struct ofpact *ofpacts; struct xport *in_port; @@ -3572,9 +4402,14 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) ctx.xout->has_fin_timeout = false; ctx.xout->nf_output_iface = NF_OUT_DROP; ctx.xout->mirrors = 0; - ofpbuf_use_stub(&ctx.xout->odp_actions, ctx.xout->odp_actions_stub, - sizeof ctx.xout->odp_actions_stub); - ofpbuf_reserve(&ctx.xout->odp_actions, NL_A_U32_SIZE); + + xout->odp_actions = xin->odp_actions; + if (!xout->odp_actions) { + xout->odp_actions = &xout->odp_actions_buf; + ofpbuf_use_stub(xout->odp_actions, xout->odp_actions_stub, + sizeof xout->odp_actions_stub); + } + ofpbuf_reserve(xout->odp_actions, NL_A_U32_SIZE); ctx.xbridge = xbridge_lookup(xcfg, xin->ofproto); if (!ctx.xbridge) { @@ -3589,7 +4424,6 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) flow_wildcards_init_catchall(wc); memset(&wc->masks.in_port, 0xff, sizeof wc->masks.in_port); - memset(&wc->masks.skb_priority, 0xff, sizeof wc->masks.skb_priority); memset(&wc->masks.dl_type, 0xff, sizeof wc->masks.dl_type); if (is_ip_any(flow)) { wc->masks.nw_frag |= FLOW_NW_FRAG_MASK; @@ -3604,16 +4438,18 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) ctx.recurse = 0; ctx.resubmits = 0; ctx.in_group = false; + ctx.in_action_set = false; ctx.orig_skb_priority = flow->skb_priority; ctx.table_id = 0; ctx.exit = false; ctx.use_recirc = false; + ctx.was_mpls = false; if (!xin->ofpacts && !ctx.rule) { - ctx.table_id = rule_dpif_lookup(ctx.xbridge->ofproto, flow, - !xin->skip_wildcards ? wc : NULL, - &rule, ctx.xin->xcache != NULL, - ctx.xin->resubmit_stats); + rule = rule_dpif_lookup(ctx.xbridge->ofproto, flow, + xin->skip_wildcards ? NULL : wc, + ctx.xin->xcache != NULL, + ctx.xin->resubmit_stats, &ctx.table_id); if (ctx.xin->resubmit_stats) { rule_dpif_credit_stats(rule, ctx.xin->resubmit_stats); } @@ -3624,6 +4460,10 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) entry->u.rule = rule; } ctx.rule = rule; + + if (OVS_UNLIKELY(ctx.xin->resubmit_hook)) { + ctx.xin->resubmit_hook(ctx.xin, rule, 0); + } } xout->fail_open = ctx.rule && rule_dpif_is_fail_open(ctx.rule); @@ -3631,7 +4471,8 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) ofpacts = xin->ofpacts; ofpacts_len = xin->ofpacts_len; } else if (ctx.rule) { - actions = rule_dpif_get_actions(ctx.rule); + const struct rule_actions *actions = rule_dpif_get_actions(ctx.rule); + ofpacts = actions->ofpacts; ofpacts_len = actions->ofpacts_len; } else { @@ -3639,6 +4480,8 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) } ofpbuf_use_stub(&ctx.stack, ctx.init_stack, sizeof ctx.init_stack); + + ctx.action_set_has_group = false; ofpbuf_use_stub(&ctx.action_set, ctx.action_set_stub, sizeof ctx.action_set_stub); @@ -3648,29 +4491,6 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) orig_flow = *flow; } - if (flow->nw_frag & FLOW_NW_FRAG_ANY) { - switch (ctx.xbridge->frag) { - case OFPC_FRAG_NORMAL: - /* We must pretend that transport ports are unavailable. */ - flow->tp_src = ctx.base_flow.tp_src = htons(0); - flow->tp_dst = ctx.base_flow.tp_dst = htons(0); - break; - - case OFPC_FRAG_DROP: - return; - - case OFPC_FRAG_REASM: - OVS_NOT_REACHED(); - - case OFPC_FRAG_NX_MATCH: - /* Nothing to do. */ - break; - - case OFPC_INVALID_TTL_TO_CONTROLLER: - OVS_NOT_REACHED(); - } - } - in_port = get_ofp_port(ctx.xbridge, flow->in_port.ofp_port); if (in_port && in_port->is_tunnel) { if (ctx.xin->resubmit_stats) { @@ -3703,15 +4523,16 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) add_sflow_action(&ctx); add_ipfix_action(&ctx); - sample_actions_len = ofpbuf_size(&ctx.xout->odp_actions); + sample_actions_len = ofpbuf_size(ctx.xout->odp_actions); if (tnl_may_send && (!in_port || may_receive(in_port, &ctx))) { do_xlate_actions(ofpacts, ofpacts_len, &ctx); /* We've let OFPP_NORMAL and the learning action look at the * packet, so drop it now if forwarding is disabled. */ - if (in_port && !xport_stp_forward_state(in_port)) { - ofpbuf_set_size(&ctx.xout->odp_actions, sample_actions_len); + if (in_port && (!xport_stp_forward_state(in_port) || + !xport_rstp_forward_state(in_port))) { + ofpbuf_set_size(ctx.xout->odp_actions, sample_actions_len); } } @@ -3732,13 +4553,16 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) } } - if (nl_attr_oversized(ofpbuf_size(&ctx.xout->odp_actions))) { + if (nl_attr_oversized(ofpbuf_size(ctx.xout->odp_actions))) { /* These datapath actions are too big for a Netlink attribute, so we * can't hand them to the kernel directly. dpif_execute() can execute * them one by one with help, so just mark the result as SLOW_ACTION to * prevent the flow from being installed. */ COVERAGE_INC(xlate_actions_oversize); ctx.xout->slow |= SLOW_ACTION; + } else if (too_many_output_actions(ctx.xout->odp_actions)) { + COVERAGE_INC(xlate_actions_too_many_output); + ctx.xout->slow |= SLOW_ACTION; } if (mbridge_has_mirrors(ctx.xbridge->mbridge)) { @@ -3889,11 +4713,16 @@ xlate_cache_normal(struct ofproto_dpif *ofproto, struct flow *flow, int vlan) /* Push stats and perform side effects of flow translation. */ void -xlate_push_stats(struct xlate_cache *xcache, bool may_learn, +xlate_push_stats(struct xlate_cache *xcache, const struct dpif_flow_stats *stats) { struct xc_entry *entry; struct ofpbuf entries = xcache->entries; + uint8_t dmac[ETH_ADDR_LEN]; + + if (!stats->n_packets) { + return; + } XC_ENTRY_FOR_EACH (entry, entries, xcache) { switch (entry->type) { @@ -3917,10 +4746,7 @@ xlate_push_stats(struct xlate_cache *xcache, bool may_learn, stats->n_packets, stats->n_bytes); break; case XC_LEARN: - if (may_learn) { - ofproto_dpif_flow_mod(entry->u.learn.ofproto, - entry->u.learn.fm); - } + ofproto_dpif_flow_mod(entry->u.learn.ofproto, entry->u.learn.fm); break; case XC_NORMAL: xlate_cache_normal(entry->u.normal.ofproto, entry->u.normal.flow, @@ -3934,6 +4760,10 @@ xlate_push_stats(struct xlate_cache *xcache, bool may_learn, group_dpif_credit_stats(entry->u.group.group, entry->u.group.bucket, stats); break; + case XC_TNL_ARP: + /* Lookup arp to avoid arp timeout. */ + tnl_arp_lookup(entry->u.tnl_arp_cache.br_name, entry->u.tnl_arp_cache.d_ip, dmac); + break; default: OVS_NOT_REACHED(); } @@ -4004,6 +4834,8 @@ xlate_cache_clear(struct xlate_cache *xcache) case XC_GROUP: group_dpif_unref(entry->u.group.group); break; + case XC_TNL_ARP: + break; default: OVS_NOT_REACHED(); }