X-Git-Url: http://git.cascardo.eti.br/?a=blobdiff_plain;f=ofproto%2Fofproto.c;h=127d8c3dd781edc346655e65ee357e13f80ff4fb;hb=58f195398e4d457d2b83b760935a65a70d9b1384;hp=5233a4ddd1b770402122771aa7ad701332e05a56;hpb=538919d3a672eab8a561048acf9a8e1721cd559c;p=cascardo%2Fovs.git diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 5233a4ddd..127d8c3dd 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -535,6 +535,7 @@ ofproto_create(const char *datapath_name, const char *datapath_type, if (error) { VLOG_ERR("failed to open datapath %s: %s", datapath_name, ovs_strerror(error)); + connmgr_destroy(ofproto->connmgr); ofproto_destroy__(ofproto); return error; } @@ -1390,8 +1391,6 @@ ofproto_destroy__(struct ofproto *ofproto) ovs_rwlock_destroy(&ofproto->groups_rwlock); hmap_destroy(&ofproto->groups); - connmgr_destroy(ofproto->connmgr); - hmap_remove(&all_ofprotos, &ofproto->hmap_node); free(ofproto->name); free(ofproto->type); @@ -1450,6 +1449,12 @@ ofproto_destroy(struct ofproto *p) } p->ofproto_class->destruct(p); + + /* We should not postpone this because it involves deleting a listening + * socket which we may want to reopen soon. 'connmgr' should not be used + * by other threads */ + connmgr_destroy(p->connmgr); + /* Destroying rules is deferred, must have 'ofproto' around for them. */ ovsrcu_postpone(ofproto_destroy__, p); }