ofp-util: Abstract table miss configuration and fix related bugs.
authorBen Pfaff <blp@nicira.com>
Mon, 11 Aug 2014 18:31:45 +0000 (11:31 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 11 Aug 2014 18:31:45 +0000 (11:31 -0700)
commit3c1bb3962236c6471fea3eb8dd2e5a83b1b4ea81
tree1b34ceefa4f1f4ddce5d7b3984d9639d103e2f34
parentb187a283c621acbccec65dc7b5f3dc67cb837ce7
ofp-util: Abstract table miss configuration and fix related bugs.

The ofproto implementation has had an abstraction layer on top of
OFPTC11_TABLE_MISS for a while.  This commit pushes that abstraction layer
farther down, into ofp-util.  This will be more useful in an upcoming
commit.

During the conversion I realized that the previous implementation was
not entirely correct.  In particular, the OpenFlow 1.3+ "table mod" was
still being treated as if it had table miss configuration bits, even
though it doesn't.  This commit fixes that issue and updates the tests.

OpenFlow 1.4 adds some more OFPTC_* flags that this new abstraction doesn't
yet support, but OVS didn't support those flags any better before this
commit, so abstracting those is left as future work.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
12 files changed:
lib/ofp-parse.c
lib/ofp-print.c
lib/ofp-util.c
lib/ofp-util.h
ofproto/connmgr.c
ofproto/ofproto-dpif.c
ofproto/ofproto-provider.h
ofproto/ofproto.c
ofproto/ofproto.h
tests/ofp-print.at
tests/ofproto-dpif.at
tests/ofproto.at