device property: Avoid potential dereferences of invalid pointers
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 27 Apr 2016 11:04:20 +0000 (14:04 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 27 Apr 2016 21:40:02 +0000 (23:40 +0200)
commit0224a4a30b57385a60065aa598181868881d8fc6
treed1cc248a6c1f86a23977e18cf35586315f4a0704
parent02da2d72174c61988eb4456b53f405e3ebdebce4
device property: Avoid potential dereferences of invalid pointers

Since fwnode may hold ERR_PTR(-ENODEV) or it may be NULL,
the fwnode type checks is_of_node(), is_acpi_node() and is
is_pset_node() need to consider it. Using IS_ERR_OR_NULL()
to check it.

Fixes: 0d67e0fa1664 (device property: fix for a case of use-after-free)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
[ rjw: Subject & changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/property.c
include/acpi/acpi_bus.h
include/linux/of.h