Reduce sequential pointer derefs in scsi_error.c and reduce size as well
authorJesper Juhl <jj@chaosbits.net>
Mon, 21 Mar 2011 19:47:31 +0000 (20:47 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 21 Mar 2011 22:54:35 +0000 (15:54 -0700)
commit0bf8c869701039b12c3520cb1bb1689595ab108b
tree4430e15c9e9a993a7bc63306e3bba7f65962c1cb
parent38f7aa23c4dd5f9af13dffca49879c42a61b0a01
Reduce sequential pointer derefs in scsi_error.c and reduce size as well

This patch reduces the number of sequential pointer derefs in
drivers/scsi/scsi_error.c

This has been submitted a number of times over a couple of years.  I
believe this version adresses all comments it has gathered over time.
Please apply or reject with a reason.

The benefits are:

 - makes the code easier to read.  Lots of sequential derefs of the same
   pointers is not easy on the eye.

 - theoretically at least, just dereferencing the pointers once can
   allow the compiler to generally slightly faster code, so in theory
   this could also be a micro speed optimization.

 - reduces size of object file (tiny effect: on x86-64, in at least one
   configuration, the text size decreased from 9439 bytes to 9400)

 - removes some pointless (mostly trailing) whitespace.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/scsi_error.c