ebpf: emit correct src_reg for conditional jumps
authorTycho Andersen <tycho.andersen@canonical.com>
Fri, 11 Sep 2015 00:25:07 +0000 (18:25 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Sep 2015 21:52:41 +0000 (14:52 -0700)
commit19539ce783dd27768d4f7f3b753152bf983db65b
tree9b60e9e3326ed629ada5b85bbfbdb018550eb223
parent1853c949646005b5959c483becde86608f548f24
ebpf: emit correct src_reg for conditional jumps

Instead of always emitting BPF_REG_X, let's emit BPF_REG_X only when the
source actually is BPF_X. This causes programs generated by the classic
converter to not be importable via bpf(), as the eBPF verifier checks that
the src_reg is correct or 0. While not a problem yet, this will be a
problem when BPF_PROG_DUMP lands, and we can potentially dump and re-import
programs generated by the converter.

Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
CC: Alexei Starovoitov <ast@kernel.org>
CC: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/filter.c