PM / Domains: Fix bad of_node_put() in failure paths of genpd_dev_pm_attach()
authorEric Anholt <eric@anholt.net>
Tue, 1 Dec 2015 17:39:31 +0000 (09:39 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 4 Dec 2015 00:21:17 +0000 (01:21 +0100)
commit265e2cf672aaa9421e7012b4aa30c0ed80f1a447
treee1c7d12d6cf4c3ee213f4263f1eabd01b5696d81
parent712caed435077966143a1ed2e6ae345916068d2e
PM / Domains: Fix bad of_node_put() in failure paths of genpd_dev_pm_attach()

It looks like these meant to be unreffing the
of_parse_phandle_with_args() node, since the error paths above it
don't do of_node_put.  That function returns a new ref in pd_args.np,
though, not a new ref on dev->of_node.  Also, it would have leaked the
ref in the success case.

Fixes "ERROR: Bad of_node_put()" on bcm2835 in the -EPROBE_DEFER case.

Fixes: aa42240ab254 (PM / Domains: Add generic OF-based PM domain look-up)
Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Kevin Hilman <khilman@linaro.org>
Cc: 3.18+ <stable@vger.kernel.org> # 3.18+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/domain.c