ext4: avoid deadlock when expanding inode size
authorJan Kara <jack@suse.cz>
Thu, 11 Aug 2016 16:38:55 +0000 (12:38 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 11 Aug 2016 16:38:55 +0000 (12:38 -0400)
commit2e81a4eeedcaa66e35f58b81e0755b87057ce392
treec51fa9b5eb8a39ec51afcaf836b2a7ad597743cd
parent443a8c41cd49de66a3fda45b32b9860ea0292b84
ext4: avoid deadlock when expanding inode size

When we need to move xattrs into external xattr block, we call
ext4_xattr_block_set() from ext4_expand_extra_isize_ea(). That may end
up calling ext4_mark_inode_dirty() again which will recurse back into
the inode expansion code leading to deadlocks.

Protect from recursion using EXT4_STATE_NO_EXPAND inode flag and move
its management into ext4_expand_extra_isize_ea() since its manipulation
is safe there (due to xattr_sem) from possible races with
ext4_xattr_set_handle() which plays with it as well.

CC: stable@vger.kernel.org # 4.4.x
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c
fs/ext4/xattr.c