net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory
authorSasha Levin <sasha.levin@oracle.com>
Thu, 7 Jan 2016 19:52:43 +0000 (14:52 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 10 Jan 2016 23:01:01 +0000 (18:01 -0500)
commit320f1a4a175e7cd5d3f006f92b4d4d3e2cbb7bb5
tree3028662cc73e52e7c7d5c025f3207dbb9f3fc25a
parent18715b261541f35ccede9b8686ee3ebaac697d38
net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory

proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.

Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.

Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sysctl.c