drm/i915/skl: Fix always true comparison in a revision id check
authorDamien Lespiau <damien.lespiau@intel.com>
Wed, 11 Feb 2015 18:21:43 +0000 (18:21 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 13 Feb 2015 22:28:39 +0000 (23:28 +0100)
commit35c8ce6ac5c2efedf76912c86b2021a6e4ec1655
tree9168066e963cf7ad669a2fb29e073721cd138293
parent77719d28aeed5cad45b61d66b198b2575a5bf4cc
drm/i915/skl: Fix always true comparison in a revision id check

It's always a good idea to keep static analysis happy (also because it
prompts doing the check like I proposed :), this time smatch complains:

drivers/gpu/drm/i915/intel_ringbuffer.c:891 gen9_init_workarounds() warn:
  always true condition '((->dev->pdev->revision) >= (0)) => (0-255 >= 0)'

That's because revision is a u8. Tweak a bit the condition then.

Cc: Nick Hoath <nicholas.hoath@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Nick Hoath <nicholas.hoath@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_ringbuffer.c