fib_trie: Correctly handle case of key == 0 in leaf_walk_rcu
authorAlexander Duyck <alexander.h.duyck@redhat.com>
Tue, 10 Mar 2015 18:25:41 +0000 (11:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Mar 2015 20:13:55 +0000 (16:13 -0400)
commit3ec320dd5c9465fbed3c84dd14ed3941ce757823
tree5b03973355f122f5ddf9e911cb7e02305e9834f8
parent7c23aaf2eacdd10825237160cb8005efd7222061
fib_trie: Correctly handle case of key == 0 in leaf_walk_rcu

In the case of a trie that had no tnodes with a key of 0 the initial
look-up would fail resulting in an out-of-bounds cindex on the first tnode.
This resulted in an entire trie being skipped.

In order resolve this I have updated the cindex logic in the initial
look-up so that if the key is zero we will always traverse the child zero
path.

Fixes: 8be33e95 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
Reported-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Tested-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_trie.c