arm64: bpf: add extra pass to handle faulty codegen
authorZi Shen Lim <zlim.lnx@gmail.com>
Thu, 14 Jan 2016 07:33:22 +0000 (23:33 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 18 Jan 2016 00:15:26 +0000 (19:15 -0500)
commit42ff712bc0c3d7cd60d29b319aecd2d2c8cc75d4
tree41722ff39391f428b5ee48ce461b32329be4fda4
parentc94ae4f7c5ec6b6fddde1c08809d5e32a963d7f3
arm64: bpf: add extra pass to handle faulty codegen

Code generation functions in arch/arm64/kernel/insn.c previously
BUG_ON invalid parameters. Following change of that behavior, now we
need to handle the error case where AARCH64_BREAK_FAULT is returned.

Instead of error-handling on every emit() in JIT, we add a new
validation pass at the end of JIT compilation. There's no point in
running JITed code at run-time only to trap due to AARCH64_BREAK_FAULT.
Instead, we drop this failed JIT compilation and allow the system to
gracefully fallback on the BPF interpreter.

Signed-off-by: Zi Shen Lim <zlim.lnx@gmail.com>
Suggested-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/arm64/net/bpf_jit_comp.c