perf machine: Search for modules in %s/lib/modules/%s
authorRichard Yao <ryao@gentoo.org>
Sat, 26 Apr 2014 17:17:55 +0000 (13:17 -0400)
committerJiri Olsa <jolsa@kernel.org>
Wed, 30 Apr 2014 14:49:29 +0000 (16:49 +0200)
commit61d4290cc1f10588147b76b385875f06827d47ff
tree1ecb38dfa2a5cdd6046395fc17a625a86746a378
parent611ec127165b572f02823e152d6774e2145305a3
perf machine: Search for modules in %s/lib/modules/%s

Modules installed outside of the kernel's build system should go into
"%s/lib/modules/%s/extra", but at present, perf will only look at them
when they are in "%s/lib/modules/%s/kernel". Lets encourage good
citizenship by relaxing this requirement to "%s/lib/modules/%s". This
way open source modules that are out-of-tree have no incentive to start
populating a directory reserved for in-kernel modules and I can stop
hex-editing my system's perf binary when profiling OSS out-of-tree
modules.

Feedback from Namhyung Kim correctly revealed that the hex-edits that I
had been doing meant that perf was also traversing the build and source
symlinks in %s/lib/modules/%s. That is undesireable, so we explicitly
exclude them from traversal with a minor tweak to the traversal routine.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Acked-by: Namhyung kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1398532675-13684-1-git-send-email-ryao@gentoo.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
tools/perf/util/machine.c