VSOCK: Fix misc device registration
authorAsias He <asias@redhat.com>
Tue, 23 Apr 2013 20:33:52 +0000 (20:33 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Apr 2013 08:21:22 +0000 (04:21 -0400)
commit6ad0b2f7fdfd95fe3107367f8aed252e94c3f654
tree285c242b6faee9bea579b2c04d8e4b0a3deeba1a
parentc6cdcf6d82bc8f53e64ad59464e0114fe48e28bb
VSOCK: Fix misc device registration

When we call vsock_core_init to init VSOCK the second time,
vsock_device.minor still points to the old dynamically allocated minor
number. misc_register will allocate it for us successfully as if we were
asking for a static one. However, when other user call misc_register to
allocate a dynamic minor number, it will give the one used by
vsock_core_init(), causing this:

  [  405.470687] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0xcc/0xf0()
  [  405.470689] Hardware name: OptiPlex 790
  [  405.470690] sysfs: cannot create duplicate filename '/dev/char/10:54'

Always set vsock_device.minor to MISC_DYNAMIC_MINOR before we
register.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andy King <acking@vmware.com>
Cc: Dmitry Torokhov <dtor@vmware.com>
Cc: Reilly Grant <grantr@vmware.com>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Asias He <asias@redhat.com>
Acked-by: Dmitry Torokhov <dtor@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/vmw_vsock/af_vsock.c