st: fix potential null pointer dereference.
authorMaurizio Lombardi <mlombard@redhat.com>
Wed, 18 Nov 2015 14:32:44 +0000 (15:32 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 19 Nov 2015 17:12:42 +0000 (12:12 -0500)
commitab08ee14393724ab52b92be643d588d41a1a05be
tree4d3f3d7c38ad4f9d178a2c15abedb84480ecdcb0
parenta35bb4458e5e5c9dc19a0daa0629409285f3b25e
st: fix potential null pointer dereference.

If cdev_add() returns an error, the code calls
cdev_del() passing the STm->cdevs[rew] pointer as parameter;
the problem is that the pointer has not been initialized yet.

This patch fixes the problem by moving the STm->cdevs[rew] pointer
initialization before the call to cdev_add().
It also sets STm->devs[rew] and STm->cdevs[rew] to NULL in
case of failure.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/st.c