powerpc/mm: Clean up error handling for htab_remove_mapping
authorDavid Gibson <david@gibson.dropbear.id.au>
Tue, 9 Feb 2016 03:32:40 +0000 (13:32 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 1 Mar 2016 11:04:17 +0000 (22:04 +1100)
commitabd0a0e7914a1137973119ac3b3cace26e8ffa96
treeb490f957a794320ef5d1938ae776c19aa94be285
parent446957ba5127141ee007fc61509e24a9e60853d9
powerpc/mm: Clean up error handling for htab_remove_mapping

Currently, the only error that htab_remove_mapping() can report is -EINVAL,
if removal of bolted HPTEs isn't implemeted for this platform.  We make
a few clean ups to the handling of this:

 * EINVAL isn't really the right code - there's nothing wrong with the
   function's arguments - use ENODEV instead
 * We were also printing a warning message, but that's a decision better
   left up to the callers, so remove it
 * One caller is vmemmap_remove_mapping(), which will just BUG_ON() on
   error, making the warning message redundant, so no change is needed
   there.
 * The other caller is remove_section_mapping().  This is called in the
   memory hot remove path at a point after vmemmap_remove_mapping() so
   if hpte_removebolted isn't implemented, we'd expect to have already
   BUG()ed anyway.  Put a WARN_ON() here, in lieu of a printk() since this
   really shouldn't be happening.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/mm/hash_utils_64.c