ofp-actions: Properly check for action that exceeds buffer length.
authorBen Pfaff <blp@nicira.com>
Thu, 23 Oct 2014 21:34:04 +0000 (14:34 -0700)
committerBen Pfaff <blp@nicira.com>
Thu, 23 Oct 2014 21:34:04 +0000 (14:34 -0700)
commitb153b9903272f858ee1bbaaba0768f5f2d6506e7
tree361182ab6d6ac61e85adc6ab94e53a9d6df4a383
parent09cac43f740b0aef1ef1cb656d952f56bedd7fec
ofp-actions: Properly check for action that exceeds buffer length.

Commit c2d936a44fa (ofp-actions: Centralize all OpenFlow action code for
maintainability.) rewrote OpenFlow action parsing but failed to check that
actions don't overflow their buffers.  This commit fixes the problem and
adds negative tests so that this bug doesn't recur.

Reported-by: Tomer Pearl <Tomer.Pearl@Contextream.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Justin Pettit <jpettit@nicira.com>
lib/ofp-actions.c
tests/ofp-actions.at