fbdev: fb_defio: Export fb_deferred_io_mmap
authorNoralf Trønnes <noralf@tronnes.org>
Thu, 28 Apr 2016 15:18:34 +0000 (17:18 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 2 May 2016 14:24:49 +0000 (16:24 +0200)
commitba0263340a2aeaf5f08e4f2b0f4c29e300828b06
tree47602035bd6b760a0d4fa93f1a9b1dc9401717f6
parenteaa434defaca1781fb2932c685289b610aeb8b4b
fbdev: fb_defio: Export fb_deferred_io_mmap

Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot.
When the framebuffer memory is allocated using dma_alloc_writecombine()
instead of vmalloc(), I get cache syncing problems on ARM.
This solves it:

static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info,
  struct vm_area_struct *vma)
{
fb_deferred_io_mmap(info, vma);
vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

return 0;
}

Could this have been done in the core?
Drivers that don't set (struct fb_ops *)->fb_mmap, gets a call to
fb_pgprotect() at the end of the default fb_mmap implementation
(drivers/video/fbdev/core/fbmem.c). This is an architecture specific
function that on many platforms uses pgprot_writecombine(), but not on
all. And looking at some of the fb_mmap implementations, some of them
sets vm_page_prot to nocache for instance, so I think the safest bet is
to do this in the driver and not in the fbdev core. And we can't call
fb_pgprotect() from fb_deferred_io_mmap() either because we don't have
access to the file pointer that powerpc needs.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1461856717-6476-5-git-send-email-noralf@tronnes.org
drivers/video/fbdev/core/fb_defio.c
include/linux/fb.h