nfsd: don't hold ls_mutex across a layout recall
authorJeff Layton <jlayton@poochiereds.net>
Sun, 29 Nov 2015 13:46:14 +0000 (08:46 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 16 Dec 2015 16:49:58 +0000 (11:49 -0500)
commitbe20aa00c67102aaa54599518c086a2338b19f4c
treef44c188279fe553b8b47f6398b7782e26ec60bbb
parent8005c49d9aea74d382f474ce11afbbc7d7130bec
nfsd: don't hold ls_mutex across a layout recall

We do need to serialize layout stateid morphing operations, but we
currently hold the ls_mutex across a layout recall which is pretty
ugly. It's also unnecessary -- once we've bumped the seqid and
copied it, we don't need to serialize the rest of the CB_LAYOUTRECALL
vs. anything else. Just drop the mutex once the copy is done.

This was causing a "workqueue leaked lock or atomic" warning and an
occasional deadlock.

There's more work to be done here but this fixes the immediate
regression.

Fixes: cc8a55320b5f "nfsd: serialize layout stateid morphing operations"
Cc: stable@vger.kernel.org
Reported-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4layouts.c