serial: sh-sci: Add missing call to uart_remove_one_port() in failure path
authorGeert Uytterhoeven <geert+renesas@linux-m68k.org>
Fri, 28 Feb 2014 13:21:33 +0000 (14:21 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 1 Mar 2014 00:39:38 +0000 (16:39 -0800)
commitbf13c9a894162a91c8bb7d9555933e9fc3ff7d0e
treefd58867515aef6102c716239a8c9274635f6b36c
parent5f5c9ae56c38942623f69c3e6dc6ec78e4da2076
serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

If cpufreq_register_notifier() fails, we have to remove the port added by
sci_probe_single(), which is not done by sci_cleanup_single().

Else the serial port stays active from the point of view of the serial
subsystem, and it may crash when userspace getty is started, or when the
loadable driver module is unloaded.

This was introduced by commit 6dae14216c85eea13db7b12c469475c5d30e5499
("serial: sh-sci: Fix probe error paths").

Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c