plip: replace spin_lock_irq with spin_lock_irqsave in irq context
authorMikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Mon, 31 Mar 2008 23:22:45 +0000 (01:22 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 1 Apr 2008 18:16:04 +0000 (11:16 -0700)
commitcabce28ec0a0ae3d0ddfa4461f0e8be94ade9e46
treed40f357c77bf99a33b9b81123b2c3149adf3717d
parenta9edadbf790d72adf6ebed476cb5caf7743e7e4a
plip: replace spin_lock_irq with spin_lock_irqsave in irq context

Plip uses spin_lock_irq/spin_unlock_irq in its IRQ handler (called from
parport IRQ handler), the latter enables interrupts without parport
subsystem IRQ handler expecting it.

The bug can be seen if you compile kernel with lock dependency checking
and use plip --- it produces a warning.

This patch changes it to spin_lock_irqsave/spin_lock_irqrestore, so that
it doesn't enable interrupts when already disabled.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/plip.c