netdev-vport: Mark netdev_vport_get_dpif_port() as OVS_WARN_UNUSED_RESULT.
authorBen Pfaff <blp@nicira.com>
Sat, 6 Jun 2015 05:09:50 +0000 (22:09 -0700)
committerBen Pfaff <blp@nicira.com>
Thu, 11 Jun 2015 17:18:47 +0000 (10:18 -0700)
commitcbc083e330186a23c17a1bea284f39dfe9ffb2ad
treed7825155cdf7c9e4bd8ca0118abae3d11c93e668
parent2b7b1427c177d28ec63632646ce896eec7f162b6
netdev-vport: Mark netdev_vport_get_dpif_port() as OVS_WARN_UNUSED_RESULT.

Ignoring the result of this function means that the caller is quite likely
blindly using the character array passed in, instead of the return value,
which leads to latent bugs.

This would have prevented one of the bugs fixed by commit "tunneling: Fix a
tunnel name display bug".

CC: Andy Zhou <azhou@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Andy Zhou <azhou@nicira.com>
lib/netdev-vport.h