hwrng: cleanup in hwrng_register()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 30 Jan 2014 11:49:43 +0000 (14:49 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 9 Feb 2014 01:59:27 +0000 (09:59 +0800)
commitd167b6e1fb8ad386b17485ca88804d14f1695805
tree17edae29c16bc089530bf54512ca5f51de88d399
parentfecfd7f7e91fc1e82d44b0e64a6bda8133f2037b
hwrng: cleanup in hwrng_register()

My static checker complains that:

drivers/char/hw_random/core.c:341 hwrng_register()
warn: we tested 'old_rng' before and it was 'false'

The problem is that sometimes we test "if (!old_rng)" and sometimes we
test "if (must_register_misc)".  The static checker knows they are
equivalent but a human being reading the code could easily be confused.

I have simplified the code by removing the "must_register_misc" variable
and I have removed the redundant check on "if (!old_rng)".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/core.c