KVM: x86: Fix uninitialized op->type for some immediate values
authorNadav Amit <namit@cs.technion.ac.il>
Sun, 2 Nov 2014 09:54:47 +0000 (11:54 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 5 Nov 2014 11:36:58 +0000 (12:36 +0100)
commitd29b9d7ed76c0b961603ca692b8a562556a20212
tree73703f51dcce80a433eb6e628f59258896e2319b
parentbc79a3179a1da387d730af81ce857d481915efdb
KVM: x86: Fix uninitialized op->type for some immediate values

The emulator could reuse an op->type from a previous instruction for some
immediate values.  If it mistakenly considers the operands as memory
operands, it will performs a memory read and overwrite op->val.

Consider for instance the ROR instruction - src2 (the number of times)
would be read from memory instead of being used as immediate.

Mark every immediate operand as such to avoid this problem.

Cc: stable@vger.kernel.org
Fixes: c44b4c6ab80eef3a9c52c7b3f0c632942e6489aa
Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/emulate.c