watchdog: Intel SCU Watchdog: Fix build and remove duplicate code
authorJesper Juhl <jj@chaosbits.net>
Thu, 26 May 2011 09:12:53 +0000 (11:12 +0200)
committerWim Van Sebroeck <wim@iguana.be>
Tue, 28 Jun 2011 07:42:50 +0000 (07:42 +0000)
commite376fd664b1547e29e264e3cfb97553a1be9054b
treea1315cfb93b516158649db48a46a8a53f6997fcc
parentdb98f89a2807966c6e82601f5c57e1a9c214c91a
watchdog: Intel SCU Watchdog: Fix build and remove duplicate code

Trying to build the Intel SCU Watchdog fails for me with gcc 4.6.0 -
$ gcc --version | head -n 1
gcc (GCC) 4.6.0 20110513 (prerelease)

like this :
  CC      drivers/watchdog/intel_scu_watchdog.o
In file included from drivers/watchdog/intel_scu_watchdog.c:49:0:
/home/jj/src/linux-2.6/arch/x86/include/asm/apb_timer.h: In function ‘apbt_time_init’:
/home/jj/src/linux-2.6/arch/x86/include/asm/apb_timer.h:65:42: warning: ‘return’ with a value, in function returning void [enabled by default]
drivers/watchdog/intel_scu_watchdog.c: In function ‘intel_scu_watchdog_init’:
drivers/watchdog/intel_scu_watchdog.c:468:2: error: implicit declaration of function ‘sfi_get_mtmr’ [-Werror=implicit-function-declaration]
drivers/watchdog/intel_scu_watchdog.c:468:32: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

make[1]: *** [drivers/watchdog/intel_scu_watchdog.o] Error 1
make: *** [drivers/watchdog/intel_scu_watchdog.o] Error 2

Additionally, linux/types.h is needlessly being included twice in
drivers/watchdog/intel_scu_watchdog.c

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
arch/x86/include/asm/apb_timer.h
drivers/watchdog/Kconfig
drivers/watchdog/intel_scu_watchdog.c