batman-adv: fix counter for multicast supporting nodes
authorLinus Lüssing <linus.luessing@c0d3.blue>
Thu, 30 Oct 2014 04:40:46 +0000 (05:40 +0100)
committerAntonio Quartulli <antonio@meshcoding.com>
Tue, 6 Jan 2015 10:05:42 +0000 (11:05 +0100)
commite8829f007e982a9a8fb4023109233d5f344d4657
tree5c039ba3df1ac2cc90e09afd3082612b94b8c0ed
parentf44d54077a69b1c990aeef49cf9b813fb274cfee
batman-adv: fix counter for multicast supporting nodes

A miscounting of nodes having multicast optimizations enabled can lead
to multicast packet loss in the following scenario:

If the first OGM a node receives from another one has no multicast
optimizations support (no multicast tvlv) then we are missing to
increase the counter. This potentially leads to the wrong assumption
that we could safely use multicast optimizations.

Fixings this by increasing the counter if the initial OGM has the
multicast TVLV unset, too.

Introduced by 60432d756cf06e597ef9da511402dd059b112447
("batman-adv: Announce new capability via multicast TVLV")

Reported-by: Tobias Hachmer <tobias@hachmer.de>
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
net/batman-adv/multicast.c