drm/i915: Allow disabling the destination colorkey for overlay
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 2 Apr 2015 09:35:08 +0000 (10:35 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 10 Apr 2015 06:55:54 +0000 (08:55 +0200)
commitea9da4e4608104108c6d5eca7b178cec2720ab22
tree938172f70c0de3d59b9841a6d60763d9109816a7
parentaa7471d228eb6dfddd0d201ea9746d6a2020972a
drm/i915: Allow disabling the destination colorkey for overlay

Sometimes userspace wants a true overlay that is never clipped. In such
cases, we need to disable the destination colorkey. However, it is
currently unconditionally enabled in the overlay with no means of
disabling. So rectify that by always default to on, and extending the
UPDATE_ATTR ioctl to support explicit disabling of the colorkey.

This is contrast to the spite code which requires explicit enabling of
either the destination or source colorkey. Handling source colorkey is
still todo for the overlay. (Of course it may be worth migrating overlay
to sprite before then.)

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_overlay.c
include/uapi/drm/i915_drm.h