thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro
authorJoe Perches <joe@perches.com>
Wed, 26 Aug 2015 18:13:38 +0000 (11:13 -0700)
committerDarren Hart <dvhart@linux.intel.com>
Fri, 28 Aug 2015 17:49:52 +0000 (10:49 -0700)
commitefd85cf86a56898686187397adfd52dfac79aff2
tree41c940cf0d3c10b23d4e7045ef77cdebb2bc9e75
parent2508a45a924dfa4a5f6e60675aa4732d888134a7
thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses
no_printk which produces no logging output but always
evaluates arguments.

Change the macro to surround the no_printk call with
do { if (0) no_printk(...); } while (0)
to avoid the unnecessary argument evaluations.

$ size drivers/platform/x86/thinkpad_acpi.o*
   text    data     bss     dec     hex filename
  60918    6184     824   67926   10956 drivers/platform/x86/thinkpad_acpi.o.new
  60927    6184     824   67935   1095f drivers/platform/x86/thinkpad_acpi.o.old

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c