PM / Runtime: don't forget to wake up waitqueue on failure
authorAlan Stern <stern@rowland.harvard.edu>
Mon, 26 Mar 2012 20:46:52 +0000 (22:46 +0200)
committerRafael J. Wysocki <rjw@sisk.pl>
Mon, 26 Mar 2012 20:46:52 +0000 (22:46 +0200)
commitf2791d733a2f06997b573d1a3cfde21e6f529826
tree2af5d3beba35cb4b5a945f148e0a24bbda0ed86f
parente22057c8599373e5caef0bc42bdb95d2a361ab0d
PM / Runtime: don't forget to wake up waitqueue on failure

This patch (as1535) fixes a bug in the runtime PM core.  When a
runtime suspend attempt completes, whether successfully or not, the
device's power.wait_queue is supposed to be signalled.  But this
doesn't happen in the failure pathway of rpm_suspend() when another
autosuspend attempt is rescheduled.  As a result, a task can get stuck
indefinitely on the wait queue (I have seen this happen in testing).

The patch fixes the problem by moving the wake_up_all() call up near
the start of the failure code.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
drivers/base/power/runtime.c