datapath: Check gso_type for correct sk_buff in queue_gso_packets().
authorBen Pfaff <blp@nicira.com>
Tue, 10 Jul 2012 21:11:59 +0000 (14:11 -0700)
committerBen Pfaff <blp@nicira.com>
Tue, 10 Jul 2012 22:30:57 +0000 (15:30 -0700)
commitfdd80c39b1822db6c8b5c8274ff0c5cebcaa36b7
treef5ac0557592ae30c9ae42b0d7e577f43a062e15e
parentf266b3db510655f0d6bff84911c5c0d7806f1e4d
datapath: Check gso_type for correct sk_buff in queue_gso_packets().

At the point where it was used, skb_shinfo(skb)->gso_type referred to a
post-GSO sk_buff.  Thus, it would always be 0.  We want to know the pre-GSO
gso_type, so we need to obtain it before segmenting.

Before this change, the kernel would pass inconsistent data to userspace:
packets for UDP fragments with nonzero offset would be passed along with
flow keys that indicate a zero offset (that is, the flow key for "later"
fragments claimed to be "first" fragments).  This inconsistency tended
to confuse Open vSwitch userspace, causing it to log messages about
"failed to flow_del" the flows with "later" fragments.

Bug #12394.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
datapath/datapath.c