drivers/scsi/sd.c:2676:2: warning: assignment from incompatible pointer type [enabled by default]
drivers/scsi/sd.c:2913:2: warning: assignment from incompatible pointer type [enabled by default]
Since there's no way to return an error, do a WARN_ON() in the error
case instead.
BUG=chromium-os:34287
TEST=none (we need an automated test for error injection here)
Change-Id: Idaf0c0184e81ef7bac63b1deeda1a7690aa48a42
Signed-off-by: Olof Johansson <olofj@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/32830
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
static int sd_remove(struct device *);
static void sd_shutdown(struct device *);
static int sd_suspend(struct device *, pm_message_t state);
static int sd_remove(struct device *);
static void sd_shutdown(struct device *);
static int sd_suspend(struct device *, pm_message_t state);
-static int __sd_resume(struct work_struct *work);
+static void __sd_resume(struct work_struct *work);
static int sd_resume(struct device *);
static void sd_rescan(struct device *);
static int sd_done(struct scsi_cmnd *);
static int sd_resume(struct device *);
static void sd_rescan(struct device *);
static int sd_done(struct scsi_cmnd *);
-static int __sd_resume(struct work_struct *work)
+static void __sd_resume(struct work_struct *work)
{
struct scsi_disk *sdkp = container_of(work, struct scsi_disk,
resume_work);
{
struct scsi_disk *sdkp = container_of(work, struct scsi_disk,
resume_work);
sd_printk(KERN_NOTICE, sdkp, "Starting disk\n");
ret = sd_start_stop_device(sdkp, 1);
sd_printk(KERN_NOTICE, sdkp, "Starting disk\n");
ret = sd_start_stop_device(sdkp, 1);
done:
scsi_disk_put(sdkp);
done:
scsi_disk_put(sdkp);
}
static int sd_resume(struct device *dev)
}
static int sd_resume(struct device *dev)