watchdog: fix double lock in watchdog_nmi_enable_all
authorMichal Hocko <mhocko@suse.cz>
Tue, 19 May 2015 07:07:27 +0000 (09:07 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 19 May 2015 17:57:03 +0000 (10:57 -0700)
Commit ab992dc38f9a ("watchdog: Fix merge 'conflict'") has introduced an
obvious deadlock because of a typo.  watchdog_proc_mutex should be
unlocked on exit.

Thanks to Miroslav Benes who was staring at the code with me and noticed
this.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Duh-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/watchdog.c

index 506edcc..581a68a 100644 (file)
@@ -621,7 +621,7 @@ void watchdog_nmi_enable_all(void)
        put_online_cpus();
 
 unlock:
-       mutex_lock(&watchdog_proc_mutex);
+       mutex_unlock(&watchdog_proc_mutex);
 }
 
 void watchdog_nmi_disable_all(void)