ASoC: Intel: Skylake: Delete an unnecessary check before the function call "release_f...
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 22 Jul 2016 16:58:14 +0000 (18:58 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 24 Jul 2016 20:48:06 +0000 (21:48 +0100)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl.c

index 2337748..cd59536 100644 (file)
@@ -781,8 +781,7 @@ static void skl_remove(struct pci_dev *pci)
        struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
        struct skl *skl = ebus_to_skl(ebus);
 
-       if (skl->tplg)
-               release_firmware(skl->tplg);
+       release_firmware(skl->tplg);
 
        if (pci_dev_run_wake(pci))
                pm_runtime_get_noresume(&pci->dev);