cxgb4: fix boolreturn.cocci warnings
authorWu Fengguang <fengguang.wu@intel.com>
Wed, 25 Mar 2015 21:55:25 +0000 (05:55 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 29 Mar 2015 19:15:56 +0000 (12:15 -0700)
drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c:49:9-10: WARNING: return of 0/1 in function 'cxgb_fcoe_sof_eof_supported' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Varun Prakash <varun@chelsio.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c

index 062d3c0..6c8a62e 100644 (file)
@@ -46,17 +46,17 @@ bool cxgb_fcoe_sof_eof_supported(struct adapter *adap, struct sk_buff *skb)
 
        if ((sof != FC_SOF_I3) && (sof != FC_SOF_N3)) {
                dev_err(adap->pdev_dev, "Unsupported SOF 0x%x\n", sof);
-               return 0;
+               return false;
        }
 
        skb_copy_bits(skb, skb->len - 4, &eof, 1);
 
        if ((eof != FC_EOF_N) && (eof != FC_EOF_T)) {
                dev_err(adap->pdev_dev, "Unsupported EOF 0x%x\n", eof);
-               return 0;
+               return false;
        }
 
-       return 1;
+       return true;
 }
 
 /**